Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65131979
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65132038
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65131836
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -801,38 +802,29 @@ setup_sshd(){
setup_vpc_apache2() {
log_it
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219709644
@DaanHoogland is correct; we're running this code in test-production. Keep
in mind however that we only use Basic Networking Zones, so I did my best to
keep
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219754165
Maybe, but for now it's still just one conditional which needs just one
decision/explanation.
On the plus side, if the decision can be taken in CsConfig
GitHub user The-Loeki opened a pull request:
https://github.com/apache/cloudstack/pull/1547
Fixes for VirtualRouters in Basic Networking, especially with mutliple
ranges in VLANs
During the last few modifications on the SystemVM scripts, it turns out
quite a lot of stuff broke
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63188699
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
def get_domain(self
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219054107
@DaanHoogland click on the (...) :dancers:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219062321
@DaanHoogland like it better now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219094194
Like this then :dart:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63691374
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVEL
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220022831
@linas-h1p tnx for the intel. Strange that I didn't encounter this, I'll go
check
---
If your project is set up for it, you can reply to this email and have
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220004141
@linas-h1p thanks for noticing, that fix got lost in commit msg translation.
I've amended the `CsAddress.py` commit to (un)fix the whitespacing &
rea
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220043104
'aight, pulling that string reveals a few more problems to fix
unfortunately.
* `cloud-init-early` shell script creates/modifies `ports.conf`, `default
Github user The-Loeki commented on the issue:
https://github.com/apache/cloudstack/pull/1603
kudos for all the hard work! Most of this should've been done a long time
ago as `pylint` is one of the first firewalls of code quality ensurance.
Side notes:
* no fan of `%s
Github user The-Loeki commented on the issue:
https://github.com/apache/cloudstack/pull/1603
Hi :) sorry I was unable to process your request to merge your PR with
mine, as you can probably tell by now this would've oversized & muddied both
PR's ;)
Depending on the up
Github user The-Loeki commented on the issue:
https://github.com/apache/cloudstack/pull/1743
See https://bugzilla.redhat.com/show_bug.cgi?id=910619 for what's actually
going on (and what actually should be going on)
---
If your project is set up for it, you can reply to this email
17 matches
Mail list logo
