Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @serg38 @ustcweizhou @koushik-das @jburwell @borisstoyanov ,
Thanks for valuable insight. Code is modified according to your suggestion.
:)
---
If your project is set up for it
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@serg38
>A part is still missing that will use forced option in UI but give a user
option to cancel deletion if active VMs exist.
I think it will be good to take
Github user priyankparihar closed the pull request at:
https://github.com/apache/cloudstack/pull/1774
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1774
Hi @borisstoyanov Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1302
Hi @borisstoyanov Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/815
Hi @borisstoyanov Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user priyankparihar reopened a pull request:
https://github.com/apache/cloudstack/pull/1774
CLOUDSTACK-9608: Errored State and Abandoned state Templates are not â¦
Errored and Abandoned Templates should also be displayed on UI so that user
has the accessibility to delete
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@borisroman and @serg38 Sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/815
HI @borisroman, I have checked few of them but this change is not reason
for ERROR/FAILURE.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r103154553
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@borisstoyanov as far as i can see test failures are not happening because
of this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
@rhtyd and @syed. If everything looks good. Please provide your precious
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@borisstoyanov please trigger smoke test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1774
Hi @ramkatru,
These failures/errors are not related to this code change( like in
'test_03_delete_template' template deletion is failing but we are not
disturbing delet
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
>can you run internal CI and post @cloudmonger test results?
@karuturi running.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r103423690
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2226,17 +2227,33 @@ int
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r103427150
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2226,17 +2227,33 @@ int
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r103427642
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2226,17 +2227,33 @@ int
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @koushik-das, @borisroman, @serg38, @jburwell and @ustcweizhou
Things are modified and added according to your suggestions. I think, Now
LGTM comment should be provided.
---
If
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1877#discussion_r103611552
--- Diff: systemvm/patches/debian/config/etc/rc.local ---
@@ -42,11 +42,12 @@ then
echo 100 > /proc/sys/net/nf_conntrack_max
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1774
@borisstoyanov Could you please provide management server log for analyzing
this failure ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r103880795
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2226,17 +2227,33 @@ int
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1302
@rhtyd I think now all of your questions are answered. Please provide your
LGTM comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r103892827
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2226,17 +2227,33 @@ int
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r103931610
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus
status
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi @mike-tutkowski sir,
You have done enough work in storage area. Please review this PR. Your one
LGTM comment is enough to lift this PR.
---
If your project is set up for it, you
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@karuturi This seems to be ready for merge (tag:mergeready).
It has 3 LGTMs and tests are passed.
---
If your project is set up for it, you can reply to this email and have your
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1894#discussion_r104105003
--- Diff: api/src/org/apache/cloudstack/api/ResponseGenerator.java ---
@@ -307,7 +307,11 @@
TemplateResponse
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1894#discussion_r104105564
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/CopyTemplateCmdByAdmin.java
---
@@ -40,11 +40,20 @@
@Override
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1894#discussion_r104106536
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/template/RegisterTemplateCmdByAdmin.java
---
@@ -40,10 +40,23 @@
@Override
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1894
@rashmidixit can you run internal CI and post @cloudmonger test results?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1894#discussion_r104114043
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/CopyTemplateCmd.java ---
@@ -51,25 +52,46 @@
@Parameter(name
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
Hi @DaanHoogland code is modified. Now we are not hiding. It will be shown
in Disconnected state.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi, @serg38 and @borisstoyanov soon test_00_deploy_vm_root_resize will be
updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1779#discussion_r104616622
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2488,6 +2488,22 @@ public boolean maintenanceFailed(final long hostId
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
@abhinandanprateek ji, If now everything LGTY then please provide your
LGTM kind of blessing.
---
If your project is set up for it, you can reply to this email and have your
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
tag:mergeready
PS: Hujur code ka tohfa kabool kijiye.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1774
Hi @serg38 and @ramkatru sir, Now, if anything is not proper then notify
otherwise please provide your LGTM comment.
---
If your project is set up for it, you can reply to this email
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi,
Thanks to @sadhugit. @serg38 and @borisstoyanov tests are updated. If
anything is still not proper please notify otherwise please provide your LGTM
comment.
---
If your project
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@borisstoyanov ,
Please change your root disk controller to ISCSI. It could be specified in
global configuration. For IDE it is not supported.
@sadhugit do you want to add
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@borisstoyanov apology for typo. It should be 'scsi'.
>I think it'll be best if those are set before executing the test and
revert back in cleanup.
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r105532534
--- Diff: test/integration/component/test_rootvolume_resize.py ---
@@ -0,0 +1,1140 @@
+# Licensed to the Apache Software Foundation (ASF
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@sadhugit
>if you run the test on vmware ,you need to use iscsi protocol.
***scsi** (modified)
---
If your project is set up for it, you can reply to this email and h
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@borisstoyanov
> If the global settings are not available and user goes and add a custom
value in that field, he'll get a non-meaningful message.
What about
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
@serg38 and @borisstoyanov Thanks for giving your precious time.
@sadhugit is looking for test cases related suggestions.
---
If your project is set up for it, you can
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
@borisstoyanov and @syed Please take a look. Test case is added. If now
everything looks ok then please provide your LGTM.
---
If your project is set up for it, you can reply to this
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1859
Hi @rhtyd,
>From my experience RM-ing for 4.3, 4.5, 4.9 -- the git history is pretty
messed-up and it becomes far too difficult to track changes.
I think everything has
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi @borisstoyanov,
>Here are some recommendations that would make user experience better. What
I'm suggesting is to implement 2 standalone checks.
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
>I'm happy that you agree with my comments, as far as resizing root disk
for runnign VM, I think checking both full.clone and root.disk.controller
global settings puts us i
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164348885
@bhaisaab
User with different account cannot create VMs with the same name, which was
possible earlier (I am not sure in which CCP version). That time
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164354949
@DaanHoogland I have tested it on my machines. what kind of proof do you
need ?
---
If your project is set up for it, you can reply to this email and have
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164381436
@runseb completely agree. But, what kind of proof should i present ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-164388358
@bhaisaab I think null check is not required. I have verified( because in
case of null if automatically picks some random value). But if you still think
it
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164395806
>>"So a migration from 6.2 to 6.5 is allowed but not the other way around."
@agneya2001 Currently UI does not allow migration between dif
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164412418
@nitin-maharana Your point looks good. Both(UI and API) should be
consistent.
---
If your project is set up for it, you can reply to this email and have
Github user priyankparihar closed the pull request at:
https://github.com/apache/cloudstack/pull/1207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user priyankparihar closed the pull request at:
https://github.com/apache/cloudstack/pull/1165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1302
CLOUDSTACK-9104: VM naming convention in case vmware is used
I have reverted all the changes. Now functionality is same as it was in
earlier version.
ACS Bug Link is as follow
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49171092
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-179028659
Hi,
@alexandrelimassantana thanks for notifying. I have made modification,
according to your suggestion.
---
If your project is set up for it, you
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1165
CLOUDSTACK-9104: VM naming convention in case vmware is used
I have reverted all the changes. Now functionality is same as it was in
earlier version.
You can merge this pull request
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1207
CLOUDSTACK-9133: Two volume.delete usage events are getting generatedâ¦
It was happening because event triggering was happening in
UserVmManagerImpl.java and VolumeStateListener.java
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-163542539
@DaanHoogland I did this change because UI does not allow migration
between different versions of hyper-visors of but sometimes user wants to do
migration
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-163912073
@DaanHoogland
Prior Behaviour
| 127 | VOLUME.DELETE | 2 | 2015-12-08 09:30:18 |
1 | 25 | ROOT-14
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/815
CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS 6.5 fails.
Removed Host version check in API. Because
Case 1:(Lower to Higher Version)
Storage XenMotion from lower version
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-219637824
@rhtyd
>please rebase against latest master and push -f.
Done.
---
If your project is set up for it, you can reply to this email and have y
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/815
>it is best to prevent them with appropriate checks rather than some
failure in the HV.
@koushik-das We can define ordering between the existing HV versions. But
it is not a g
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1302
Hi @rhtyd and @sateesh-chodapuneedi,
I have made modification, according to your suggestion. Please take a look.
---
If your project is set up for it, you can reply to this email
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60372700
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-212846127
@sateesh-chodapuneedi @koushik-das I will get back to you soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-214146326
@koushik-das
Currently UI does not allow migration between different versions, and
changing UI for this change is not elegant. Purpose of doing this
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1773
CLOUDSTACK-9607: Preventing template deletion when template is in use.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1774
CLOUDSTACK-9608: Errored State and Abandoned state Templates are not â¦
Errored State and Abandoned state Templates are not displayed on UI.
You can merge this pull request into a Git
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1775
CLOUDSTACK-9606: While IP address is released, tag are not deleted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/priyankparihar
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1776
CLOUDSTACK-9603: concurrent.snapshots.threshold.perhost does not valiâ¦
concurrent.snapshots.threshold.perhost does not validate value given
You can merge this pull request into a Git
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1777
clearCLOUDSTACK-9133: Two volume.delete usage events are getting
generatedâ¦
⦠for destoy vm.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1779
CLOUDSTACK-9610: Disabled Host Keeps Being up status after unmanaging â¦
Disabled Host Keeps Being up status after unmanaging cluster.
You can merge this pull request into a Git
Github user priyankparihar closed the pull request at:
https://github.com/apache/cloudstack/pull/1777
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1776
Thanks @rajesh-battala and @jburwell
>You can modify the description and which can reflect the fix or the check
you are doing in the code.
Modified.
---
If your project
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
Hi @syed,
>can you please provide a description and steps to reproduce
Please check
[CLOUDSTACK-9606](https://issues.apache.org/jira/browse/CLOUDSTACK-9606).
---
If y
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1775
Hi @rajesh-battala,
Changes are included. Thanks for your careful syntax observation.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1774
Hi @ustcweizhou,
>If the templates are displayed on UI, is there any action we can do on
them? eg, delete template.
I hope modified description, answers your quest
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
Hi @syed,
I hope modified description, answers your question.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1813
CLOUDSTACK-9604: Root disk resize support for VMware and XenServer.
For complete description please refer ->
[CLOUDSTACK-9604](https://issues.apache.org/jira/browse/CLOUDSTACK-9
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1774
Hi @ustcweizhou,
>We had an issue in deleting template in UploadAbandoned
Could you please update what issue are you facing and how can i reproduce
it ?
---
If your proj
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi @pdion891, @borisstoyanov, @anshul1886 and @pdube,
Thanks for your valuable suggestion and help.
---
If your project is set up for it, you can reply to this email and have your
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi @borisstoyanov and @serg38 ,
Test case is fixed. Please check. If anything is improper please notify.
--
Thanks :)
---
If your project is set up for it, you can
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1813
Hi @borisstoyanov and @serg38 ,
Test code is modified. Please take a look. I think now it will not fail.
---
If your project is set up for it, you can reply to this email and have
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @jburwell ,
Thanks for teaching me something new. Test is also added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @jburwell ,
Would like to add something on @ustcweizhou comment ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @ustcweizhou @serg38 and @borisroman,
Thanks for your valuable suggestions.
> @ustcweizhou the default value of forced is false, might cause issue on
backwa
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @ustcweizhou,
By default enabling force option(force=true) will be very risky, same is
mentioned by @borisstoyanov.
---
If your project is set up for it, you can reply to this
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1779
Hi Bhai Sahab @rhtyd,
Integration test 'test_04_disable_host_unmanage_cluster_check_hosts_status'
is validating this behavior.
---
If your project is set up for it, you ca
Github user priyankparihar commented on the issue:
https://github.com/apache/cloudstack/pull/1773
Hi @koushik-das @rajesh-battala ,
>The default value of forced is false, might cause issue on backwards
compatibility.
Should i make changes according to @serg38
94 matches
Mail list logo
