[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-07 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162532791 This index comes from schema-40to410.sql: CREATE TABLE `cloud`.`nicira_nvp_router_map` ( `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT 'id

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-06 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162319994 Since you are testing L3 connectivity existing switch patch to router shouldn't overlap an ip range used by the new subnet. Cidr #1 should work fine . You might

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-10 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-163684761 Assuming everything else is ready e.g. service controllers, transport zone, management server, STT tunnels in-between then to create L2 gateway (page 89 of the User

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-06-19 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell If no sanity-check-last-id is present it will run Sanity on the whole cloud_usage data set and then create a new sanity-check-last-id file. The whole part of sanity checking related

[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring

2016-06-19 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r67618240 --- Diff: usage/conf/log4j-cloud_usage.xml.in --- @@ -48,7 +48,7 @@ under the License

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-01-25 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-174554271 Unfortunately NFS version negotiation doesn't work properly with all storage vendors. Some vendors e.g. Tintri require that vers=3 is supplied in mount command

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-01-25 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-174746870 I believe the main reason is to provide the most of backward compatibility. image_store_details doesn't have NFS version in existing installations so after

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-02-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-184799968 Hi committers, Can someone perform a second review and merge it at the earliest? We would like this to be part of 4.9? --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-02-17 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-185256350 If requirements to use particular NFS version is known beforehand it can be specified during the image store creation using details argument details[0].key

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

2016-04-07 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206989623 @swill , @rafaelweingartner I work very closely with @nvazquez. His PRs pass very rigorous testing in our Lab on physical Vmware hypervisors. I reviewed his code

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

2016-04-07 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-206990689 @rafaelweingartner On a general note we got a verbal commitment from Accelerite who bought CloudPlatform from Citrix last month to contribute more to the community

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-04-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-208387324 @rafaelweingartner. That's correct. 3 indexes: 1 - primary + 2 unique indexes, all based on ID column. Those 2 unique indexes are not needed and only consume disk

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-04-10 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-208121230 @rafaelweingartner >>>>>>>> Here you change this table "ovs_tunnel_network", you dropped the primary key "id";

[GitHub] cloudstack pull request: CLOUDSTACK-9333: Exclude clusters from OV...

2016-03-31 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1457#issuecomment-204152844 @rafaelweingartner How about 'cluster.exclude' or 'cluster.storage.operations.exclude'. I think the latter is the better choice. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9298: Improve performance of r...

2016-03-31 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1425#issuecomment-204005079 Great!!! 2 LGTM received. Can we have this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-04-28 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-215572026 With this change PR passed Travis and Jenkins. @rafaelweingartner and @rhtyd will you be able to give your blessing? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220652018 @swill Travis passed. Looks like it is ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218466672 @swill Last Travis run for this PR was a success for test_list_ids_parameter. Which PR gives an issue? Marvin Init Successful === TestName

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218480013 The issue that it couldn't find a snaphsot because it is already cleaned by account cleanup. +cls._cleanup

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218543261 @swill PR1539 passed Jenkins and Travis. After you merge it should resolve the issue in other PRs --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219473209 @remibergsma, @DaanHoogland Current global support for nested virtualization is only vmware specific and done in VmwareGuru. Are you proposing to move

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219468957 @remibergsma In some private cloud environments nested virtualization is not a good fit so it is generally disabled. That's fine but we found that it would be very

[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-219067011 It would be nice if this is resolved. The issue still exists in 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-219154273 This doesn't seem to be related to this PR.Can you post managment-server.log extract around the failure time? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-03 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216650029 All checks passed. @rhtyd, @wido or @GabrielBrascher can you review and give second OK. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-05-03 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216574386 All checks have been passed after squashing. @swill did you CI run pass? If so can you merge it please? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-05-04 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216876560 Thanks @koushik-das. Looks like before 5.6 Mysql auto restricted length of InnoDB indexes to 255 characters without giving trouble if index length is not specified

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

2016-05-04 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216967912 @rhtyd I just finished QA of changes on MySQL 5.1, 5.5, 5.6 and 5.7. No issues. 64byte index on ssh_keypairs table is created fine on all DB platforms. @koushik

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-09 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-218052341 @koushik-das Will you be able to review this PR? It has been waiting for 2d LGTM for a while now. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 Ping for second review -- @GabrielBrascher, @rhtyd, @wido, @rafaelweingartner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 Ping for review -- @sateesh-chodapuneedi, @rhtyd, @koushik-das --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @rafaelweingartner That's correct. At this point advanced VM details and advanced template details have no UI exposure. At some point we can bring in PR to show this in UI and allow API based

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. The default behavior won't change. The proposed enhancement will add an ability to control link/full clone deployment of a primary storage level. If it is not defined there a current

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular VMware vms creation as ful...

2016-07-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. On Vmware using link cloned was a default behavior. The primary use cases are: - storage saving if underlying arrays don't support deduplication - speed of the deployment

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. Absolutely it can although the effort seems to be well beyond and scope of this PR. @nvazquez and I have only access to vmware hypervisors at this point. If there is an interest to expand

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell LGTM for the test part. This PR was extensively tested on Environment: RHEL 6 management servers, Vmware ESX5.5 and 6.0 with advanced networking --- If your project is set up

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-17 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Support for NFS version for Secondary storage is already merged via PR 1361. Since there were integration tests developed and executed over there we seem to be needed tests only

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-08 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rafaelweingartner Do we get you LGTM? @DaanHoogland @rhtyd Can we kick off tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @koushik-das @rhtyd @rafaelweingartner Can you review changes @nvazquez put in place? CI tests are good. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rafaelweingartner This PR is two fold. 1. This is something that was done a long ago for hosts and was never implemented for storage. It transitions location of of storage tags over

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rafaelweingartner Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1833: BUG-ID:CLOUDSTACK-9678

2017-01-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1833 @pdumbre I confirm your observation. LGTM on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1711: XenServer 7 Support

2017-01-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1711 Yes it is in 4.9.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rhtyd @karuturi Can we run tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rhtyd @karuturi Can we run tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @karuturi Can we merge this one ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1905 @rhtyd @karuturi Can we run tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1913 @rhtyd @karuturi Can we run vmware tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar A part is still missing that will use forced option in UI but give a user option to cancel deletion if active VMs exist --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-20 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @ustcweizhou @priyankparihar @borisstoyanov The default behavior was always equivalent of force=true. We seem to agree that the UI behavior should remain forced=true but with extra warning. We

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-20 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez @rhtyd @anshul1886 We might need to tweak the test_data.py to add additional nfs mount e.g. nfs1 and use it in this test. E.g adding "nfs1": { "u

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar @ustcweizhou There seems to be just one case where it will affect resetVM operations. If template is deleted and root disk is migrated to another PS where there is no template

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar Resize test still fails on vmware. It is hard to see the reason in blueorangutain output but you might want to make sure the test provisioning uses full clones via setting

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-23 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1958#discussion_r102753237 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @borisstoyanov @rhtyd Can we re-test this with B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @karuturi I agree with @nvazquez . This PR can be safely merged and then B.O. runtime environment needs to be adjusted to define nfs2 mountpoint in test_data.py --- If your project is set up

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner Can you review latest updates from @nvazquez . Since tests are passing this PR will be ready for merging to 4.10 --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar I agree with @ustcweizhou . Default behavior should remain forced. And in this case Web UI we should give a warning with "yes and no" if template has deployed VM so

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele I tend to agree with @rhtydthat it could break some of the upgrades. If I get it right with your proposed changes, upgrade scripts become obsolete since all the changes can be done

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @jburwell That was default behavior for few years to allow deletion of the template even if active VMs exist. Deletion of the template on secondary doesn't remove the template copy on primary

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from self.services["nfs"], to self.services["nfs2"], and re-merge this PR so

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar Well. API use cases can be recoded but not UI. Presently we can delete templates in UI even with active VMs. With your changes there will be no recourse. An easy option

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/927 @karuturi Smoke test test_internal_lb.py uses a value of network.loadbalancer.haproxy.stats.auth which is encrypted for haproxy checks. settings["username"]

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @karuturi This one is ready for merging. Two LGTMs + tests passing on all 3 hypervisors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @karuturi Test passed. Two LGTM received. Looks like it is ready for merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @DaanHoogland @borisstoyanov @rhtyd Guys can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-02-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1913 @karuturi This one is ready for merging. LGTM and test results are positive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-02-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1913 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-15 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar You need to adjust smoke test test_deploy_vm_root_resize.py to support vmware root resize. Otherwise it will keep failing 2017-02-15 12:48:59,150 - CRITICAL - FAILED

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-15 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Looks like some environmental issues with backend NFS. Can you kick it again for vmware ? u'2017-02-15T20:21:38+', jobresult : {errorcode : 530, errortext : u'Failed

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @borisstoyanov @DaanHoogland @rhtyd KVM tests passed but key smoke test is skipped test_change_service_offering_for_vm_with_snapshots Skipped To be on the safe side can we test

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-01-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @nvazquez Since 4.9.2 is already released and this is not a bugfix the DB changes should go to schema-490to4910.sql --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @rafaelweingartner @swill Will you be able to review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @karuturi @jburwell There are 2 LGTM in this PR. Packaging, Travis and Jenkins all passed. Can this be merged? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rafaelweingartner @jburwell @rhtyd @koushik-das Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @jburwell @rhtyd @koushik-das Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 Debian returns: 1 packets transmitted, 1 packets received, 0% packet loss CentOs returns: 1 packets transmitted, 1 received, 0% packet loss, time 4ms Between those 2 we could

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 Thanks @priyankparihar . We verified in our environment that all is working fine including UI part. LGTM I think this one is tag:mergeready --- If your project is set up

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @rhtyd @borisstoyanov @DaanHoogland Can we get B.O. management server log to check why exception is generated? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-01 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r103719599 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus status) throws

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-26 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rhtyd @karuturi To fix errors in B.O in test_02_list_snapshots_with_removed_data_store we need to merge PR1961 and then adjust test_data on B.O side to have correct mapping for nfs2 label

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 LGTM for testing. Vmware ESX 5.5 and 6.0 hypervisors, advanced networking, RHEL 6 management servers [root@ussarlabcsmgt41 ~]# cat /tmp//MarvinLogs/test_volumes_930LZ3/results.txt|grep

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-09-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @rhtyd @jburwell Just re-ran Marvin tests. All passes including test_network_acl which fails without this fix. [root@ussarlabcsmgt41 ~]# cat /tmp//MarvinLogs/test_volumes_939G6N

[GitHub] cloudstack issue #1668: Fixing test_router_dhcp outside ping response as it ...

2016-08-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1668 @borisstoyanov This PR can be probably closed since the issue with correct ping responses is being addressed globally in PR1651 --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-09-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @rhtyd @jburwell @swill @koushik-das @rafaelweingartner @wido This PR has enough of everything. Can one of the committers merge it? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-09-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 @rhtyd @jburwell @swill @koushik-das @rafaelweingartner @wido This PR has enough of everything. Can one of the committers merge it? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-09-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @rhtyd @jburwell @swill @koushik-das @rafaelweingartner @wido This PR has enough of everything. Can one of the committers merge it? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-09-11 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rafaelweingartner @jburwell This PR seems to be ready for merging as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-09-11 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 LGTM for testing. Re-ran smoke tests: test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === ok test

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-09-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 LGTM for the testing. Smoke test results ``` test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === test

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-09-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @jburwell Thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

  1   2   3   >