Re: Unable to start secondary storage in DevCloud

2013-07-09 Thread Syed
have any settings to recommend that I can fiddle around and make this VM come up though I do not know what exactly this is used for. Thanks for your help. I was able to get something working. Thanks -Syed WARN [cloud.consoleproxy.ConsoleProxyManagerImpl] (consoleproxy-1:) Exception while

[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...

2015-10-03 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...

2015-10-03 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/10#issuecomment-145297866 This was a problem with my setup where I had multiple versions of `request`. Closing as not a bug --- If your project is set up for it, you can reply

[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...

2015-10-02 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/10 Import error when running cloudmonkey The cloudmonkey install from pip does not run and gives an import error because the latest `requests` package dropped

[GitHub] cloudstack pull request: Fix secondary storage not working with sw...

2015-11-27 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1133 Fix secondary storage not working with swift Original PR and discussion at #1112 You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-27 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1112#issuecomment-160187393 Guys, I am closing this and opening this request against 4.6.1 as I have been told that it is the new way now. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-27 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-23 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1112 Fix Instance creation with swift as Secondary Storage [CLOUDSTACK-9061] Swift is currently broken when used as Secondary storage. This fix does the right thing when creating directories

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-12 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1331 Fix Sync of template.properties in Swift When using Swift as a secondary storage, we create a template.properties file which stores the metadata about the template. Currently the data which

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-12 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1332 Add ability to download templates in Swift This PR adds the ability to download templates when using Swift as a secondary storage. Uses the "temp_url" feature of Swift so that te

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1584 LGTM based on the code review. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-26 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-26 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-170667305 Hi Guys ( @bhaisaab, @DaanHoogland, @remibergsma ).Did you get a chance to look at this? I think we can remove this safely. --- If your project is set up

[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...

2016-06-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 Yes @swill I've tested this on my local setup. On Mon, Jun 27, 2016 at 5:16 PM, Will Stevens <notificati...@github.com> wrote: > @syed <https://github.

[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...

2016-06-27 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-02-08 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-181507090 Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-02-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-182023310 @DaanHoogland I'm not sure why the tests are failing. My changes shouldn't have affected that --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-176289614 Added unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153892 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153916 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153907 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51154027 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-02-03 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-179502412 Can we get this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-02-25 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1424 [CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region store This PR fixes a case where when we create a template from a snpashot in a region wide store, we don't

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-02-23 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r50443906 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -942,6 +931,83 @@ protected

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r50446719 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -942,6 +931,83 @@ protected

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-21 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-173678575 Jira ticket : [CLOUDSTACK-9247](https://issues.apache.org/jira/browse/CLOUDSTACK-9247) I've tested this on our local setup and it works as expected

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r50451895 --- Diff: plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java --- @@ -67,7 +73,28 @@ public

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r50452491 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-173688390 JIRA: [CLOUDSTACK-9248](https://issues.apache.org/jira/browse/CLOUDSTACK-9248) Tested this on our local setup. Created a template and generated the download

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r50451763 --- Diff: plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java --- @@ -67,7 +73,28 @@ public

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-02-15 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-184250180 LGTM. I've also been testing this in my dev environment with no issues so far --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-03-10 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-194962876 @kiwiflyer : Rebase done. Here is the log from the VR when I enable client side vpn ``` 2016-03-10 17:01:25,876 merge.py load:60 Loading data bag type

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-03-14 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-196448014 @remibergsma Going through the VPN tests on Marvin, I see that it is not actually testing if VPN is working. It just check if we can enable VPN without any errors

[GitHub] cloudstack pull request: Changed Void Methods to void

2016-03-14 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1439#issuecomment-196448464 @rodrigo93 Do you know why we have `Void` return types? I've seen them and not sure why they were added. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-03-14 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-196429053 @remibergsma I beleive there is a [marvin test](https://github.com/apache/cloudstack/blob/master/test/integration/smoke/test_vpc_vpn.py) for this but I beleive

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-04-05 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-205922970 @bvbharatk it looks to be a problem with the test. Volume creation should work irrespective of my changes. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-04-05 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-205981012 Sure @swill . I've sqashed them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-209390353 @rafaelweingartner I've written a simple test which will fail if someone throws an exception and it is not caught. I've tried mocking the `s_logger

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-207898283 @swill I beleieve we can do a better test. After the VPN is set up we can do something like `ike-scan -M 172.16.21.200` to see if the VPN opened up. I'll test

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-08 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-207676112 @swill I've squashed the commits @kollyma I'm sorry I missed your message. Do you still see a problem? Something strage that I see in your output

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-207898130 @rafaelweingartner Done. Although I didn't create any test cases yet. There is nothing much to test. The function doesn't throw any execptions, doesn't expect any

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-208176655 @rafaelweingartner Updated the comment as a javadoc. For the test. I am not sure what the best strategy is. Maybe you can help me understand better. Would

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-03-25 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-201355723 @kollyma This was happening for swift because the `template.properties` file was not correctly populated. So, when a management restart happens, it syncs data from

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-03-02 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1424#discussion_r54762401 --- Diff: server/src/com/cloud/template/TemplateManagerImpl.java --- @@ -275,6 +277,8 @@ private StorageCacheManager cacheMgr; @Inject

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-03-02 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1424#discussion_r54762197 --- Diff: server/src/com/cloud/api/ApiResponseHelper.java --- @@ -1388,7 +1388,7 @@ public TemplateResponse createTemplateUpdateResponse(ResponseView view

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-209759974 For sure @rafaelweingartner. As I have outlined in my mail to you, I've been basically following the practices that have been put in place by the previous developers

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1424 [CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region store This PR fixes a case where when we create a template from a snpashot in a region wide store, we don't

[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

2016-05-19 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481 Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM. ``` $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-24 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-24 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-16 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-16 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219162095 @swill I got the file from jenkins and it points to `utils/testsmallfileinactive` ... I have no idea where this file came from --- If your project is set up

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1331 Fix Sync of template.properties in Swift When using Swift as a secondary storage, we create a template.properties file which stores the metadata about the template. Currently the data which

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219166142 @DaanHoogland sure ... doesn't hurt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-10 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-218154430 @swill the problem is because of `LocalNfsSecondaryStorageResourceTest`. Before my commit, tests were ignored for this module probably because of the above file

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-18 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-211455173 Loving the discussion here guys! Based on the comments by @jburwell I found http://stackoverflow.com/questions/1827677/how-to-do-a-junit-assert-on-a-message

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-19 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211996541 @bhaisaab Do you have an idea of why Marvin is failing on my dev setup? I've followed the guide mentioned [here](https://cwiki.apache.org/confluence/display

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-19 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-19 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-211995051 @rafaelweingartner I've added the test mocking the `BufferedWriter`. When I tried to run the tests I found that the test required `agent.properties` and `log4j.xml

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211374488 @swill I have added a marvin test to see if the VPN service starts correctly however I am having trouble getting marvin to work correctly. When I run the test I get

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-19 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-21 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-212907833 @jburwell @rafaelweingartner I've added the test for checking the logged message using the gist provided by @jburwell. I've also added a `log4j.xml` because the test

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

2016-04-21 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1501#issuecomment-212800599 LGTM based on code review @mike-tutkowski cc @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62505096 --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java --- @@ -21,7 +21,13 @@ import

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62505426 --- Diff: engine/components-api/src/com/cloud/agent/Listener.java --- @@ -87,6 +93,18 @@ boolean processDisconnect(long agentId, Status state

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62505386 --- Diff: engine/components-api/src/com/cloud/agent/Listener.java --- @@ -87,6 +93,18 @@ boolean processDisconnect(long agentId, Status state

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62508121 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -933,7 +937,7 @@ private PlugNicAnswer execute

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62509667 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -18,40 +18,69

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62509977 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -65,22 +94,182 @@ public

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62511172 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -91,18 +280,5 @@ public

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62513240 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod, final String

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

2016-05-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217890036 @mike-tutkowski I've reviewed the code and it LGTM. I have a few minor comments that should be fairly simple to adress. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-217971133 @rafaelweingartner @jburwell Sorry for the late reply to this. I was on vacation and returned today. I've decided to use John's approach for the logging test as I

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-217972386 @rhtyd Squashed. It is pending a LGTM. If you can have a quick look at this one, it would be awesome! --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-217972968 @swill Sqashed. I believe this is good to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-13 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Thanks @karuturi for your comments, I will get to them as soon as I have some free cycles. Right now this is only supported for XenServer as this requires the backend to be able to do native

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-11 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I think the `Destroyed` state should suffice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1595: ui: show resize volume button to all users

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1595 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 @swill. I've fixed the whitespaces and rebased everything. Should be good now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1597: added constant for magic code

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1597 Looks like there are some trailing space problems. Can you please fix that @vcharmcaster ``` /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy

[GitHub] cloudstack issue #1597: added constant for magic code

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1597 @vcharmcaster it looks like your commit still did not fix the problems. Can you check the problems I mentioned in my previous comments. There are some trailing spaces and tabs which need

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-06 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks guys. The code LGTM based on the code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-06 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 Thanks @romain-dartigues based on your comments the code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-06 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 we do have to remember that arping is ipv4 only so we need to fix this for ipv6 too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-04 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski , the list snapshot already returns the `loacationType`. I think you've already added that. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations

2016-07-05 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1604#discussion_r69583623 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py --- @@ -228,7 +228,7 @@ def processCLItem(self, num, nw_type): if('localgw

[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1586 agree with @yvsubhash. I don't see an need to set the name-label to `detached` the code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 @romain-dartigues do we know why the `arping` is failing? Ideally, if the vif is configured correctly, the arping should go through properly. If the `arping` fails, do we still know

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks @serg38 my question is more along the lines of can this `fullClone`/ `linkedClone` functionality be extended to other hypervisors, in that case, we can make the code hypervisor agnostic

  1   2   3   4   5   6   >