Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1716
this is not an isolated issue.
See https://issues.apache.org/jira/browse/CLOUDSTACK-8186
it would be better to fix it in framework/db/
---
If your project is set up for it, you can
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2041
@Slair1 this is already fixed by commit ba9dcba in 4.10/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2033
@karuturi LGTM. I did not see big difference from #1950
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1950
it would be nice if this can be merged into 4.10.0.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1950#discussion_r109633875
--- Diff: debian/control ---
@@ -16,14 +16,15 @@ Description: A common package which contains files
which are shared by several C
Package
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/2025
Fix error in restart network in 4.10.0.0 RC
The PR fixes the error in restart network:
2017-04-04 10:27:39,217 DEBUG [c.c.n.r.NetworkHelperImpl]
(API-Job-Executor-2:ctx-08904854 job
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@rhtyd it seems we can discard 'router' in vpc part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
LGTM now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2011
@DaanHoogland @karuturi @borisstoyanov
Here is a short explanation why the issue happened:
Normally getBroadcastUriFromBridge method in KVM plugin will get the URI
from
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@karuturi to be honest, I think PR#2011 fixes the issue, not this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2011
@borisstoyanov first 4.9, then merge into master.
this patch can also be applied to master.
```
wget --no-check-certificate
https://github.com/apache/cloudstack/pull/2011.patch
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/2011
CLOUDSTACK-9811: fix duplicated nics on VR caused by nic name
pp
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov could you please test with my suggestion? I think it should
fix the duplicated nics in VR.
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1889
LGTM, please merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1889
@rashmidixit finally I decide to say LGTM to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1889
@rashmidixit thanks for the update.
Compared with old patch, I notice you changed the return if args.page == 1.
However, it does not solve my issue. We have several hosts (more than 1
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov
I suspect this is caused by the name of your public interface (p55p1).
can you please try the following change
```
diff --git
a/plugins/hypervisors/kvm/src
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov I think this is caused by KVM plugin.
can you please perform the following on KVM host ?
(1) change INFO to DEBUG in /etc/cloudstack/agent/log4j-cloud.xml, and
restart
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@swill
first_i_p in json -> firstIP in java. This is formatted by google.gson
it is defined in api/src/com/cloud/agent/api/to/IpAddressTO.java, and used
in server/src/com/cl
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
nics in database seems ok, so it looks some issue in creating
ip_associations.json
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1726
code LGTM
@yvsubhash it would be nice if you can reformat part of the code with java
code conventions.
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov moreover, can you please restart the network with cleanup,
to see if the new VRs can start ?
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov what's the last commit in your code ?
could you check how many nics attached to the VR in database, select * from
nics where instance_id= ?
---
If your project is set up
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
it seems nicDevId is not set correctly in java code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov are you using vpc ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@swill what I mean is , if you do not want to change the logic, do you need
to change 'else:' to 'elif index == -1:' ?
---
If your project is set up for it, you can reply to this email
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1889
@rashmidixit thanks for your work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
not tested it. but it seems the 'else' part also need to be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1889
@rashmidixit We have ported it in our branch and found it inconvenient to
click the OK button in dialog with warning "No more hosts are available for
migration" frequently.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1965
@bvbharatk Yes, you might know only the vm has sshkey attached will have
the password in vm details. If the vm does not have ssh keypair, then the vm
password will not saved
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1999
@resmo I agree with adding vpcid to NicResponse, then you do not need an
extra API call. You only need to search NicResponse in loop.
---
If your project is set up for it, you can reply
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1999
@resmo please create another vpc and some vpc tiers, and have a retry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1999
@resmo I still think vpcid should not be added to UserVmResponse, because
vm can be added to multiple vpc tiers (same as networks, this is why I asked
about networkid at the beginning), I
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1999
@resmo VM can be part of any isolated networks, shared networks, vpc tiers.
You can try adding another vpc tier to an existing vm in a vpc.
Anyway, adding Vpcid in NicResponse
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1999
two questions
(1) is the network id set in response ? It seems not. Why do we set vpcid
but not networkid ?
(2) what if the vm is in multiple vpc tiers ?
I suggest to add
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1995
@rhtyd thanks for your explanation.
@abhinandanprateek LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1995
@abhinandanprateek can you spend time on what caused the issue ?
The VR will not be stopped with this PR, it will help troubleshooting the
issue, good.
I never saw this issue before
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1995
@abhinandanprateek I woud say the change is good, but it does not really
fix the issue you described.
The issue seems to be caused by missing
/var/cache/cloud/cloud-scripts-signature
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1868
@anshul1886 good, I will test it.
Could you please change the default value to true ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1988
awesome
@DaanHoogland could you upload /etc/cloudstack/management/k8s-master.yml
and /etc/cloudstack/management/k8s-node.yml as well ?
For the license on top of some files
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana yes, you are right. I forgot it.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/827
@yvsubhash Sorry I still disagree with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana
if this is performed in project view, should projectid be passed ?
projectId: args.context.projects[0].id
---
If your project is set up for it, you can reply
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana cannot we dedicate guest vlan range to projects in other
domains ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana I think it is better to list projects by domain.
Just an example, if there are 3 projects with same name created in 3
domains, it will be difficult to choose
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1868
@anshul1886
Sorry I think it would be better to add a global setting.
This is campatible with 3.X, but not with 4.X which has more users.
---
If your project is set up for it, you
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1970
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@jayapalu LGTM
I have two questions
(1) Is it possible to disable the check ?
(2) Could you please fix CLOUDSTACK-9413 (with this PR or in new PR) ?
---
If your project
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1965
@bvbharatk I think the new password should be saved to one of the running
routers, not all running routers.
I disagree with change line 797.
---
If your project is set up for it, you
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1991
code LGTM. not tested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1991#discussion_r104393162
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
type = getIpsetType()
tmpname
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r104370668
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2263,27 +2264,43 @@ public void cleanupDownloadUrls
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana should projectId dependsOn domainId ? If the domain
changes, the project list should change according to the new domainid.
---
If your project is set up for it, you can
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1868
@anshul1886
Considering about backwards compatibility. I would like to add the global
setting, then users will have two options
(1) deploy vm fails if specified host does not have
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1868
Do we need to add a global setting to determine whether deploy to other
hosts if the specified host is out of capacity ?
---
If your project is set up for it, you can reply to this email
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1773
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1980
is there any issue for normal users ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana I thought dedicating guest vlan range is already
implemented in CLOUDSTACK-8958.
Actually they are two stories.
In this case, we have to remove the Domain scope from
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1771
@nitin-maharana you may add "ignoreProject: true" in
createURL('dedicateGuestVlanRange') if scope is set to Domain
---
If your project is set up for it, you can reply to
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1241
I am wondering if this is a general issue when create other resources
(volume,vm,etc) using integration port 8096.
---
If your project is set up for it, you can reply to this email
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1978#discussion_r103416124
--- Diff: server/test/resources/createNetworkOffering.xml ---
@@ -34,22 +34,23
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1907
code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1972
code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1950
updated.
changes
(1) add init-system-helpers version
(2) add ExecStartPre to avoid the issue caused by JAVA_HOME
---
If your project is set up for it, you can reply
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1950
@rhtyd The permission issue seems to be caused by
./scripts/vm/systemvm/injectkeys.sh
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1972#discussion_r103072546
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java
---
@@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1922
LGTM as it is same to commit edd839ab10226760749d4fc15703a41eddc1dfdd
not tested yet, as VPC with RVR is working fine, so I assume this fixes the
issue in VPC with single VR
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1950#discussion_r102716218
--- Diff: .gitignore ---
@@ -51,7 +51,6 @@ tools/cli/build/
*.jar
*.war
*.mar
-*.zip
--- End diff --
@wido ,yes
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1965
@bvbharatk can you format the code ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
@jayapalu Thanks. Have you made changes for kvm ? I cannot find
GetVmIpAddressCommand in plugins/hypervisors/kvm(actually only find it in
plugins/hypervisors/xenserver/)
---
If your
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1873
code LGTM
one small suggestion:
Could you modify line 2253 (_vmIpFetchThreadExecutor.execute) to be
executed only when hypervisor is XenServer(already supported) or Vmware
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1957
tested. LGTM
btw, you can use "git push --force" to overwrite the code
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1957#discussion_r102209429
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java
---
@@ -621,6 +627,10 @@ public void
doInTransactionWithoutResult
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut maxsize is fine for me.
Could you please remove delaycompress, and increase rotate in
systemvm/patches/debian/config/etc/logrotate.d/cloud (eg from 4 to 10) ?
LTGM after
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1954
quite simple and useful change. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@priyankparihar the default behaviour is forced=true from few years ago. If
the template is removed, the user vm is not impacted which is very good. There
is indeed an issue when reinstall
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101968821
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1915
1. As @dmabry said, the logrotate is moved from cron.daily to cron.hourly
in isolated network VR in commit.
We should make similar change for VPC VR and VR for shared network
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@dmabry I will test it and update you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@serg38 yes, your approach is the best solution for now.
By the way, I've implemented the copy of template between storage pools on
kvm/nfs in our branch, not implemented for other
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1915
agree with @dmabry
logrotate need to be moved (or copied) to cron.hourly
```
diff --git a/systemvm/patches/debian/config/etc/cron.hourly/logrotate
b/systemvm/patches/debian
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1952
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@priyankparihar
1. the file change from 10644 to 10755 is not necessary
2. the default value of forced is false, might cause issue on backwards
compatibility
3. In the vm
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1950
CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support
tomcat6/tomcat7
Changes
(1) add systemd support in debian/control and debian/rules for 16.04
(2) add python
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1916
@borisstoyanov It is weird I did not specify the minimal version of
init-system-helpers in debian/control. Did you build the packages on ubuntu
16.04 and install it on ubuntu 14.04
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1916
@rhtyd As 4.9 is LTS version, it seems not good to drop ubuntu 12.04
support in next minor release (4.9.3 ?), some customers may still use ubuntu
12.04 as management server.
I
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1857
@adwaitpatankar oh, I totally understand the issue and the change you made.
You are right as I remember. However, I think the recalculation on other
accounts in the domain is not necessary
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1857
@adwaitpatankar this is because _resourceLimitMgr.recalculateResourceCount
only recalculate the resource count on account(if accountid is set), or domain
(if accountid is not set), not both
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1874
harmless change, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1916
@rhtyd then I will close this PR, and create another PR for 4.10/master.
Someone who run with 4.9 LTS and want to have 16.04 systemd support, can
feel free to merge this PR
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1771#discussion_r101618476
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan
dedicateGuestVlanRange
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut I agree with reducing the size.
However, I suggest to
(1) remove the delaycompress, then the files like syslog.1 or rsyslog.1
will be compressed.
(2) keep rotate
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101515754
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1947
CLOUDSTACK-9789: Fix releasing secondary guest IP fails with associated
static nat which is actually not used
You can merge this pull request into a Git repository by running:
$ git
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1946
CLOUDSTACK-9788: Fix exception listNetworks with pagesize=0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1945
CLOUDSTACK-9787: Fix wrong return value in NetUtils.isNetworkAWithinNetworkB
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1910
@Ashadeepa your comments in previous comment is not what I expect.
In my opinion, if username and keyword are both set, we should search by
both condition, but only one.
You
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/847
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 462 matches
Mail list logo
