Github user dmabry closed the pull request at:
https://github.com/apache/cloudstack/pull/1974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1974
Thanks @rhtyd!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dmabry closed the pull request at:
https://github.com/apache/cloudstack/pull/1973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1973
Closing PR as it will be cherry-picked from master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1974
shall I close this PR or do you guys need it open to make sure the
cherry-pick happens?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1973
Did a git cherry-pick as suggested by @rafaelweingartner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1974
Done. I'll also do a cherry pick on the other PR. Thanks for the guidance
@rafaelweingartner.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1974
@rafaelweingartner No problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1954
@rhtyd I have created PRs for 4.8 and 4.9. They are PR #1973 and PR #1974
respectively.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/1974
CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for
vpcrouter
[BACKPORT PR1954]
moved logrotate from cron.daily to cron.hourly for vpcrouter in
cloud-early-config
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/1973
CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for
vpcrouter
[BACKPORT PR1954]
moved logrotate from cron.daily to cron.hourly for vpcrouter in
cloud-early-config
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1954
@rhtyd Sure, no problem. How would you like to handle the back porting?
Do you want me to open PRs against 4.8 and 4.9?
---
If your project is set up for it, you can reply to this email
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
LGTM. tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1954
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1954
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut Can you do a force push to kick off jenkins again. I'm guessing
Jenkins just had an issue and not the PR.
---
If your project is set up for it, you can reply to this email and have
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1955
We are deploying this to our QA environment right now and hope to have it
tested in a few days. Great work @kiwiflyer and @nathanejohnson.
---
If your project is set up for it, you can reply
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut I agree with @ustcweizhou. Please remove delaycompress and up to
10. I'd like to get this PR in as it is the second part of the problem
resolution for my issue. After that LGTM
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@ustcweizhou Thanks for taking the time to test as well. I confirm in our
testing over the weekend that we were able to consistently
create/destroy/expunge VMs every 2 minutes without issue
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
I have submitted a PR against master that fixes cloud-early-config.
https://github.com/apache/cloudstack/pull/1954
---
If your project is set up for it, you can reply to this email and have
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/1954
CLOUDSTACK-9795: moved logrotate from cron.daily to cron.hourly for
vpcrouter
in cloud-early-config
You can merge this pull request into a Git repository by running:
$ git pull https
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@serbaut Just curious, are you using VPC routers?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
@ustcweizhou - Thanks for the +1 on cron.hourly move. From looking at the
code, it looks like non-redundant VRs are already moving to cron.hourly, but
vpcrouter isn't. In our case, we
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1915
Agreed with @leprechau . I don't think just changing logrotate to compress
and rotate at smaller size intervals will not completely solve our issues here.
We really need to adjust logrotate
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1943
LGTM based on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1590
Sorry, I put this pull request against the wrong tree. That's what I get
for being in a rush on a Monday morning.
---
If your project is set up for it, you can reply to this email and have
Github user dmabry closed the pull request at:
https://github.com/apache/cloudstack/pull/1590
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/1590
Ena vpc acl fix
This includes the patch from PR 1581 by pdube. I have manually tested and
verified that it works.
You can merge this pull request into a Git repository by running:
$ git
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1581
@pdube No problem. Think you could kick this off again and see if Travis
comes back green?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1581
I tested this in our lab with advanced networking verified the patch is
working as expected. I used the following test process.
1. Created an acl and applied it to 1 VPC Network Tier
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1581
I just kicked off a build that includes this PR. I'm going to push this to
our lab for testing and report back.
---
If your project is set up for it, you can reply to this email and have your
Github user dmabry commented on the issue:
https://github.com/apache/cloudstack/pull/1548
LGTM based code review. This is a very straight forward change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-220065889
@swill sorry for the late reply. I pulled this patch into a 4.7 bubble and
manually tested it and it worked as expected. LGTM based on manual testing
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-219764564
@swill: pulling this into a 4.7 lab now. I will manually test and verify
as soon as I can. What's my deadline? I should be able to have this tested
before EOB
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218765751
I tested this in our 4.8 HW Lab and it worked as expected. I found the
MASTER VR for a TEST VPC with a private gateway configured. I started a ping
to the private
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-218764129
Also, tested in a 4.8 lab and I was able to migrate VMs between hosts when
using VXLAN Guest Isolated network.
LGTM
---
If your project is set up
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218600092
LGTM. We tested this in our Lab on HW and all static routes on each PG
came up as expected.
---
If your project is set up for it, you can reply to this email
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-217552585
So, Si (@kiwiflyer) and I have been testing this functionality against VPCs
in our lab and we verified that static routes are indeed loaded when a VR goes
from
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217485432
We have rolled this patch in our lab and verified that it does indeed
report the number of sockets correctly. Based on testing this LGTM.
Please do a force
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217482136
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-217322431
I know it doesn't really need my LGTM, but this commit definitely improves
the accuracy, and possibly the performance, of marvin and I'd personally like
to see
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217321289
I ran this in our lab and tested the failover and works as expected. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215120369
OK, all checks have passed! ;) Looking for another LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215103808
Yea, I saw that jenkins failed pulling 4.7 branch, so I kicked it off
again. I'm going to keep an eye on travis and jenkins. There is no reason
those tests should
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215084188
[test_volumes_NV6XFO.zip](https://github.com/apache/cloudstack/files/238694/test_volumes_NV6XFO.zip)
Here is the zip file containing the test results
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215083560
Ok, I have run this through my lab again and specifically ran the
test_volumes.py file. All tests passed. See below. I have also attached the
results dir
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-213853837
I made all requested changes. I'm going to run a full bubble CI test
against this PR and I will post the results.
---
If your project is set up for it, you can
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602700
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602140
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602084
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60585058
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60584441
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582709
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582064
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60581671
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212426369
@koushik-das - Thanks for the feedback. I have added the
require_hardware="false" as you suggested and pushed a new commit to the branch.
If all
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212085924
Ok, I have made the requested changes. Please review and let me know if
there is anything else I need to change.
---
If your project is set up for it, you can
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60225742
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60222679
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60222132
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-21138
Here is a manual test using cloudmonkey against our KVM lab.
`(local) ðµ > list volumes
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 listall=t
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/1500
CLOUDSTACK-9349
This PR addresses the KVM detach/attach ROOT disks from VMs
(CLOUDSTACK-9349). In short, this allows the KVM Hypervisor, and I added the
Simulator as a valid hypervisor
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-193407327
@remibergsma , We loaded up the management server with this patch and it
appears to work just fine on 4.7.1 with db.ha.enable=false and db.cloud.slaves
left blank
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150588016
@DaanHoogland Sounds good. I'll hold off. Thanks for the help.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/966#issuecomment-150582452
I'll take a look at #812 and see about combining them into this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user dmabry opened a pull request:
https://github.com/apache/cloudstack/pull/966
Added support for KVM teamd devices to LibvirtComputingResource.java
This will allow KVM users to utilize teamd nic teaming devices named team*.
You can merge this pull request into a Git
66 matches
Mail list logo
