[GitHub] cloudstack issue #1716: CLOUDSTACK-9555 when a template is deleted and then ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1716
  
this is not an isolated issue.
See https://issues.apache.org/jira/browse/CLOUDSTACK-8186
it would be better to fix it in framework/db/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2041: CLOUDSTACK-9873: VR related periodic jobs are schedu...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2041
  
@Slair1 this is already fixed by commit ba9dcba in 4.10/master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2033: [master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 1...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2033
  
@karuturi LGTM. I did not see big difference from #1950 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
it would be nice if this can be merged into 4.10.0.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r109633875
  
--- Diff: debian/control ---
@@ -16,14 +16,15 @@ Description: A common package which contains files 
which are shared by several C
 Package: cloudstack-management
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends}, openjdk-8-jre-headless | 
java8-runtime-headless | java8-runtime, cloudstack-common (= 
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector, 
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool, lsb-release
+Recommends: init-system-helpers (>= 1.14)
--- End diff --

@rhtyd Sorry I just noticed your comment.  I will remove all 3 lines
Recommends: init-system-helpers (>= 1.14)

I am not sure if it will cause any issue. Please test it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2025: Fix error in restart network in 4.10.0.0 RC

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/2025

Fix error in restart network in 4.10.0.0 RC

The PR fixes the error in restart network:
2017-04-04 10:27:39,217 DEBUG [c.c.n.r.NetworkHelperImpl] 
(API-Job-Executor-2:ctx-08904854 job-29417 ctx-3405d3f2) (logid:19bbd6e6) 
Router requires upgrade. Unable to send command to router:9784, router template 
version : Cloudstack Release 4.10.0 Wed Feb 15 05:42:18 UTC 2017, minimal 
required version : 4.10.0.0

It works after changing minreq.sysvmtemplate.version from 4.10.0.0 to 4.10.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 4.10-restartnetwork

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2025


commit 5018b579ab1578fa22fdb2ca1ee9218d740c1df7
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date:   2017-04-04T10:43:27Z

Fix error in restart network in 4.10.0.0 RC




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1980
  
@rhtyd it seems we can discard 'router' in vpc part.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1726
  
LGTM now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@DaanHoogland @karuturi @borisstoyanov 

Here is a short explanation why the issue happened:
Normally getBroadcastUriFromBridge method in KVM plugin will get the URI 
from a bridge name. for example, breth1-100 -> vlan://100, brem1-200 -> 
vlan://200.
However, for the bridge like brp55p1-100, it will return vlan://1 which is 
obviously wrong.

The method getBroadcastUriFromBridge  is used in 
prepareNetworkElementCommand for command IpAssocCommand  in VR. Each time when 
a new ip is associated, it will check the existing nics by getting the URIs 
from bridge name of nics. If the URIs do not contain the uri of te new ip, then 
a new nic will be plugged and new ip will be associated to the new nic.

The issue happened when cloudstack try to set more information of  eth2 
(public nic) of a VR, as for the error described in part 1 , the URI of eth2 
return wrong result (vlan://1) which is different from uri of ip (it is 
vlan://7 from StartCommand), so eth3 is added.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@karuturi to be honest, I think PR#2011 fixes the issue, not this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2011: CLOUDSTACK-9811: fix duplicated nics on VR caused by...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2011
  
@borisstoyanov first 4.9, then merge into master.
this patch can also be applied to master.
```
wget --no-check-certificate 
https://github.com/apache/cloudstack/pull/2011.patch
git am 2011.patch 
(or patch -p1 <2011.patch)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2011: CLOUDSTACK-9811: fix duplicated nics on VR ca...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/2011

CLOUDSTACK-9811: fix duplicated nics on VR caused by nic name 
pp



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack fix-issue-p55p1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2011


commit cf442b459ae79ff7828c0ae868c4e1af9c078f01
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date:   2017-03-16T10:48:35Z

CLOUDSTACK-9811: fix duplicated nics on VR caused by nic name 
pp




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov could you please test with my suggestion? I think it should 
fix the duplicated nics in VR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
LGTM, please merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit finally  I decide to say LGTM to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit thanks for the update.
Compared with old patch, I notice you changed the return if args.page == 1.
However, it does not solve my issue. We have several hosts (more than 1 
page). Each time when I get the last page (full list),  I get the alert dialog, 
that is what I want to avoid.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov 
I suspect this is caused by the name of your public interface (p55p1). 
can you please try the following change
```
diff --git 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingReso
index d925297..706f7d9 100755
--- 
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
+++ 
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
@@ -1481,7 +1481,7 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv

 private String getBroadcastUriFromBridge(final String brName) {
 final String pif = matchPifFileInDirectory(brName);
-final Pattern pattern = 
Pattern.compile("(\\D+)(\\d+)(\\D*)(\\d*)");
+final Pattern pattern = 
Pattern.compile("(\\D+)(\\d+)(\\D*)(\\d*)(\\D*)(\\d*)");
 final Matcher matcher = pattern.matcher(pif);
 s_logger.debug("getting broadcast uri for pif " + pif + " and 
bridge " + brName);
 if(matcher.find()) {
@@ -1489,7 +1489,9 @@ public class LibvirtComputingResource extends 
ServerResourceBase implements Serv
 return 
BroadcastDomainType.Vxlan.toUri(matcher.group(2)).toString();
 }
 else{
-if (!matcher.group(4).isEmpty()) {
+if (!matcher.group(6).isEmpty()) {
+return 
BroadcastDomainType.Vlan.toUri(matcher.group(6)).toString();
+} else if (!matcher.group(4).isEmpty()) {
 return 
BroadcastDomainType.Vlan.toUri(matcher.group(4)).toString();
 } else {
 //untagged or not matching (eth|bond|team)#.#
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov I think this is caused by KVM plugin.
can you please perform the following on KVM host ?
(1) change INFO to DEBUG in /etc/cloudstack/agent/log4j-cloud.xml, and 
restart cloudstack-agent
(2) restart the VR (on UI), and post the StartCommand in 
/var/log/cloudstack/agent/agent.log
(3) post the xml definition of VR (virsh dumpxml r--VM)
(4) post bridge information (brctl show)
(5) post /etc/cloudstack/agent/agent.properties





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill 
first_i_p in json -> firstIP in java. This is formatted by google.gson
it is defined in api/src/com/cloud/agent/api/to/IpAddressTO.java, and used 
in server/src/com/cloud/network/router/CommandSetupHelper.java

so, the issue might be caused by commit 
baac747089ef48ea6627a6aacf27156222862352
not sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
nics in database seems ok, so it looks some issue in creating 
ip_associations.json




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1726
  
code LGTM
 @yvsubhash it would be nice if you can reformat part of the code with java 
code conventions.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov moreover, can you please restart the network with cleanup, 
to see if the new VRs can start ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov what's the last commit in your code ?
could you check how many nics attached to the VR in database, select * from 
nics where instance_id= ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
it seems nicDevId is not set correctly in java code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@borisstoyanov are you using vpc ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
@swill what I mean is , if you do not want to change the logic, do you need 
to change 'else:' to 'elif index == -1:' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit thanks for your work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2003: fixed an issue if the dev is not in the databag

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/2003
  
not tested it. but it seems the 'else' part also need to be changed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit We have ported it in our branch and found it inconvenient to 
click the OK button in dialog with warning "No more hosts are available for 
migration" frequently.

could you remove the line below ?
```
 
cloudStack.dialog.notice({
 message: 
_l('message.no.host.available')
 }); //Only a 
single host in the set up
-} else {
- 
cloudStack.dialog.notice({
- message: 
_l('message.no.more.hosts.available')
- });
 }
 }
 });
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@bvbharatk Yes, you might know only the vm has sshkey attached will have 
the password in vm details. If the vm does not have ssh keypair, then the vm 
password will not saved into user_vm_details.

Actually the vm password should be synced between master and backup. Saving 
to only one of them or saving to both of them are not working fine.
for example, if we save password in master, but not save it in backup. Once 
the master is down, then vm cannot get password from backup vr.
another example is, if we save password on both of master and backup, if vm 
get the password from master and reset it, once the master is down (or 
master->backup switch) and we reboot vm later, the vm will get the old password 
from backup again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1999
  
@resmo I agree with adding vpcid to NicResponse, then you do not need an 
extra API call. You only need to search NicResponse in loop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1999
  
@resmo please create another vpc and some vpc tiers, and have a retry



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1999
  
@resmo I still think vpcid should not be added to UserVmResponse, because 
vm can be added to multiple vpc tiers (same as networks, this is why I asked 
about networkid at the beginning), I just confirmed yes.

I am not clear what your issue is. Anyway, if you want to know which vpc 
the vm belongs to, you can still get the vpcid from NicResponse (even now, if 
you get networkid of nic, then you can get the vpcid from networkid via 
ListNetworks).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1999
  
@resmo VM can be part of any isolated networks, shared networks, vpc tiers. 
You can try adding another vpc tier to an existing vm in a vpc.

Anyway, adding Vpcid in NicResponse makes more sense.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1999
  
two questions
(1) is the network id set in response ? It seems not. Why do we set vpcid 
but not networkid ?
(2) what if the vm is in multiple vpc tiers ?

I suggest to add vpcid to NicResponse, instead of UserVmResponse.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1995
  
@rhtyd thanks for your explanation.
@abhinandanprateek LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1995
  
@abhinandanprateek can you spend time on what caused the issue ?
The VR will not be stopped with this PR, it will help troubleshooting the 
issue, good.
I never saw this issue before actually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1995
  
@abhinandanprateek I woud say the change is good, but it does not really 
fix the issue you described.
The issue seems to be caused by missing 
/var/cache/cloud/cloud-scripts-signature
The file should be created in cloud-early-config. How could it be missed ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1868
  
@anshul1886 good, I will test it.
Could you please change the default value to true ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1988: WIP: CLOUDSTACK-9815 intergration of ApplicationClus...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1988
  
awesome

@DaanHoogland  could you upload /etc/cloudstack/management/k8s-master.yml 
and /etc/cloudstack/management/k8s-node.yml as well ?

For the license on top of some files, will you change it ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana yes, you are right. I forgot it. 
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #827: BUG-ID: CLOUDSTACK-8849: Usage job should stop usage ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/827
  
@yvsubhash Sorry I still disagree with it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana 
if this is performed in project view, should projectid be passed ?
projectId: args.context.projects[0].id


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana cannot we dedicate guest vlan range to projects in other 
domains ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana I think it is better to list projects by domain.
Just an example, if there are 3 projects with same name created in 3 
domains, it will be difficult to choose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1868
  
@anshul1886 
Sorry I think it would be better to add a global setting.
This is campatible with 3.X, but not with 4.X which has more users.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1970: CLOUDSTACK-9725 Failed to update VPC Network during ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1970
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@jayapalu  LGTM

I have two questions
(1) Is it possible to disable the check ?
(2) Could you please fix CLOUDSTACK-9413 (with this PR or in new PR) ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@bvbharatk  I think the new password should be saved to one of the running 
routers, not all running routers.
I disagree with change line 797.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1991
  
code LGTM. not tested.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1991#discussion_r104393162
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -1267,9 +1267,9 @@ def cache_ipset_keyword():
 type = getIpsetType()
 tmpname = 'ipsetqzvxtmp'
 try:
-util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
+util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])
--- End diff --

is the space after "-N". "-F" . "-X" needed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1726#discussion_r104370668
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2263,27 +2264,43 @@ public void cleanupDownloadUrls(){
 
 // Cleanup expired volume URLs
 List volumesOnImageStoreList = 
_volumeStoreDao.listVolumeDownloadUrls();
+HashSet expiredVolumeIds = new HashSet();
+HashSet activeVolumeIds = new HashSet();
 for(VolumeDataStoreVO volumeOnImageStore : 
volumesOnImageStoreList){
 
+long volumeId = volumeOnImageStore.getVolumeId();
 try {
 long downloadUrlCurrentAgeInSecs = 
DateUtil.getTimeDifference(DateUtil.now(), 
volumeOnImageStore.getExtractUrlCreated());
 if(downloadUrlCurrentAgeInSecs < 
_downloadUrlExpirationInterval){  // URL hasnt expired yet
+activeVolumeIds.add(volumeId);
 continue;
 }
-
-s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + 
volumeOnImageStore.getVolumeId());
+expiredVolumeIds.add(volumeId);
+s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
 
 // Remove it from image store
 ImageStoreEntity secStore = (ImageStoreEntity) 
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(), 
DataStoreRole.Image);
 
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(), 
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
 
+_snapshotStoreDao.findByVolume(volumeId, 
DataStoreRole.Image);
--- End diff --

what's the proposal of line 2285 to line 2287 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana should projectId dependsOn domainId ? If the domain 
changes, the project list should change according to the new domainid.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1868
  
@anshul1886 
Considering about backwards compatibility. I would like to add the global 
setting, then users will have two options
(1) deploy vm fails if specified host does not have enough capacity. This 
is what this PR wants to do.
(2) deploy to other hosts if specified host does not have enough capacity. 
In this case, the specified host can be regarded as the perferred host. This is 
also what cloudstack works currently.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1868
  
Do we need to add a global setting to determine whether deploy to other 
hosts if the specified host is out of capacity ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1980
  
tested. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1980
  
is there any issue for normal users ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana I thought dedicating guest vlan range is already 
implemented in CLOUDSTACK-8958.
Actually they are two stories.
In this case, we have to remove the Domain scope from UI as it is not 
supported, unless you make more changes to support it (similar to 
37301ed4540450c29be4f975d58b38dbeec6c296 for CLOUDSTACK-8958).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN range to Pr...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1771
  
@nitin-maharana you may add "ignoreProject: true" in 
createURL('dedicateGuestVlanRange') if scope is set to Domain


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1241
  
I am wondering if this is a general issue when create other resources 
(volume,vm,etc) using integration port 8096.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1978: CLOUDSTACK-9779 : Releasing secondary guest I...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1978#discussion_r103416124
  
--- Diff: server/test/resources/createNetworkOffering.xml ---
@@ -34,22 +34,23 @@
 
 
 
-
-  
-
-
-
-
-
-
-
+
+  
+
+
+
+
+
+
+
 
 
-
-
-
-
+
+
+
+
 
+
--- End diff --

this change LGTM, otherwise the unit tests will fail


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1907
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1972
  
code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
updated.
changes
(1) add init-system-helpers version
(2) add ExecStartPre to avoid the issue caused by JAVA_HOME


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@rhtyd The permission issue seems to be caused by 
./scripts/vm/systemvm/injectkeys.sh


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1972: CLOUDSTACK-9779 : Releasing secondary guest I...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1972#discussion_r103072546
  
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java 
---
@@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl() {
 return listBy(sc);
 }
 
+@Override
+public boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, 
String instanceIp, long networkId, FirewallRule.Purpose purpose)
+{
+SearchBuilder lbVmMapSearch = 
_loadBalancerVMMapDao.createSearchBuilder();
+lbVmMapSearch.and("instanceIp", 
lbVmMapSearch.entity().getInstanceIp(),SearchCriteria.Op.EQ);
+lbVmMapSearch.and("instanceId", 
lbVmMapSearch.entity().getInstanceId(), SearchCriteria.Op.EQ);
+
+SearchBuilder firewallRuleIdSearch = 
_firewallRulesDao.createSearchBuilder();
--- End diff --

You might know LoadBalancerVO extends FirewallRuleVO, you can use 
LoadBalancerVO instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1922
  
LGTM as it is same to commit edd839ab10226760749d4fc15703a41eddc1dfdd
not tested yet, as VPC with RVR is working fine, so I assume this fixes the 
issue in VPC with single VR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r102716218
  
--- Diff: .gitignore ---
@@ -51,7 +51,6 @@ tools/cli/build/
 *.jar
 *.war
 *.mar
-*.zip
--- End diff --

@wido ,yes, ./core/test/resources/vhds/test.vhd.zip for testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@bvbharatk can you format the code ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
@jayapalu Thanks. Have you made changes for kvm ? I cannot find 
GetVmIpAddressCommand in plugins/hypervisors/kvm(actually only find it in 
plugins/hypervisors/xenserver/)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
code LGTM

one small suggestion: 
Could you modify line 2253 (_vmIpFetchThreadExecutor.execute) to be 
executed only when hypervisor is XenServer(already supported) or Vmware 
(supported by this PR) ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1957
  
tested. LGTM

btw, you can use "git push --force" to overwrite the code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1957#discussion_r102209429
  
--- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java 
---
@@ -621,6 +627,10 @@ public void 
doInTransactionWithoutResult(TransactionStatus status) {
 sc.setParameters("username", username);
 }
 
+if (keyword!= null) {
--- End diff --

it seems line 630 to 633 are not needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@serbaut maxsize is fine for me.
Could you please remove delaycompress, and increase rotate in 
systemvm/patches/debian/config/etc/logrotate.d/cloud (eg from 4 to 10) ?
LTGM after that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1954
  
quite simple and useful change. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar the default behaviour is forced=true from few years ago. If 
the template is removed, the user vm is not impacted which is very good. There 
is indeed an issue when reinstall the vm. For you it could be a very risky 
issue. For us at least it is not a big issue as we provide some other templates 
for vm reinstallation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1937#discussion_r101968821
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long 
ipAddressId) {
 throw new InvalidParameterValueException("Can' remove the 
ip " + secondaryIp + "is associate with static NAT rule public IP address id " 
+ publicIpVO.getId());
 }
 
-if (_lbService.isLbRuleMappedToVmGuestIp(secondaryIp)) {
+List lbRuleIdList = 
_firewallDao.listIdByNetworkAndPurposeAndNotRevoked(network.getId(), 
Purpose.LoadBalancing);
--- End diff --

@niteshsarda sorry what I said is not clear. You added two methods in Daos: 
listIdByNetworkAndPurposeAndNotRevoked and 
listByLoadBalancerIdVmIdAndInstanceIp, I suggest to implement it by one method 
in LoadBalancerDaoImpl.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
1. As @dmabry said, the logrotate is moved from cron.daily to cron.hourly 
in isolated network VR in commit.
We should make similar change for VPC VR and VR for shared network.
```
commit 6ac06e5e5e3ceed4a3e3a86ea5f82ffb59c266f2
Author: Abhinandan Prateek <abhinandan.prat...@shapeblue.com>
AuthorDate: Mon Mar 30 11:36:11 2015 +0530
Commit: Abhinandan Prateek <abhinandan.prat...@shapeblue.com>
CommitDate: Mon Mar 30 13:49:23 2015 +0530

CLOUDSTACK-6885: rotate logs hourly on VR
---
 .../debian/config/etc/init.d/cloud-early-config|4 
 systemvm/patches/debian/config/etc/logrotate.conf  |2 +-
 .../patches/debian/config/etc/logrotate.d/cloud|3 ---
 .../patches/debian/config/etc/logrotate.d/rsyslog  |2 ++
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/systemvm/patches/debian/config/etc/init.d/cloud-early-config 
b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
index 729b58f..5a2ee6f 100755
--- a/systemvm/patches/debian/config/etc/init.d/cloud-early-config
+++ b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
@@ -995,6 +995,10 @@ setup_router() {
   sed -i "s/-A INPUT -i eth0 -p udp -m udp --dport 53 -j ACCEPT/-A INPUT 
-i eth0 -p udp -m udp --dport 53 -s $DHCP_RANGE\/$CIDR_SIZE -j ACCEPT/g" 
/etc/iptables/rules
   sed -i "s/-A INPUT -i eth0 -p tcp -m tcp --dport 53 -j ACCEPT/-A INPUT 
-i eth0 -p tcp -m tcp --dport 53 -s $DHCP_RANGE\/$CIDR_SIZE -j ACCEPT/g" 
/etc/iptables/rules.v4
   sed -i "s/-A INPUT -i eth0 -p tcp -m tcp --dport 53 -j ACCEPT/-A INPUT 
-i eth0 -p tcp -m tcp --dport 53 -s $DHCP_RANGE\/$CIDR_SIZE -j ACCEPT/g" 
/etc/iptables/rules
+
+  #setup hourly logrotate
+  mv -n /etc/cron.daily/logrotate /etc/cron.hourly 2>&1
+
 }
```

2. size and maxsize have no difference in my testing. Anyway, maxsize is ok 
for me.

3. As I said in previous comment, we'd better use more 'rotate' for 
cloud.log

4. @dmabry If you are not confident with hourly file compress, we can add a 
file in /etc/cron.d/
```
# cat /etc/cron.d/logrorate.cloud
* * * * * root /usr/sbin/logrotate /etc/logrotate.d/cloud 2>&1 > /dev/null
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@dmabry I will test it and update you.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@serg38 yes, your approach is the best solution for now.

By the way, I've implemented the copy of template between storage pools on 
kvm/nfs in our branch, not implemented for other situations yet. The missing 
template also impact storage migration (live/offline).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
agree with @dmabry 
logrotate need to be moved (or copied) to cron.hourly
```
diff --git a/systemvm/patches/debian/config/etc/cron.hourly/logrotate 
b/systemvm/patches/debian/config/etc/cron.hourly/logrotate
new file mode 100755
index 000..055b4d5
--- /dev/null
+++ b/systemvm/patches/debian/config/etc/cron.hourly/logrotate
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+test -x /usr/sbin/logrotate || exit 0
+/usr/sbin/logrotate /etc/logrotate.conf
+
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1952: CLOUDSTACK-9790: fix NPE in case of Basic zone.

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1952
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar 
1. the file change from 10644 to 10755 is not necessary
2. the default value of forced is false, might cause issue on backwards 
compatibility
3. In the vm installation, as the template is still in use , so we can find 
it in the storage pool where the root disk is located. We need to improve it by 
using the existing template image on storage pool, or copying the template from 
storage pool where the root disk is located to another new storage pool (pool 
of allocated new root disk).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: CLOUDSTACK-9462: Build packages on Ubuntu 14....

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1950

CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support 
tomcat6/tomcat7

Changes
(1) add systemd support in debian/control and debian/rules for 16.04
(2) add python-setuptools in Build-Depends in debian/control
(3) seperate cloudstack-management.service and 
cloudstack-management.default for CentOS7 and Ubuntu 16.04
(4) add server7-ssl.xml and server7-nonssl.xml in management installation
(5) link /usr/share/cloudstack-management/lib and 
/usr/share/cloudstack-management/bin to correct path (tomcat6 or tomcat7)
(6) link /etc/cloudstack/management/server.xml to correct file path 
(server-nonssl.xml or server7-nonssl.xml)
(7) remove *.zip from .gitignore to avoid build error caused by missing 
/vhds/test.vhd.zip

Instruction
(1) build packages on Ubuntu 16.04: dpkg-buildpackage -uc -us
Output on Ubuntu 16.04:
-rw-r--r-- 1 root root  4090 Feb 17 10:12 
cloudstack_4.10.0.0-SNAPSHOT_amd64.changes
-rw-r--r-- 1 root root  1235 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.dsc
-rw-r--r-- 1 root root   8018248 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.tar.xz
-rw-r--r-- 1 root root  91868746 Feb 17 10:11 
cloudstack-agent_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52882 Feb 17 10:12 
cloudstack-cli_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  98556216 Feb 17 10:08 
cloudstack-common_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52864 Feb 17 10:12 
cloudstack-docs_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root585434 Feb 17 10:12 
cloudstack-integration-tests_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 323459934 Feb 17 10:10 
cloudstack-management_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root442656 Feb 17 10:12 
cloudstack-marvin_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  87037576 Feb 17 10:12 
cloudstack-usage_4.10.0.0-SNAPSHOT_all.deb

(2) setup tomcat6/tomcat7 on management server:
tomcat6: cloudstack-setup-management --tomcat6
tomcat7: cloudstack-setup-management --tomcat7

Already tested on Ubuntu 16.04, upgraded from 4.7.1 to 4.10.0.0-SNAPSHOT

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 4.10-ubuntu16-systemd

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1950


commit fb3d78a96ee886679699a5d5e041f198c54b978f
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date:   2017-02-17T08:59:52Z

CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support 
tomcat6/tomcat7

Changes
(1) add systemd support in debian/control and debian/rules for 16.04
(2) add python-setuptools in Build-Depends in debian/control
(3) seperate cloudstack-management.service and 
cloudstack-management.default for CentOS7 and Ubuntu 16.04
(4) add server7-ssl.xml and server7-nonssl.xml in management installation
(5) link /usr/share/cloudstack-management/lib and 
/usr/share/cloudstack-management/bin to correct path (tomcat6 or tomcat7)
(6) link /etc/cloudstack/management/server.xml to correct file path 
(server-nonssl.xml or server7-nonssl.xml)
(7) remove *.zip from .gitignore to avoid build error caused by missing 
/vhds/test.vhd.zip

Instruction
(1) build packages on Ubuntu 16.04: dpkg-buildpackage -uc -us
Output on Ubuntu 16.04:
-rw-r--r-- 1 root root  4090 Feb 17 10:12 
cloudstack_4.10.0.0-SNAPSHOT_amd64.changes
-rw-r--r-- 1 root root  1235 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.dsc
-rw-r--r-- 1 root root   8018248 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.tar.xz
-rw-r--r-- 1 root root  91868746 Feb 17 10:11 
cloudstack-agent_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52882 Feb 17 10:12 
cloudstack-cli_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  98556216 Feb 17 10:08 
cloudstack-common_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52864 Feb 17 10:12 
cloudstack-docs_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root585434 Feb 17 10:12 
cloudstack-integration-tests_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 323459934 Feb 17 10:10 
cloudstack-management_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root442656 Feb 17 10:12 
cloudstack-marvin_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  87037576 Feb 17 10:12 
cloudstack-usage_4.10.0.0-SNAPSHOT_all.deb

(2) setup tomcat6/tomcat7 on management server:
tomcat6: cloudstack-setup-management --tomcat6
tomcat7: cloudstack-setup-management --tomcat7

Already tested on Ubuntu 16.04, upgraded from 4.7.1 to 4.10.0-SN

[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@borisstoyanov  It is weird I did not specify the minimal version of 
init-system-helpers in debian/control. Did you build the packages on ubuntu 
16.04 and install it on ubuntu 14.04 ?

by the way, could you tell me what command you use to build the packages ? 
dpkg-buildpackage or packaging/build-deb.sh ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@rhtyd As 4.9 is LTS version, it seems not good to drop ubuntu 12.04 
support in next minor release (4.9.3 ?), some customers may still use ubuntu 
12.04 as management server.

I will aim to add this support from 4.10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1857: CLOUDSTACK-8284: On expunge VM, initiate resource co...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1857
  
@adwaitpatankar oh, I totally understand the issue and the change you made. 
You are right as I remember. However, I think the recalculation on other 
accounts in the domain is not necessary ( we also thought about this change 
before), so please test my suggestion in previous comment if possible.

by the way, the issue also exists in 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1857: CLOUDSTACK-8284: On expunge VM, initiate resource co...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1857
  
@adwaitpatankar this is because _resourceLimitMgr.recalculateResourceCount 
only recalculate the resource count on account(if accountid is set), or domain 
(if accountid is not set), not both account/domain.

We have this issue before, it is fixed by replacing 
_resourceLimitMgr.recalculateResourceCount with
{code}
_resourceLimitMgr.decrementResourceCount(vm.getAccountId(), 
ResourceType.primary_storage, rootVol.get(0).isDisplay(), new 
Long(rootVol.get(0).getSize()));
{code}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1874: CLOUDSTACK-9711: Fixed error reporting while adding ...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1874
  
harmless change, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@rhtyd then I will close this PR, and create another PR for 4.10/master.
Someone who run with 4.9 LTS and want to have 16.04 systemd support, can 
feel free to merge this PR into their branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1771#discussion_r101618476
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan 
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
 // Verify account is valid
 Account vlanOwner = null;
 if (projectId != null) {
-if (accountName != null) {
-throw new InvalidParameterValueException("accountName and 
projectId are mutually exclusive");
-}
+//accountName and projectId are mutually exclusive
--- End diff --

@nitin-maharana I disagree this change. We'd better keep like it.
I suggest to make ui change to add a new field 'scope' which can be set to 
'domain', 'account', 'project'.
It is similar to the scope field in the dialog to create a shared network 
in advanced zone.

scope='Domain', domain field is shown.
scope='Account, domain and account are shown
scope='Project', domain and project are shown.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@serbaut I agree with reducing the size.

However, I suggest to 
(1) remove the delaycompress, then the files like syslog.1 or rsyslog.1 
will be compressed.
(2) keep rotate , as the compressed file are quite small (< 1MB). Keeping 
more compressing files (especially cloud.log) will be helpful for 
troubleshooting in case we have some issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1937#discussion_r101515754
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long 
ipAddressId) {
 throw new InvalidParameterValueException("Can' remove the 
ip " + secondaryIp + "is associate with static NAT rule public IP address id " 
+ publicIpVO.getId());
--- End diff --

@niteshsarda I've created a PR for it: 
https://github.com/apache/cloudstack/pull/1947


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1947: CLOUDSTACK-9789: Fix releasing secondary gues...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1947

CLOUDSTACK-9789: Fix releasing secondary guest IP fails with associated 
static nat which is actually not used



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack RemoveSecondaryIP

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1947.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1947


commit 0f054246b65d003ae7f024b6ef125b2ec1846879
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date:   2017-02-16T13:18:56Z

CLOUDSTACK-9789: Fix releasing secondary guest IP fails with associated 
static nat which is actually not used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1946: CLOUDSTACK-9788: Fix exception listNetworks w...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1946

CLOUDSTACK-9788: Fix exception listNetworks with pagesize=0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack pagesizeIs0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1946


commit c883e294d36f64d09bed2f7e22086ab413f28d33
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date:   2017-02-16T11:01:44Z

CLOUDSTACK-9788: Fix exception listNetworks with pagesize=0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1945: CLOUDSTACK-9787: Fix wrong return value in Ne...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1945

CLOUDSTACK-9787: Fix wrong return value in NetUtils.isNetworkAWithinNetworkB



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 
isNetworkAWithinNetworkB

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1945.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1945


commit 99fcb1f2b0472d470099442dc10d21da41a8f7e3
Author: Wei Zhou <w.z...@tech.leaseweb.com>
Date:   2017-02-16T13:03:26Z

CLOUDSTACK-9787: Fix wrong return value in NetUtils.isNetworkAWithinNetworkB




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1910
  
@Ashadeepa your comments in previous comment is not what I expect.
In my opinion, if username and keyword are both set, we should search by 
both condition, but only one.

You might missed the line in your testing.
```
sb.and("keyword", sb.entity().getUsername(), 
SearchCriteria.Op.LIKE);
```
it works fine in my testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/847
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---