[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-221304669
  
@swill if you are happy to merge this without including the tests requested 
by @jburwell then this PR is ready to merge.

@luhaijiao I've created CLOUDSTACK-9385 to deal with the password server 
not running on redundant virtual routers. Please can you post your findings 
there if they do not match what I've described?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-221184807
  
@swill There is a question about enhanced integration testing but no code 
supplied so, tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-221162753
  
This one is green.  I think this one is ready???  Please verify if there is 
anything outstanding on this one.  Thanks...  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

GitHub user dsclose reopened a pull request:

https://github.com/apache/cloudstack/pull/1514

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR

Rebase of PR #1509 against the 4.7 branch as requested by @swill 

One LGTM from @ustcweizhou carried from previous PR. Previous PR will be 
closed.

Description from PR #1509:

CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this 
is no-longer accurate, as service monitoring is not active on the post-4.6 
routers. These routers still suffer an essentially identical issue, however, 
because "dnsmasq needs to be restarted each time configure.py is called in 
order to avoid lease problems." As such, dnsmasq is still running on backup 
RvRs, causing the issues described in CLOUDSTACK-6975.

This PR is based on a patch submitted by @ustcweizhou. The code now checks 
the redundant state of the router before restarting dnsmasq.

RvR networks without this patch have dnsmasq running on both master and 
backup routers. RvR networks with this patch have dnsmasq running on only the 
master router.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-6975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1514


commit 38b3bdd488745b3ded6d54ae2d3093842bc4d763
Author: dean.close 
Date:   2016-05-09T10:34:47Z

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose closed the pull request at:

https://github.com/apache/cloudstack/pull/1514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220982534
  
@luhaijiao I reverted to a vanilla Cloudstack 4.8.0 ISO. The 
cloud-passwd-srvr service failed to start. The following appears in 
/var/log/messages on the router:

`Password server failed with error code 1. Restarting it...`

The same was true with this patch as well. In both cases, manually 
restarting the service (as the root user) was successful. I think we should 
treat the password server issue as separate and raise that elsewhere.

I'll kick off the tests again here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220964156
  
@luhaijiao I've seen the same error in our XenServer setup but wasn't sure 
what the cause is. I'd be surprised if this was the cause but it's worth 
exploring.

I will try to boot some system VMs now without this patch to see if the 
password server starts properly and then apply the patch to see if it 
subsequently fails. I'll report back here shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[luhaijiao]

Github user luhaijiao commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220950805
  
@dsclose we install this patch in our environment(ACS 4.7.1, KVM) to solve 
the password issue with RVR. 

We found the new password for VM is still incorrect unless we restart the 
password service manually. Should it be OK since we have destroy and rebuild VR 
?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose closed the pull request at:

https://github.com/apache/cloudstack/pull/1514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

GitHub user dsclose reopened a pull request:

https://github.com/apache/cloudstack/pull/1514

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR

Rebase of PR #1509 against the 4.7 branch as requested by @swill 

One LGTM from @ustcweizhou carried from previous PR. Previous PR will be 
closed.

Description from PR #1509:

CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this 
is no-longer accurate, as service monitoring is not active on the post-4.6 
routers. These routers still suffer an essentially identical issue, however, 
because "dnsmasq needs to be restarted each time configure.py is called in 
order to avoid lease problems." As such, dnsmasq is still running on backup 
RvRs, causing the issues described in CLOUDSTACK-6975.

This PR is based on a patch submitted by @ustcweizhou. The code now checks 
the redundant state of the router before restarting dnsmasq.

RvR networks without this patch have dnsmasq running on both master and 
backup routers. RvR networks with this patch have dnsmasq running on only the 
master router.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-6975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1514


commit 38b3bdd488745b3ded6d54ae2d3093842bc4d763
Author: dean.close 
Date:   2016-05-09T10:34:47Z

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220918847
  
@dsclose  you can close/reopen this PR instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220918123
  
@swill 
Pardon me - I was on leave for a week. I'll get this force pushed 
momentarily.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220738431
  
I would like to get this one re-pushed or closed and reopened so we can 
kick the CI again to see if we can get things green.  I am getting very close 
to freezing and this is one of the PRs on the edge.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220629640
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 8h 44m 23s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__May_20_2016_06_52_13_R81P2X/runinfo.txt)

**`/tmp/MarvinLogs/test_network_YQPLQU:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_YQPLQU/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_YQPLQU/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_YQPLQU/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_WA26EB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_WA26EB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_WA26EB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_WA26EB/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220629958
  
This one is coming back clean.  If we can get Jenkins and Travis green I 
think this one is ready...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220514409
  
@dsclose can you please rebase and repush this one to kick off jenkins and 
travis again.  We have fixes in both travis and jenkins so we should be able to 
get this one green.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-219536627
  
@dsclose can you rebase and re-push this PR to try to get it green.  We are 
down to the wire now.  I will probably merge some PRs that only have jenkins 
failing if travis is passing, but I don't think I can make exceptions if both 
jenkins and travis are failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-218792730
  
@dsclose we have pushed fixes to both Jenkins and Travis today.  Can you 
please do a force push or close and reopen this PR in order to kick off Jenkins 
and Travis again.  I think this one is pretty close...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825
  
LGTM. Tested in hardware lab and works as designed.

tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1514#discussion_r62344011
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
 self.cloud.commit()
 
 # We restart DNSMASQ every time the configure.py is called in 
order to avoid lease problems.
-CsHelper.service("dnsmasq", "restart")
+if not self.cl.is_redundant() or self.cl.is_master():
--- End diff --

@jburwell Whilst that check might be convenient in some cases, I think that 
convenience would be a curse. For example "bring up dnsmasq on non-redundant or 
master routers" is a nice explicit declaration of behaviour. Simplifying that 
to "bring up dnsmasq on master routers" might do the same thing but it 
increases the learning curve for someone reading the code for the first time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1514#discussion_r62329838
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
 self.cloud.commit()
 
 # We restart DNSMASQ every time the configure.py is called in 
order to avoid lease problems.
-CsHelper.service("dnsmasq", "restart")
+if not self.cl.is_redundant() or self.cl.is_master():
--- End diff --

Would is make sense for the ``is_redundant()`` check to be in the 
``is_master()`` method?  To my way of thinking, any non-redundant router is a 
de facto master.  

I understand such a change may be too far to be practical at this time, so 
we may want to table it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-217392996
  
@DaanHoogland yes, the line `CsHelper.service("dnsmasq", "restart")` in 
`set_master` is in 
systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py. When a backup 
router transitions to master, it successfully launches the dnsmasq service.

I should point out that I have only verified that the service is running. I 
have not confirmed that it is successfully configured.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-216243431
  
code looks good and functionally sane but this needs extensive testing. 
Especially when master fails the dns functionality needs to be still available, 
i.e. be started on the new master. @dsclose did you test this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-216232254
  
@rhtyd I'd love to. But I never used the Redundant VR, so I can't tell.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-216229708
  
Good pr, let's ask comments from @remibergsma @DaanHoogland @wido and 
others?

tag:needlove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-215095216
  
The test that failed is one that periodically fails in my env, so I don't 
think we can assume it is related to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-215089828
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 1
   Errors: 0
```

**Summary of the problem(s):**
```
FAIL: test_03_vpc_privategw_restart_vpc_cleanup 
(integration.smoke.test_privategw_acl.TestPrivateGwACL)
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
265, in test_03_vpc_privategw_restart_vpc_cleanup
self.performVPCTests(vpc_off, True)
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
331, in performVPCTests
self.check_pvt_gw_connectivity(vm1, public_ip_1, vm2.nic[0].ipaddress)
  File 
"/data/git/cs2/cloudstack/test/integration/smoke/test_privategw_acl.py", line 
559, in check_pvt_gw_connectivity
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
--
Additional details in: /tmp/MarvinLogs/test_network_FCU6EL/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_55_22_XGXMQ6:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_55_22_XGXMQ6/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_55_22_XGXMQ6/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/DeployDataCenter__Apr_27_2016_06_55_22_XGXMQ6/runinfo.txt)

**`/tmp/MarvinLogs/test_network_FCU6EL:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_FCU6EL/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_FCU6EL/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_network_FCU6EL/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_3IQGOS:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_3IQGOS/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_3IQGOS/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1514/tmp/MarvinLogs/test_vpc_routers_3IQGOS/runinfo.txt)


Uploads will be available until `2016-06-27 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-214966578
  
@dsclose don't worry about the travis failure, it is due to a timeout.  
Just do a force push to kick it off again and it will probably pass next time.  
I will start a CI run on this now.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-214246821
  
@jburwell - sure, I should be able to look at that this week. I'll 
investigate why the CI build failed as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-213486309
  
@dsclose would it be possible for you to enhance 
``test/ntegration/component/test_redundant_router_services.py`` to verify that 
dnsmasq is only running on the master router and that dnsmasq properly starts 
on failover?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1509#issuecomment-213467207
  
@swill and thank you for you're support - much appreciated :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1509#issuecomment-213465470
  
Rebased off of 4.7 branch and opened PR #1514 - closing this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose closed the pull request at:

https://github.com/apache/cloudstack/pull/1509


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

GitHub user dsclose opened a pull request:

https://github.com/apache/cloudstack/pull/1514

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR

Rebase of PR #1509 against the 4.7 branch as requested by @swill 

One LGTM from @ustcweizhou carried from previous PR. Previous PR will be 
closed.

Description from PR #1509:

CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this 
is no-longer accurate, as service monitoring is not active on the post-4.6 
routers. These routers still suffer an essentially identical issue, however, 
because "dnsmasq needs to be restarted each time configure.py is called in 
order to avoid lease problems." As such, dnsmasq is still running on backup 
RvRs, causing the issues described in CLOUDSTACK-6975.

This PR is based on a patch submitted by @ustcweizhou. The code now checks 
the redundant state of the router before restarting dnsmasq.

RvR networks without this patch have dnsmasq running on both master and 
backup routers. RvR networks with this patch have dnsmasq running on only the 
master router.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-6975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1514


commit cb16ce7e6c8197ae289d105bbf829c68db6d5086
Author: dean.close 
Date:   2016-04-22T14:58:16Z

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant routers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1509#issuecomment-213442284
  
Lets close this PR and open it based off the 4.7 branch.  @ustcweizhou's 
LGTM vote will still count on the new PR.  Lets just reference this PR in the 
new PR so we remember to count his vote.  :)

Basically how this works is as follows:
- The current release is 4.8.  
- We support fixes in one release prior the the current release, and those 
fixes are put against the main branch, so in this case 4.7.  I am not sure of 
the release cycle on this branch, but at some point a newer minor release may 
be cut from this branch (something like 4.7.2 for example).
- Whenever a fix is made in a previous release, the fix is then forward 
merged into the later releases.  This is so the commit hash is consistent 
between all branches making it easier to understand if a specific fix is in a 
specific branch.  So if a commit is added to the 4.7 branch, it will be forward 
merged to the 4.8 branch, and then forward merged again to master.
- We treat master as the next release and add new features there and make 
sure everything is stable for the next release (in this case 4.9).

Does that all make sense?  Don't be shy if you have questions.  I will do 
my best to support you.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

Github user dsclose commented on the pull request:

https://github.com/apache/cloudstack/pull/1509#issuecomment-213437832
  
@swill I raised the PR against `apache:4.7.1-RC20160120T2318` because it 
seemed sensible to include it in the latest 4.7 branch. I'd assumed it could be 
forward merged but as this is only my second PR for Cloudstack I don't think I 
should be making any recommendations.

It's not clear to me how to determine which branch I should raise PRs 
against - but that's probably a question for the mailing list rather than here. 
Let me know if you want it based off something else and I'll sort that out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1509#issuecomment-213419572
  
@dsclose this PR is currently opened against 
`apache:4.7.1-RC20160120T2318`.  Should this be merged into 4.7 and then we 
will forward merge it to 4.8 and master?

Need one more LGTM code review and I would like to verify this PR via CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1509#issuecomment-213345085
  
LGTM, tested


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[dsclose]

GitHub user dsclose opened a pull request:

https://github.com/apache/cloudstack/pull/1509

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup RvR

CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this 
is no-longer accurate, as service monitoring is not active on the post-4.6 
routers. These routers still suffer an essentially identical issue, however, 
because "dnsmasq needs to be restarted each time configure.py is called in 
order to avoid lease problems." As such, dnsmasq is still running on backup 
RvRs, causing the issues described in CLOUDSTACK-6975.

This PR is based on a patch submitted by @ustcweizhou. The code now checks 
the redundant state of the router before restarting dnsmasq.

RvR networks without this patch have dnsmasq running on both master and 
backup routers. RvR networks with this patch have dnsmasq running on only the 
master router.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-6975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1509


commit e17a085b208ca04a436600cb1b3420400547f01e
Author: dean.close 
Date:   2016-04-22T08:38:42Z

CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant routers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---