[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1600 Looks like all the issues are resolved and the tests are good. I am merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski yes, those failing tests are known to cause intermittent failures. LGTM on tests. If all the reported issues have been fixed, this can be merged. /cc @jburwell --- If your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @rhtyd I don't think either of those two errors are related to this PR (probably environment issues). I think we are good to go here. What do you think? --- If your project is set up

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 Trillian test result (tid-239) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27277 seconds Marvin logs:

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 @jburwell a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I will kick off regression tests now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed Just an FYI that this branch had two conflicts with master (after recent changes to master). I went ahead and fixed the conflicts and re-pushed the commit. --- If your project is

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @karuturi Anything else @syed needs to do for this one? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 Thanks for the clarification, @jburwell. I had the same question for #1642, but your answer here works for both PRs. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski we are holding merges until we get all smoke tests passing on #1692 (and the subsequent PRs for the 4.9 and master branches). When those fixes are merged, we have you rebase,

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 Just following up on this one. Is there any pending work item that remains or are we able to merge? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed Thanks! I had a similar issue with #1642 and fixed it the same way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski @jburwell looks like we are green now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski @jburwell I've re-opened the PR to trigger jenkins again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 It looks like we're having an issue with Travis? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 I have run all of the relevant managed-storage tests and all passed (details below). I did encounter one issue: When the fourth test of TestSnapshots ran, it failed

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski sounds good. I am putting together a test results email which should be out shortly. It outlines the issues we have found thus far. As such, I expect the testing period for

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @jburwell Yes, the managed-storage tests should be re-executed. I can do this over the weekend as my CloudStack systems in the lab here are being fully utilized for the time being with

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed @mike-tutkowski should the tests be re-executed to make sure everything is super green? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 Sounds good, @syed Since what you added is the same as what's currently in master, it looks like your list of changed files for this PR is down to 35 (only one of which is a Python file,

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I've added your updated tests and rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed It actually looks like the rebase lead to the integration tests being put back in their pre-official SolidFire SDK for Python state. I recommend you just remove all

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @jburwell Rebased with master and resolved conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed You can actually just remove the integration tests from this PR as they were added (along with updates to use the new SolidFire SDK for Python) in #1689. --- If your project is

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed it appears that conflicts were introduced when #1689 was merged. Could you please resolve? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed #1692 is testing now. It addresses ping test related failures in the smoke test suite. I am hoping the tests pass, and we can merge it first thing tomorrow. Once it has, we can rebase

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 @jburwell a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed @jburwell I should be able to run the tests toward the end of the week or during the weekend. At the moment, my resources in the lab are devoted to other CloudStack dev activities.

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @jburwell Squashed the commits. You can run the smoke tests on this. This change is mostly on the managed storage side so running any volume related tests would be helpful apart from the tests

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed could you please squash your commits? Once that is done, the following items will be need to be completed: * [ ] Re-execute functional test since the code has changed since they

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski @syed needs to resolve the conflicts before we can proceed with package and functional testing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed @karuturi @jburwell Just wondering how we're doing on this one. Is there anything else that Syed needs to do here? Thanks! --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 @jburwell @syed There is no real overlap. Syed and I are working on items from a shared to-do list. The PR here is something he and I built so that volume snapshots can be taken

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed I want to hold this PR until we have a chance to review #1642. On the surface, there appears to be some overlap, and I like to understand it before proceeding. --- If your project is

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @karuturi @jburwell Can we merge this in? Anthing left from my side? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 Packaging result: ✔centos6 ✔centos7 ✔debian repo: http://packages.shapeblue.com/cloudstack/pr/1600 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1600 Packaging result: ✖centos6 ✖centos7 ✖debian repo: http://packages.shapeblue.com/cloudstack/pr/1600 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Thanks @karuturi for your comments, I will get to them as soon as I have some free cycles. Right now this is only supported for XenServer as this requires the backend to be able to do native

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1600 BTw, does this work only with xenserver? I dont see any vmware related changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1600 `locationType` Standard and Archive refer to either secondary or primary based on the storage type and is confusing(atleast for me). Can we make this simple and use the locationType as primary

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I think the `Destroyed` state should suffice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

; Sent: Monday, July 11, 2016 1:39 PM To: dev@cloudstack.apache.org Subject: [GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 A comment: I have observed that

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 A comment: I have observed that the SR that was previously not being detached from XenServer is now being detached with your newer version of the code. One

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I've fixed the problem where the volume was not being detached after the copy. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 My mistake. I forgot that I added that a while ago. :) On Jul 4, 2016, at 12:40 PM, Syed Mushtaq Ahmed > wrote:

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski , the list snapshot already returns the `loacationType`. I think you've already added that. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 A bit of background on how this feature works. When locationType is specified as `Archve`, a snaphsot is taken at the storage, but the copy to seconday storage is done via the hypervisor as it is

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 Can you return the new locationtype parameter in the listSnapshots API call? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Good catch @mike-tutkowski. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 In manual testing, I've noticed that the SR that contains the VDI that we copy from primary to secondary storage is not removed from XenServer. I see that the SolidFire volume

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 The code LGTM. In addition, my automated regression tests have all come back successful (documented above). I plan to write new automated tests for this PR. --- If

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 My fifth and final test run is successful - TestAddRemoveHosts.py: test_add_remove_host_with_solidfire_plugin_1 (TestAddRemoveHosts.TestAddRemoveHosts) ... === TestName:

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 My fourth test run is successful - TestSnapshots.py: test_01_create_volume_snapshot_using_sf_snapshot (TestSnapshots.TestSnapshots) ... === TestName:

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 My third test run is successful - TestVMSnapshots.py: test_01_take_VM_snapshot (TestVMSnapshots.TestVMSnapshots) ... === TestName: test_01_take_VM_snapshot | Status : SUCCESS ===

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 My second test run is successful - TestVolumes with resigning: test_00_check_template_cache (TestVolumes.TestVolumes) ... === TestName: test_00_check_template_cache | Status :

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1600 My first test run is successful - TestVolumes.py without resigning: test_00_check_template_cache (TestVolumes.TestVolumes) ... === TestName: test_00_check_template_cache | Status

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 This was done in two parts: The work to add the API parameter was done by @mike-tutkowski and the work to enable this on the backend was done by me. The rebase destroyed history but I