[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user nnesic commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r61122746 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59863002 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59861537 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59860632 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59860389 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59859824 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59859628 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicyManager.java --- @@ -0,0 +1,32 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59859123 --- Diff: api/src/com/cloud/naming/ResourceNamingPolicy.java --- @@ -0,0 +1,36 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210081172 np, imagined that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210078861 @DaanHoogland I apologize -- I missed the context. Yes, for an integration test, a counter would be perfectly acceptable, and likely, the best choice to ensure

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210056555 @jburwell we are talking about integration test code here! not about a production policy. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210055791 @DaanHoogland -1 to counters -- the require coordination across all nodes in the cluster. In multi-region configurations, they would require coordination across

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-210052430 sorry for not answerring on github I could imagine a policy that keeps a static counter and name a resource bla- and then checks if the next

Re: [GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

On Thu, Apr 14, 2016 at 4:14 PM, ProjectMoon wrote: > Github user ProjectMoon commented on the pull request: > > https://github.com/apache/cloudstack/pull/1492#issuecomment-209963503 > > @DaanHoogland Do you have any kind of integration tests in mind? > ​I could

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209963503 @DaanHoogland Do you have any kind of integration tests in mind? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59717381 --- Diff: engine/schema/src/com/cloud/naming/ConsoleProxyNamingPolicy.java --- @@ -0,0 +1,9 @@ +package com.cloud.naming; --- End diff --

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209945535 @ProjectMoon I will run through the code after I read the detailed design. one remark so far. This is a nice feature to have. please add integration tests for

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1492#discussion_r59717124 --- Diff: plugins/naming-policies/src/com/cloud/naming/DefaultConsoleProxyNamingPolicy.java --- @@ -0,0 +1,58 @@ +package com.cloud.naming;

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209875708 > @ProjectMoon correct resource naming is critical to the proper operation of the management server. We have had a significant bugs and production issues

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209856283 @ProjectMoon we'll need more information on why you're doing this, why we should have it, what is fixes and will it guarantee backward resource-name compatibility

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209634604 @ProjectMoon correct resource naming is critical to the proper operation of the management server. We have had a significant bugs and production issues caused by

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1492#issuecomment-209550386 Jenkins build is currently failing on this due to needing to "resolve index first." Seems like an issue with the build server. --- If your project is set up

[GitHub] cloudstack pull request: [CLOUDSTACK-9003] Resource Naming Policie...

GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1492 [CLOUDSTACK-9003] Resource Naming Policies Pull request #988, completed and reinvented. This is an initial submission, a request for commentary. This started with