Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221304669
@swill if you are happy to merge this without including the tests requested
by @jburwell then this PR is ready to merge.
@luhaijiao I've created
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221184807
@swill There is a question about enhanced integration testing but no code
supplied so, tag:mergeready
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221162753
This one is green. I think this one is ready??? Please verify if there is
anything outstanding on this one. Thanks... :)
---
If your project is set up for it,
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220982534
@luhaijiao I reverted to a vanilla Cloudstack 4.8.0 ISO. The
cloud-passwd-srvr service failed to start. The following appears in
/var/log/messages on the router:
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220964156
@luhaijiao I've seen the same error in our XenServer setup but wasn't sure
what the cause is. I'd be surprised if this was the cause but it's worth
exploring.
Github user luhaijiao commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220950805
@dsclose we install this patch in our environment(ACS 4.7.1, KVM) to solve
the password issue with RVR.
We found the new password for VM is still
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1514
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose reopened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220918847
@dsclose you can close/reopen this PR instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220918123
@swill
Pardon me - I was on leave for a week. I'll get this force pushed
momentarily.
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220738431
I would like to get this one re-pushed or closed and reopened so we can
kick the CI again to see if we can get things green. I am getting very close
to freezing and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220629640
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 44m 23s
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220629958
This one is coming back clean. If we can get Jenkins and Travis green I
think this one is ready...
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-220514409
@dsclose can you please rebase and repush this one to kick off jenkins and
travis again. We have fixes in both travis and jenkins so we should be able to
get this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-219536627
@dsclose can you rebase and re-push this PR to try to get it green. We are
down to the wire now. I will probably merge some PRs that only have jenkins
failing if
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218792730
@dsclose we have pushed fixes to both Jenkins and Travis today. Can you
please do a force push or close and reopen this PR in order to kick off Jenkins
and Travis
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825
LGTM. Tested in hardware lab and works as designed.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dsclose commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1514#discussion_r62344011
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
self.cloud.commit()
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1514#discussion_r62329838
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -54,7 +54,8 @@ def process(self):
self.cloud.commit()
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-217392996
@DaanHoogland yes, the line `CsHelper.service("dnsmasq", "restart")` in
`set_master` is in
systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py. When a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-216243431
code looks good and functionally sane but this needs extensive testing.
Especially when master fails the dns functionality needs to be still available,
i.e.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-216232254
@rhtyd I'd love to. But I never used the Redundant VR, so I can't tell.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-216229708
Good pr, let's ask comments from @remibergsma @DaanHoogland @wido and
others?
tag:needlove
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-215095216
The test that failed is one that periodically fails in my env, so I don't
think we can assume it is related to this PR.
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-215089828
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
```
**Summary of the problem(s):**
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-214966578
@dsclose don't worry about the travis failure, it is due to a timeout.
Just do a force push to kick it off again and it will probably pass next time.
I will start
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-214246821
@jburwell - sure, I should be able to look at that this week. I'll
investigate why the CI build failed as well.
---
If your project is set up for it, you can
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-213486309
@dsclose would it be possible for you to enhance
``test/ntegration/component/test_redundant_router_services.py`` to verify that
dnsmasq is only running on the
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213467207
@swill and thank you for you're support - much appreciated :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213465470
Rebased off of 4.7 branch and opened PR #1514 - closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1514
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup redundant RvR
Rebase of PR #1509 against the 4.7 branch as requested by @swill
One LGTM from @ustcweizhou carried from
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213442284
Lets close this PR and open it based off the 4.7 branch. @ustcweizhou's
LGTM vote will still count on the new PR. Lets just reference this PR in the
new PR so we
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213437832
@swill I raised the PR against `apache:4.7.1-RC20160120T2318` because it
seemed sensible to include it in the latest 4.7 branch. I'd assumed it could be
forward
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213419572
@dsclose this PR is currently opened against
`apache:4.7.1-RC20160120T2318`. Should this be merged into 4.7 and then we
will forward merge it to 4.8 and master?
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1509#issuecomment-213345085
LGTM, tested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1509
CLOUDSTACK-6975: Prevent dnsmasq from starting on backup RvR
CLOUDSTACK-6975 refers to service monitoring bringing up dnsmasq but this
is no-longer accurate, as service monitoring is not
40 matches
Mail list logo
