Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215410772
We'll take a look at this in a separate PR. We don't use the UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215408560
is there any UI change possible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215401063
@swill CI Test good, 2+ reviews. Ready to Merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215372191
LGTM. Had already given one earlier based on simulator testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215308516
LGTM for test code based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215120369
OK, all checks have passed! ;) Looking for another LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215103065
@koushik-das can I get your code review on this? Thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215103808
Yea, I saw that jenkins failed pulling 4.7 branch, so I kicked it off
again. I'm going to keep an eye on travis and jenkins. There is no reason
those tests should
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215102785
Thanks @kiwiflyer. :) I was about to ask you to re-push to kick off the
runs again and you did it as I was typing. ð
---
If your project is set up for it,
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215099770
Tested this patch manually on a KVM 4.8 lab. We also ran the new Marvin
unit tests successfully against the simulator, bubble instance and a hardware
lab. Works
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215087358
Thank you for the results. I think that is all we need from a CI
perspective. Jenkins and Travis have been kicked off again as well, so that is
good. Hopefully we
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215084188
[test_volumes_NV6XFO.zip](https://github.com/apache/cloudstack/files/238694/test_volumes_NV6XFO.zip)
Here is the zip file containing the test results.
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-215083560
Ok, I have run this through my lab again and specifically ran the
test_volumes.py file. All tests passed. See below. I have also attached the
results dir as a
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-213853837
I made all requested changes. I'm going to run a full bubble CI test
against this PR and I will post the results.
---
If your project is set up for it, you can
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602700
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602140
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60602084
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60585058
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60584441
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582709
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582658
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60582064
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60581671
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60533148
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60533118
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60532285
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60531417
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60531171
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212533078
We need some LGTM code reviews of this one. I would also like to run CI
against it because it changes code that is common to other functionality to
make sure
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212426369
@koushik-das - Thanks for the feedback. I have added the
require_hardware="false" as you suggested and pushed a new commit to the branch.
If all looks
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212400883
@koushik-das - Our use case is to emulate a snapshot revert with Ceph by
using createVolume sourced from a snapshot, then detaching and reattach the
root volume
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212267285
@dmabry Thanks for the fix. I ran it on simulator and it worked as
expected. So +1 on the changes. Although it existed for XenServer and Vmware, I
am trying to
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60352254
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"Check
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-212085924
Ok, I have made the requested changes. Please review and let me know if
there is anything else I need to change.
---
If your project is set up for it, you can
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60225742
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60222679
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"Check the
Github user dmabry commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60222132
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"Check the
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60193647
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"Check the
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60193089
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,134 @@ def test_01_volume_attach_detach(self):
"Check the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1500#issuecomment-211551366
would you mind squashing your commits for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
41 matches
Mail list logo
