Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eriweb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60384237
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-212074504
@bhaisaab thank you, I appreciate the effort. ð
I am actively trying to get more people involved in code review, so we will
have to lead by example for
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-212060526
@swill I've explained my intent above, and it was not intended to be hard
on @rafaelweingartner either
While he's indeed putting good effort on PRs, I'm seeing
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60284224
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-212040090
@bhaisaab I think you are being too hard on @rafaelweingartner. He simply
asked a question because the format was presented differently in two different
files in
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-212034630
@swill we may ignore them, those are non-issues unless @rafaelweingartner
has strong opinions
@rafaelweingartner things you can do to improve your
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60275113
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60272259
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211930508
@bhaisaab I will let you address @rafaelweingartner's comment. If you
choose to make a change, it will not impact the 'readiness' of this PR. I am
not sure which
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211918504
The command ââumaskâ at âscripts/vm/systemvm/injectkeys.shâ is
using â022â as a parameter, while the one at
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60226618
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211915697
@mlsorensen did you do a code review of this or are you just excited about
the change. :)
Ideally I would get another LGTM before merging. I am pretty
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211785290
@swill thanks, the change builds into systemvm.iso and no new template is
necessary.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211706714
Do I need to do anything special with this merge because it includes
systemvm changes? If I need to do anything special, please help me understand
the details.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211706541
With these results, I think this PR is ready. I will add it to my merge
list.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211706355
## CI RESULTS
### 84/85 TESTS PASSED
The test that failed is a test that commonly fails in my environment and
has been
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211706237
## CI RESULTS
### 84/85 TESTS PASSED
The test that failed is a test that commonly fails in my environment and
has been
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211263537
@swill yes though we should run CI, the fix is simple and ensure that umask
setting is used when creating new files. the umask 022 is default on most
distros
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-208914356
Do we have any assurances that this works and does not break anything? Do
we need to run CI or how do we validate this?
---
If your project is set up for it, you
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-208847097
@swill what's the status on getting this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-206544148
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mlsorensen commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-206540043
Let's merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-187282499
@DaanHoogland I don't have access on Apache jenkins; also this would
require some S3 storage or large disk space if we want to keep the rpms (say at
least for a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-187261697
@bhaisaab can you port that job to apache?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-187236270
PR Jenkins RPM build-regression job:
http://jenkins.bhaisaab.org:/job/cloudstack/160/
---
If your project is set up for it, you can reply to this email and
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r53457178
--- Diff: scripts/vm/systemvm/injectkeys.sh ---
@@ -27,7 +27,7 @@ set -e
TMP=/tmp
MOUNTPATH=${HOME}/systemvm_mnt
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1419
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1420
systemvm: preserve file permissions, set default umask
- In injectkeys.sh which is used to inject new public keys everytime
cloudstack
starts; while copying files preserve the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1419#issuecomment-186203679
This needs to be on all 4.7+ closing & reopening
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1419
systemvm: preserve file permissions, set default umask
- In injectkeys.sh which is used to inject new public keys everytime
cloudstack
starts; while copying files preserve the
31 matches
Mail list logo
