I have posted my review comments. Except for a few minor comments changes look
good to me.
-Koushik
On 02-Dec-2013, at 9:15 PM, Alex Ough alex.o...@sungard.com wrote:
All,
It's been a while since this review was requested, so can anyone review
this to move on?
Thanks in advance.
Alex
Thank Koushik, and I modified what you pointed out (for 'MigrateCommand'
text) and updated the diffs.
Let me know if there is anything missing/incorrect.
Thanks
Alex Ough
On Tue, Dec 3, 2013 at 2:46 AM, Koushik Das koushik@citrix.com wrote:
I have posted my review comments. Except for a
All,
It's been a while since this review was requested, so can anyone review
this to move on?
Thanks in advance.
Alex Ough
On Fri, Nov 22, 2013 at 11:51 AM, Alex Ough alex.o...@sungard.com wrote:
Thanks to help from many developers,
I sent my first review request in the cloudstack,
Thanks to help from many developers,
I sent my first review request in the cloudstack,
https://reviews.apache.org/r/15763/,
so please take a look at it and let me know if there is anything
missing/incorrect.
Thanks again.
Alex Ough
On Thu, Nov 21, 2013 at 10:09 AM, Alex Ough
It's because we switched over to a new way to declare configuration variables.
Here's some information about it.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Configuration
--Alex
From: Alex Ough [mailto:alex.o...@sungard.com]
Sent: Wednesday, November 20, 2013 9:56 AM
To: Alex Huang
Hi Wido,
Related with the 'disk_offering.cache_mode',
I found that there is a sql file to add that column, which is 'cloudstack/
developer/target/db/db/schema-430to440.sql'.
But after running it manually, I have another error saying that the
'cache_mode' cannot be null, so I just changed the
I see. Thanks for the information, Alex.
Alex Ough
On Thu, Nov 21, 2013 at 9:22 AM, Alex Huang alex.hu...@citrix.com wrote:
It’s because we switched over to a new way to declare configuration
variables. Here’s some information about it.
Hi Alex,
It looks like you moved the 'ExecuteInSequence' to the vm level from the
management server, which seems to be ok, but at this time I cannot test it
because when I try to start up the management server, it fails because of
database schema error, which is 'Unknown column
Wido,
Looks like you didn't update your schema file or forgot to add a schema upgrade
file in master? See the error described by Alex below.
@Alex
You can probably remove the cachemode field in the DiskOfferingVO for now. Or
revert 1edaa36 on your local repo to keep moving forward.
--Alex
Cc Alena,
I just recalled that Alena was working with sending hypervisor
commands from cloudstack in parallel to the agent. She might have some
idea about why getExecuteInSequence() defaults to all commands going
in parallel now for VirtualMachineManager
On Mon, Nov 18, 2013 at 08:16:57AM -0600,
Alex,
Sorry for the late reply. Been travelling the last couple of weeks. I'll look
into this today.
--Alex
From: Alex Ough [mailto:alex.o...@sungard.com]
Sent: Monday, November 18, 2013 6:17 AM
To: dev@cloudstack.apache.org
Cc: Alex Huang
Subject: Re: A question on vm migrations when hosts
Alex,
Can you do a pull from master and see if my fix fits your needs.
Unfortunately, I'm on the road and couldn't do an actual test of it.
--Alex
From: Alex Huang
Sent: Tuesday, November 19, 2013 4:45 AM
To: 'Alex Ough'; dev@cloudstack.apache.org
Subject: RE: A question on vm migrations when
Thank Parasanna Sebastien,
I also got his email and sent an email.
Waiting for his reply...
Thanks
Alex Ough
On Sat, Nov 16, 2013 at 3:05 PM, Sebastien Goasguen run...@gmail.comwrote:
cc Alex Huang to get his attention:
On Nov 15, 2013, at 10:17 PM, Prasanna Santhanam t...@apache.org
I hate to sending the same emails over and over again, but I really need to
finalize this feature to be included in the next code freeze because this
feature is very critical in our inside project.
Anyone who can help, please?
Thanks
Alex Ough
On Thu, Nov 14, 2013 at 1:27 PM, Alex Ough
Alex, Could you just do a git blame on the file and copy the emails of
people who changed that bit of code? They may be able to help if Cc-ed
directly.
Thanks,
On Fri, Nov 15, 2013 at 01:49:07PM -0600, Alex Ough wrote:
I hate to sending the same emails over and over again, but I really need to
All,
While merging my changes to 4.3 branch, I found that the option,
'execute.in.sequence.hypervisor.commands' is NOT used in Start/Stop/Copy
commands in 'VirtualMachineManagerImpl.java' any more as below.
*StopCommand stop = new StopCommand(vm, getExecuteInSequence());*
*protected boolean
I'm not sure. I know in the past when I've seen files change locations
it has also clobbered updates to that file. Someone branched, did the
reorganization work, and merged, while in-between the original file
changed.
On Wed, Nov 13, 2013 at 9:21 AM, Alex Ough alex.o...@sungard.com wrote:
All,
It sounds a little scary...
I looked at the history and found these.
8/9/ : file moved to engine by Alex Huang
9/16 : '_mgmtServer.getExecuteInSequence()' changed to
'getExecuteInSequence()' by Alex Huang
Hi Alex Huang,
I'm not sure if you're aware of this, but can you check this for me?
I have done parallel KVM migrations without issue, it's supposed to
work. Really I think it's in the same boat as parallel start/stop. It
should work, but the config option is there just in case. I think we
should add it.
On Thu, Oct 3, 2013 at 11:41 AM, Chip Childers
chip.child...@sungard.com
Thanks a lot for your confirmation, Marcus.
I'll create a review request unless anyone has an objection.
Thanks
Alex Ough
On Tue, Nov 12, 2013 at 3:37 PM, Marcus Sorensen shadow...@gmail.comwrote:
I have done parallel KVM migrations without issue, it's supposed to
work. Really I think it's
Hi Koushik,
Thanks for your reply, but unfortunately, this setting does NOT cover
'MigrateCommand'.
As you specified, it seems to be effective only in Start/Stop/CopyCommand.
So can we include 'MigrateCommand' in that setting?
Thanks
Alex Ough
On Wed, Oct 2, 2013 at 11:44 PM, Koushik Das
Alena,
I see that you had added this config setting. Any specific reason that this
only for Start/Stop/Copy and not for all the commands as Alex mentioned? The
name of the setting looks generic.
-Koushik
On 03-Oct-2013, at 8:10 PM, Alex Ough alex.o...@sungard.com wrote:
Hi Koushik,
Thanks
On 10/3/13 9:25 AM, Koushik Das koushik@citrix.com wrote:
Alena,
I see that you had added this config setting. Any specific reason that
this only for Start/Stop/Copy and not for all the commands as Alex
mentioned? The name of the setting looks generic.
Because these are the commands for
I'm not sure what else commands 'MigrateCommand' actually execute in
addition to 'Start/Stop/CopyCommand', but can we include 'MigrateCommand'
if it consists of only those 3 commands?
Thanks
Alex Ough
On Thu, Oct 3, 2013 at 11:31 AM, Alena Prokharchyk
alena.prokharc...@citrix.com wrote:
On
On Thu, Oct 03, 2013 at 11:44:46AM -0500, Alex Ough wrote:
I'm not sure what else commands 'MigrateCommand' actually execute in
addition to 'Start/Stop/CopyCommand', but can we include 'MigrateCommand'
if it consists of only those 3 commands?
Thanks
Alex Ough
In the case of VMware, the
Marcus/Kelven,
Any thoughts on my suggestions?
Thanks
Alex Ough
On Tue, Sep 24, 2013 at 12:09 PM, Alex Ough alex.o...@sungard.com wrote:
Oh, sorry for the confusion. I must have reversed the flags.
As Kelven pointed, it is set as 'TRUE', which makes the process as
sequential.
So my
Not sure. I don't know the history well enough to know if there were
issues in the past, it might be that some hypervisors were fine and
others weren't.
On Wed, Oct 2, 2013 at 9:21 AM, Alex Ough alex.o...@sungard.com wrote:
Marcus/Kelven,
Any thoughts on my suggestions?
Thanks
Alex Ough
Thanks for the reply, Marcus.
What about the option #3, which is to make it as a global setting?
I think it can prevent side effects if exist.
Alex Ough
On Wed, Oct 2, 2013 at 11:37 AM, Marcus Sorensen shadow...@gmail.comwrote:
Not sure. I don't know the history well enough to know if there
It is already a global setting in 4.2. The name of the setting is
execute.in.sequence.hypervisor.commands.
Check out Config.java
ExecuteInSequence(Advanced, ManagementServer.class, Boolean.class,
execute.in.sequence.hypervisor.commands, true, If set to true,
StartCommand, StopCommand,
For a resolution without breaking possible flows, I'd like to add the value
of 'executeInSequence' to the global setting.
Is there any reason not to do this?
Thanks
Alex Ough
On Mon, Sep 23, 2013 at 12:57 PM, Alex Ough alex.o...@sungard.com wrote:
All,
After a little more investigation, I
Hey Kelven - This topic was discussed briefly in the past [1]. Are you
able to provide any thoughts on Alex's ideas below?
-chip
[1] http://markmail.org/message/fznrszaswruvlmuy
On Tue, Sep 24, 2013 at 10:53:04AM -0500, Alex Ough wrote:
For a resolution without breaking possible flows, I'd
I thought executeInSequence of 'true' made it go serially, or
sequentially. In my codebase for 4.1,4.2,master it's been 'true' since
August of 2010:
2010-08-11 09:13:29 -0700 19) public class MigrateCommand extends Command {
2010-08-11 09:13:29 -0700 20) String vmName;
2010-08-11 09:13:29
Oh, sorry for the confusion. I must have reversed the flags.
As Kelven pointed, it is set as 'TRUE', which makes the process as
sequential.
So my questions are
1. If there is any reason why the method have been defined to return '*TRUE*'
always?
2. Do we expect any side effects and/or
All,
After a little more investigation, I found that the 'MigrateCommand'
defined its 'executeInSequence' method to return 'FALSE', which seems to
make the vm migrations as serial even if the migration requests are
dispatched to ha_worker in parallel.
You can confirm this in line 56 of
I checked the vm migration when their host is set to a maintenance mode and
found that even if the orchestration layer fires the each vm migration at
the same time using a ha_worker thread, the actual migration seems to be
executed serially.
Is this what we expect? And if so, any chance to make
35 matches
Mail list logo
