Re: Integration tests

2008-01-15 Thread Grzegorz Kossakowski
Reinhard Poetz pisze: Grzegorz Kossakowski wrote: [EMAIL PROTECTED] pisze: I'm not sure how to say this but... Guys, there is a lot of to cover by test in this module and writing tests in trunk is not painful by any means. you are right and this particular bug was my fault because I

[jira] Created: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page

2008-01-15 Thread Drew Buschhorn (JIRA)
[PATCH] Fix for Paginator when accessing out of bounds Pagination page -- Key: COCOON-2162 URL: https://issues.apache.org/jira/browse/COCOON-2162 Project: Cocoon Issue

[jira] Updated: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page

2008-01-15 Thread Drew Buschhorn (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Buschhorn updated COCOON-2162: --- Attachment: paginator.diff svn diff of Paginator.java [PATCH] Fix for Paginator when

Re: Integration tests

2008-01-15 Thread Reinhard Poetz
Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Grzegorz Kossakowski wrote: [EMAIL PROTECTED] pisze: I'm not sure how to say this but... Guys, there is a lot of to cover by test in this module and writing tests in trunk is not painful by any means. you are right and this particular bug was

[jira] Updated: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page

2008-01-15 Thread Drew Buschhorn (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Drew Buschhorn updated COCOON-2162: --- Attachment: screenshot-1.jpg This is what should happen, I believe. Made after applying

Re: Integration tests

2008-01-15 Thread Reinhard Poetz
Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Grzegorz Kossakowski wrote: [EMAIL PROTECTED] pisze: I'm not sure how to say this but... Guys, there is a lot of to cover by test in this module and writing tests in trunk is not painful by any means. you are right and this particular bug was

Re: Integration tests

2008-01-15 Thread Grzegorz Kossakowski
Reinhard Poetz pisze: Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Yes I was very happy to see your commits. However, I always thought that it's first that you write unit tests for covering the most basic functionality and ITs for testing how different parts interact with each other.

Re: Integration tests

2008-01-15 Thread Reinhard Poetz
Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Yes I was very happy to see your commits. However, I always thought that it's first that you write unit tests for covering the most basic functionality and ITs for testing how different parts

Re: Fw: cocoon 2.2 Trunk DEMO at cocon.zones.apache.org crashes at various samples

2008-01-15 Thread Gabriel Gruber
Thanx Grek for your effort, I am allmost satisfied :-) still however ajax doesn't work now. as soon as I request an ajax/browser-update I get an error saying Request failed. Show server response? Some examples: http://cocoon.zones.apache.org/demos/trunk/samples/forms/do-dynaRepeater.flow

Re: usage of cocoon.createObject

2008-01-15 Thread Antonio Gallardo
Hi Carlos, Thanks for spotting the issue, people might get this code as a best practices. Would you file the issue and include a patch in scarab? I will be glad to commit the fix. Thank you in advance. Best Regards, Antonio Gallardo. Carlos Chávez escribió: Hello All, About the usage of

[jira] Commented: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page

2008-01-15 Thread JIRA
[ https://issues.apache.org/jira/browse/COCOON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12559305#action_12559305 ] Jörg Heinicke commented on COCOON-2162: --- Instead of a 404 I would rather send the

[jira] Commented: (COCOON-2162) [PATCH] Fix for Paginator when accessing out of bounds Pagination page

2008-01-15 Thread Drew Buschhorn (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12559314#action_12559314 ] Drew Buschhorn commented on COCOON-2162: Thought about that, but I have two

Re: svn commit: r611525 - /cocoon/trunk/blocks/cocoon-imageop/cocoon-imageop-impl/src/changes/changes.xml

2008-01-15 Thread David Crossley
Grzegorz Kossakowski wrote: Joerg Heinicke pisze: joerg wrote: Modified: cocoon/trunk/blocks/cocoon-imageop/cocoon-imageop-impl/src/changes/changes.xml Could it be we switched from status.xml to changes.xml? :) Yes, I believe so. I haven't touch any status.xml since I'm

Re: Where is the mirror.html?

2008-01-15 Thread David Crossley
Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Grzegorz Kossakowski wrote: Reinhard Poetz pisze: Apparently, it does not work any more. Do you know who has set up this cron job? Sorry, no idea. I'll ask infra folks, then. Grek, i have a cronjob that does 'svn update' the

Re: svn commit: r612363 - in /cocoon/trunk: blocks/cocoon-ajax/cocoon-ajax-impl/ blocks/cocoon-apples/cocoon-apples-impl/ blocks/cocoon-apples/cocoon-apples-impl/src/changes/ blocks/cocoon-asciiart/co

2008-01-15 Thread Joerg Heinicke
On 16.01.2008 01:10, [EMAIL PROTECTED] wrote: Author: joerg Date: Tue Jan 15 22:09:53 2008 New Revision: 612363 URL: http://svn.apache.org/viewvc?rev=612363view=rev Log: convert status.xml (Forrest) to changes.xml (Maven), see also http://marc.info/?t=12001912511r=1w=4 Only one missing

Re: Integration tests

2008-01-15 Thread Bertrand Delacretaz
On Jan 15, 2008 9:44 PM, Reinhard Poetz [EMAIL PROTECTED] wrote: Grzegorz Kossakowski wrote: ...I guess it should be always easier to write isolated unit tests than ITs. Am I wrong? hmmm, it depends. Integration tests for Cocoon have always been tests at HTTP/XHTML level Might be