Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-09 Thread Carsten Ziegeler
Ralph Goers wrote: I changed the expire time from 5 to 10 and then changed the sleep time to 11000. That got the unit test to pass. I'm not sure what to do about this. Having a unit test rely on an external resource is very bad practice just for this reason. Worse, if I didn't have an active

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-09 Thread Grzegorz Kossakowski
Carsten Ziegeler pisze: Yepp, I have no idea why it changed from local to remote. But we want to test the caching source and not our network connection, so we should rather go back to something local. +1 It's not the first time when this test causes troubles. -- Grzegorz Kossakowski

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-09 Thread Grzegorz Kossakowski
Ralph Goers pisze: Rats. Sorry. I was trying to squeeze that in when I had free time and I just get so used to skipping the tests since every time I've tried to run them my build has failed. I shouldn't have assumed they were still not working. To be honest when I was working on this I was

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Grzegorz Kossakowski
[EMAIL PROTECTED] pisze: Author: rgoers Date: Sun Jan 6 01:35:48 2008 New Revision: 609282 URL: http://svn.apache.org/viewvc?rev=609282view=rev Log: Created XPathXMLFileModule to fix problems with XMLFileModule. Added getAttributeValue to JXPathHelper and changed all references to

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Ralph Goers
Rats. Sorry. I was trying to squeeze that in when I had free time and I just get so used to skipping the tests since every time I've tried to run them my build has failed. I shouldn't have assumed they were still not working. To be honest when I was working on this I was just very frustrated

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Ralph Goers
Come to think of it, although it is a pretty lame excuse, the reason I ran with tests disabled is I just cut and pasted the command line from the README - I can never remember the format since -P allblocks isn't something you normally do with maven. Perhaps the README should be changed? It

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Ralph Goers
OK. So using PreparedVariableResolver fixes the problems with the dependencies. I've committed the change. But I am still getting 1 unit test failure in cocoon core - CachingSourceTestCase is failing on line 88. How could this possibly have anything to do with what I changed? Ralph Goers

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Joerg Heinicke
On 08.01.2008 22:59, Ralph Goers wrote: But I am still getting 1 unit test failure in cocoon core - CachingSourceTestCase is failing on line 88. How could this possibly have anything to do with what I changed? Since our Continuum build now runs successful it seems to be an issue with your

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Ralph Goers
Well, that just means I'm going to be up a while trying to figure out why. But thanks. It's good to know that it is working again. I also verified that the XPathXMLFileModule sample still works, so that is good. Then I just need to write some unit tests for it. I modified my own copy of

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Joerg Heinicke
On 08.01.2008 23:23, Joerg Heinicke wrote: But I am still getting 1 unit test failure in cocoon core - CachingSourceTestCase is failing on line 88. How could this possibly have anything to do with what I changed? Since our Continuum build now runs successful it seems to be an issue with

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Ralph Goers
I put slashdot.org in my browser on that machine and it took quite a while to display but it did. I notice that the unit tests pause for quite a while on that test. I'm not sure why. Anyway, I changed the 5 to 30 and it still fails. Should unit tests really be going to external resources?

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-08 Thread Ralph Goers
I changed the expire time from 5 to 10 and then changed the sleep time to 11000. That got the unit test to pass. I'm not sure what to do about this. Having a unit test rely on an external resource is very bad practice just for this reason. Worse, if I didn't have an active internet connection

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-07 Thread David Crossley
Ralph Goers wrote: I didn't know about the plugin, but yes I knew I should have put the issue number in the commit. I just forgot to do it. Do: svn propedit svn:log --revprop -r609282 https://svn.apache.org/repos/asf/cocoon/trunk -David Joerg Heinicke wrote: On 06.01.2008 04:35, [EMAIL

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-06 Thread Joerg Heinicke
On 06.01.2008 04:35, [EMAIL PROTECTED] wrote: Author: rgoers Date: Sun Jan 6 01:35:48 2008 New Revision: 609282 URL: http://svn.apache.org/viewvc?rev=609282view=rev Log: Created XPathXMLFileModule to fix problems with XMLFileModule. Added getAttributeValue to JXPathHelper and changed all

Re: svn commit: r609282 [1/2] - in /cocoon/trunk: blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resources/COB-INF/modules/ blocks/cocoon-core-sample/cocoon-core-main-sample/src/main/resou

2008-01-06 Thread Ralph Goers
I didn't know about the plugin, but yes I knew I should have put the issue number in the commit. I just forgot to do it. Joerg Heinicke wrote: On 06.01.2008 04:35, [EMAIL PROTECTED] wrote: Author: rgoers Date: Sun Jan 6 01:35:48 2008 New Revision: 609282 URL: