Re: [DBCP] DBCP2 and logging

2013-07-27 Thread Romain Manni-Bucau
I like it! Le 27 juil. 2013 04:24, James Carman ja...@carmanconsulting.com a écrit : On Fri, Jul 26, 2013 at 10:01 PM, Gary Gregory garydgreg...@gmail.com wrote: On Jul 26, 2013, at 19:24, James Carman ja...@carmanconsulting.com wrote: Perhaps an event listener for all dbcp events? Then

[proxy] Refactoring Stub Support...

2013-07-27 Thread James Carman
I think we need to re-think the stubbing support in proxy2. I'm not saying I don't like the idea. What I propose is that we introduce some lower-level abstractions on which the stubbing is built. For instance, I would propose we introduce a couple of interfaces (or the concept of these

Re: [proxy] Refactoring Stub Support...

2013-07-27 Thread Romain Manni-Bucau
Hi Isnt it a particular kind of interceptor/handler (CompositeInterceptor)? So does it need so much details? Le 27 juil. 2013 15:31, James Carman jcar...@carmanconsulting.com a écrit : I think we need to re-think the stubbing support in proxy2. I'm not saying I don't like the idea. What I

[proxy] and impl

2013-07-27 Thread Romain Manni-Bucau
Hi On a mail on [monitoring] i put some point on proxy. The main question was shouldnt proxy give a default impl of proxying instead of being a facade (which needs to put all impl specifities in the api or a way to get them)? In tomee/openejb and owb we use asm to create proxies and

Re: [proxy] Refactoring Stub Support...

2013-07-27 Thread James Carman
On Sat, Jul 27, 2013 at 9:44 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Hi Isnt it a particular kind of interceptor/handler (CompositeInterceptor)? So does it need so much details? Well, the idea behind stubbing is that we would be specifying behavior for very specific method

Re: [proxy] and impl

2013-07-27 Thread James Carman
While I get what you're saying, that's kind of the entire reason Commons Proxy was created. Proxy came about from my experience with Apache HiveMind and Javassist. We were constantly doing Javassist coding each time we wanted new proxying logic. There was a LOT of repeated code because of all

Re: [proxy] and impl

2013-07-27 Thread Romain Manni-Bucau
Once ill have done the monitoring stuff ill try to work on it. Le 27 juil. 2013 16:06, James Carman ja...@carmanconsulting.com a écrit : While I get what you're saying, that's kind of the entire reason Commons Proxy was created. Proxy came about from my experience with Apache HiveMind and

Re: [proxy] and impl

2013-07-27 Thread James Carman
On Sat, Jul 27, 2013 at 10:34 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Once ill have done the monitoring stuff ill try to work on it. What would be really cool is to have a smackdown once we get ASM into the mix to see which one performs the best and exactly how fast they are compared

Re: [proxy] Refactoring Stub Support...

2013-07-27 Thread James Carman
I have created https://issues.apache.org/jira/browse/PROXY-20 to track the progress of this issue. I have already checked in some code into the branch. On Sat, Jul 27, 2013 at 9:54 AM, James Carman ja...@carmanconsulting.com wrote: On Sat, Jul 27, 2013 at 9:44 AM, Romain Manni-Bucau

Re: [proxy] and impl

2013-07-27 Thread Romain Manni-Bucau
Hehe, we benched in owb but lets wait the porting ;) Le 27 juil. 2013 16:49, James Carman ja...@carmanconsulting.com a écrit : On Sat, Jul 27, 2013 at 10:34 AM, Romain Manni-Bucau rmannibu...@gmail.com wrote: Once ill have done the monitoring stuff ill try to work on it. What would be

Re: [proxy] Refactoring Stub Support...

2013-07-27 Thread Matt Benson
As I had mentioned, support for some form of dynamic response was the last feature I had wanted to get into the stub module, so I am certainly not opposed to this. I had simply thought to eat dog food by using [functor] interfaces, but that's not a big deal. I have not yet reviewed your latest

Re: [proxy] and impl

2013-07-27 Thread Matt Benson
AFAIK Mark Struberg's work on the OWB proxies could be instructive, and since I've just spent several weeks in ASM hell I might just be a bit of use there myself. The only thing is, isn't cglib built on ASM as well? The dynamic nature of the various proxy helpers means that we probably couldn't

Re: [proxy] Refactoring Stub Support...

2013-07-27 Thread James Carman
I do not plan on making us lose anything. What I am looking for is to build layers of abstraction. The stuff you have developed right now I would probably point at the lower-level abstractions that I'm writing currently. Does that make sense? On Saturday, July 27, 2013, Matt Benson wrote: As

Re: [proxy] Refactoring Stub Support...

2013-07-27 Thread Matt Benson
Yep, thanks. ;-) On Jul 27, 2013 1:36 PM, James Carman ja...@carmanconsulting.com wrote: I do not plan on making us lose anything. What I am looking for is to build layers of abstraction. The stuff you have developed right now I would probably point at the lower-level abstractions that I'm

Re: [proxy] and impl

2013-07-27 Thread Romain Manni-Bucau
Cglib is almost dead if i'm right, javassist is alive but not that stable and owb is faster ATM and at least would bring an Apache impl adapted to [proxy]. Note: the fact to be able to reuse InvocationHandler and not a new API is great too Le 27 juil. 2013 20:13, Matt Benson gudnabr...@gmail.com