Re: [email] Suggestion to avoid NullPointerException

2014-07-20 Thread Benedikt Ritter
Hello Fuxiang, thanks for your interest in Apache Commons Email. I don't see a reason to add the add a null check here. We're talking about a test class and we know that the VALID_EMAILS array will never be null. Adding a null check just clutters the test code and makes it harder to understand.

[ANNOUNCE] Apache Commons DbUtils 1.6 released!

2014-07-20 Thread Benedikt Ritter
The Apache Commons Team is pleased to announce the release of Apache Commons DbUtils 1.6. The Commons DbUtils library is a small set of classes designed to make working with JDBC easier. JDBC resource cleanup code is mundane, error prone work so these classes abstract out all of the cleanup tasks

[email] Suggestion to avoid NullPointerException

2014-07-20 Thread Fuxiang Chen
Dear Developers, We are a team of researchers from the Hong Kong University of Science and Technology (HKUST). Currently, we are studying how crowdsourcing can help developers to build a higher quality software. One of the subjects that we used is Apache Commons Email. From our experiment, we ide

[math] Suggestion to use List instead of Type array

2014-07-20 Thread Fuxiang Chen
Dear Developers, We are a team of researchers from the Hong Kong University of Science and Technology (HKUST). Currently, we are studying how crowdsourcing can help developers to build a higher quality software. One of the subjects that we used is Apache Commons Math. From our experiment, we iden

Re: [CSV] Rename isIgnoreEmptyHeaders? (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-20 Thread Emmanuel Bourg
Le 20/07/2014 22:35, Benedikt Ritter a écrit : > Okay, but we can agree upon "allow missing column names" instead of "ignore > empty headers"? I'm ok for "allow missing column names" or "missing column names allowed". Emmanuel Bourg -

Re: [CSV] Rename isIgnoreEmptyHeaders? (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-20 Thread Benedikt Ritter
Okay, but we can agree upon "allow missing column names" instead of "ignore empty headers"? I'll have some time to incorporate the suggestions of this thread and the other into trunk tomorrow evening. We'll see how that feels like. Benedikt Send from my mobile device > Am 20.07.2014 um 14:10

Re: [dbcp] Javadoc "{*link Foo}"?

2014-07-20 Thread Benedikt Ritter
I see no reason to treat dbcp special wrt JavaDoc. I'm fine with changing the links. Benedikt Send from my mobile device > Am 20.07.2014 um 20:57 schrieb Gary Gregory : > > Javadoc 8 blows up left and right for this component, and I do not see > complaints about *link. > > Gary > > >> On Su

Re: [dbcp] Javadoc "{*link Foo}"?

2014-07-20 Thread Gary Gregory
Javadoc 8 blows up left and right for this component, and I do not see complaints about *link. Gary On Sun, Jul 20, 2014 at 5:05 AM, Benedikt Ritter wrote: > Try to build that with Java 8... it will tell you whether that's valid ;-) > > > 2014-07-20 8:26 GMT+02:00 Gary Gregory : > > > Is there

Re: [parent] publish version 35?

2014-07-20 Thread Gary Gregory
Looks great! I would not bother with tabs unless if feels it is necessary.  Gary Original message From: Benedikt Ritter Date:07/20/2014 12:54 (GMT-05:00) To: Commons Developers List Subject: Re: [parent] publish version 35? Here is what I have currently: http://people.apa

Re: [parent] publish version 35?

2014-07-20 Thread Benedikt Ritter
Here is what I have currently: http://people.apache.org/~britter/lang-with-coords/download_lang.html How do you like it so far? Depending on how much spare time I have next week, it'll take another week to get the tabs in place. I have committed my changes to the build plugin, so others can help o

Re: [pool] Usage of logging API in common-pool ?

2014-07-20 Thread Phil Steitz
On 7/20/14, 7:54 AM, Phil Steitz wrote: > On 7/19/14, 5:45 PM, Gary Gregory wrote: >> I just had a case today actually, where I had to unroll PoolUtils.prefill >> and add logging before each call to addObject(). > Why? > > Nine times out of ten, when you think you need logging when using > [pool],

Re: [pool] Usage of logging API in common-pool ?

2014-07-20 Thread Phil Steitz
On 7/19/14, 5:45 PM, Gary Gregory wrote: > I just had a case today actually, where I had to unroll PoolUtils.prefill > and add logging before each call to addObject(). Why? Nine times out of ten, when you think you need logging when using [pool], you can get what you need by instrumenting *your*

Re: [CSV] Rename isIgnoreEmptyHeaders? (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-20 Thread Gary Gregory
"Is allowing property x" sounds awful to me.  The following would be acceptable: - is property x allowed - is property x enabled - is property x on/off - is property - in some cases like isActive, isEnabled, is closed Gary Original message From: Benedikt Ritter Date:07/20/2014

Re: [CSV] Naming pattern of getters and setters in CSVFormat (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-20 Thread Gary Gregory
I like using all "get" methods and no "is" methods. It is simpler and makes the getters easier to access as a group with code completion IMO. The with methods do not behave like Java bean method so I do not thing we need to worry about that. Unless we want to register immutability... Gary

Re: [parent] publish version 35?

2014-07-20 Thread Gary Gregory
I think we can wait. What is your time frame?  Gary Original message From: Benedikt Ritter Date:07/20/2014 04:00 (GMT-05:00) To: Commons Developers List Subject: Re: [parent] publish version 35? hm... I'll need some more time to finish the changes in the build plugin. If

[GitHub] commons-validator pull request: Deprecate the JS part of commons v...

2014-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-validator/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: [dbcp] Javadoc "{*link Foo}"?

2014-07-20 Thread Benedikt Ritter
Try to build that with Java 8... it will tell you whether that's valid ;-) 2014-07-20 8:26 GMT+02:00 Gary Gregory : > Is there something special being done with the funky format for Javadocs > that look like "{*link Foo}" as opposed to "{@link Foo}"? > > Gary > > > > -- > E-Mail: garydgreg...@gm

Re: [CSV] Rename isIgnoreEmptyHeaders? (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-20 Thread Benedikt Ritter
Any thoughts about this? I still think isAllowingEmptyColumnNames() is a good name.​ :) Benedikt

[RESULT][VOTE] Release Commons DbUtils 1.6 based on RC2

2014-07-20 Thread Benedikt Ritter
Hi, this vote passes with the following binding +1 votes: - Gary Gregory - Oliver Heger - Benedikt Ritter thanks to all who reviewed this RC. I'll promote the artifacts now. Benedikt 2014-07-16 21:52 GMT+02:00 Benedikt Ritter : > We have fixed quite a few bugs and added some significant en

Re: [CSV] Naming pattern of getters and setters in CSVFormat (was: Re: [VOTE] Release Commons CSV 1.0 based on RC1)

2014-07-20 Thread Benedikt Ritter
using "get" for methods that return booleans is very uncommon imho... how about leaving all the gramme stuff out and use: void withSkipEmptyHeaders(boolean) boolean isSkipEmptyHeaders that would - restore symmetry between getter and setter - almost follow JavaBean conventions (except for the "wi

Re: [parent] publish version 35?

2014-07-20 Thread Benedikt Ritter
hm... I'll need some more time to finish the changes in the build plugin. If you need the changes in CP 35, go for it. I can release CP 36 when I'm finished with the build plugin. br, Benedikt 2014-07-20 6:34 GMT+02:00 Gary Gregory : > Any thoughts on publishing it? > > Gary > > -- > E-Mail: ga