On 2020-06-02, Peter Lee wrote:
> Oops, I was looking the commit and found two @throws
> IllegalArgumentException, and I was thinking this is a duplicated throws
> caused by copy-paste. And I was so much foolish that I deleted it without
> any invesgating into the code. Really sorry about this.
+1 in principle too.
Bruno P. Kinoshita 于2020年6月2日周二 上午11:24写道：
> I **think** projects using Apache gitbox can be/are hosted/mirrored on
> GitHub.
>
> As for moving to git, I'm +1 in principle. But I don't know if we create
> git repositories under github.com/apache for projects in the sandbox.
I **think** projects using Apache gitbox can be/are hosted/mirrored on GitHub.
As for moving to git, I'm +1 in principle. But I don't know if we create git
repositories under github.com/apache for projects in the sandbox. Maybe one
option here would be moving the sandbox over to git instead?
>Github will be better to attract more contributors and easy to review codes
via PR
Just make sure to have enough reviews for reviewing prs.
IMO after put it to github you might receive far more prs than before.
Oops, I was looking the commit and found two @throws
IllegalArgumentException, and I was thinking this is a duplicated throws
caused by copy-paste. And I was so much foolish that I deleted it without
any invesgating into the code. Really sorry about this.
On Mon, Jun 1, 2020 at 10:57 PM Stefan
Going from less to more visibility is not going to break BC, so that's OK.
Gary
On Mon, Jun 1, 2020 at 9:48 PM Mark Roberts
wrote:
> It’s the other way around - it was protected in 6.4.1 and we need it to be
> public or else there is no way to manipulate annotations. Without that
> we're
It’s the other way around - it was protected in 6.4.1 and we need it to be
public or else there is no way to manipulate annotations. Without that we're
dead.
Mark
(There was never a pr because I could never get anybody to say it was okay. )
-Original Message-
From: Gary Gregory
Did I miss a PR? I do not see an open PR from you.
Gary
On Mon, Jun 1, 2020 at 7:54 PM Mark Roberts
wrote:
> I'm happy to do that - but what about my requested changes to
> src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java?
>
> 123c123
> < protected void
If something is public in 6.4.1, we cannot change that. Basically, we
cannot break BC.
Gary
On Mon, Jun 1, 2020 at 9:44 PM Gary Gregory wrote:
> Did I miss a PR? I do not see an open PR from you.
>
> Gary
>
> On Mon, Jun 1, 2020 at 7:54 PM Mark Roberts
> wrote:
>
>> I'm happy to do that -
Hello All,
I wanted to fetch opinion about moving commons-graph to git and possibly
creation of github mirror.
1. Moving to git will be better for code management and change /
contribution history perspective.
2. Github will be better to attract more contributors and easy to review
codes via
Hi Gilles,
On Tue, Jun 2, 2020, 4:36 AM Gilles Sadowski wrote:
> Hello.
>
> 2020-06-01 22:18 UTC+02:00, Amey Jadiye :
> > Thanks for all the information/support guys. I dug into the archives and
> > found this[1] is the most recent interest shown by someone in
> > commons-graph.
> > even
I'm happy to do that - but what about my requested changes to
src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java?
123c123
< protected void addAnnotationEntry(final AnnotationEntryGen ag) // TODO
could this be package protected?
---
> public void addAnnotationEntry(final
Hi Mark,
May you please try the latest from git master and see how that goes? I've
merged PR 39 and 40.
Gary
On Mon, Jun 1, 2020 at 5:15 PM Mark Roberts
wrote:
> In order to support Java 11 in our tools set we needed to update BCEL.
> Hence, we made a private release (marked as version
Hello.
2020-06-01 22:18 UTC+02:00, Amey Jadiye :
> Thanks for all the information/support guys. I dug into the archives and
> found this[1] is the most recent interest shown by someone in
> commons-graph.
> even created a Jira[2] with lots of digestible information and todo already
> but never
In order to support Java 11 in our tools set we needed to update BCEL.
Hence, we made a private release (marked as version 6.4.2) that contained
the following changes:
Issue 333 - pull request 39
Issue 334 - pull request 40
Made AnnotationEntry methods public instead of protected.
I sent at
Thanks for all the information/support guys. I dug into the archives and
found this[1] is the most recent interest shown by someone in commons-graph.
even created a Jira[2] with lots of digestible information and todo already
but never progressed anymore. looks like maintainers left it here[3]
On 2020-06-01, wrote:
> The following commit(s) were added to refs/heads/master by this push:
> new 42b6aa4 minor typos cleanup
> - * @throws IllegalArgumentException if the {@link
> TarArchiveOutputStream#longFileMode} equals
> - * {@link
>
17 matches
Mail list logo
