Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-09 Thread Benedikt Ritter
Hello, > Am 09.06.2017 um 11:25 schrieb sebb : > > If the intention of the change was to ensure that the values were > correct, then there are two alternative option: > > 1) add a test to check the values I’ve implemented this proposal in 5ffb6620 > 2) add assertions in the class to check the

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-09 Thread sebb
If the intention of the change was to ensure that the values were correct, then there are two alternative option: 1) add a test to check the values 2) add assertions in the class to check the values On 9 June 2017 at 08:07, Benedikt Ritter wrote: > >> Am 09.06.2017 um 08:44 schrieb Duncan Jone

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-09 Thread Benedikt Ritter
> Am 09.06.2017 um 08:44 schrieb Duncan Jones : > > On Fri, 9 Jun 2017 at 02:35, Gary Gregory wrote: > >> On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: >> >>> There is a one other compatibility issue, which can be seen in the >> attached >>> code: >>> >>> import java.nio.charset.Standar

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Duncan Jones
On Fri, 9 Jun 2017 at 02:35, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > > > There is a one other compatibility issue, which can be seen in the > attached > > code: > > > > import java.nio.charset.StandardCharsets; > > > > public class Weasel { > > > > private

[CANCEL][VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Benedikt Ritter
> Am 08.06.2017 um 10:48 schrieb Benedikt Ritter : > > Hello, > > we have fixed quite a few bugs and added some nice new features since Commons > Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on > RC3. > The following issues have been fixed since RC2: > > - Site bui

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Benedikt Ritter
Hi, > Am 09.06.2017 um 03:34 schrieb Gary Gregory : > > On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > >> There is a one other compatibility issue, which can be seen in the attached >> code: >> >> import java.nio.charset.StandardCharsets; >> >> public class Weasel { >> >>private st

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Gary Gregory
On Thu, Jun 8, 2017 at 6:29 PM, Simon Spero wrote: > There is a one other compatibility issue, which can be seen in the attached > code: > > import java.nio.charset.StandardCharsets; > > public class Weasel { > > private static final String US_ASCII = "US-ASCII"; > private static final St

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Simon Spero
There is a one other compatibility issue, which can be seen in the attached code: import java.nio.charset.StandardCharsets; public class Weasel { private static final String US_ASCII = "US-ASCII"; private static final String UTF_8 = "UTF-8"; private static final String STANDARD_US_AS

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread sebb
On 8 June 2017 at 18:09, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 9:57 AM, sebb wrote: > >> On 8 June 2017 at 17:19, Gary Gregory wrote: >> > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: >> > >> >> [A Note, not a vote :) ] >> >> >> >> 1. Clirr is generally considered obsolete, as it h

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Rob Tompkins
+1 (non-binding) Signatures ok mvn clean site works in distro. > On Jun 8, 2017, at 1:09 PM, Gary Gregory wrote: > >> On Thu, Jun 8, 2017 at 9:57 AM, sebb wrote: >> >>> On 8 June 2017 at 17:19, Gary Gregory wrote: On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: [A Note, n

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Gary Gregory
On Thu, Jun 8, 2017 at 9:57 AM, sebb wrote: > On 8 June 2017 at 17:19, Gary Gregory wrote: > > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: > > > >> [A Note, not a vote :) ] > >> > >> 1. Clirr is generally considered obsolete, as it hadn't been worked on > for > >> about ten years. japi

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Gary Gregory
+1. >From src zip: ASC, MD5, SHA1 OK. RAT and Clirr OK. Clirr does have the warnings discussed on this thread. Running 'mvn clean site' passes with: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T12:39:06-07:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version:

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread sebb
On 8 June 2017 at 17:19, Gary Gregory wrote: > On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: > >> [A Note, not a vote :) ] >> >> 1. Clirr is generally considered obsolete, as it hadn't been worked on for >> about ten years. japicmp is a good replacement, especially for report >> generation

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Gary Gregory
On Thu, Jun 8, 2017 at 5:38 AM, Simon Spero wrote: > [A Note, not a vote :) ] > > 1. Clirr is generally considered obsolete, as it hadn't been worked on for > about ten years. japicmp is a good replacement, especially for report > generation, and is used in other commons projects. > IIRC, we'v

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Simon Spero
[A Note, not a vote :) ] 1. Clirr is generally considered obsolete, as it hadn't been worked on for about ten years. japicmp is a good replacement, especially for report generation, and is used in other commons projects. 2. Are the "changes" to the values in CharEncoding really necessary[1] (Th

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Bruno P. Kinoshita
Commons Lang 3.6 based on RC3 Hello, we have fixed quite a few bugs and added some nice new features since Commons Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on RC3. The following issues have been fixed since RC2: - Site build now works from source distribution

[VOTE] Release Apache Commons Lang 3.6 based on RC3

2017-06-08 Thread Benedikt Ritter
Hello, we have fixed quite a few bugs and added some nice new features since Commons Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on RC3. The following issues have been fixed since RC2: - Site build now works from source distribution - IBM JDK test failures have been