Re: Request approving Pull request

2023-11-22 Thread Glavo
Hello Gary, Can you also review this PR ( https://github.com/apache/commons-compress/pull/378) again? Thank you so much! Glavo On Thu, Nov 23, 2023 at 12:45 AM Gary Gregory wrote: > Hi CommonsSanjana Rampur Kottur, > > The key is patience here. We are volunteers here doing our best juggling

Re: Request approving Pull request

2023-11-22 Thread Gary Gregory
Hi CommonsSanjana Rampur Kottur, The key is patience here. We are volunteers here doing our best juggling many tasks. I'll take a look over the weekend and get back to you (this is a long holiday weekend starting tomorrow in the US). TY, Gary On Wed, Nov 22, 2023, 11:41 AM Sanjana RK wrote: >

Request approving Pull request

2023-11-22 Thread Sanjana RK
Hello Gary, As a part of my assignment and personal passion and interest I chose to work on Apache commons, it would be really helpful if you could approve at least a few PR's as I have worked my best and I am ready to adhere to your reviews and rectify the current changes if needed. Please help

Re: [LANG] Extend "EqualsBuilder (Was: Pull request)

2023-10-11 Thread Marc Cappelletti
Hello all, Just a comment that my ICLA has been filled. The jira for the PR https://github.com/apache/commons-lang/pull/1114 is https://issues.apache.org/jira/browse/LANG-1712 Now heading to address the comments. Marc Le mer. 27 sept. 2023 à 12:35, Gilles Sadowski a écrit : > Hello. > > Le

Re: [LANG] Extend "EqualsBuilder (Was: Pull request)

2023-09-27 Thread Gilles Sadowski
Hello. Le mer. 27 sept. 2023 à 11:48, Marc Cappelletti a écrit : > > Hello Gilles, > > Thanks for the details and the comment. Thanks for your interest in contributing. > > By the way, do we comment directly on the PR Many people mostly do it on GH (which shuns people who don't want to

Re: [LANG] Extend "EqualsBuilder (Was: Pull request)

2023-09-27 Thread Marc Cappelletti
ot; of the "Commons" > project, the "Subject: " line should be prefixed by the "id" of the > component > (in this case: "[LANG] Pull request"). It is also nice if the subject > line is a > bit more specific (in this case: "[LANG] Extend &

[LANG] Extend "EqualsBuilder (Was: Pull request)

2023-09-27 Thread Gilles Sadowski
Hello. As this list is shared among many (30+) "components" of the "Commons" project, the "Subject: " line should be prefixed by the "id" of the component (in this case: "[LANG] Pull request"). It is also nice if the subject line is

Pull request

2023-09-27 Thread Marc Cappelletti
Hello, I'm a new contributor and I have a pull request: https://github.com/apache/commons-lang/pull/1114 Is everything okay for a review or do I need to publish the link somewhere, like in this dev list? :) Thanks for your information, -- Marc Cappelletti

Re: [GitHub] [commons-dbutils] thecarlhall merged pull request #161: Bump mockito-core from 4.9.0 to 4.10.0

2022-12-19 Thread Gary Gregory
Please STOP merging PRs into a broken build and revert what original PR you merged to cause the break in the first place. Gary On Mon, Dec 19, 2022, 08:37 GitBox wrote: > > thecarlhall merged PR #161: > URL: https://github.com/apache/commons-dbutils/pull/161 > > > -- > This is an automated

Fwd: [GitHub] [commons-text] kinow merged pull request #378: Bump actions/upload-artifact from 3.1.0 to 3.1.1

2022-10-22 Thread Gary Gregory
You have to change the comment to match, as it is now wrong. Gary -- Forwarded message - From: GitBox Date: Fri, Oct 21, 2022, 21:35 Subject: [GitHub] [commons-text] kinow merged pull request #378: Bump actions/upload-artifact from 3.1.0 to 3.1.1 To: kinow merged PR #378

Re: Pull Request Reviews/Feedback Please

2021-09-16 Thread Gilles Sadowski
Hi. Le sam. 11 sept. 2021 à 18:49, John Patrick a écrit : > > So dependabot, most commons project already have it, so was helping out > adding it the the rest. > But the main reason was pro-active DevSecOps. So automatically testing the > current main branch against the latest releases of

Re: Pull Request Reviews/Feedback Please

2021-09-11 Thread Matt Sicker
Updates that help with testing in newer JDKs while still supporting older ones (which version tends to depend on the specific component; most have been or can be upgraded to JDK 8 at least). With Java 17 coming out, some developers will make the jump from 11 to 17. On Sat, Sep 11, 2021 at 11:49

Re: Pull Request Reviews/Feedback Please

2021-09-11 Thread John Patrick
So dependabot, most commons project already have it, so was helping out adding it the the rest. But the main reason was pro-active DevSecOps. So automatically testing the current main branch against the latest releases of dependencies. Save developer and contributors manually watching out for new

Re: Pull Request Reviews/Feedback Please

2021-09-08 Thread Gilles Sadowski
Hello. Le mer. 8 sept. 2021 à 21:10, John Patrick a écrit : > > Hi, > > Could someone look at this pr's, some coming up to a year open. Thanks for the reminder; however ... > > Dependabot, adding the commons standard. > [...] > https://github.com/apache/commons-math/pull/160 >

Pull Request Reviews/Feedback Please

2021-09-08 Thread John Patrick
Hi, Could someone look at this pr's, some coming up to a year open. Dependabot, adding the commons standard. https://github.com/apache/commons-jci/pull/3 https://github.com/apache/commons-jelly/pull/7 https://github.com/apache/commons-jxpath/pull/21

[Numbers][All] Code readability vs System.arraycopy (Was: [...] pull request #99: [...])

2021-06-20 Thread Gilles Sadowski
gt; > > arturobernalg commented on a change in pull request #99: > URL: https://github.com/apache/commons-numbers/pull/99#discussion_r654891918 > > > > ## > File path: > commons-numbers-combinatorics/src/main/java/org/apache/commons/numbers/combinatorics/LogFa

Re: [commons-imaging] 01/01: Merge pull request #96 from apache/dependabot/maven/commons-io-commons-io-2.8.0

2020-09-10 Thread Gary Gregory
nges MUST be documented IMO. > > Personally, I just document it all, it makes for a simpler process (for me.) > > Thank you, > Gary > > ------ Forwarded message - > From: > Date: Thu, Sep 10, 2020 at 1:33 AM > Subject: [commons-imaging] 01/01: Merge pull re

Re: [commons-imaging] 01/01: Merge pull request #96 from apache/dependabot/maven/commons-io-commons-io-2.8.0

2020-09-10 Thread Bruno P. Kinoshita
you, Gary -- Forwarded message - From: Date: Thu, Sep 10, 2020 at 1:33 AM Subject: [commons-imaging] 01/01: Merge pull request #96 from apache/dependabot/maven/commons-io-commons-io-2.8.0 To: comm...@commons.apache.org This is an automated email from the ASF dual-hosted git

Fwd: [commons-imaging] 01/01: Merge pull request #96 from apache/dependabot/maven/commons-io-commons-io-2.8.0

2020-09-10 Thread Gary Gregory
pull request #96 from apache/dependabot/maven/commons-io-commons-io-2.8.0 To: comm...@commons.apache.org This is an automated email from the ASF dual-hosted git repository. kinow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-imaging.git commit

Fwd: [GitHub] [commons-text] kinow merged pull request #161: Bump commons-io from 2.7 to 2.8.0

2020-09-10 Thread Gary Gregory
Please update changes.xml! Gary -- Forwarded message - From: GitBox Date: Thu, Sep 10, 2020, 01:26 Subject: [GitHub] [commons-text] kinow merged pull request #161: Bump commons-io from 2.7 to 2.8.0 To: kinow merged pull request #161: URL: https://github.com/apache/commons

Re: [GitHub] [commons-collections] kinow commented on pull request #173: Bump actions/checkout from v2.3.1 to v2.3.2

2020-08-10 Thread Gary Gregory
/org.apache.maven.plugins-maven-antrun-plugin-3.0.0, origin/dependabot/maven/org.apache.maven.plugins-maven-pmd-plugin-3.13.0, origin/HEAD, origin/master On Mon, Aug 10, 2020 at 5:49 AM GitBox wrote: > > kinow commented on pull request #173: > URL: > https://github.com/apache/commons-collecti

[Math] Bypassing official channels... (Was: [GitHub] [commons-math] chentao106 opened a new pull request #117: Implement the MiniBatchKMeansClusterer)

2020-01-16 Thread Gilles Sadowski
Hi. Can someone comment on GitHub that communication should be through the "dev" ML and/or JIRA? Thanks, Gilles Le jeu. 16 janv. 2020 à 17:37, GitBox a écrit : > > chentao106 opened a new pull request #117: Implement the > MiniBatchKMeansClusterer > URL: https://github.c

[general] Phishing emails mentioning Apache coming in after pull request submitted

2019-12-05 Thread Eric Barnhill
Some unsavory types are watching Apache activity. I submitted my first Apache PR in a long time yesterday, by morning I had two phishing emails mentioning Apache in both subject and body at the relevant email address. I hope the community is aware of this issue? I don't recall this happening even

Re: [GitHub] [commons-statistics] chtompki opened a new pull request #17: STATISTICS-7

2019-06-15 Thread Gilles Sadowski
Hello. Le sam. 15 juin 2019 à 03:24, GitBox a écrit : > > chtompki opened a new pull request #17: STATISTICS-7 > URL: https://github.com/apache/commons-statistics/pull/17 > I don't understand this pull request. Code is not in a state to be merged to "master". [Not e

Re: [statistics] Pull request for GLSMultipleLinearRegression

2019-06-07 Thread Alexey Dievsky
Hi Eric, as Elena's mentor, I can try to shed some light on this question. IRLS, as used in GLM fitting, does require a matrix, but it's always diagonal. See, for example, https://bwlewis.github.io/GLM/ , section "Algorithm IRLS". The motivation for this pull request is exactly this --

Re: [beanutils2] CVE-2014-0114 Pull Request

2019-05-25 Thread Rob Tompkins
ted my first Apache Commons PR which addresses the issue which I >> was hoping I could get code reviewed and hopefully merged. I followed all >> guidelines and included a specific unit test to prove the issue and the fix. >> >> Pull Request: https://github.com/apache/commo

Re: [beanutils2] CVE-2014-0114 Pull Request

2019-05-25 Thread Matt Sicker
critical so I opened a ticket: > https://issues.apache.org/jira/browse/BEANUTILS-520 > > I submitted my first Apache Commons PR which addresses the issue which I > was hoping I could get code reviewed and hopefully merged. I followed all > guidelines and included a specific unit test to p

Re: [statistics] Pull request for GLSMultipleLinearRegression

2019-05-23 Thread Eric Barnhill
Hi Elena, Thanks for this intriguing idea. As far as I ever knew IRLS requires a matrix. Can you provide me with a citation where I can read about this vector-based approach? Thanks, Eric On Thu, May 23, 2019, 06:44 Елена Картышева wrote: > Hello. > > I would like to propose a pul

RE: [statistics] Pull request for GLSMultipleLinearRegression

2019-05-23 Thread Ben Nguyen
component, please post insights here as well: https://issues.apache.org/jira/browse/STATISTICS-8 GitHub Repo: https://github.com/apache/commons-statistics Thank you for your post, Cheers, -Ben Nguyen From: Елена Картышева Sent: Thursday, May 23, 2019 8:44 AM To: dev Subject: [statistics] Pull request

[statistics] Pull request for GLSMultipleLinearRegression

2019-05-23 Thread Елена Картышева
Hello. I would like to propose a pull request implementing an option to use variance vector instead of covariance matrix. It allows users to avoid unnecessary memory usage and excessive computation in case of uncorrelated but heteroscedastic errors thus making it possible to work with huge

[statistics] Pull request for GLSMultipleLinearRegression

2019-05-23 Thread Ellen Kartysheva
I would like to propose a pull request implementing an option to use variance vector instead of covariance matrix. It allows users to avoid unnecessary memory usage and excessive computation in case of uncorrelated but heteroscedastic errors thus making it possible to work with huge input matrices

[beanutils2] CVE-2014-0114 Pull Request

2019-05-23 Thread Melloware Inc
Apache Commons PR which addresses the issue which I was hoping I could get code reviewed and hopefully merged. I followed all guidelines and included a specific unit test to prove the issue and the fix. Pull Request: https://github.com/apache/commons-beanutils/pull/7 I really feel like

Re: [LANG]DurationUtils pull request reminder

2019-03-18 Thread Aleksander Ściborek
for such a situation -- perhaps using > MethodHandle, > > > or using a lambda expression? > > > > > > And then I would say ditto for the unit of rounding. So rather than > > > repetitive methods like roundUpDays(), you construct a > > > Dur

Re: [LANG]DurationUtils pull request reminder

2019-03-18 Thread Eric Barnhill
. > > > > Please jump in if anyone finds this approach objectionable. > > > > Eric > > > > On Tue, Mar 12, 2019 at 4:05 PM Aleksander Ściborek < > > aleksanderscibo...@gmail.com> wrote: > > > > > Hi, > > > I would like to remind abut my pull request : > > > https://github.com/apache/commons-lang/pull/406 > > > I know that you have a lot of work, but please take look at it - this > PR > > > was created almost month ago. > > > Aleksander > > > > > >

Re: [LANG]DurationUtils pull request reminder

2019-03-17 Thread Aleksander Ściborek
der Ściborek < > aleksanderscibo...@gmail.com> wrote: > > > Hi, > > I would like to remind abut my pull request : > > https://github.com/apache/commons-lang/pull/406 > > I know that you have a lot of work, but please take look at it - this PR > > was created almost month ago. > > Aleksander > > >

Re: [LANG]DurationUtils pull request reminder

2019-03-12 Thread Eric Barnhill
ue, Mar 12, 2019 at 4:05 PM Aleksander Ściborek < aleksanderscibo...@gmail.com> wrote: > Hi, > I would like to remind abut my pull request : > https://github.com/apache/commons-lang/pull/406 > I know that you have a lot of work, but please take look at it - this PR > was created almost month ago. > Aleksander >

[LANG]DurationUtils pull request reminder

2019-03-12 Thread Aleksander Ściborek
Hi, I would like to remind abut my pull request : https://github.com/apache/commons-lang/pull/406 I know that you have a lot of work, but please take look at it - this PR was created almost month ago. Aleksander

[GitHub] garydgregory merged pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality.

2019-03-02 Thread GitBox
garydgregory merged pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality. URL: https://github.com/apache/commons-text/pull/105 This is an automated message from the Apache Git Service

[GitHub] aherbert opened a new pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality.

2019-03-02 Thread GitBox
aherbert opened a new pull request #105: TEXT-151: Use StringUtils.equals to test for CharSequence equality. URL: https://github.com/apache/commons-text/pull/105 Comparing CharSequence using Object.equals will fail when the CharSequence implementation does not support

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-02 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261841223 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] garydgregory commented on a change in pull request #5: optimize map columns 2 properties code

2019-03-02 Thread GitBox
garydgregory commented on a change in pull request #5: optimize map columns 2 properties code URL: https://github.com/apache/commons-dbutils/pull/5#discussion_r261832711 ## File path: src/main/java/org/apache/commons/dbutils/BeanProcessor.java ## @@ -465,9 +465,6

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-02 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261831169 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-02 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261818800 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert opened a new pull request #26: RNG-76: Added primitive long constructor to SplitMix64

2019-03-01 Thread GitBox
aherbert opened a new pull request #26: RNG-76: Added primitive long constructor to SplitMix64 URL: https://github.com/apache/commons-rng/pull/26 This is an automated message from the Apache Git Service. To respond

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-01 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261698482 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-01 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261710128 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-01 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261708871 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-03-01 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r261698482 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] zsoltii opened a new pull request #74: Add new function: byteCountToDisplayRoundedSize

2019-03-01 Thread GitBox
zsoltii opened a new pull request #74: Add new function: byteCountToDisplayRoundedSize URL: https://github.com/apache/commons-io/pull/74 Commons IO/IO-373 https://issues.apache.org/jira/browse/IO-373

[GitHub] aeschwabe closed pull request #30: [CSV-226] Add CSVParser test case for standard charsets.

2019-02-28 Thread GitBox
aeschwabe closed pull request #30: [CSV-226] Add CSVParser test case for standard charsets. URL: https://github.com/apache/commons-csv/pull/30 This is an automated message from the Apache Git Service. To respond

[GitHub] aherbert opened a new pull request #25: RNG-73: Add methods used from UniformRandomProvider to the samplers.

2019-02-28 Thread GitBox
aherbert opened a new pull request #25: RNG-73: Add methods used from UniformRandomProvider to the samplers. URL: https://github.com/apache/commons-rng/pull/25 This adds details to the javadoc for the samplers describing the method(s) used from {{UniformRandomProvider}}. I added

[GitHub] asfgit merged pull request #24: RNG-74: DiscreteUniformSampler can be optimised for the algorithm

2019-02-28 Thread GitBox
asfgit merged pull request #24: RNG-74: DiscreteUniformSampler can be optimised for the algorithm URL: https://github.com/apache/commons-rng/pull/24 This is an automated message from the Apache Git Service. To respond

[GitHub] garydgregory merged pull request #30: Seems a trivial change to me, should I create a Jira?

2019-02-28 Thread GitBox
garydgregory merged pull request #30: Seems a trivial change to me, should I create a Jira? URL: https://github.com/apache/commons-dbcp/pull/30 This is an automated message from the Apache Git Service. To respond

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260927842 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r26092 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260869818 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260868918 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260868918 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260867964 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260867481 ## File path: src/test/java/org/apache/commons/text/similarity/SorensenDicesSimilarityTest.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260866952 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260867021 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260866733 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] asfgit closed pull request #39: [CSV-238] Escape quotes in CLOBs

2019-02-27 Thread GitBox
asfgit closed pull request #39: [CSV-238] Escape quotes in CLOBs URL: https://github.com/apache/commons-csv/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260720252 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260712894 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-27 Thread GitBox
aherbert commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260711148 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] JacquesLeRoux opened a new pull request #30: Seems a trivial change to me, should I create a Jira?

2019-02-27 Thread GitBox
JacquesLeRoux opened a new pull request #30: Seems a trivial change to me, should I create a Jira? URL: https://github.com/apache/commons-dbcp/pull/30 In OFBiz we implemented DebugManagedDataSource http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main

[GitHub] ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-26 Thread GitBox
ameyjadiye commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260580097 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-26 Thread GitBox
kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260477613 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-26 Thread GitBox
kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260477903 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-26 Thread GitBox
kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260477046 ## File path: src/main/java/org/apache/commons/text/similarity/SorensenDicesSimilarity.java

[GitHub] kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-26 Thread GitBox
kinow commented on a change in pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103#discussion_r260478425 ## File path: src/test/java/org/apache/commons/text/similarity/SorensenDicesSimilarityTest.java

[GitHub] ameyjadiye opened a new pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham

2019-02-26 Thread GitBox
ameyjadiye opened a new pull request #103: TEXT-126: Adding Sorensen-Dice similarity algoritham URL: https://github.com/apache/commons-text/pull/103 This pull request adds the Sorensen-Dice Similarity Algorithm to Apache Commons Text. The Sorensen–Dice coefficient is a statistic

[GitHub] vanzin merged pull request #93: JNA version is updated to 4.4.0

2019-02-26 Thread GitBox
vanzin merged pull request #93: JNA version is updated to 4.4.0 URL: https://github.com/apache/commons-crypto/pull/93 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] aherbert opened a new pull request #24: RNG-74: DiscreteUniformSampler can be optimised for the algorithm

2019-02-26 Thread GitBox
aherbert opened a new pull request #24: RNG-74: DiscreteUniformSampler can be optimised for the algorithm URL: https://github.com/apache/commons-rng/pull/24 Split the algorithm into two private classes. This is an automated

[GitHub] aherbert opened a new pull request #24: RNG-74: DiscreteUniformSampler can be optimised for the algorithm

2019-02-26 Thread GitBox
aherbert opened a new pull request #24: RNG-74: DiscreteUniformSampler can be optimised for the algorithm URL: https://github.com/apache/commons-rng/pull/24 Split the algorithm into two private classes. This is an automated

[GitHub] dedabob closed pull request #36: [CSV-234] Add support for java.sql.Clob

2019-02-26 Thread GitBox
dedabob closed pull request #36: [CSV-234] Add support for java.sql.Clob URL: https://github.com/apache/commons-csv/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] ossdev07 opened a new pull request #93: JNA version is updated to 4.4.0

2019-02-25 Thread GitBox
ossdev07 opened a new pull request #93: JNA version is updated to 4.4.0 URL: https://github.com/apache/commons-crypto/pull/93 jvm is getting crashed patch on AARCH64 platform (CentOS7) with openJDK8 with JNA version 4.2.2 and working fine with JNA 4.4.0 Signed-off-by: ossdev07

[GitHub] asfgit merged pull request #21: RNG-71: Validate parameters for the distribution samplers

2019-02-25 Thread GitBox
asfgit merged pull request #21: RNG-71: Validate parameters for the distribution samplers URL: https://github.com/apache/commons-rng/pull/21 This is an automated message from the Apache Git Service. To respond

[GitHub] asfgit merged pull request #22: RNG-72: Add new JMH benchmark ConstructionPerformance

2019-02-25 Thread GitBox
asfgit merged pull request #22: RNG-72: Add new JMH benchmark ConstructionPerformance URL: https://github.com/apache/commons-rng/pull/22 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] asfgit merged pull request #23: Update readme using commons-build-plugin

2019-02-25 Thread GitBox
asfgit merged pull request #23: Update readme using commons-build-plugin URL: https://github.com/apache/commons-rng/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] kinow merged pull request #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

2019-02-23 Thread GitBox
kinow merged pull request #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102 This is an automated message from the Apache Git Service. To respond

[GitHub] aherbert opened a new pull request #23: Update readme using commons-build-plugin

2019-02-23 Thread GitBox
aherbert opened a new pull request #23: Update readme using commons-build-plugin URL: https://github.com/apache/commons-rng/pull/23 All Javadoc links are now valid where appropriate. Manual edits were made on the build plugin output to support the sub-modules

[GitHub] aherbert opened a new pull request #22: RNG-72: Add new JMH benchmark ConstructionPerformance

2019-02-22 Thread GitBox
aherbert opened a new pull request #22: RNG-72: Add new JMH benchmark ConstructionPerformance URL: https://github.com/apache/commons-rng/pull/22 Initial benchmark version. Results posted in [RNG-72](https://issues.apache.org/jira/browse/RNG-72?focusedCommentId=16775619

[GitHub] visruth opened a new pull request #7: get generated keys from queryRunner.insertBatch

2019-02-20 Thread GitBox
visruth opened a new pull request #7: get generated keys from queryRunner.insertBatch URL: https://github.com/apache/commons-dbutils/pull/7 This class will be useful to get generated keys from the queryRunner.insertBatch operation. Eg:- ``` ResultSetHandler> rsh =

[GitHub] kinow opened a new pull request #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report

2019-02-20 Thread GitBox
kinow opened a new pull request #102: TEXT-104: deprecate JaroWinkler methods for 2.0, and fix clirr report URL: https://github.com/apache/commons-text/pull/102 This PR makes the Clirr report pass for 1.7. It keeps the new `JaroWinklerSimilarity` class, but reverts the change

[GitHub] kinow merged pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

2019-02-19 Thread GitBox
kinow merged pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity URL: https://github.com/apache/commons-text/pull/100 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] vanzin closed pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX

2019-02-19 Thread GitBox
vanzin closed pull request #91: run time support is added for openssl 1.0 and 1.1 for UNIX URL: https://github.com/apache/commons-crypto/pull/91 This is an automated message from the Apache Git Service. To respond

[GitHub] vanzin merged pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1

2019-02-19 Thread GitBox
vanzin merged pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92 This is an automated message from the Apache Git Service

[GitHub] luyseyal opened a new pull request #39: [CSV-234] Enable escaping of quotes in CLOBs

2019-02-18 Thread GitBox
luyseyal opened a new pull request #39: [CSV-234] Enable escaping of quotes in CLOBs URL: https://github.com/apache/commons-csv/pull/39 This fixes Excel output. Given a CLOB like: ``` Choose either "Y" or "N" ``` The patch will transform it to:

[GitHub] saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

2019-02-18 Thread GitBox
saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity URL: https://github.com/apache/commons-text/pull/100#discussion_r257781951 ## File path: src/main/java/org/apache/commons/text/similarity/package-info.java

[GitHub] saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

2019-02-18 Thread GitBox
saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity URL: https://github.com/apache/commons-text/pull/100#discussion_r257781239 ## File path: src/main/java/org/apache/commons/text/similarity/JaroWinklerSimilarity.java

[GitHub] saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity

2019-02-18 Thread GitBox
saschaszott commented on a change in pull request #100: TEXT-104: Jaro Winkler Distance refers to similarity URL: https://github.com/apache/commons-text/pull/100#discussion_r257780047 ## File path: src/main/java/org/apache/commons/text/similarity/JaroWinklerDistance.java

[GitHub] aherbert opened a new pull request #21: RNG-71: Validate parameters for the distribution samplers

2019-02-17 Thread GitBox
aherbert opened a new pull request #21: RNG-71: Validate parameters for the distribution samplers URL: https://github.com/apache/commons-rng/pull/21 This adds checks matching those found in the commons-math3 distributions to the samplers. An additional check missing in commons-math3

[GitHub] asfgit merged pull request #30: GEOMETRY-28: Line API Updates

2019-02-17 Thread GitBox
asfgit merged pull request #30: GEOMETRY-28: Line API Updates URL: https://github.com/apache/commons-geometry/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] britter merged pull request #73: Fix broken build

2019-02-17 Thread GitBox
britter merged pull request #73: Fix broken build URL: https://github.com/apache/commons-io/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] kinow merged pull request #69: Fix site report issues

2019-02-17 Thread GitBox
kinow merged pull request #69: Fix site report issues URL: https://github.com/apache/commons-collections/pull/69 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] kinow merged pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported

2019-02-17 Thread GitBox
kinow merged pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported URL: https://github.com/apache/commons-dbutils/pull/6 This is an automated message from the Apache Git Service

[GitHub] darkma773r opened a new pull request #30: GEOMETRY-28: Line API Updates

2019-02-16 Thread GitBox
darkma773r opened a new pull request #30: GEOMETRY-28: Line API Updates URL: https://github.com/apache/commons-geometry/pull/30 Cleaning up the 2D Line API and adding additional unit tests. This is an automated message from

  1   2   3   4   5   6   7   8   9   10   >