RE: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

>From the peanut gallery, in-line. > -Original Message- > From: Gilles [mailto:gil...@harfang.homelinux.org] > Sent: Monday, August 8, 2016 08:50 > To: dev@commons.apache.org > Subject: Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed > contract of "Math#round()" in Java 8 >

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

Le 8/08/2016 à 17:50, Gilles a écrit : > Hence, you assume that reviewers are either not necessary, or that > they their time is worth less than yours. >From my experience it doesn't take more time to review a one commit change on a branch or on the trunk. Emmanuel Bourg

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

On Mon, 8 Aug 2016 16:40:04 +0200, Emmanuel Bourg wrote: Le 8/08/2016 à 16:22, Gilles a écrit : There are pro and contra; IMO, saving a few characters is not worth wondering upon reading whether "assertEquals" is from (JUnit) "Assert" or Commons Math "TestUtils". Seriously, there is little

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

> On Aug 8, 2016, at 10:40 AM, Emmanuel Bourg wrote: > > Le 8/08/2016 à 16:22, Gilles a écrit : > >> There are pro and contra; IMO, saving a few characters is not worth >> wondering upon reading whether "assertEquals" is from (JUnit) "Assert" >> or Commons Math "TestUtils".

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

Le 8/08/2016 à 16:22, Gilles a écrit : > There are pro and contra; IMO, saving a few characters is not worth > wondering upon reading whether "assertEquals" is from (JUnit) "Assert" > or Commons Math "TestUtils". Seriously, there is little doubt that "assertEquals" comes from JUnit in a FooTest

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

On Mon, 8 Aug 2016 13:14:18 +0200, Emmanuel Bourg wrote: Le 8/08/2016 à 00:42, Gilles a écrit : In CM, the usage was to not use "import static". You should make an exception for the unit tests, otherwise the JUnit 4 syntax is too verbose (and JUnit 4 was designed with static imports in

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

Le 8/08/2016 à 00:42, Gilles a écrit : > In CM, the usage was to not use "import static". You should make an exception for the unit tests, otherwise the JUnit 4 syntax is too verbose (and JUnit 4 was designed with static imports in mind). > Excerpts from "CONTRIBUTING.md": > + Create a topic

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

On Sat, 6 Aug 2016 11:46:01 -0700, Dennis E. Hamilton wrote: -Original Message- From: Gilles [mailto:gil...@harfang.homelinux.org] Sent: Friday, August 5, 2016 09:11 To: Commons Developers List Subject: Re: [5/7] [math] Fix "FastMath#round(..)" to comply to

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

Le 6/08/2016 à 20:46, Dennis E. Hamilton a écrit : > Oh, and is there a JIRA about this (the Math.round contract) or some other > way to tie in whatever scholarship and traceability is involved in the > specialized case of [MATH] software? (I may have missed this - sorry for > asking if

RE: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

> -Original Message- > From: Gilles [mailto:gil...@harfang.homelinux.org] > Sent: Friday, August 5, 2016 09:11 > To: Commons Developers List > Subject: Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed > contract of "Math#round()" in Java 8 > > Hi.

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

Hi. Changes in this file seem unrelated to the commit message. Gilles On Fri, 05 Aug 2016 15:06:53 -, ebo...@apache.org wrote: http://git-wip-us.apache.org/repos/asf/commons-math/blob/83b70a37/src/test/java/org/apache/commons/math4/util/FastMathTest.java