Re: [VOTE] Release Apache Commons BCEL based on RC1

ven repository, all good. Thanks! Bruno From: Gary Gregory <garydgreg...@gmail.com> To: Commons Developers List <dev@commons.apache.org> Sent: Friday, 8 December 2017 9:36 AM Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 I am looking for more reviews f

Re: [VOTE] Release Apache Commons BCEL based on RC1

+1 (non-binding) On Thu, Dec 7, 2017 at 12:34 PM, Gary Gregory wrote: > I am looking for more reviews from PMC members please. > > Gary > > On Dec 7, 2017 13:33, "Oliver Heger" wrote: > > > > > > > Am 06.12.2017 um 22:26 schrieb Gary

Re: [VOTE] Release Apache Commons BCEL based on RC1

I am looking for more reviews from PMC members please. Gary On Dec 7, 2017 13:33, "Oliver Heger" wrote: > > > Am 06.12.2017 um 22:26 schrieb Gary Gregory: > > Oliver, how do you feel about installing Java 9 and trying again? > > > > Gary > > > > On Tue, Dec 5,

Re: [VOTE] Release Apache Commons BCEL based on RC1

Am 06.12.2017 um 22:26 schrieb Gary Gregory: > Oliver, how do you feel about installing Java 9 and trying again? > > Gary > > On Tue, Dec 5, 2017 at 1:48 PM, Gary Gregory wrote: > >> The test calls the registryGetKeys Windows API and that throws an >> exception

Re: [VOTE] Release Apache Commons BCEL based on RC1

Oliver, how do you feel about installing Java 9 and trying again? Gary On Tue, Dec 5, 2017 at 1:48 PM, Gary Gregory wrote: > The test calls the registryGetKeys Windows API and that throws an > exception because Java 9 is not installed on that machine. This is a bug in >

Re: [VOTE] Release Apache Commons BCEL based on RC1

The test calls the registryGetKeys Windows API and that throws an exception because Java 9 is not installed on that machine. This is a bug in the test only. Fixed in trunk. Not a showstopper IMO. Gary On Sun, Dec 3, 2017 at 1:44 PM, Oliver Heger wrote: > Here is

RE: [VOTE] Release Apache Commons BCEL based on RC1

This works, thanks for including the BCEL-295 fix. So my vote is now +1. Mark -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Saturday, December 02, 2017 1:04 PM To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 Well

Re: [VOTE] Release Apache Commons BCEL based on RC1

Here is the stack trace: --- Test set: org.apache.bcel.generic.JDKGenericDumpTestCase --- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time

Re: [VOTE] Release Apache Commons BCEL based on RC1

Do you have a full stack trace? It smells like the code that looks for JDK and JRE locations is failing. Gary On Dec 3, 2017 08:33, "Oliver Heger" wrote: > Hi, > > when building on Windows 10 with both Java 1.7 and 1.8 I get the test > failure below. Does anybody

Re: [VOTE] Release Apache Commons BCEL based on RC1

Hi, when building on Windows 10 with both Java 1.7 and 1.8 I get the test failure below. Does anybody else see this? Oliver Results : Tests in error: JDKGenericDumpTestCase.data:82->findJavaHomes:87->findJavaHomesOnWindows:97->addAllJavaHomesOnWindows:65 ▒ Win32 Tests run: 107, Failures: 0,

RE: [VOTE] Release Apache Commons BCEL based on RC1

I will give it a try - but might take a couple of days -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Saturday, December 02, 2017 1:04 PM To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 Well, you you try this RC

Re: [VOTE] Release Apache Commons BCEL based on RC1

already had to release a private > version of BCEL, we were hoping that the next version would fix that. > > -Original Message- > From: Gary Gregory [mailto:garydgreg...@gmail.com] > Sent: Saturday, December 02, 2017 12:14 PM > To: Commons Developers List > Subject: Re: [VOTE]

RE: [VOTE] Release Apache Commons BCEL based on RC1

] Sent: Saturday, December 02, 2017 12:14 PM To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons BCEL based on RC1 Mark, Unless BCEL-295 <https://issues.apache.org/jira/browse/BCEL-295> is a regression, I see no technical reason for a -1. What am I missing? Gary On Sat,

Re: [VOTE] Release Apache Commons BCEL based on RC1

Looking at the release notes https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt, you will see BCEL-295 is in this RC. Gary On Sat, Dec 2, 2017 at 1:24 PM, Gary Gregory wrote: > Also note that my prime motivation here is to get a version out of the >

Re: [VOTE] Release Apache Commons BCEL based on RC1

Also note that my prime motivation here is to get a version out of the door that does not blow up violently when Java 9 bytes codes are scanned. Gary On Sat, Dec 2, 2017 at 1:14 PM, Gary Gregory wrote: > Mark, > > Unless BCEL-295

Re: [VOTE] Release Apache Commons BCEL based on RC1

Mark, Unless BCEL-295 is a regression, I see no technical reason for a -1. What am I missing? Gary On Sat, Dec 2, 2017 at 12:35 PM, Mark Roberts wrote: > I have to vote -1 until 295 is fixed - this will force us to

RE: [VOTE] Release Apache Commons BCEL based on RC1

I have to vote -1 until 295 is fixed - this will force us to have a private version of bcel. https://issues.apache.org/jira/browse/BCEL-295 Mark -Original Message- From: Gary Gregory [mailto:ggreg...@apache.org] Sent: Thursday, November 30, 2017 8:18 PM To: Commons Developers List

Re: [VOTE] Release Apache Commons BCEL based on RC1

+1 from me and a request to the PMC to have a look ;-) Thank you! Gary On Thu, Nov 30, 2017 at 9:17 PM, Gary Gregory wrote: > We fixed a few bugs and added some enhancements since we released Apache > Commons BCEL 6.1, so I would like to release Commons BCEL 6.2. > >