Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-25 Thread Benedikt Ritter
I'm okay with removing the @deprecated tag from the said methods. Maybe we can just add it as Note: to the main JavaDoc, or something like that? 2013/10/25 Matt Benson > Do we want to go with Sebastian's suggestion here, or discuss further? I > wouldn't call the matter resolved, and it does in

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-25 Thread Matt Benson
Do we want to go with Sebastian's suggestion here, or discuss further? I wouldn't call the matter resolved, and it does indeed look a bit irritating to see deprecation warnings in [lang]'s *own* code. Matt On Tue, Oct 22, 2013 at 3:00 PM, sebb wrote: > On 22 October 2013 20:55, Matt Benson w

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-22 Thread sebb
On 22 October 2013 20:55, Matt Benson wrote: > On Tue, Oct 22, 2013 at 2:49 PM, sebb wrote: > >> On 21 October 2013 20:28, Henri Yandell wrote: >> > On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: >> > >> >> On 21 October 2013 11:52, Benedikt Ritter wrote: >> >> > >> >> > >> >> > Send from my mob

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-22 Thread Matt Benson
On Tue, Oct 22, 2013 at 2:49 PM, sebb wrote: > On 21 October 2013 20:28, Henri Yandell wrote: > > On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > > > >> On 21 October 2013 11:52, Benedikt Ritter wrote: > >> > > >> > > >> > Send from my mobile device > >> > > >> >> Am 21.10.2013 um 03:46 schrieb

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-22 Thread sebb
On 21 October 2013 20:28, Henri Yandell wrote: > On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > >> On 21 October 2013 11:52, Benedikt Ritter wrote: >> > >> > >> > Send from my mobile device >> > >> >> Am 21.10.2013 um 03:46 schrieb sebb : >> >> >> >>> On 20 October 2013 15:03, Benedikt Ritter w

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-22 Thread Benedikt Ritter
Well your comment makes sense anyway... 2013/10/21 Henri Yandell > On Mon, Oct 21, 2013 at 12:28 PM, Henri Yandell > wrote: > > > > > > > > > On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > > > >> On 21 October 2013 11:52, Benedikt Ritter wrote: > >> > > >> > > >> > Send from my mobile device

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread Henri Yandell
On Mon, Oct 21, 2013 at 12:28 PM, Henri Yandell wrote: > > > > On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > >> On 21 October 2013 11:52, Benedikt Ritter wrote: >> > >> > >> > Send from my mobile device >> > >> >> Am 21.10.2013 um 03:46 schrieb sebb : >> >> >> >>> On 20 October 2013 15:03, Ben

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread Henri Yandell
On Mon, Oct 21, 2013 at 7:29 AM, sebb wrote: > On 21 October 2013 11:52, Benedikt Ritter wrote: > > > > > > Send from my mobile device > > > >> Am 21.10.2013 um 03:46 schrieb sebb : > >> > >>> On 20 October 2013 15:03, Benedikt Ritter wrote: > >>> I agree. If we don't deprecate it now, and agre

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread sebb
On 21 October 2013 11:52, Benedikt Ritter wrote: > > > Send from my mobile device > >> Am 21.10.2013 um 03:46 schrieb sebb : >> >>> On 20 October 2013 15:03, Benedikt Ritter wrote: >>> I agree. If we don't deprecate it now, and agree to release the next major >>> version targeting Java 7, we woul

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-21 Thread Benedikt Ritter
Send from my mobile device > Am 21.10.2013 um 03:46 schrieb sebb : > >> On 20 October 2013 15:03, Benedikt Ritter wrote: >> I agree. If we don't deprecate it now, and agree to release the next major >> version targeting Java 7, we would remove those methods without ever >> mentioning it before

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-20 Thread sebb
On 20 October 2013 15:03, Benedikt Ritter wrote: > I agree. If we don't deprecate it now, and agree to release the next major > version targeting Java 7, we would remove those methods without ever > mentioning it before. That's not how I see it working. I think the deprecations should be added o

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-20 Thread Benedikt Ritter
I agree. If we don't deprecate it now, and agree to release the next major version targeting Java 7, we would remove those methods without ever mentioning it before. Thanks for adding the suppressions, btw :-) Benedikt 2013/10/19 Henri Yandell > My tuppence: > > Lang 3 targets Java 6, but use

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-19 Thread Henri Yandell
My tuppence: Lang 3 targets Java 6, but users can go upgrade to Java 7. So the deprecated warnings are actionable by changing your code to Java 7. Internal use - would this lead to warnings? As long as it isn't leading to warnings, updating internal is only a best practice and in this case wouldn

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-18 Thread Matt Benson
Perhaps we need some other kind of pre-deprecation convention. Matt On Fri, Oct 18, 2013 at 11:14 AM, sebb wrote: > When adding an @depecrated annotation, please add the version in which > the code was deprecated. > > Also, although the comment provides an alternative method, it's not > actual

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-18 Thread sebb
When adding an @depecrated annotation, please add the version in which the code was deprecated. Also, although the comment provides an alternative method, it's not actually available until Java 7. As Lang currently targets Java 6, that is not helpful to end users. How are they supposed to avoid th

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-14 Thread Benedikt Ritter
Hi Matt, (fired the last one without adding my comment :-) 2013/10/14 Benedikt Ritter > > > > 2013/10/14 Matt Benson > >> Hi Benedikt, see inline: >> >> >> On Mon, Oct 14, 2013 at 1:15 PM, wrote: >> >> > Author: britter >> > Date: Mon Oct 14 18:15:39 2013 >> > New Revision: 1532011 >> > >> >

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-14 Thread Benedikt Ritter
2013/10/14 Matt Benson > Hi Benedikt, see inline: > > > On Mon, Oct 14, 2013 at 1:15 PM, wrote: > > > Author: britter > > Date: Mon Oct 14 18:15:39 2013 > > New Revision: 1532011 > > > > URL: http://svn.apache.org/r1532011 > > Log: > > Deprecate methods that are available in Java 7's java.lang.O

Re: svn commit: r1532011 - in /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3: ArrayUtils.java ObjectUtils.java

2013-10-14 Thread Matt Benson
Hi Benedikt, see inline: On Mon, Oct 14, 2013 at 1:15 PM, wrote: > Author: britter > Date: Mon Oct 14 18:15:39 2013 > New Revision: 1532011 > > URL: http://svn.apache.org/r1532011 > Log: > Deprecate methods that are available in Java 7's java.lang.Objects > > Modified: > > commons/proper/lang/t