Re: [CSV] Should the Builder API be optional?

2013-04-10 Thread Oliver Heger
Am 09.04.2013 08:48, schrieb Benedikt Ritter: 2013/4/8 Emmanuel Bourg Le 08/04/2013 22:39, Gary Gregory a écrit : But that's the price for immutability for some of these objects. Not sure, we already achieved immutability last year without paying this price: http://svn.apache.org/repos/a

[fileupload] - Custom OutputStream and digest on the fly

2013-04-10 Thread Francisco Carriedo Scher
Hello there! Last week I was seeking for an extended funtionalities of the fileupload library, only to find that such functionalities are not available yet ( http://www.mail-archive.com/user@commons.apache.org/msg08530.html). The two extended functionalities are: - calculating the checksum (M

Re: svn commit: r1466591 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java

2013-04-10 Thread Simone Tripodi
just an idea: the `test` prefix on methods signature can be now omitted, since they are already marked with @Test my 0.0002 cents, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Apr 10, 2013 at

Re: svn commit: r1466591 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java

2013-04-10 Thread Benedikt Ritter
Hi Simo, 2013/4/10 Simone Tripodi > just an idea: the `test` prefix on methods signature can be now omitted, > since they are already marked with @Test > Yes, I agree (I liked that in BU2) but CSV still uses the old JUnit 3.x convention of prefixing tests with "test". I'm not sure whether it's

Re: svn commit: r1466591 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java

2013-04-10 Thread Emmanuel Bourg
Le 10/04/2013 23:18, Benedikt Ritter a écrit : > Yes, I agree (I liked that in BU2) but CSV still uses the old JUnit 3.x > convention of prefixing tests with "test". I'm not sure whether it's a good > idea to start mixing this styles. WDYT? I agree. I always preferred the JUnit 3.x style anyway.

Re: [fileupload] - Custom OutputStream and digest on the fly

2013-04-10 Thread Simone Tripodi
Hola Francisco, I'd opt for option #2 - would you be able to submit a patch? TIA, all the best! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Apr 10, 2013 at 10:03 PM, Francisco Carriedo Sche

Re: [CSV] Should the Builder API be optional?

2013-04-10 Thread Benedikt Ritter
2013/4/10 Oliver Heger > Am 09.04.2013 08:48, schrieb Benedikt Ritter: > > 2013/4/8 Emmanuel Bourg >> >> Le 08/04/2013 22:39, Gary Gregory a écrit : >>> >>> But that's the price for immutability for some of these objects. >>> >>> Not sure, we already achieved immutability last year witho

Re: svn commit: r1466591 - /commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java

2013-04-10 Thread Gary Gregory
On Apr 10, 2013, at 17:24, Emmanuel Bourg wrote: > Le 10/04/2013 23:18, Benedikt Ritter a écrit : > >> Yes, I agree (I liked that in BU2) but CSV still uses the old JUnit 3.x >> convention of prefixing tests with "test". I'm not sure whether it's a good >> idea to start mixing this styles. WDYT?