[VOTE] Release JEXL 3.0 based on RC2

2015-12-18 Thread Emmanuel Bourg
Hi all, JEXL 3.0 RC2 is now available for review. Distribution: https://dist.apache.org/repos/dist/dev/commons/jexl/ (r11664) Maven artifacts: https://repository.apache.org/content/repositories/orgapachecommons-1133/org/apache/commons/commons-jexl3/3.0/ Release notes:

Re: [VOTE] Release JEXL 3.0 based on RC2

2015-12-18 Thread Matt Benson
On Fri, Dec 18, 2015 at 10:05 AM, Emmanuel Bourg wrote: > Hi all, > > JEXL 3.0 RC2 is now available for review. > > Distribution: > https://dist.apache.org/repos/dist/dev/commons/jexl/ (r11664) > > Maven artifacts: >

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Romain Manni-Bucau
+1 Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2015-12-17 23:57 GMT+01:00 Matt Benson

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Phil Steitz
It does not look to me like any implementation we have of this interface actually throws raw IAE anywhere. I think maybe it is the javadoc that is wrong. On 12/18/15 4:47 AM, l...@apache.org wrote: > Repository: commons-math > Updated Branches: > refs/heads/master abb205795 -> 5566a21d2 > > >

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Ole Ersoy
On 12/18/2015 04:07 PM, Phil Steitz wrote: On 12/18/15 2:59 PM, Ole Ersoy wrote: I think it makes sense. If the destination array is too small, throw an IAE. Right. That is what the implementations do - it is just a specialized IAE. We decided a while back not to throw "raw" IAE but to

Re: svn commit: r1720859 - in /commons/proper/weaver/trunk: ant/NOTICE.txt modules/NOTICE.txt

2015-12-18 Thread Matt Benson
And yes, I know these copyright years seem odd, but that's what they are on the site and in their Subversion repo. Matt On Fri, Dec 18, 2015 at 5:38 PM, wrote: > Author: mbenson > Date: Fri Dec 18 23:38:26 2015 > New Revision: 1720859 > > URL:

[math] ArithmeticUtils subAndCheck try catch

2015-12-18 Thread Ole Ersoy
The (This is nit picky) ArithmeticUtils subAndCheck uses a message template that is meant for addition. Should it catch and rethrow the exception with a subtraction template? This is how the exception is thrown (Line 470):

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Matt Benson
On Fri, Dec 18, 2015 at 5:31 PM, Phil Steitz wrote: > On 12/18/15 3:38 PM, Matt Benson wrote: >> On Fri, Dec 18, 2015 at 4:33 PM, Phil Steitz wrote: >>> On 12/17/15 3:57 PM, Matt Benson wrote: I would like to release the [weaver] component.

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Phil Steitz
On 12/18/15 3:38 PM, Matt Benson wrote: > On Fri, Dec 18, 2015 at 4:33 PM, Phil Steitz wrote: >> On 12/17/15 3:57 PM, Matt Benson wrote: >>> I would like to release the [weaver] component. >>> >>> Apache Commons Weaver 1.2 RC1 is available for review at: >>>

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Oliver Heger
Hi Matt, Am 18.12.2015 um 22:03 schrieb Matt Benson: > On Fri, Dec 18, 2015 at 2:54 PM, Oliver Heger > wrote: >> Artifacts and site look good, signatures are fine. >> >> However, I was not able to build from source with Java 1.6 and 1.7 on >> Windows 10. This is

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Oliver Heger
Artifacts and site look good, signatures are fine. However, I was not able to build from source with Java 1.6 and 1.7 on Windows 10. This is what I get: [INFO] --- maven-bundle-plugin:2.5.3:manifest (bundle-manifest) @ commons-weaver-maven-plugin --- [ERROR] Manifest

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Matt Benson
On Fri, Dec 18, 2015 at 4:33 PM, Phil Steitz wrote: > On 12/17/15 3:57 PM, Matt Benson wrote: >> I would like to release the [weaver] component. >> >> Apache Commons Weaver 1.2 RC1 is available for review at: >> https://dist.apache.org/repos/dist/dev/commons/weaver/

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Matt Benson
On Fri, Dec 18, 2015 at 3:10 PM, Oliver Heger wrote: > Hi Matt, > > Am 18.12.2015 um 22:03 schrieb Matt Benson: >> On Fri, Dec 18, 2015 at 2:54 PM, Oliver Heger >> wrote: >>> Artifacts and site look good, signatures are fine. >>> >>>

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Matt Benson
On Fri, Dec 18, 2015 at 2:54 PM, Oliver Heger wrote: > Artifacts and site look good, signatures are fine. > > However, I was not able to build from source with Java 1.6 and 1.7 on > Windows 10. This is what I get: > > [INFO] --- maven-bundle-plugin:2.5.3:manifest

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Ole Ersoy
I think it makes sense. If the destination array is too small, throw an IAE. Perhaps the implementations need to be updated. I'm attempting to modularize the linear package ATM so I'll have a closer look. Cheers, - Ole On 12/18/2015 01:31 PM, Phil Steitz wrote: It does not look to me like

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Phil Steitz
On 12/18/15 2:59 PM, Ole Ersoy wrote: > I think it makes sense. If the destination array is too small, > throw an IAE. Right. That is what the implementations do - it is just a specialized IAE. We decided a while back not to throw "raw" IAE but to use things like

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread Phil Steitz
On 12/17/15 3:57 PM, Matt Benson wrote: > I would like to release the [weaver] component. > > Apache Commons Weaver 1.2 RC1 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r11649). > > Maven artifacts are at: >

[math] Arithmetic module

2015-12-18 Thread Ole Ersoy
Hi, I just published an arithmetic module / ArithmeticUtils repackaged. I would love to get some feedback on what you think of the exception design...any improvements...Do you think it could work for CM in general, etc? The exception design strips localization, but it should be very easy to

Re: [VOTE] Release Apache Commons Weaver 1.2 based on RC1

2015-12-18 Thread sebb
On 18 December 2015 at 23:31, Phil Steitz wrote: > On 12/18/15 3:38 PM, Matt Benson wrote: >> On Fri, Dec 18, 2015 at 4:33 PM, Phil Steitz wrote: >>> On 12/17/15 3:57 PM, Matt Benson wrote: I would like to release the [weaver] component.

Re: svn commit: r1720859 - in /commons/proper/weaver/trunk: ant/NOTICE.txt modules/NOTICE.txt

2015-12-18 Thread sebb
-1 But are the NOTICE files actually needed? What does the LICENSE file say? Indeed where are the related LICENSE files? AFAICT from the ASM license: http://asm.ow2.org/asmdex-license.html there is no need to add anything to the NOTICE file, but of course there is a need to provide the