[GitHub] commons-imaging pull request #30: add-tests

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538871 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java --- @@ -1,3 +1,19 @@ +/* --- End diff --

[GitHub] commons-imaging pull request #30: add-tests

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538915 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to

[GitHub] commons-imaging pull request #30: add-tests

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538887 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] commons-imaging pull request #30: add-tests

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538792 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- -0 Looks like it reduces the

[GitHub] commons-imaging pull request #30: add-tests

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538892 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/18#discussion_r131540224 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java --- @@ -248,6 +258,35 @@ public PhotoshopApp13Data

[GitHub] commons-imaging pull request #18: IMAGING-168 installing package with Swedis...

Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/18#discussion_r131540245 --- Diff: src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcRecord.java --- @@ -50,6 +50,10 @@ public IptcRecord(final IptcType iptcType,

Re: [VOTE] Release Apache Commons JCS 2.2 based on RC1

Ah, got it. Thanks -Amey On Sun, Aug 6, 2017, 12:57 AM Romain Manni-Bucau wrote: > 2017-08-05 19:41 GMT+02:00 Amey Jadiye : > > > Correct me if I'm wrong, but I see we have individual jars released for > > each modules. > > > > commons-jcs-jcache >

Re: [VOTE] Release Apache Commons JCS 2.2 based on RC1

+1 (non-binding) On Wed, Aug 2, 2017 at 7:02 PM, Thomas Vandahl wrote: > I would like to release the [jcs] component to resolve some overdue bugs > > Apache Commons JCS 2.2 RC1 is available for review at: > https://dist.apache.org/repos/dist/dev/commons/jcs/ (r20728). > >

Re: [all/travis-ci] Regarding potential Travis-CI solutions

looking at inclination of community I will be closing the PR without expecting merge after a week by 14th August 2017 unless someone see it's useful. Reference will be there in closed PR list on github so if someone need it in future it will be there. Regards, Amey On Fri, Aug 4, 2017, 3:02 AM