Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

Normally I'm against adding dependencies that are not normally used with other libraries. In most projects I use/contribute to, AssertJ is not used. Said that, I learned to appreciate AssertJ after I wrote some code that handled several map objects. Writing tests to assert things about keys &

Re: [LANG] Introduce JUnit 5

Another argument to wait a bit is the lacking JUnit 5 support in Eclipse. JUnit support out of the box was only introduced with the version released this week. Even-though the support seems a bit lacking, as JUnit 5 tests are skipped when you run all tests and the project contains a

Re: [VOTE] Release Apache Commons IO 2.6 based on RC2

Hi Oliver, > Am 14.10.2017 um 21:28 schrieb Oliver Heger : > > Hi Benedikt, > > it seems that the binary artifact does not contain the real classes, but > classes manipulated by Cobertura. commons-io-2.6.jar contains a > cobertura.properties file, and opening a

Re: [text] always use static imports for assertion methods

On Sun, 15 Oct 2017 09:34:04 + (UTC), pascalschumac...@apache.org wrote: Repository: commons-text Updated Branches: refs/heads/master 51645b4f0 -> 8f7d0494d always use static imports for assertion methods Why? Gilles [...]

[VOTE] Release Apache Commons IO 2.6 based on RC3

Hello, we have fixed quite a few bugs and added some nice new features since Apache Commons IO 2.5 was released, so I would like to release Apache Commons IO 2.6 based on RC3. The changes between RC1 and RC2 are: - Worked on the design of the ByteOrderParser class - Fixed IO-546 - Fixed IO-553

Re: [text] always use static imports for assertion methods

Just for consistency. All almost all tests already used static imports, so I adjusted the few that did not. -Pascal Am 15.10.2017 um 11:44 schrieb Gilles: On Sun, 15 Oct 2017 09:34:04 + (UTC), pascalschumac...@apache.org wrote: Repository: commons-text Updated Branches:  

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

Great to know ! (making a note to add it to the backlog at work) Keen to give it a try in some component. ThanksBruno From: Pascal Schumacher To: dev@commons.apache.org Sent: Sunday, 15 October 2017 9:51 PM Subject: Re: commons-collections git commit:

Re: [LANG] Add module-info.java?

Log4J is adding module-info.java now, and its not overly complicated to do here either. The main question seems to be around the maven site plugin, but thats likely to be fixed soon. ie. I'd like to get to the point where all the basic commons projects have module-info.java (because proper

[GitHub] commons-text issue #70: partial automated migration to assertj

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/70 >Cool! Have missed the discussion about introducing this for Text. I like it. These was no discussion yet. I just thought I do a quick prototype with a component after the

Re: [LANG] Introduce JUnit 5

> Am 15.10.2017 um 12:26 schrieb Pascal Schumacher : > > While I'm generally a fan of JUnit 5 it requires Java 8 and lang is still on > Java 7. Right, forgot that. Maybe we can introduce it once we decide to move the build to Java 9. Benedikt > > Am 15.10.2017 um

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

Yes AssertJ works fine with JUnit 5. The JUnit team uses AssertJ assertions (in combination with JUnit 5) for the unit test of JUnit 5. Am 15.10.2017 um 10:39 schrieb Bruno P. Kinoshita: Normally I'm against adding dependencies that are not normally used with other libraries. In most projects

[CANCEL][VOTE] Release Apache Commons IO 2.6 based on RC2

Hello, > Am 14.10.2017 um 14:35 schrieb Benedikt Ritter : > > Hello, > > we have fixed quite a few bugs and added some nice new features since Apache > Commons IO 2.5 was released, so I would like to release Apache Commons IO 2.6 > based on RC2. > > The changes since RC1

Re: [LANG] Add module-info.java?

Okay, let’s get back to topic. I feel that the community want’s to wait some more until at least all maven plugins we use work with Java 9? Regards, Benedikt > Am 15.10.2017 um 01:30 schrieb Matt Sicker : > > Which is mainly because the version of Java in Android is

[LANG] Introduce JUnit 5

Hi, I’d like to update Commons Lang to use JUnit 5. Existing tests will still run on the JUnit 5 vintage engine and we can migrate tests step by step to JUnit 5 style. One nice feature I’d like to use are nested tests. With these we could for example create a nested test class for each method

[GitHub] commons-text pull request #70: partial automated migration to assertj

GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/70 partial automated migration to assertj Migrated using a modified version of

[GitHub] commons-text issue #70: partial automated migration to assertj

Github user britter commented on the issue: https://github.com/apache/commons-text/pull/70 Cool! Have missed the discussion about introducing this for Text. I like it. --- - To unsubscribe, e-mail:

Re: commons-collections git commit: MapUtilsTest: fix order of expected and actual parameter in assertions (closes #32)

As mentioned by Matt, assertj focuses on providing assertions. Readable, fluent assertions and helpful error messages. It's basically as if Hamcrest added a fluent interface (so available assertions are easy to discover) and continued development at full speed after releasing 1.3, adding many

Re: [LANG] Introduce JUnit 5

While I'm generally a fan of JUnit 5 it requires Java 8 and lang is still on Java 7. Am 15.10.2017 um 11:48 schrieb Benedikt Ritter: Hi, I’d like to update Commons Lang to use JUnit 5. Existing tests will still run on the JUnit 5 vintage engine and we can migrate tests step by step to JUnit

[GitHub] commons-text issue #70: partial automated migration to assertj

Github user britter commented on the issue: https://github.com/apache/commons-text/pull/70 Good idea. It's always better to discuss with some acutal code examples at hands. --- - To unsubscribe, e-mail:

[GitHub] commons-text issue #70: partial automated migration to assertj

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/70 [](https://coveralls.io/builds/13722459) Coverage remained the same at 98.238% when pulling

Re: [LANG] Introduce JUnit 5

+1 Bruno From: Benedikt Ritter To: Commons Developers List Sent: Sunday, 15 October 2017 10:48 PM Subject: [LANG] Introduce JUnit 5 Hi, I’d like to update Commons Lang to use JUnit 5. Existing tests will still run on the JUnit 5

Re: [LANG] Add module-info.java?

> Am 15.10.2017 um 12:04 schrieb Stephen Colebourne : > > Log4J is adding module-info.java now, and its not overly complicated > to do here either. The main question seems to be around the maven site > plugin, but thats likely to be fixed soon. ie. I'd like to get to the >

Re: [text] always use static imports for assertion methods

On Sun, 15 Oct 2017 12:22:13 +0200, Pascal Schumacher wrote: Just for consistency. Consistency is fine. ;-) All almost all tests already used static imports, so I adjusted the few that did not. It's the use of "import static" which I was questioning. Gilles -Pascal Am 15.10.2017 um

Re: [text] always use static imports for assertion methods

Assertion classes are just containers for static methods. Using "import static" is the only way in Java to import the individual methods as if the class itself were a package. Also, doing this is pretty common when using the Assert class as all its methods are prefixed with "assert" anyways. On

Re: [CANCEL][VOTE] Release Apache Commons IO 2.6 based on RC2

Jacoco code coverage does runtime instrumentation, so this would not happen with Jacoco profile. Chas > On Oct 15, 2017, at 2:45 AM, Benedikt Ritter wrote: > > Hello, > >> Am 14.10.2017 um 14:35 schrieb Benedikt Ritter : >> >> Hello, >> >> we have

Re: [2/2] [lang] remove unused bcel test dependency

You can use dependency:analyze to find used and undeclared or unused and declared dependencies. Perhaps we should add dependency:analyze-only to release profile of parent pom to make sure dependencies are clean. Chas > On Oct 14, 2017, at 9:56 AM, Gary Gregory wrote:

Re: [VOTE] Release Apache Commons IO 2.6 based on RC3

How do you verify that the class files are not Cobertura tweaked? Can we add that as a step to the wiki and commons build plugin? Gary On Oct 15, 2017 04:22, "Benedikt Ritter" wrote: > Hello, > > we have fixed quite a few bugs and added some nice new features since > Apache

[GitHub] commons-text pull request #71: Apply (relaxed) checkstyle rules to test and ...

GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-text/pull/71 Apply (relaxed) checkstyle rules to test and fix existing violations … …(incomplete) Similar to lang. Not yet finished, there are still around 70 violations left

Re: [VOTE] Release Compress 1.15 based on RC1

With 'mvn package site -Pjacoco' all is well. So +1! Gary On Sat, Oct 14, 2017 at 12:56 PM, Gary Gregory wrote: > Running with: > > Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; > 2017-04-03T13:39:06-06:00) > Maven home:

[GitHub] commons-text issue #71: Apply (relaxed) checkstyle rules to test and fix exi...

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/71 Now complete. If I knew before how much work this would be, I would not have started. --- - To unsubscribe,

Re: [LANG] Add module-info.java?

I should point out - just for reference - that Log4j has a maven module dedicated to Java 9 and only that is built with the Java 9 compiler. Everything else uses Java 7. We also use Java 7 when running the maven site plugin. It complains when it finds Java 9 classes but it doesn’t fail. I

[GitHub] commons-text issue #71: Apply (relaxed) checkstyle rules to test and fix exi...

Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/71 [](https://coveralls.io/builds/1372) Coverage remained the same at 98.238% when pulling

Re: [text] always use static imports for assertion methods

On Sun, 15 Oct 2017 14:45:09 -0500, Matt Sicker wrote: Assertion classes are just containers for static methods. Using "import static" is the only way in Java to import the individual methods as if the class itself were a package. Also, doing this is pretty common when using the Assert class