[GitHub] commons-collections pull request #44: COLLECTIONS-687: Moved some JUnit 3 te...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/44


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #44: COLLECTIONS-687: Moved some JUnit 3 te...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/44


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[parent] cobertura dead, replace with jacoco?

[Gary Gregory]

It seems cobertura has not been updated since 2015 (
https://github.com/cobertura/cobertura/releases) and does not work on Java
> 9:

[INFO]

[INFO] BUILD FAILURE
[INFO]

[INFO] Total time: 05:24 min
[INFO] Finished at: 2018-06-20T14:28:47-06:00
[INFO]

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on
project commons-pool2: failed to get report for
org.codehaus.mojo:cobertura-maven-plugin: Plugin
org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its dependencies
could not be resolved: Could not find artifact com.sun:tools:jar:0 at
specified path C:\Program Files\Java\jdk-9.0.4/../lib/tools.jar -> [Help 1]
[ERROR]

I say we remove it from commons-parent and use Jacoco from now on.

Thoughts?

Gary

Re: [parent] cobertura dead, replace with jacoco?

[Pascal Schumacher]

+1

Am 20.06.2018 um 22:37 schrieb Gary Gregory:

It seems cobertura has not been updated since 2015 (
https://github.com/cobertura/cobertura/releases) and does not work on Java

9:

[INFO]

[INFO] BUILD FAILURE
[INFO]

[INFO] Total time: 05:24 min
[INFO] Finished at: 2018-06-20T14:28:47-06:00
[INFO]

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on
project commons-pool2: failed to get report for
org.codehaus.mojo:cobertura-maven-plugin: Plugin
org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its dependencies
could not be resolved: Could not find artifact com.sun:tools:jar:0 at
specified path C:\Program Files\Java\jdk-9.0.4/../lib/tools.jar -> [Help 1]
[ERROR]

I say we remove it from commons-parent and use Jacoco from now on.

Thoughts?

Gary




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [parent] release?

[Pascal Schumacher]

+1

Am 20.06.2018 um 19:58 schrieb Gary Gregory:

Are we ready?

Gary




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [parent] cobertura dead, replace with jacoco?

[Rob Tompkins]

+1

> On Jun 20, 2018, at 5:00 PM, Pascal Schumacher  
> wrote:
> 
> +1
> 
>> Am 20.06.2018 um 22:37 schrieb Gary Gregory:
>> It seems cobertura has not been updated since 2015 (
>> https://github.com/cobertura/cobertura/releases) and does not work on Java
>>> 9:
>> [INFO]
>> 
>> [INFO] BUILD FAILURE
>> [INFO]
>> 
>> [INFO] Total time: 05:24 min
>> [INFO] Finished at: 2018-06-20T14:28:47-06:00
>> [INFO]
>> 
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on
>> project commons-pool2: failed to get report for
>> org.codehaus.mojo:cobertura-maven-plugin: Plugin
>> org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its dependencies
>> could not be resolved: Could not find artifact com.sun:tools:jar:0 at
>> specified path C:\Program Files\Java\jdk-9.0.4/../lib/tools.jar -> [Help 1]
>> [ERROR]
>> 
>> I say we remove it from commons-parent and use Jacoco from now on.
>> 
>> Thoughts?
>> 
>> Gary
>> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Apache Commons Build Plugin 1.9 Released

[Rob Tompkins]

[Not cross posted to @announce since this is internal to Commons]

Apache Commons has released the Apache Commons Build Plugin 1.9.

The Apache Commons Build Plugin is a Maven Plugin which can be used by
Apache Commons components.

See:
   http://commons.apache.org/commons-build-plugin/ 


VERSION 1.9 - 2018-06-16


Changes since the last release:
1. Fix in src/main/resources/commons-xdoc-templates/readme-md-template.md for 
components that have a major version number in their artifact IDs.
2. Add a goal for creating all items for pre-release. 
3. Fix README.md generation typo: 'JavaDoc' -> 'Javadoc'.
4. Change the Maven goal prefix from "commons" to "commons-build".
5. Add a goal for generating the NOTICE.txt file.
6. Update platform requirement from Java 7 to Java 8.

Cheers,
-Rob

[GitHub] commons-collections pull request #44: Moved some JUnit 3 tests to JUnit 4

[sfuhrm]

GitHub user sfuhrm opened a pull request:

https://github.com/apache/commons-collections/pull/44

Moved some JUnit 3 tests to JUnit 4

This pull request moves many JUnit 3 tests to JUnit 4 nomenclature.
Actually this was the easy part without base class inheritance.

Verified that the tests in master branch and this PR are the same:

`[INFO] Tests run: 24589, Failures: 0, Errors: 0, Skipped: 0
`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sfuhrm/commons-collections JUnit4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-collections/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #44


commit 4702e747323690ecba6bb3a80940b4a2c1aebce1
Author: Stephan Fuhrmann 
Date:   2018-06-20T18:42:02Z

Moved some JUnit 3 tests to JUnit 4




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #44: COLLECTIONS-687: Moved some JUnit 3 tests to ...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-collections/pull/44
  

[![Coverage 
Status](https://coveralls.io/builds/17597721/badge)](https://coveralls.io/builds/17597721)

Coverage decreased (-0.007%) to 87.386% when pulling 
**4702e747323690ecba6bb3a80940b4a2c1aebce1 on sfuhrm:JUnit4** into 
**11eca16f4a8b2e22c7271cae1fe9f23608bfb98e on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [DBCP] PStmtKey with SQL and catalog but not schema.

[Gary Gregory]

On Wed, Jun 20, 2018 at 8:54 AM Gary Gregory  wrote:

> On Wed, Jun 20, 2018 at 6:04 AM Mark Thomas  wrote:
>
>> On 20/06/18 01:43, Gary Gregory wrote:
>> > The PStmtKey class keys off of a SQL statement, catalog but not the
>> schema.
>> >
>> > Since a catalog is usually a collection of schema, shouldn't we use the
>> > schema as part of this key?
>>
>> If only the relationship was that simple. And consistent across vendors.
>>
>> There is a good summary here on SO:
>>
>> https://stackoverflow.com/questions/7942520/relationship-between-catalog-schema-user-and-database-instance
>>
>> > (Java 7 added supported for getSchema() on a Connection.)
>>
>> Assuming that the SO information is correct (I have no reason to think
>> otherwise apart from cynicism) then including the schema in the key
>> makes sense to me.
>>
>
> Tracking here: https://issues.apache.org/jira/browse/DBCP-508
>

This is done; in git master.

Gary


>
> Gary
>
>
>>
>> Mark
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>

[parent] release?

[Gary Gregory]

Are we ready?

Gary

Re: [parent] release?

[Rob Tompkins]

That’s what I was thinking. Anyone else?

> On Jun 20, 2018, at 1:58 PM, Gary Gregory  wrote:
> 
> Are we ready?
> 
> Gary

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #83: (doc) Typo: 'RandomStringBuilder' -> 'RandomStringGe...

[chtompki]

Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/83
  
Looks good to me. Many thanks for the contribution.


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Commons Release Plugin 1.3 Released.

[Rob Tompkins]

[This announcement is only going to the dev list.]

The Apache Commons Release Plugin team is pleased to announce the release of
Apache
Commons Release Plugin 1.3.

The Apache Commons Release Plugin is a collection of Java based Maven mojos for
Apache Commons
Release process. These mojos are intended to be used as a collection of steps to
be strung
together for the purpose of removing the manual steps required to produce an
Apache Commons Release.

Changes in this version include:

NEW FEATURES

o COMMONSSITE-112:  Add a vote.txt file.
o COMMONSSITE-108:  Adding README.html and HEADER.html to staged release

CHANGES
===
o COMMONSSITE-117: Remove md5 signatures from release artifacts.
o COMMONSSITE-113: Put unpacked site in scm dev dist directory for navigating 
purposes.
o Update platform requirement from Java 7 to Java 8.
List of changes:
http://commons.apache.org/commons-release-plugin/changes-report.html 


For complete information on Apache Commons Release Plugin, including
instructions
on how to submit bug reports,
patches, or suggestions for improvement, see the Apache Apache Commons
Release Plugin website:

http://commons.apache.org/commons-release-plugin/index.html 


Cheers,
-Rob

Re: [DBCP] PStmtKey with SQL and catalog but not schema.

[Gary Gregory]

On Wed, Jun 20, 2018 at 6:04 AM Mark Thomas  wrote:

> On 20/06/18 01:43, Gary Gregory wrote:
> > The PStmtKey class keys off of a SQL statement, catalog but not the
> schema.
> >
> > Since a catalog is usually a collection of schema, shouldn't we use the
> > schema as part of this key?
>
> If only the relationship was that simple. And consistent across vendors.
>
> There is a good summary here on SO:
>
> https://stackoverflow.com/questions/7942520/relationship-between-catalog-schema-user-and-database-instance
>
> > (Java 7 added supported for getSchema() on a Connection.)
>
> Assuming that the SO information is correct (I have no reason to think
> otherwise apart from cynicism) then including the schema in the key
> makes sense to me.
>

Tracking here: https://issues.apache.org/jira/browse/DBCP-508

Gary


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[GitHub] commons-text pull request #83: (doc) Typo: 'RandomStringBuilder' -> 'RandomS...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/83


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LAZY][VOTE] Release Apache Commons Build Plugin Maven Mojo 1.9 based on RC1

[Rob Tompkins]

Here’s my +1, recognizing that I had a few typographical errors in the [VOTE] 
email.

> On Jun 16, 2018, at 9:30 AM, Rob Tompkins  wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements since 
> Apache Commons Build Plugin Maven Mojo 1.8 was released, so I would like to 
> release Apache Commons Build Plugin Maven Mojo 1.9.
> 
> Apache Commons Build Plugin Maven Mojo 1.9 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1 
> (svn revision 27505)
> 
> The Git tag commons-commons-build-plugin-1.9-RC1 commit for this RC is fatal: 
> ambiguous argument 'commons-commons-build-plugin-1.9-RC1': unknown revision 
> or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git  [...] -- [...]' which you can browse here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-commons-build-plugin.git;a=tag;h=refs/tags/commons-commons-build-plugin-1.9-RC1
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-build-plugin/1.9/
> 
> These are the Maven artifacts and their hashes in Nexus:
> 
> #Release SHA-1s
> #Sat Jun 16 09:11:04 EDT 2018
> commons-build-plugin-1.9-src-zip.asc=5a3b94769badbcf56f976f121b1872b6afe07575
> commons-build-plugin-1.9-javadoc-jar.asc=27eb5dc44ee7141def03fee9670fc329e78c10b8
> commons-build-plugin-1.9-sources-jar.asc=a19fb8a9ef1ea3c94a31bf0ae118590576a2e4cf
> commons-build-plugin-1.9-src-tar.gz.asc=4d27ee7b7ad8ecbacd43d4c1b16ee83b3a744e75
> commons-build-plugin-1.9-tests-test-jar=c8c09a579b38a3f111e1a3cc0796a4a8d6c64d52
> commons-build-plugin-1.9-jar.asc=4cbd8dd19463f5f0db3fe0eecb51a326f1f9c3c7
> commons-build-plugin-1.9-src-zip=08e1127bad5703193ccc3fcb032f3c4a29f8f433
> commons-build-plugin-1.9-test-sources-jar.asc=45d3be49653fa0056ad1d56d35cc7b361c965642
> commons-build-plugin-1.9-pom.asc=055be6e4c22179876d711c1494c996a58a63a7fa
> commons-build-plugin-1.9-javadoc-javadoc=65159d5db375ee1ae770f59bcb28f3a1404b9abf
> commons-build-plugin-1.9-sources-java-source=e2927627cdeea9e91856398815c1cf0b5c573fed
> commons-build-plugin-1.9-src-tar.gz=dd0ebec94f102226097a4845f1bf2e4b182d6e15
> commons-build-plugin-1.9-tests-jar.asc=c73305ddceec566eb7ecb4c217e84206af55ec1e
> commons-build-plugin-1.9-test-sources-java-source=962efca71894a9989f7381aa66b5278d1b6376de
> 
> #Release SHA-256s
> #Sat Jun 16 09:11:04 EDT 2018
> commons-build-plugin-1.9-src-zip.asc=7ef3e756cedc77307aa9c0a70a7f8fc92fe1405a7973916855325a7c5a4d4fa7
> commons-build-plugin-1.9-javadoc-jar.asc=16a8e5b8c4d7de8abe93f6a841b4942d7d2376cb57cc8484490abd415b2cf4ce
> commons-build-plugin-1.9-sources-jar.asc=4b9c5a3e61d7f6c7e78a89e7040788172e7ccffcd3ffc0fd164e107efe5abc02
> commons-build-plugin-1.9-src-tar.gz.asc=fb7e6945fa69a70fe2c6aa2c60585f17aa3a81a7a63b50a2b5d9a96eb10ff0e5
> commons-build-plugin-1.9-tests-test-jar=b041417ebe6f1e7498bdc99243a7ff40d159efc63916bdb2ce910cc953abf3d2
> commons-build-plugin-1.9-jar.asc=7ca597ba0996dadf8178efd0bd63fb68f789a323d0c799505244d243383edaa0
> commons-build-plugin-1.9-src-zip=87574e860d39e35118f2dcb6ee69d0c17a7e94bd8a02b5f6fc6cc953813efc5d
> commons-build-plugin-1.9-test-sources-jar.asc=f51e252bab4846c827d855adcc729a15add97188c2c5d62a32cb81890983cdea
> commons-build-plugin-1.9-pom.asc=85e8af5432783686ee2271a10c946cf8b5842b103e31597de287382ce3a024bc
> commons-build-plugin-1.9-javadoc-javadoc=a0b713972a0169651e81fd245d98bd7ed85c7a3e096d1074e3834bd3cb831a2c
> commons-build-plugin-1.9-sources-java-source=28e1a1b30eb113ef5b59f21bef30aebb68ee5b40e42e36d262c44c19eef44335
> commons-build-plugin-1.9-src-tar.gz=afc685ac593deea402953618f8f36bcf30e5d1f3d9de7522870d8b0b21058dfd
> commons-build-plugin-1.9-tests-jar.asc=7d5cf75349f8ec16c07891dc4d2c81d4a6934161f99572d01aa955b6aed5e054
> commons-build-plugin-1.9-test-sources-java-source=320d052c41ffc829602365858ffafcf092715ddc7d42f0974b165753a139dc27
> 
> 
> (no need for .asc hashes!)
> 
> I have tested this with 'mvn clean install site' using: 
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 
> 2018-02-24T14:49:05-05:00)
> Maven home: /usr/local/Cellar/maven/3.5.3/libexec
> Java version: 1.8.0_162, vendor: Oracle Corporation
> Java home: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.5", arch: "x86_64", family: "mac"
> 
> Details of changes since 1.8 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1/site
>(note some *relative* links are broken and the 1.9 directories are not yet 
> created - these will be OK once the site is deployed.)

[RESULT][LAZY][VOTE] Release Apache Commons Build Plugin Maven Mojo 1.9 based on RC1

[Rob Tompkins]

This [LAZY][VOTE] passes with a +1 from Gary Gregory, a +1 from myself, and no 
-1’s. I will perform the release promotion duties now.

Many thanks.
-Rob

> On Jun 16, 2018, at 9:30 AM, Rob Tompkins  wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements since 
> Apache Commons Build Plugin Maven Mojo 1.8 was released, so I would like to 
> release Apache Commons Build Plugin Maven Mojo 1.9.
> 
> Apache Commons Build Plugin Maven Mojo 1.9 RC1 is available for review here:
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1 
> (svn revision 27505)
> 
> The Git tag commons-commons-build-plugin-1.9-RC1 commit for this RC is fatal: 
> ambiguous argument 'commons-commons-build-plugin-1.9-RC1': unknown revision 
> or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git  [...] -- [...]' which you can browse here:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-commons-build-plugin.git;a=tag;h=refs/tags/commons-commons-build-plugin-1.9-RC1
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-${commons.nexus.repo.id}/org/apache/commons/commons-build-plugin/1.9/
> 
> These are the Maven artifacts and their hashes in Nexus:
> 
> #Release SHA-1s
> #Sat Jun 16 09:11:04 EDT 2018
> commons-build-plugin-1.9-src-zip.asc=5a3b94769badbcf56f976f121b1872b6afe07575
> commons-build-plugin-1.9-javadoc-jar.asc=27eb5dc44ee7141def03fee9670fc329e78c10b8
> commons-build-plugin-1.9-sources-jar.asc=a19fb8a9ef1ea3c94a31bf0ae118590576a2e4cf
> commons-build-plugin-1.9-src-tar.gz.asc=4d27ee7b7ad8ecbacd43d4c1b16ee83b3a744e75
> commons-build-plugin-1.9-tests-test-jar=c8c09a579b38a3f111e1a3cc0796a4a8d6c64d52
> commons-build-plugin-1.9-jar.asc=4cbd8dd19463f5f0db3fe0eecb51a326f1f9c3c7
> commons-build-plugin-1.9-src-zip=08e1127bad5703193ccc3fcb032f3c4a29f8f433
> commons-build-plugin-1.9-test-sources-jar.asc=45d3be49653fa0056ad1d56d35cc7b361c965642
> commons-build-plugin-1.9-pom.asc=055be6e4c22179876d711c1494c996a58a63a7fa
> commons-build-plugin-1.9-javadoc-javadoc=65159d5db375ee1ae770f59bcb28f3a1404b9abf
> commons-build-plugin-1.9-sources-java-source=e2927627cdeea9e91856398815c1cf0b5c573fed
> commons-build-plugin-1.9-src-tar.gz=dd0ebec94f102226097a4845f1bf2e4b182d6e15
> commons-build-plugin-1.9-tests-jar.asc=c73305ddceec566eb7ecb4c217e84206af55ec1e
> commons-build-plugin-1.9-test-sources-java-source=962efca71894a9989f7381aa66b5278d1b6376de
> 
> #Release SHA-256s
> #Sat Jun 16 09:11:04 EDT 2018
> commons-build-plugin-1.9-src-zip.asc=7ef3e756cedc77307aa9c0a70a7f8fc92fe1405a7973916855325a7c5a4d4fa7
> commons-build-plugin-1.9-javadoc-jar.asc=16a8e5b8c4d7de8abe93f6a841b4942d7d2376cb57cc8484490abd415b2cf4ce
> commons-build-plugin-1.9-sources-jar.asc=4b9c5a3e61d7f6c7e78a89e7040788172e7ccffcd3ffc0fd164e107efe5abc02
> commons-build-plugin-1.9-src-tar.gz.asc=fb7e6945fa69a70fe2c6aa2c60585f17aa3a81a7a63b50a2b5d9a96eb10ff0e5
> commons-build-plugin-1.9-tests-test-jar=b041417ebe6f1e7498bdc99243a7ff40d159efc63916bdb2ce910cc953abf3d2
> commons-build-plugin-1.9-jar.asc=7ca597ba0996dadf8178efd0bd63fb68f789a323d0c799505244d243383edaa0
> commons-build-plugin-1.9-src-zip=87574e860d39e35118f2dcb6ee69d0c17a7e94bd8a02b5f6fc6cc953813efc5d
> commons-build-plugin-1.9-test-sources-jar.asc=f51e252bab4846c827d855adcc729a15add97188c2c5d62a32cb81890983cdea
> commons-build-plugin-1.9-pom.asc=85e8af5432783686ee2271a10c946cf8b5842b103e31597de287382ce3a024bc
> commons-build-plugin-1.9-javadoc-javadoc=a0b713972a0169651e81fd245d98bd7ed85c7a3e096d1074e3834bd3cb831a2c
> commons-build-plugin-1.9-sources-java-source=28e1a1b30eb113ef5b59f21bef30aebb68ee5b40e42e36d262c44c19eef44335
> commons-build-plugin-1.9-src-tar.gz=afc685ac593deea402953618f8f36bcf30e5d1f3d9de7522870d8b0b21058dfd
> commons-build-plugin-1.9-tests-jar.asc=7d5cf75349f8ec16c07891dc4d2c81d4a6934161f99572d01aa955b6aed5e054
> commons-build-plugin-1.9-test-sources-java-source=320d052c41ffc829602365858ffafcf092715ddc7d42f0974b165753a139dc27
> 
> 
> (no need for .asc hashes!)
> 
> I have tested this with 'mvn clean install site' using: 
> Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 
> 2018-02-24T14:49:05-05:00)
> Maven home: /usr/local/Cellar/maven/3.5.3/libexec
> Java version: 1.8.0_162, vendor: Oracle Corporation
> Java home: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_162.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.5", arch: "x86_64", family: "mac"
> 
> Details of changes since 1.8 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/commons-build-plugin/1.9-RC1/site
>(note some *relative* links are broken and the 1.9 directories 

[GitHub] commons-text pull request #83: (doc) Typo: 'RandomStringBuilder' -> 'RandomS...

[josteitv]

GitHub user josteitv opened a pull request:

https://github.com/apache/commons-text/pull/83

(doc) Typo: 'RandomStringBuilder' -> 'RandomStringGenerator'



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/josteitv/commons-text master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit 2151502eea87759211267a3c0732f4a8dae6045a
Author: Jostein Tveit 
Date:   2018-06-20T11:38:02Z

(doc) Typo: 'RandomStringBuilder' -> 'RandomStringGenerator'




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #83: (doc) Typo: 'RandomStringBuilder' -> 'RandomStringGe...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/83
  

[![Coverage 
Status](https://coveralls.io/builds/17589655/badge)](https://coveralls.io/builds/17589655)

Coverage remained the same at 97.833% when pulling 
**2151502eea87759211267a3c0732f4a8dae6045a on josteitv:master** into 
**13627dab88753468c8d7c530f2fa2e68488a1d4f on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [DBCP] PStmtKey with SQL and catalog but not schema.

[Mark Thomas]

On 20/06/18 01:43, Gary Gregory wrote:
> The PStmtKey class keys off of a SQL statement, catalog but not the schema.
> 
> Since a catalog is usually a collection of schema, shouldn't we use the
> schema as part of this key?

If only the relationship was that simple. And consistent across vendors.

There is a good summary here on SO:
https://stackoverflow.com/questions/7942520/relationship-between-catalog-schema-user-and-database-instance

> (Java 7 added supported for getSchema() on a Connection.)

Assuming that the SO information is correct (I have no reason to think
otherwise apart from cynicism) then including the schema in the key
makes sense to me.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org