[GitHub] coveralls edited a comment on issue #20: RNG-70: Add new XoShiRo generators
coveralls edited a comment on issue #20: RNG-70: Add new XoShiRo generators URL: https://github.com/apache/commons-rng/pull/20#issuecomment-463829859 [](https://coveralls.io/builds/21664435) Coverage increased (+0.3%) to 97.861% when pulling **5f329ce70d748abc500f9975a122f25628c5fe1a on aherbert:feature-RNG-70** into **cb9d99d5b78dce706874bf1bf760309d14684873 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons DBCP 2.6.0 based on RC1
I forgot to add that on Java 11, the test setup fails: [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.03 s <<< FAILURE! - in org.apache.commons.dbcp2.managed.TestSynchronizationOrder [ERROR] testInterposedSynchronization(org.apache.commons.dbcp2.managed.TestSynchronizationOrder) Time elapsed: 0.003 s <<< ERROR! java.lang.IllegalArgumentException: javax.sql.XADataSource referenced from a method is not visible from class loader at org.apache.commons.dbcp2.managed.TestSynchronizationOrder.setup(TestSynchronizationOrder.java:299) [ERROR] testSessionSynchronization(org.apache.commons.dbcp2.managed.TestSynchronizationOrder) Time elapsed: 0.001 s <<< ERROR! java.lang.IllegalArgumentException: javax.sql.XADataSource referenced from a method is not visible from class loader at org.apache.commons.dbcp2.managed.TestSynchronizationOrder.setup(TestSynchronizationOrder.java:299) I think we should address that in a subsequent maintenance release. I am interested in pushing out our current batch of fixes out of git master ASAP. Gary On Fri, Feb 15, 2019 at 11:01 AM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons DBCP 2.5.0 was released, so I would like to release > Apache Commons DBCP 2.6.0. > > Apache Commons DBCP 2.6.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1 (svn > revision 32518) > > The Git tag commons-dbcp-2.6.0-RC1 commit for this RC is > 3e7fca08d3585aa7cf70045ee3ed607cbaf04baa which you can browse here: > > https://github.com/apache/commons-dbcp/releases/tag/commons-dbcp-2.6.0-RC1 > > Maven artifacts are here: > > https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.6.0-RC1 > > https://repository.apache.org/content/repositories/orgapachecommons-1425/org/apache/commons/commons-dbcp2/2.6.0/ > > These are the Maven artifacts and their hashes in Nexus: > > #Release SHA-512s > #Fri Feb 15 10:46:39 EST 2019 > > commons-dbcp2-2.6.0-src-tar.gz=edf28b1a7fecaa8149a00f796e1116f72ee502ab24853c623b397ea07fc4c63408f31930e24a9abd43edbdfcd4c17b16559a5ffcba01c954f5161c96eb860f74 > > commons-dbcp2-2.6.0-src-tar.gz.asc=d991126ab89f8b594da690e12cdb5ef05dde4e78f575f35284cc195349d3b438a47c7648d0e3189ff37d1cfdeac48f3d929fd0af46ad146911a25207ab36301b > > commons-dbcp2-2.6.0-tests-test-jar=ee304fd225d3a850c96b88d84195d26fd11370e529b9699b554e38dcef87be1006695bf818cb44ea7cd90e5ac65db59a1e656869e711fb1cd11d95727886d265 > > commons-dbcp2-2.6.0-test-sources-java-source=fe3c9367446ed44e06f2328e890517ad1818bbc6f8a53cbde8410c2d6308937f889bb164a2d76ff90837befcdccdff410a1c4de17e92a05b1a395c79b1f84325 > > commons-dbcp2-2.6.0-bin-tar.gz=3231c0431ed683bd99cb5b24ad6fa18a2693e39a23f22f6d36e30e54ec3b2dd2f7320c98e345577385443d30bf9d6d857e9b768107ba353048cce3651e6f4c9e > > commons-dbcp2-2.6.0-bin-tar.gz.asc=26e7f73436db583d6cdfe8037d5afeb43fdd67c0712bd915806427aa291921b39868614f16fb900a6d7266c541be3eae63bc5f152661fbe3341615a6bffa503e > > commons-dbcp2-2.6.0-javadoc-javadoc=31d7af557c41adfcd6fce58282ae2b5f045f278a5f829ad5661e31c80137f9b32e3eb29a5088c542a5664de882a6de816ed5daa4ebae233fed16d2688f66b016 > > commons-dbcp2-2.6.0-src-zip.asc=98434d9d165a85f4bd7f2cdaaa776204bd274dd919d22e7542ee9b98a84323236f05946e01dcd31c430b3fb028b3c8b30be733d49e4f0bc9324bd27782f3c1e3 > > commons-dbcp2-2.6.0-test-sources-jar.asc=668b378078ea24407a9ccd2e76479bec54db722408276fc343f25df7b3679f84ccf2548b843a57f49a5e73e542d70f1b16306838c18b123a005e0055a5e2f5dc > > commons-dbcp2-2.6.0-src-zip=955514067b4e774e53aecc906d3497f4e966b0abf76d61d2abc600957d42c5151e0c21c660ebc6d86a35ae78e41d710819ba9dbd67bc39b701004239c89c34e8 > > commons-dbcp2-2.6.0-tests-jar.asc=99efeb6ae0c576389270655967484fde298b59a1da62f25e6b308e867cdc9f7ecc0a8281820a7d070776acf3d2be6f7d445bc1a7cd2270883d6a05684c8519f1 > > commons-dbcp2-2.6.0-jar.asc=c88950da16bd1ed5ff6f7eb06eead26dff3fe864f5a4830537d49f61d99afc46491cba5c1af6b09815bbe5b33001f6ccaec0bf9f30d29ea25684aa81f0ae7267 > > commons-dbcp2-2.6.0-sources-java-source=971ff6b43e91d4350d14ec4fbb25da5c4a3e73469fa1834b26c2cdda9b2ddf4037370a73e9b51abed61f4e59f43e0600409082ae85e88f598418249cd5d227e9 > > commons-dbcp2-2.6.0-sources-jar.asc=0f12bab2270e5569ed6260f646f3bd5d830b35d517363578f842232842fa48e62c579f8ae44ef2b7dc82fadb38191c346bf1f4e512358768c23259fca42d96d8 > > commons-dbcp2-2.6.0-bin-zip=d115146bea6026ed26a5944e99448427c31d89a147b85a4fcf6e24fc8c42a26d0afa5b1485a64b67243493f2cb4f183b636ff35f7576757d079d7c18502c1761 > > commons-dbcp2-2.6.0-bin-zip.asc=3ac3e77075134175daaf015d98bcd259a4db8330d0985614f015f5a273c32ef2d12dd673485c73239e8f5b3ce55a7b944cfdcdff599a9b2c5e9ec793c13091cd > > commons-dbcp2-2.6.0-pom.asc=b567be342c4736663f170f00abdaf399ec6020115288710aaa611ebbecfe4d1680b2c5ca48e09e0228b2b9122491e47b52b78858a1c91ac21cdd569444eca3a1 > >
Re: [All, Math, Statistics] MathJax support
Le ven. 15 févr. 2019 à 12:15, Alex Herbert a écrit :
>
>
> On 15/02/2019 02:56, Gilles Sadowski wrote:
> > Le jeu. 14 févr. 2019 à 16:54, Alex Herbert a
> > écrit :
> >> Commons RNG uses MathJax as a script to add support for rendering
> >> equations in the Javadocs.
> >>
> >> This support was originally included using the tag of
> >> the maven-javadoc-plugin. This was valid for 2.x (see [1]).
> >>
> >> Version 3.x (used in the latest commons-parent) changed the tag to
> >> (see [2]).
> >>
> >> I believe the switch to version 3 occurred at commons-parent 43 about 1
> >> year ago [3].
> >>
> >> Any project that uses MathJax should check this setting is up-to-date. I
> >> am not familiar with all the projects but e.g. [Math, Statistics] still
> >> use .
> > Thanks. Don't hesitate to fix them too.
> >
> > Gilles
>
> I have fixed [Math] and verified the local javadocs now have nice
> equations again.
Great. Thanks.
Gilles
>
> I updated [Statistics] but since none of the javadocs currently have
> equations (no presence of "\(" in the .java files) you cannot see it
> working. The local javadocs now include the MathJax script so it will
> work in the future.
>
> Alex
>
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[VOTE] Release Apache Commons DBCP 2.6.0 based on RC1
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.5.0 was released, so I would like to release Apache Commons DBCP 2.6.0. Apache Commons DBCP 2.6.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1 (svn revision 32518) The Git tag commons-dbcp-2.6.0-RC1 commit for this RC is 3e7fca08d3585aa7cf70045ee3ed607cbaf04baa which you can browse here: https://github.com/apache/commons-dbcp/releases/tag/commons-dbcp-2.6.0-RC1 Maven artifacts are here: https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.6.0-RC1 https://repository.apache.org/content/repositories/orgapachecommons-1425/org/apache/commons/commons-dbcp2/2.6.0/ These are the Maven artifacts and their hashes in Nexus: #Release SHA-512s #Fri Feb 15 10:46:39 EST 2019 commons-dbcp2-2.6.0-src-tar.gz=edf28b1a7fecaa8149a00f796e1116f72ee502ab24853c623b397ea07fc4c63408f31930e24a9abd43edbdfcd4c17b16559a5ffcba01c954f5161c96eb860f74 commons-dbcp2-2.6.0-src-tar.gz.asc=d991126ab89f8b594da690e12cdb5ef05dde4e78f575f35284cc195349d3b438a47c7648d0e3189ff37d1cfdeac48f3d929fd0af46ad146911a25207ab36301b commons-dbcp2-2.6.0-tests-test-jar=ee304fd225d3a850c96b88d84195d26fd11370e529b9699b554e38dcef87be1006695bf818cb44ea7cd90e5ac65db59a1e656869e711fb1cd11d95727886d265 commons-dbcp2-2.6.0-test-sources-java-source=fe3c9367446ed44e06f2328e890517ad1818bbc6f8a53cbde8410c2d6308937f889bb164a2d76ff90837befcdccdff410a1c4de17e92a05b1a395c79b1f84325 commons-dbcp2-2.6.0-bin-tar.gz=3231c0431ed683bd99cb5b24ad6fa18a2693e39a23f22f6d36e30e54ec3b2dd2f7320c98e345577385443d30bf9d6d857e9b768107ba353048cce3651e6f4c9e commons-dbcp2-2.6.0-bin-tar.gz.asc=26e7f73436db583d6cdfe8037d5afeb43fdd67c0712bd915806427aa291921b39868614f16fb900a6d7266c541be3eae63bc5f152661fbe3341615a6bffa503e commons-dbcp2-2.6.0-javadoc-javadoc=31d7af557c41adfcd6fce58282ae2b5f045f278a5f829ad5661e31c80137f9b32e3eb29a5088c542a5664de882a6de816ed5daa4ebae233fed16d2688f66b016 commons-dbcp2-2.6.0-src-zip.asc=98434d9d165a85f4bd7f2cdaaa776204bd274dd919d22e7542ee9b98a84323236f05946e01dcd31c430b3fb028b3c8b30be733d49e4f0bc9324bd27782f3c1e3 commons-dbcp2-2.6.0-test-sources-jar.asc=668b378078ea24407a9ccd2e76479bec54db722408276fc343f25df7b3679f84ccf2548b843a57f49a5e73e542d70f1b16306838c18b123a005e0055a5e2f5dc commons-dbcp2-2.6.0-src-zip=955514067b4e774e53aecc906d3497f4e966b0abf76d61d2abc600957d42c5151e0c21c660ebc6d86a35ae78e41d710819ba9dbd67bc39b701004239c89c34e8 commons-dbcp2-2.6.0-tests-jar.asc=99efeb6ae0c576389270655967484fde298b59a1da62f25e6b308e867cdc9f7ecc0a8281820a7d070776acf3d2be6f7d445bc1a7cd2270883d6a05684c8519f1 commons-dbcp2-2.6.0-jar.asc=c88950da16bd1ed5ff6f7eb06eead26dff3fe864f5a4830537d49f61d99afc46491cba5c1af6b09815bbe5b33001f6ccaec0bf9f30d29ea25684aa81f0ae7267 commons-dbcp2-2.6.0-sources-java-source=971ff6b43e91d4350d14ec4fbb25da5c4a3e73469fa1834b26c2cdda9b2ddf4037370a73e9b51abed61f4e59f43e0600409082ae85e88f598418249cd5d227e9 commons-dbcp2-2.6.0-sources-jar.asc=0f12bab2270e5569ed6260f646f3bd5d830b35d517363578f842232842fa48e62c579f8ae44ef2b7dc82fadb38191c346bf1f4e512358768c23259fca42d96d8 commons-dbcp2-2.6.0-bin-zip=d115146bea6026ed26a5944e99448427c31d89a147b85a4fcf6e24fc8c42a26d0afa5b1485a64b67243493f2cb4f183b636ff35f7576757d079d7c18502c1761 commons-dbcp2-2.6.0-bin-zip.asc=3ac3e77075134175daaf015d98bcd259a4db8330d0985614f015f5a273c32ef2d12dd673485c73239e8f5b3ce55a7b944cfdcdff599a9b2c5e9ec793c13091cd commons-dbcp2-2.6.0-pom.asc=b567be342c4736663f170f00abdaf399ec6020115288710aaa611ebbecfe4d1680b2c5ca48e09e0228b2b9122491e47b52b78858a1c91ac21cdd569444eca3a1 commons-dbcp2-2.6.0-javadoc-jar.asc=ac4930c222543406378dd2a83ee58d4b39985b974dfaee5489e2af7d6a3d555be5e6d30a81ed6414235abb1c7031e9981e1164cf5807ac1d7f303421d7017cd8 (no need for .asc hashes!) I have tested this with 'mvn clean install site' using: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 1.8.0_202, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_202\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" and the 'mvn test -Dcommons.jacoco.version=0.8.3' using: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.2 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Details of changes since 2.5.0 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/RELEASE-NOTES.txt https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/site/changes-report.html Site: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1/site (note some *relative* links are broken
Re: [All, Math, Statistics] MathJax support
On 15/02/2019 02:56, Gilles Sadowski wrote:
Le jeu. 14 févr. 2019 à 16:54, Alex Herbert a écrit :
Commons RNG uses MathJax as a script to add support for rendering
equations in the Javadocs.
This support was originally included using the tag of
the maven-javadoc-plugin. This was valid for 2.x (see [1]).
Version 3.x (used in the latest commons-parent) changed the tag to
(see [2]).
I believe the switch to version 3 occurred at commons-parent 43 about 1
year ago [3].
Any project that uses MathJax should check this setting is up-to-date. I
am not familiar with all the projects but e.g. [Math, Statistics] still
use .
Thanks. Don't hesitate to fix them too.
Gilles
I have fixed [Math] and verified the local javadocs now have nice
equations again.
I updated [Statistics] but since none of the javadocs currently have
equations (no presence of "\(" in the .java files) you cannot see it
working. The local javadocs now include the MathJax script so it will
work in the future.
Alex
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[DISCUSS] Change github notifications for all commons sub-projects
Hey all, There was a recent thread ([1]) with a brief discussion about the number of github updates that are currently ending up in the dev@ mailing list. Personally I find that a little too noisy (especially since I get 2 e-mails for repos that I'm subscribed to), and it seems others also don't like it very much. So I'd like to throw out 3 different proposals to see what people think. All 3 are used today by different repos, so this would also be a proposal to make this consistent across all commons projects. (1) Move all github notifications to issues@ (a la commons-lang) (2) Move all github notifications to notifications@ (a la commons-numbers) (3) Move all github notifications to dev@ (a la a bunch of others) Another option would be to create a separate list for these, although that's probably overkill. I know I said I'd open an infra ticket for commons-crypto at least, but not being in the PMC, I'm sure they'd have asked for PMC input. Thanks! [1] https://lists.apache.org/thread.html/d210cf6c008d30d5e0ce105dc5f54dfb1e65c7a8df98a88b509669fc@%3Cdev.commons.apache.org%3E -- Marcelo - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357531
##
File path:
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
##
@@ -294,49 +280,57 @@ static unsigned long pthreads_thread_id(void)
* If using an Intel chipset with RDRAND, the high-performance hardware
* random number generator will be used.
*/
-static ENGINE * openssl_rand_init(void)
+static ENGINE * openssl_rand_init(JNIEnv *env)
{
- locks_setup();
+ if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+locks_setup(env);
+ static void (*dlsym_ENGINE_load_rdrand) (void);
+ dlsym_ENGINE_load_rdrand = do_dlsym(env, openssl, "ENGINE_load_rdrand");
+ dlsym_ENGINE_load_rdrand();
+ }
- dlsym_ENGINE_load_rdrand();
ENGINE *eng = dlsym_ENGINE_by_id("rdrand");
- int ret = -1;
- do {
-if (NULL == eng) {
- break;
-}
+int ret = -1;
+do {
+ if (NULL == eng) {
+break;
+ }
-int rc = dlsym_ENGINE_init(eng);
-if (0 == rc) {
- break;
-}
+ int rc = dlsym_ENGINE_init(eng);
+ if (0 == rc) {
+break;
+ }
-rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
-if (0 == rc) {
- break;
-}
+ rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
+ if (0 == rc) {
+break;
+ }
-ret = 0;
- } while(0);
+ ret = 0;
+} while(0);
- if (ret == -1) {
-openssl_rand_clean(eng, 0);
- }
+if (ret == -1) {
+ openssl_rand_clean(env, eng, 0);
+}
- return eng;
+return eng;
}
-static void openssl_rand_clean(ENGINE *eng, int clean_locks)
+static void openssl_rand_clean(JNIEnv *env, ENGINE *eng, int clean_locks)
{
if (NULL != eng) {
-dlsym_ENGINE_finish(eng);
-dlsym_ENGINE_free(eng);
+ dlsym_ENGINE_finish(eng);
+ dlsym_ENGINE_free(eng);
}
- dlsym_ENGINE_cleanup();
- if (clean_locks) {
-locks_cleanup();
+ if(dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+ static void (*dlsym_ENGINE_cleanup) (void);
Review comment:
nit: indentation in this whole block is wonky
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357843
##
File path:
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
##
@@ -294,49 +280,57 @@ static unsigned long pthreads_thread_id(void)
* If using an Intel chipset with RDRAND, the high-performance hardware
* random number generator will be used.
*/
-static ENGINE * openssl_rand_init(void)
+static ENGINE * openssl_rand_init(JNIEnv *env)
{
- locks_setup();
+ if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+locks_setup(env);
+ static void (*dlsym_ENGINE_load_rdrand) (void);
+ dlsym_ENGINE_load_rdrand = do_dlsym(env, openssl, "ENGINE_load_rdrand");
+ dlsym_ENGINE_load_rdrand();
+ }
- dlsym_ENGINE_load_rdrand();
ENGINE *eng = dlsym_ENGINE_by_id("rdrand");
- int ret = -1;
- do {
-if (NULL == eng) {
- break;
-}
+int ret = -1;
+do {
+ if (NULL == eng) {
+break;
+ }
-int rc = dlsym_ENGINE_init(eng);
-if (0 == rc) {
- break;
-}
+ int rc = dlsym_ENGINE_init(eng);
+ if (0 == rc) {
+break;
+ }
-rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
-if (0 == rc) {
- break;
-}
+ rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
+ if (0 == rc) {
+break;
+ }
-ret = 0;
- } while(0);
+ ret = 0;
+} while(0);
- if (ret == -1) {
-openssl_rand_clean(eng, 0);
- }
+if (ret == -1) {
+ openssl_rand_clean(env, eng, 0);
+}
- return eng;
+return eng;
}
-static void openssl_rand_clean(ENGINE *eng, int clean_locks)
+static void openssl_rand_clean(JNIEnv *env, ENGINE *eng, int clean_locks)
{
if (NULL != eng) {
-dlsym_ENGINE_finish(eng);
-dlsym_ENGINE_free(eng);
+ dlsym_ENGINE_finish(eng);
+ dlsym_ENGINE_free(eng);
}
- dlsym_ENGINE_cleanup();
- if (clean_locks) {
-locks_cleanup();
+ if(dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+ static void (*dlsym_ENGINE_cleanup) (void);
+ dlsym_ENGINE_cleanup = do_dlsym(env, openssl, "ENGINE_cleanup");
Review comment:
I know this probably will never fail, yet it would be nice to have a null
check here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257355590 ## File path: src/main/native/org/apache/commons/crypto/OpenSslInfoNative.c ## @@ -94,30 +76,12 @@ static int load_library(JNIEnv *env) THROW(env, "java/lang/UnsatisfiedLinkError", msg); return 0; } - get_methods(env, openssl); +#ifdef UNIX Review comment: I'm sure we'll want this on Windows too at some point, but right now we need to figure out the Windows build in the first place, so this is ok. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357402
##
File path:
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
##
@@ -294,49 +280,57 @@ static unsigned long pthreads_thread_id(void)
* If using an Intel chipset with RDRAND, the high-performance hardware
* random number generator will be used.
*/
-static ENGINE * openssl_rand_init(void)
+static ENGINE * openssl_rand_init(JNIEnv *env)
{
- locks_setup();
+ if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+locks_setup(env);
+ static void (*dlsym_ENGINE_load_rdrand) (void);
+ dlsym_ENGINE_load_rdrand = do_dlsym(env, openssl, "ENGINE_load_rdrand");
+ dlsym_ENGINE_load_rdrand();
+ }
- dlsym_ENGINE_load_rdrand();
ENGINE *eng = dlsym_ENGINE_by_id("rdrand");
- int ret = -1;
- do {
-if (NULL == eng) {
- break;
-}
+int ret = -1;
+do {
+ if (NULL == eng) {
+break;
+ }
-int rc = dlsym_ENGINE_init(eng);
-if (0 == rc) {
- break;
-}
+ int rc = dlsym_ENGINE_init(eng);
+ if (0 == rc) {
+break;
+ }
-rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
-if (0 == rc) {
- break;
-}
+ rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
+ if (0 == rc) {
+break;
+ }
-ret = 0;
- } while(0);
+ ret = 0;
+} while(0);
- if (ret == -1) {
-openssl_rand_clean(eng, 0);
- }
+if (ret == -1) {
+ openssl_rand_clean(env, eng, 0);
+}
- return eng;
+return eng;
}
-static void openssl_rand_clean(ENGINE *eng, int clean_locks)
+static void openssl_rand_clean(JNIEnv *env, ENGINE *eng, int clean_locks)
{
if (NULL != eng) {
-dlsym_ENGINE_finish(eng);
-dlsym_ENGINE_free(eng);
+ dlsym_ENGINE_finish(eng);
Review comment:
nit: indentation
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257357499
##
File path:
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
##
@@ -294,49 +280,57 @@ static unsigned long pthreads_thread_id(void)
* If using an Intel chipset with RDRAND, the high-performance hardware
* random number generator will be used.
*/
-static ENGINE * openssl_rand_init(void)
+static ENGINE * openssl_rand_init(JNIEnv *env)
{
- locks_setup();
+ if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+locks_setup(env);
+ static void (*dlsym_ENGINE_load_rdrand) (void);
+ dlsym_ENGINE_load_rdrand = do_dlsym(env, openssl, "ENGINE_load_rdrand");
+ dlsym_ENGINE_load_rdrand();
+ }
- dlsym_ENGINE_load_rdrand();
ENGINE *eng = dlsym_ENGINE_by_id("rdrand");
- int ret = -1;
- do {
-if (NULL == eng) {
- break;
-}
+int ret = -1;
+do {
+ if (NULL == eng) {
+break;
+ }
-int rc = dlsym_ENGINE_init(eng);
-if (0 == rc) {
- break;
-}
+ int rc = dlsym_ENGINE_init(eng);
+ if (0 == rc) {
+break;
+ }
-rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
-if (0 == rc) {
- break;
-}
+ rc = dlsym_ENGINE_set_default(eng, ENGINE_METHOD_RAND);
+ if (0 == rc) {
+break;
+ }
-ret = 0;
- } while(0);
+ ret = 0;
+} while(0);
- if (ret == -1) {
-openssl_rand_clean(eng, 0);
- }
+if (ret == -1) {
+ openssl_rand_clean(env, eng, 0);
+}
- return eng;
+return eng;
}
-static void openssl_rand_clean(ENGINE *eng, int clean_locks)
+static void openssl_rand_clean(JNIEnv *env, ENGINE *eng, int clean_locks)
{
if (NULL != eng) {
-dlsym_ENGINE_finish(eng);
-dlsym_ENGINE_free(eng);
+ dlsym_ENGINE_finish(eng);
+ dlsym_ENGINE_free(eng);
}
- dlsym_ENGINE_cleanup();
- if (clean_locks) {
-locks_cleanup();
+ if(dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
Review comment:
nit: space after `if`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257356945
##
File path:
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
##
@@ -294,49 +280,57 @@ static unsigned long pthreads_thread_id(void)
* If using an Intel chipset with RDRAND, the high-performance hardware
* random number generator will be used.
*/
-static ENGINE * openssl_rand_init(void)
+static ENGINE * openssl_rand_init(JNIEnv *env)
{
- locks_setup();
+ if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+locks_setup(env);
+ static void (*dlsym_ENGINE_load_rdrand) (void);
+ dlsym_ENGINE_load_rdrand = do_dlsym(env, openssl, "ENGINE_load_rdrand");
+ dlsym_ENGINE_load_rdrand();
+ }
- dlsym_ENGINE_load_rdrand();
ENGINE *eng = dlsym_ENGINE_by_id("rdrand");
- int ret = -1;
- do {
-if (NULL == eng) {
- break;
-}
+int ret = -1;
Review comment:
nit: mind undoing these changes? Previous indentation was correct.
(Then we can see what's actually changing.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] aremily commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
aremily commented on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-464273910 I think I got all the changes. I finally changed my c file formatter to stop defaulting with tabs. Should have done that a month ago. Please have a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449676652 [](https://coveralls.io/builds/21681193) Coverage decreased (-0.8%) to 72.884% when pulling **49b00e50c8ff7e075d0b42be7ee8c29fd68fbe30 on aremily:openssl_version_1_1_0_support_branch** into **9456415cd185b17782507006013556c306441a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416308
##
File path:
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h
##
@@ -94,11 +94,30 @@ void *do_dlsym(JNIEnv *env, void *handle, const char
*symbol) {
return func_ptr;
}
+static __attribute__ ((unused))
+void *do_version_dlsym(JNIEnv *env, void *handle) {
+ if (!env || !handle) {
+ THROW(env, "java/lang/InternalError", NULL);
+ return NULL;
+ }
+ void *func_ptr = dlsym(handle, "OpenSSL_version_num");
+ if (func_ptr == NULL) {
+ func_ptr = dlsym(handle, "SSLeay");
Review comment:
and here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416282
##
File path:
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h
##
@@ -94,11 +94,30 @@ void *do_dlsym(JNIEnv *env, void *handle, const char
*symbol) {
return func_ptr;
}
+static __attribute__ ((unused))
+void *do_version_dlsym(JNIEnv *env, void *handle) {
+ if (!env || !handle) {
+ THROW(env, "java/lang/InternalError", NULL);
Review comment:
indentation again
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416454
##
File path:
src/main/native/org/apache/commons/crypto/random/OpenSslCryptoRandomNative.c
##
@@ -294,49 +280,57 @@ static unsigned long pthreads_thread_id(void)
* If using an Intel chipset with RDRAND, the high-performance hardware
* random number generator will be used.
*/
-static ENGINE * openssl_rand_init(void)
+static ENGINE * openssl_rand_init(JNIEnv *env)
{
- locks_setup();
+ if (dlsym_OpenSSL_version_num() < VERSION_1_1_X) {
+locks_setup(env);
+ static void (*dlsym_ENGINE_load_rdrand) (void);
Review comment:
again
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416402
##
File path:
src/main/native/org/apache/commons/crypto/org_apache_commons_crypto.h
##
@@ -94,11 +94,30 @@ void *do_dlsym(JNIEnv *env, void *handle, const char
*symbol) {
return func_ptr;
}
+static __attribute__ ((unused))
+void *do_version_dlsym(JNIEnv *env, void *handle) {
+ if (!env || !handle) {
+ THROW(env, "java/lang/InternalError", NULL);
+ return NULL;
+ }
+ void *func_ptr = dlsym(handle, "OpenSSL_version_num");
+ if (func_ptr == NULL) {
+ func_ptr = dlsym(handle, "SSLeay");
+ }
+ return func_ptr;
+}
+
/* A helper macro to dlsym the requisite dynamic symbol and bail-out on error.
*/
#define LOAD_DYNAMIC_SYMBOL(func_ptr, env, handle, symbol) \
if ((func_ptr = do_dlsym(env, handle, symbol)) == NULL) { \
return; \
}
+
+/* A macro to dlsym the appropriate OpenSSL version number function. */
+#define LOAD_OPENSSL_VERSION_FUNCTION(func_ptr, env, handle) \
+if ((func_ptr = do_version_dlsym(env, handle)) == NULL) { \
+ THROW(env, "java/lang/Error", NULL); \
Review comment:
and here; also the body of the macro should be indented a bit (see macro
above)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
vanzin commented on a change in pull request #92: OpenSSL 1.1.0 updates with
backward compatibility for OpenSSL 1.0.2 and 1.0.1
URL: https://github.com/apache/commons-crypto/pull/92#discussion_r257416150
##
File path: src/main/native/org/apache/commons/crypto/cipher/OpenSslNative.c
##
@@ -716,3 +676,50 @@ JNIEXPORT void JNICALL
Java_org_apache_commons_crypto_cipher_OpenSslNative_clean
EVP_CTX_Wrapper *wrapper = CTX_WRAPPER(ctx);
free_context_wrapper(wrapper);
}
+
+static int check_update_max_output_len(EVP_CTX_Wrapper *wrapper, int
input_len, int max_output_len)
+{
+ if (dlsym_EVP_CIPHER_CTX_test_flags(wrapper->ctx, EVP_CIPH_NO_PADDING) ==
EVP_CIPH_NO_PADDING) {
+ if (max_output_len >= input_len) {
Review comment:
Indentation should be 2 spaces, for consistency.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [DISCUSS] Change github notifications for all commons sub-projects
+1 for moving github notifications to issues@ Am 15.02.2019 um 20:02 schrieb Marcelo Vanzin: Hey all, There was a recent thread ([1]) with a brief discussion about the number of github updates that are currently ending up in the dev@ mailing list. Personally I find that a little too noisy (especially since I get 2 e-mails for repos that I'm subscribed to), and it seems others also don't like it very much. So I'd like to throw out 3 different proposals to see what people think. All 3 are used today by different repos, so this would also be a proposal to make this consistent across all commons projects. (1) Move all github notifications to issues@ (a la commons-lang) (2) Move all github notifications to notifications@ (a la commons-numbers) (3) Move all github notifications to dev@ (a la a bunch of others) Another option would be to create a separate list for these, although that's probably overkill. I know I said I'd open an infra ticket for commons-crypto at least, but not being in the PMC, I'm sure they'd have asked for PMC input. Thanks! [1] https://lists.apache.org/thread.html/d210cf6c008d30d5e0ce105dc5f54dfb1e65c7a8df98a88b509669fc@%3Cdev.commons.apache.org%3E - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1
coveralls edited a comment on issue #92: OpenSSL 1.1.0 updates with backward compatibility for OpenSSL 1.0.2 and 1.0.1 URL: https://github.com/apache/commons-crypto/pull/92#issuecomment-449676652 [](https://coveralls.io/builds/21681320) Coverage decreased (-0.8%) to 72.884% when pulling **fa2ffef409905442bbb78af8fdd89e010f56e7b5 on aremily:openssl_version_1_1_0_support_branch** into **9456415cd185b17782507006013556c306441a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on issue #21: Update README.md
kinow commented on issue #21: Update README.md URL: https://github.com/apache/commons-dbcp/pull/21#issuecomment-464277860 Good catch @LichKing-lee ! And sorry for taking so long to look at this PR. There is a release going on, but once it's done, I will try to sort out conflicts and merge it. Thanks! Bruno This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons DBCP 2.6.0 based on RC1
[ x ] +1 Release these artifacts (assuming tests failing on Java10 and Java11 are OK) Built with `mvn clean test install site` on Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-45-generic", arch: "amd64", family: "unix" I believe you mentioned in another e-mail that it was known it would not built against Java 11. Just FWIW, it failed on Java 10 too, but I believe it is also not a blocker? Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache-maven-3.5.4 Java version: 10.0.2, vendor: Oracle Corporation, runtime: /home/kinow/Development/java/jdk-10.0.2 Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.15.0-45-generic", arch: "amd64", family: "unix" [ERROR] Errors: [ERROR] TestSynchronizationOrder.setup:299 » IllegalArgument javax.sql.XADataSource re...[ERROR] TestSynchronizationOrder.setup:299 » IllegalArgument javax.sql.XADataSource re...[INFO] [ERROR] Tests run: 1415, Failures: 0, Errors: 2, Skipped: 4 Minor issues added in checkstyle, pmd, findbugs, and coverage reduced a bit. But no blockers IMO (and I am planning on tackling some of these issues introduced in the last releases in the next days :) Checked signatures of Maven staged artefacts and they look OK. Thanks for RM'ing! Cheers Bruno On Saturday, 16 February 2019, 5:01:58 am NZDT, Gary Gregory wrote: We have fixed quite a few bugs and added some significant enhancements since Apache Commons DBCP 2.5.0 was released, so I would like to release Apache Commons DBCP 2.6.0. Apache Commons DBCP 2.6.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.6.0-RC1 (svn revision 32518) The Git tag commons-dbcp-2.6.0-RC1 commit for this RC is 3e7fca08d3585aa7cf70045ee3ed607cbaf04baa which you can browse here: https://github.com/apache/commons-dbcp/releases/tag/commons-dbcp-2.6.0-RC1 Maven artifacts are here: https://gitbox.apache.org/repos/asf?p=commons-dbcp.git;a=tag;h=refs/tags/commons-dbcp-2.6.0-RC1 https://repository.apache.org/content/repositories/orgapachecommons-1425/org/apache/commons/commons-dbcp2/2.6.0/ These are the Maven artifacts and their hashes in Nexus: #Release SHA-512s #Fri Feb 15 10:46:39 EST 2019 commons-dbcp2-2.6.0-src-tar.gz=edf28b1a7fecaa8149a00f796e1116f72ee502ab24853c623b397ea07fc4c63408f31930e24a9abd43edbdfcd4c17b16559a5ffcba01c954f5161c96eb860f74 commons-dbcp2-2.6.0-src-tar.gz.asc=d991126ab89f8b594da690e12cdb5ef05dde4e78f575f35284cc195349d3b438a47c7648d0e3189ff37d1cfdeac48f3d929fd0af46ad146911a25207ab36301b commons-dbcp2-2.6.0-tests-test-jar=ee304fd225d3a850c96b88d84195d26fd11370e529b9699b554e38dcef87be1006695bf818cb44ea7cd90e5ac65db59a1e656869e711fb1cd11d95727886d265 commons-dbcp2-2.6.0-test-sources-java-source=fe3c9367446ed44e06f2328e890517ad1818bbc6f8a53cbde8410c2d6308937f889bb164a2d76ff90837befcdccdff410a1c4de17e92a05b1a395c79b1f84325 commons-dbcp2-2.6.0-bin-tar.gz=3231c0431ed683bd99cb5b24ad6fa18a2693e39a23f22f6d36e30e54ec3b2dd2f7320c98e345577385443d30bf9d6d857e9b768107ba353048cce3651e6f4c9e commons-dbcp2-2.6.0-bin-tar.gz.asc=26e7f73436db583d6cdfe8037d5afeb43fdd67c0712bd915806427aa291921b39868614f16fb900a6d7266c541be3eae63bc5f152661fbe3341615a6bffa503e commons-dbcp2-2.6.0-javadoc-javadoc=31d7af557c41adfcd6fce58282ae2b5f045f278a5f829ad5661e31c80137f9b32e3eb29a5088c542a5664de882a6de816ed5daa4ebae233fed16d2688f66b016 commons-dbcp2-2.6.0-src-zip.asc=98434d9d165a85f4bd7f2cdaaa776204bd274dd919d22e7542ee9b98a84323236f05946e01dcd31c430b3fb028b3c8b30be733d49e4f0bc9324bd27782f3c1e3 commons-dbcp2-2.6.0-test-sources-jar.asc=668b378078ea24407a9ccd2e76479bec54db722408276fc343f25df7b3679f84ccf2548b843a57f49a5e73e542d70f1b16306838c18b123a005e0055a5e2f5dc commons-dbcp2-2.6.0-src-zip=955514067b4e774e53aecc906d3497f4e966b0abf76d61d2abc600957d42c5151e0c21c660ebc6d86a35ae78e41d710819ba9dbd67bc39b701004239c89c34e8 commons-dbcp2-2.6.0-tests-jar.asc=99efeb6ae0c576389270655967484fde298b59a1da62f25e6b308e867cdc9f7ecc0a8281820a7d070776acf3d2be6f7d445bc1a7cd2270883d6a05684c8519f1 commons-dbcp2-2.6.0-jar.asc=c88950da16bd1ed5ff6f7eb06eead26dff3fe864f5a4830537d49f61d99afc46491cba5c1af6b09815bbe5b33001f6ccaec0bf9f30d29ea25684aa81f0ae7267 commons-dbcp2-2.6.0-sources-java-source=971ff6b43e91d4350d14ec4fbb25da5c4a3e73469fa1834b26c2cdda9b2ddf4037370a73e9b51abed61f4e59f43e0600409082ae85e88f598418249cd5d227e9 commons-dbcp2-2.6.0-sources-jar.asc=0f12bab2270e5569ed6260f646f3bd5d830b35d517363578f842232842fa48e62c579f8ae44ef2b7dc82fadb38191c346bf1f4e512358768c23259fca42d96d8 commons-dbcp2-2.6.0-bin-zip=d115146bea6026ed26a5944e99448427c31d89a147b85a4fcf6e24fc8c42a26d0afa5b1485a64b67243493f2cb4f183b636ff35f7576757d079d7c18502c1761
[GitHub] kinow commented on issue #38: Cleaned up PNG component.
kinow commented on issue #38: Cleaned up PNG component. URL: https://github.com/apache/commons-imaging/pull/38#issuecomment-464302976 Just to let you know I haven't forgotten this pull request. Just busy with other things, but Imaging 1.0 should be out soon, then next step is maintenance and improvements like this one :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on issue #46: travis: add java 10 to build
kinow commented on issue #46: travis: add java 10 to build URL: https://github.com/apache/commons-collections/pull/46#issuecomment-464304240 The change looks OK @grimreaper , though in commons-io, for some reason [we are using openjdk10](https://github.com/apache/commons-io/blob/30f81c47f7ea0e9f743e08e73f48c0cfcfb746ff/.travis.yml#L19), and skipping oracle jdk 10. And it failed due to clirr tests. Maybe if you rebase your changes it will work this time? Cheers Bruno This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on issue #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor
kinow commented on issue #66: Avoid Code Duplication: Reuse Sleep from ThreadMonitor URL: https://github.com/apache/commons-io/pull/66#issuecomment-464305120 Hi @DaGeRe ! Agree that code duplication is bad. But the change could perhaps be changed a little bit to make it easier to accept it in my opinion. In `ThreadMonitor`, when you make it public, it also means that we are telling users that they are free to use this class in their code as well. Instead of it being hidden in the package level (which doesn't necessarily stops them, but discourages and at least raises the question of whether they should use it). But I agree with the remaining changes (except by one incorrect indentation that may raise a checkstyle issue). Would you like to try, perhaps, creating a test class in the same package, but under the test sources? That way you can either wrap or extend the origin `ThreadMonitor` and still remove the duplication in the `sleep` method. Also making it easier for us to maintain the code :-) Cheers Bruno This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow opened a new pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported
kinow opened a new pull request #6: Fix PMD issue of unnecessary fully qualified name for class already imported URL: https://github.com/apache/commons-dbutils/pull/6 Fixes only PMD issue in the project report. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on issue #69: refactor similar test cases
kinow commented on issue #69: refactor similar test cases URL: https://github.com/apache/commons-io/pull/69#issuecomment-464303616 Tests failing in Travis-CI due to Checkstyle issues. Mind having a look @yannickzj ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on issue #65: Performance Enhancement: Call toArray with Zero Array Size
kinow commented on issue #65: Performance Enhancement: Call toArray with Zero Array Size URL: https://github.com/apache/commons-io/pull/65#issuecomment-464305656 Hi @DaGeRe ! I don't know if anything changed in Java 10+, but I think this is a good change, and will mark it as approved. Alas I can't merge it straight away due to the failing Travis-CI builds. I am not certain that they are related to your change, but I suspect they are not (master is broken too, but there are issues in progress working to fix it). Thanks! Bruno This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on a change in pull request #64: Two small tweaks.
kinow commented on a change in pull request #64: Two small tweaks.
URL: https://github.com/apache/commons-io/pull/64#discussion_r257450883
##
File path: src/main/java/org/apache/commons/io/TaggedIOException.java
##
@@ -129,7 +129,7 @@ public Serializable getTag() {
* @return wrapped exception
*/
@Override
-public IOException getCause() {
+public synchronized IOException getCause() {
Review comment:
Interesting! Didn't know `Throwable`'s `getCuase` was `synchronized`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] kinow commented on issue #54: Code cleanup
kinow commented on issue #54: Code cleanup URL: https://github.com/apache/commons-io/pull/54#issuecomment-464307076 Looks good to me! Much more readable! I only would need to consult the documentation (and perhaps other devs) regarding removing exception from public methods. I am not sure if that's OK for (binary) backward compatibility. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
