ok,
here it is: https://gist.github.com/rmannibucau/6128964
btw I have some question and notes about what i saw in proxy2:
1) i didn't fully get the goal of stub module, any pointers?
2) in ProxyFactory methods have this kind of signature
T T createDelegatorProxy( ClassLoader classLoader,
Hi Gary,
2013/8/1 ggreg...@apache.org
Author: ggregory
Date: Thu Aug 1 02:03:33 2013
New Revision: 1509068
URL: http://svn.apache.org/r1509068
Log:
- Add some real world CSV files.
- Add a record API to get column values using an Enum.
- Throw a better exception when a resource is not
Do we want to keep cxf module?
IMO it can be replaced by a monitoring filter (web module)
wdyt?
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn:
Le 01/08/2013 04:03, ggreg...@apache.org a écrit :
- Add some real world CSV files.
Are we allowed to distribute these files?
Emmanuel Bourg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
Le 01/08/2013 01:38, Gary Gregory a écrit :
Thoughts?
You'll always find a weird formats that doesn't fit with the common
model. I don't think we should spend too much time trying to support all
of them.
In this case the header will have to be provided by the developer, and
the first lines
+1
2013/8/1 Romain Manni-Bucau rmannibu...@gmail.com:
Do we want to keep cxf module?
IMO it can be replaced by a monitoring filter (web module)
wdyt?
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog:
On Thu, Aug 1, 2013 at 2:44 AM, Romain Manni-Bucau
rmannibu...@gmail.com wrote:
ok,
here it is: https://gist.github.com/rmannibucau/6128964
Thanks!
1) i didn't fully get the goal of stub module, any pointers?
It provides features very similar to the mocking support in libraries
like
Ok for all excepted last point (i was not clear i think). The ProxyFactory
impl using jdk proxy uses Invocationhandler like the asm implementation so
it would be great to be able to share the handler classes between both impl.
*Romain Manni-Bucau*
*Twitter: @rmannibucau
On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 04:03, ggreg...@apache.org a écrit :
- Add some real world CSV files.
Are we allowed to distribute these files?
I did not see any copyrights, or licenses. I did not text that states you
cannot. I do see
On 1 August 2013 10:56, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 01:38, Gary Gregory a écrit :
Thoughts?
You'll always find a weird formats that doesn't fit with the common
model. I don't think we should spend too much time trying to support all
of them.
+1
In this case the
On 1 August 2013 13:48, Gary Gregory garydgreg...@gmail.com wrote:
On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 04:03, ggreg...@apache.org a écrit :
- Add some real world CSV files.
Are we allowed to distribute these files?
I did not see any
On Thu, Aug 1, 2013 at 8:56 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 13:48, Gary Gregory garydgreg...@gmail.com wrote:
On Thu, Aug 1, 2013 at 5:48 AM, Emmanuel Bourg ebo...@apache.org
wrote:
Le 01/08/2013 04:03, ggreg...@apache.org a écrit :
- Add some real world CSV files.
You mean all the InvocationHandler classes in JdkProxy? I guess we
could break those out into top-level classes, but then you'd have
multiple implementations on your classpath if you made a dependency on
commons-proxy-jdk. We could move those to core I guess.
On Thu, Aug 1, 2013 at 7:49 AM,
Why not just create files that look like these files? Do we have to
use the originals?
On Thu, Aug 1, 2013 at 9:22 AM, Gary Gregory garydgreg...@gmail.com wrote:
On Thu, Aug 1, 2013 at 8:56 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 13:48, Gary Gregory garydgreg...@gmail.com wrote:
+1
jdkproxyfactory can even be hardcoded as a default IMO (without using the
SPI)
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
I would like to note this CSVRecord addition I am planning on:
public Boolean getBoolean(String name) {
public boolean getBooleanPrimitive(String name)
The method listings are at the end of this message.
What I want to note here is that these are conversion methods and that the
record
On Thu, Aug 1, 2013 at 8:51 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 10:56, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 01:38, Gary Gregory a écrit :
Thoughts?
You'll always find a weird formats that doesn't fit with the common
model. I don't think we should spend
On 1 August 2013 14:51, James Carman ja...@carmanconsulting.com wrote:
Why not just create files that look like these files? Do we have to
use the originals?
If it's necessary to read the originals to create the look-alikes,
that seems like cheating to me.
I don't think that's something as a
Hi,
since Emmanuel has hijacked the original thread for discussing legal
issues, I'm bringing this up under a new topic ;-)
Please see my comments below.
Benedikt
-- Forwarded message --
From: Benedikt Ritter brit...@apache.org
Date: 2013/8/1
Subject: Re: svn commit: r1509068 -
But is there some technical reason why it's helpful for ASM proxies to use
InvocationHandler specifically? Why wouldn't they just use Invoker
directly?
Matt
On Thu, Aug 1, 2013 at 8:51 AM, Romain Manni-Bucau rmannibu...@gmail.comwrote:
+1
jdkproxyfactory can even be hardcoded as a default
Are you kidding me? We can't ascertain a file format from some
example file and create a similarly-formatted file in our test
resources which exhibits this format to make sure we handle it? It's
CSV! I can't imagine anyone can claim this is their IP. Do they have
a patent on using CSV in this
Just like the bean mapping I prefer to keep the type conversion out of 1.0.
Emmanuel Bourg
Le 01/08/2013 16:00, Gary Gregory a écrit :
I would like to note this CSVRecord addition I am planning on:
public Boolean getBoolean(String name) {
public boolean getBooleanPrimitive(String
a sed shold almost work but the issue is the same: the code is duplicated,
no? is there invoker elsewhere?
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn:
Le 01/08/2013 16:17, Benedikt Ritter a écrit :
since Emmanuel has hijacked the original thread for discussing legal
issues, I'm bringing this up under a new topic ;-)
Hey I simply started a parallel discussion ;)
+1 for NoSuchElementException
Emmanuel Bourg
Which code are you worried about? The checking for equals/hashcode?
On Thu, Aug 1, 2013 at 10:21 AM, Romain Manni-Bucau
rmannibu...@gmail.com wrote:
a sed shold almost work but the issue is the same: the code is duplicated,
no? is there invoker elsewhere?
*Romain Manni-Bucau*
*Twitter:
On 1 August 2013 15:21, Emmanuel Bourg ebo...@apache.org wrote:
Just like the bean mapping I prefer to keep the type conversion out of 1.0.
+1
It's definitely not essential to the initial release.
I'm not sure it belongs in CSV at all.
Emmanuel Bourg
Le 01/08/2013 16:00, Gary Gregory a
The behavior of proxies is specified by Invokers, ObjectProviders, and
Interceptors. Each ProxyFactory implementation bridges from these
interfaces to the most appropriate mechanism specific to the target
technology. In the case of ASM, I would think that would be direct calls
against the proxy
On 1 August 2013 15:23, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 16:17, Benedikt Ritter a écrit :
since Emmanuel has hijacked the original thread for discussing legal
issues, I'm bringing this up under a new topic ;-)
Hey I simply started a parallel discussion ;)
+1 for
Well for the maintainance it is easier (and not really slower) to use a
little abstraction. InvocationHandler/Inoker is fine. Since JdkProxy uses
the exact same code i throught it could be shared.
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog:
On Thu, Aug 1, 2013 at 10:08 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 14:51, James Carman ja...@carmanconsulting.com wrote:
Why not just create files that look like these files? Do we have to
use the originals?
If it's necessary to read the originals to create the look-alikes,
Does the ASM API require a java.lang.reflect.InvocationHandler?
On Thu, Aug 1, 2013 at 10:41 AM, Romain Manni-Bucau
rmannibu...@gmail.com wrote:
Well for the maintainance it is easier (and not really slower) to use a
little abstraction. InvocationHandler/Inoker is fine. Since JdkProxy uses
the
On Thu, Aug 1, 2013 at 10:35 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 15:23, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 16:17, Benedikt Ritter a écrit :
since Emmanuel has hijacked the original thread for discussing legal
issues, I'm bringing this up under a new topic
Thank you for catching this Sebb.
Gary
On Thu, Aug 1, 2013 at 10:38 AM, s...@apache.org wrote:
Author: sebb
Date: Thu Aug 1 14:38:17 2013
New Revision: 1509260
URL: http://svn.apache.org/r1509260
Log:
Remove doc for non-existent parameter
Modified:
Le 01/08/2013 16:48, Gary Gregory a écrit :
I agree with Sebb. In addition, the whole point is to use 'real world'
files. If we are not allowed this particular file set, then that's too bad.
Alternatively, if the URL is stable the file could be downloaded during
the tests.
Emmanuel Bourg
2013/8/1 Gary Gregory garydgreg...@gmail.com
On Thu, Aug 1, 2013 at 10:35 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 15:23, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 16:17, Benedikt Ritter a écrit :
since Emmanuel has hijacked the original thread for discussing
That's my point; it doesn't.
On Thu, Aug 1, 2013 at 9:49 AM, James Carman ja...@carmanconsulting.comwrote:
Does the ASM API require a java.lang.reflect.InvocationHandler?
On Thu, Aug 1, 2013 at 10:41 AM, Romain Manni-Bucau
rmannibu...@gmail.com wrote:
Well for the maintainance it is
On Thu, Aug 1, 2013 at 10:52 AM, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 16:48, Gary Gregory a écrit :
I agree with Sebb. In addition, the whole point is to use 'real world'
files. If we are not allowed this particular file set, then that's too
bad.
Alternatively, if the
On Thu, Aug 1, 2013 at 10:53 AM, Benedikt Ritter brit...@apache.org wrote:
2013/8/1 Gary Gregory garydgreg...@gmail.com
On Thu, Aug 1, 2013 at 10:35 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 15:23, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 16:17, Benedikt Ritter a
No, but believe me you want a handler (this one or invoker) to maintain the
code and keep it easy.
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn:
On Thu, Aug 1, 2013 at 10:30 AM, sebb seb...@gmail.com wrote:
On 1 August 2013 15:21, Emmanuel Bourg ebo...@apache.org wrote:
Just like the bean mapping I prefer to keep the type conversion out of
1.0.
+1
It's definitely not essential to the initial release.
It's one of those things
hehe, do you have figures?
when JIT did its work reflection is almost free. You can update the asm
proxy factory to handle 3 implementations but it is not worth it IMO
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog:
Build using Java 1.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 98
X-Continuum-Project-Name: Commons Pool
Online report :
Project Maven 2 Build Definition (Java 1.7)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 73
X-Continuum-Project-Name: Commons DBCP
Online report :
Group (shared) Maven 2 Build Definition (Java 1.5)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 97
X-Continuum-Project-Name: Commons Math
Online report :
Online report :
http://vmbuild.apache.org/continuum/buildResult.action?buildId=27212projectId=132
Build statistics:
State: Failed
Previous State: Failed
Started at: Thu 1 Aug 2013 15:52:16 +
Finished at: Thu 1 Aug 2013 15:52:28 +
Total time: 11s
Build Trigger: Schedule
This is rudimentary off the top of my head, but the following code
produces this output:
It took a total of 9.022382 seconds using $Proxy0.
It took a total of 5.528322 seconds using
TestAnnotationTrainer$Foo$$EnhancerByCGLIB$$c462c19e.
It took a total of 5.084160 seconds using
can you add asm and run benchmark 10 times?
*Romain Manni-Bucau*
*Twitter: @rmannibucau https://twitter.com/rmannibucau*
*Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
I agree with Gary. This sounds like a useful feature that doesn't seem to
be to hard to implement. And if he (Gary) has the time to do the necessary
coding, why not?
The only thing I don't like is the getBooleanPrimitive(String) method. I
think it is enough to have a getBoolean(String) that
On Thu, Aug 1, 2013 at 3:45 PM, Benedikt Ritter brit...@apache.org wrote:
I agree with Gary. This sounds like a useful feature that doesn't seem to
be to hard to implement. And if he (Gary) has the time to do the necessary
coding, why not?
The only thing I don't like is the
Le 01/08/2013 21:45, Benedikt Ritter a écrit :
I agree with Gary. This sounds like a useful feature that doesn't seem to
be to hard to implement. And if he (Gary) has the time to do the necessary
coding, why not?
Because you start with getBoolean(), then you add getInt(), getDate(),
getList(),
Le 01/08/2013 23:57, ggreg...@apache.org a écrit :
Add CSVRecord#getInt(String) API and tests.
All of these methods are already implemented in [configuration] with
pretty much all the types you might need (Enums, URLs, colors, emails,
dates, calendars, primitives, arrays, etc). If CSVRecord
On 1 August 2013 15:51, Gary Gregory garydgreg...@gmail.com wrote:
Thank you for catching this Sebb.
Thank Eclipse.
Gary
On Thu, Aug 1, 2013 at 10:38 AM, s...@apache.org wrote:
Author: sebb
Date: Thu Aug 1 14:38:17 2013
New Revision: 1509260
URL: http://svn.apache.org/r1509260
Log:
On 1 August 2013 23:32, Emmanuel Bourg ebo...@apache.org wrote:
Le 01/08/2013 21:45, Benedikt Ritter a écrit :
I agree with Gary. This sounds like a useful feature that doesn't seem to
be to hard to implement. And if he (Gary) has the time to do the necessary
coding, why not?
Because you
On 1 August 2013 22:57, ggreg...@apache.org wrote:
Author: ggregory
Date: Thu Aug 1 21:57:46 2013
New Revision: 1509450
URL: http://svn.apache.org/r1509450
Log:
Add CSVRecord#getInt(String) API and tests.
-1
I think this is out of scope for CSV.
Added:
You are -1ing a code modification, which means this counts as a veto.
Are you sure you want to veto this?
On Thu, Aug 1, 2013 at 7:28 PM, sebb seb...@gmail.com wrote:
On 1 August 2013 22:57, ggreg...@apache.org wrote:
Author: ggregory
Date: Thu Aug 1 21:57:46 2013
New Revision: 1509450
None of these methods document exceptions if the conversion fails (eg, not
an integer). Also, how strict is the conversion? Can x represent boolean
false or is that an exception?
On Aug 1, 2013 9:00 AM, Gary Gregory garydgreg...@gmail.com wrote:
I would like to note this CSVRecord addition I am
On 2 August 2013 00:44, James Carman ja...@carmanconsulting.com wrote:
You are -1ing a code modification, which means this counts as a veto.
Are you sure you want to veto this?
Yes.
We don't have agreement that CSV should include these methods.
On Thu, Aug 1, 2013 at 7:28 PM, sebb
On 1 August 2013 22:54, ggreg...@apache.org wrote:
Author: ggregory
Date: Thu Aug 1 21:54:37 2013
New Revision: 1509449
URL: http://svn.apache.org/r1509449
Log:
Add CSVRecord#getLong(String) API and tests.
-1
We don't have agreement to add these methods.
Added:
On 1 August 2013 22:11, ggreg...@apache.org wrote:
Author: ggregory
Date: Thu Aug 1 21:11:10 2013
New Revision: 1509431
URL: http://svn.apache.org/r1509431
Log:
CSVRecord.get(String) throws IAE if the column is not mapped (does not
exist). This is similar to what JDBC does in ResultSet.
You might want to think of a conversion addon package using Common
BeanUtils. That project is skilled at conversions from String and has
pluggable capability to customize conversion types.
On Aug 1, 2013 6:51 PM, Paul Benedict pbened...@apache.org wrote:
None of these methods document exceptions
On 1 August 2013 17:58, ggreg...@apache.org wrote:
Author: ggregory
Date: Thu Aug 1 16:58:31 2013
New Revision: 1509328
URL: http://svn.apache.org/r1509328
Log:
[LEGAL-175] Distribute sample files from www.ferc.gov for unit tests.
I'm not convinced that the NOTICE should be encumbered
Perhaps it belongs in Commons Lang?
Anything like this that you try to put together is going to blow up
really quickly, by the way (registering new converter types, etc.). I
don't see how having a few little helper methods in CSV is that big of
an issue, personally.
On Thu, Aug 1, 2013 at 7:59
How about we put it to a vote? Would you withdraw your veto if a
majority votes against it?
On Thu, Aug 1, 2013 at 7:55 PM, sebb seb...@gmail.com wrote:
On 2 August 2013 00:44, James Carman ja...@carmanconsulting.com wrote:
You are -1ing a code modification, which means this counts as a veto.
I can see that we should provide a decorator/delegate (CSVRecordWrapper?)
that has these additional methods and defers them to Beanutils. We should
use our other Commons project to accomplish the pluggable and configurable
conversion. Beanutils can be an optional Maven dependency. This doesn't
Okay, totally forgot we had ConvertUtils in BeanUtils. So, since we
have the functionality, especially for Strings, and it's extensible,
we could recommend that in the Javadocs perhaps.
That Converter API is screaming for some generics action!
On Thu, Aug 1, 2013 at 8:23 PM, Paul Benedict
On Thu, Aug 1, 2013 at 8:00 PM, sebb seb...@gmail.com wrote:
On 1 August 2013 17:58, ggreg...@apache.org wrote:
Author: ggregory
Date: Thu Aug 1 16:58:31 2013
New Revision: 1509328
URL: http://svn.apache.org/r1509328
Log:
[LEGAL-175] Distribute sample files from www.ferc.gov for
66 matches
Mail list logo
