Le 05/08/2013 23:59, Gary Gregory a écrit :
Do we want to do anything about this for 1.0? 1.x? Ever?
I'm fine with the IOException, I suggest closing this issue.
Emmanuel Bourg
-
To unsubscribe, e-mail:
Le 05/08/2013 19:34, Gary Gregory a écrit :
Thoughts?
-0, that's not very friendly to people willing to extend [csv].
Emmanuel Bourg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands,
2013/8/6 Emmanuel Bourg ebo...@apache.org
Le 05/08/2013 23:59, Gary Gregory a écrit :
Do we want to do anything about this for 1.0? 1.x? Ever?
I'm fine with the IOException, I suggest closing this issue.
Agreed, but please make sure that Bob Smith is added to the contributors
section of
I think the idea is that it promotes composition instead of
subclassing as the extension pattern.
If I wanted the parser to produce a different kind of record,
Gary
On Aug 6, 2013, at 4:44, Emmanuel Bourg ebo...@apache.org wrote:
Le 05/08/2013 19:34, Gary Gregory a écrit :
Thoughts?
-0,
I am also -0 to this idea in general. Are we talking about literally
making all classes final?
On Tuesday, August 6, 2013, Gary Gregory wrote:
I think the idea is that it promotes composition instead of
subclassing as the extension pattern.
If I wanted the parser to produce a different kind
On Tue, Aug 6, 2013 at 8:43 AM, James Carman ja...@carmanconsulting.comwrote:
I am also -0 to this idea in general. Are we talking about literally
making all classes final?
What is the difference between a class that is literally final and
figuratively final? ;)
Gary
On Tuesday, August
On Tue, Aug 6, 2013 at 8:43 AM, James Carman ja...@carmanconsulting.comwrote:
I am also -0 to this idea in general. Are we talking about literally
making all classes final?
I think there are two points in the +0 camp, if I can call this camp such
that I'd like to outline.
1) Promote
Group (shared) Maven 2 Build Definition (Java 1.5)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 97
X-Continuum-Project-Name: Commons Math
Online report :
I was trying to emphasize all.
On Tuesday, August 6, 2013, Gary Gregory wrote:
On Tue, Aug 6, 2013 at 8:43 AM, James Carman
ja...@carmanconsulting.comjavascript:;
wrote:
I am also -0 to this idea in general. Are we talking about literally
making all classes final?
What is the
Is this an issue then?
-Ajo
On Fri, Aug 2, 2013 at 3:48 PM, Phil Steitz phil.ste...@gmail.com wrote:
On 8/2/13 3:09 PM, Ajo Fod wrote:
The class design of AbstractStorelessStats (Storeless) suggests that it
is
storing data in its parent AbstractUnivariate (Parent) and there are
methods
On Tue, Aug 6, 2013 at 10:19 AM, James Carman ja...@carmanconsulting.comwrote:
I was trying to emphasize all.
Then, yes, except Lexer which is currently subclassed by alternate test
implementations.
Do we still need those subclasses?
Gary
On Tuesday, August 6, 2013, Gary Gregory wrote:
When does this become an issue?
-Ajo
On Sun, Aug 4, 2013 at 9:42 AM, Phil Steitz phil.ste...@gmail.com wrote:
On 8/4/13 7:44 AM, Ajo Fod wrote:
Guys,
What is the use of inverseCumAccuracy when people want to instantiate an
AbstractRealDistribution with a random generator?
2013/8/6 Gary Gregory garydgreg...@gmail.com
On Tue, Aug 6, 2013 at 10:19 AM, James Carman ja...@carmanconsulting.com
wrote:
I was trying to emphasize all.
Then, yes, except Lexer which is currently subclassed by alternate test
implementations.
Do we still need those subclasses?
On 6 August 2013 15:32, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 Gary Gregory garydgreg...@gmail.com
On Tue, Aug 6, 2013 at 10:19 AM, James Carman ja...@carmanconsulting.com
wrote:
I was trying to emphasize all.
Then, yes, except Lexer which is currently subclassed by
On Tue, Aug 6, 2013 at 10:38 AM, sebb seb...@gmail.com wrote:
On 6 August 2013 15:32, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 Gary Gregory garydgreg...@gmail.com
On Tue, Aug 6, 2013 at 10:19 AM, James Carman
ja...@carmanconsulting.com
wrote:
I was trying to emphasize
The class names in [csv] are (pp) means package private, others are public
org.apache.commons.csv.Constants (pp)
org.apache.commons.csv.CSVFormat
org.apache.commons.csv.CSVLexer
org.apache.commons.csv.CSVParser
org.apache.commons.csv.CSVPrinter
org.apache.commons.csv.CSVRecord
On 6 August 2013 15:48, Gary Gregory garydgreg...@gmail.com wrote:
The class names in [csv] are (pp) means package private, others are public
org.apache.commons.csv.Constants (pp)
org.apache.commons.csv.CSVFormat
org.apache.commons.csv.CSVLexer
That is also (pp)
Le 06/08/2013 16:48, Gary Gregory a écrit :
So all of the _public_ types except Quote are prefixed with CSV.
- Should all types be prefixed with CSV?
- Should Quote be renamed to CSVQuote?
I'm fine with 'Quote' as it stands out as an enum. Alternatively it
could be turned into an inner
2013/8/6 sebb seb...@gmail.com
On 6 August 2013 15:48, Gary Gregory garydgreg...@gmail.com wrote:
The class names in [csv] are (pp) means package private, others are
public
org.apache.commons.csv.Constants (pp)
org.apache.commons.csv.CSVFormat
org.apache.commons.csv.CSVLexer
That is
It looks like now all the CSVLexer ivars can be private.
Gary
On Tue, Aug 6, 2013 at 11:44 AM, s...@apache.org wrote:
Author: sebb
Date: Tue Aug 6 15:44:41 2013
New Revision: 1511006
URL: http://svn.apache.org/r1511006
Log:
Merge Lexer with CSVLexer
Removed:
On Tue, Aug 6, 2013 at 6:16 AM, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 Emmanuel Bourg ebo...@apache.org
Le 05/08/2013 23:59, Gary Gregory a écrit :
Do we want to do anything about this for 1.0? 1.x? Ever?
I'm fine with the IOException, I suggest closing this issue.
Roger?
G
On Mon, Aug 5, 2013 at 9:06 PM, sebb seb...@gmail.com wrote:
On 6 August 2013 01:29, Roger L. Whitcomb roger.whitc...@actian.com
wrote:
With the latest code I'm getting build errors related to the format
builder changes:
Tests in error:
We have:
/**
* A special reader decorator which supports more sophisticated access to
the underlying reader object.
* p
* In particular the reader supports a look-ahead option, which allows you
to see the next char returned by
* {@link #read()}.
*
* @version $Id: ExtendedBufferedReader.java
On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 sebb seb...@gmail.com
On 6 August 2013 15:48, Gary Gregory garydgreg...@gmail.com wrote:
The class names in [csv] are (pp) means package private, others are
public
org.apache.commons.csv.Constants
2013/8/6 Gary Gregory garydgreg...@gmail.com
We have:
/**
* A special reader decorator which supports more sophisticated access to
the underlying reader object.
* p
* In particular the reader supports a look-ahead option, which allows you
to see the next char returned by
* {@link
Terrible function name also :)
On Tue, Aug 6, 2013 at 10:28 AM, Ajo Fod ajo@gmail.com wrote:
When does this become an issue?
-Ajo
On Sun, Aug 4, 2013 at 9:42 AM, Phil Steitz phil.ste...@gmail.com wrote:
On 8/4/13 7:44 AM, Ajo Fod wrote:
Guys,
What is the use of
Le 06/08/2013 18:47, Gary Gregory a écrit :
Thoughts?
Well, it's invisible to the end user. Feel free to rename it
YodaBufferedReader if you want :)
Emmanuel Bourg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
mvn clean test worked fine -- sorry for the noise; just old files hanging
around.
~Roger
-Original Message-
From: sebb [mailto:seb...@gmail.com]
Sent: Monday, August 05, 2013 6:07 PM
To: Commons Developers List
Subject: Re: [CSV] Test failures with latest code
On 6 August 2013 01:29,
On Tue, Aug 6, 2013 at 1:00 PM, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 Gary Gregory garydgreg...@gmail.com
We have:
/**
* A special reader decorator which supports more sophisticated access to
the underlying reader object.
* p
* In particular the reader supports a
On Tue, Aug 6, 2013 at 1:00 PM, Emmanuel Bourg ebo...@apache.org wrote:
Le 06/08/2013 18:47, Gary Gregory a écrit :
Thoughts?
Well, it's invisible to the end user. Feel free to rename it
YodaBufferedReader if you want :)
I'll leave it as is for now. Extended reflects its specialized
Send from my mobile device
Am 06.08.2013 um 19:12 schrieb Gary Gregory garydgreg...@gmail.com:
On Tue, Aug 6, 2013 at 1:00 PM, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 Gary Gregory garydgreg...@gmail.com
We have:
/**
* A special reader decorator which supports more
On 8/6/13 10:00 AM, Konstantin Berlin wrote:
Terrible function name also :)
Can you suggest a better name for this parameter? It is meant to
indicate the proscribed accuracy of the inverse cumulative
probability. By function name I assume you are talking about the
name of the constructor
Actually I think by function name he was referring to the unfortunate
English-language sexual innuendo incurred by the abbreviation of the word
cumulative in the method name.
Matt
On Tue, Aug 6, 2013 at 2:27 PM, Phil Steitz phil.ste...@gmail.com wrote:
On 8/6/13 10:00 AM, Konstantin Berlin
I wonder how many were waiting in silence to see if someone else would
speak up for a rename.
On Tue, Aug 6, 2013 at 3:16 PM, Matt Benson gudnabr...@gmail.com wrote:
Actually I think by function name he was referring to the unfortunate
English-language sexual innuendo incurred by the
I am also -0 to this idea in general. Are we talking about literally
making all classes final?
In general I am a big fan of starting out with everything as much
final as possible and control where subclassing is explicitly
intended. Also helps with the API design. Only later make them
My question is if it is like one of those buttons on a calculator that no
one has really ever used.
I've used the random number generator to get repetable paths, and the
parameters, but never the inverseCum. So, how many people need the
parameter at all?
Cheers,
-Ajo
On Tue, Aug 6, 2013 at
On 8/6/13 1:52 PM, Ajo Fod wrote:
My question is if it is like one of those buttons on a calculator that no
one has really ever used.
It is used. I have used it myself. We need to retain it. For
convenience, we can add a constructor that omits it, but allows the
RandomGenerator to be
OK. When does it become something that can be posted as an issue?
-Ajo
On Tue, Aug 6, 2013 at 2:13 PM, Phil Steitz phil.ste...@gmail.com wrote:
On 8/6/13 1:52 PM, Ajo Fod wrote:
My question is if it is like one of those buttons on a calculator that no
one has really ever used.
It is
On 6 August 2013 17:47, Gary Gregory garydgreg...@gmail.com wrote:
On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter brit...@apache.org wrote:
2013/8/6 sebb seb...@gmail.com
On 6 August 2013 15:48, Gary Gregory garydgreg...@gmail.com wrote:
The class names in [csv] are (pp) means package
I think we can be done unless other opinions come in...
G
On Tue, Aug 6, 2013 at 6:57 PM, sebb seb...@gmail.com wrote:
On 6 August 2013 17:47, Gary Gregory garydgreg...@gmail.com wrote:
On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter brit...@apache.org
wrote:
2013/8/6 sebb
Hi,
I am curious when CSV will be released. It is on this page [1] as a released
component and was moved to proper 16 months ago according to svn.
We are looking to make use of it, but it would be much better as a pull from
the Maven repos than as a jar from a nightly build.
I know there is
I quite like the idea of dropping the CSV prefix - the package name is
csv so the CSV prefix is redundant.
But if no-one else is keen, it's not a big deal.
On 7 August 2013 00:19, Gary Gregory garydgreg...@gmail.com wrote:
I think we can be done unless other opinions come in...
G
On Tue,
On Tue, Aug 6, 2013 at 7:31 PM, sebb seb...@gmail.com wrote:
I quite like the idea of dropping the CSV prefix
+1
Gary
- the package name is
csv so the CSV prefix is redundant.
But if no-one else is keen, it's not a big deal.
On 7 August 2013 00:19, Gary Gregory garydgreg...@gmail.com
On Tue, Aug 6, 2013 at 7:23 PM, Dave Fisher dave2w...@comcast.net wrote:
Hi,
I am curious when CSV will be released.
It feels like we are winding down. There are two JIRA issues marked for 1.0
that need more work or be punted for 1.x. I am guessing that within a
month, we could have a 1.0
On 8/6/13 7:27 AM, Ajo Fod wrote:
Is this an issue then?
Best not to top-post. Lets see if we get any other views on how the
setup may be improved. Then when we have consensus that a design
change is warranted and what that change will be, we can open a
ticket to track the work.
Phil
-Ajo
On 8/6/13 3:52 PM, Ajo Fod wrote:
OK. When does it become something that can be posted as an issue?
Fine by me to open an issue to add constructors that omit the
parameter. If people don't like the formal parameter name and
someone cares enough to make a patch changing it, that is fine by me
as
I have now gotten all of the tests to pass after the refactoring I
have been working on, other that this one:
testCheckMinIdleObjectPool(org.apache.commons.pool2.TestPoolUtils)
Time elapsed: 1.012 sec FAILURE!
junit.framework.AssertionFailedError: expected:2 but was:0
at
ok
On Tue, Aug 6, 2013 at 5:17 PM, Phil Steitz phil.ste...@gmail.com wrote:
On 8/6/13 7:27 AM, Ajo Fod wrote:
Is this an issue then?
Best not to top-post. Lets see if we get any other views on how the
setup may be improved. Then when we have consensus that a design
change is warranted
Ignore this. I figured out what was going on. Sorry for the noise.
Phil
On 8/6/13 5:41 PM, Phil Steitz wrote:
I have now gotten all of the tests to pass after the refactoring I
have been working on, other that this one:
testCheckMinIdleObjectPool(org.apache.commons.pool2.TestPoolUtils)
49 matches
Mail list logo
