[ANNOUNCEMENT] Apache Commons BCEL 6.3 Released

2019-01-28 Thread Gary Gregory
The Apache Commons BCEL team is pleased to announce the release of Apache Commons BCEL 6.3! The Byte Code Engineering Library (BCEL) is intended to give users a convenient way to analyze, create, and manipulate compiled .class files. Classes are represented by objects containing all the symbolic

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Maxim Solodovnik
Hello All, I have added japicmp report here: https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html I see no issues here :( On Tue, 29 Jan 2019 at 03:03, Marcelo Vanzin wrote: > On Mon, Jan 28, 2019 at 11:36 AM sebb wrote: > > > Haven't looked at the code, but if

[LANG] Checked Functions PR

2019-01-28 Thread Aleksander Ściborek
I've just created pull request to a set of functions which are wrappers for standard interfaces from java.util.function. The idea behind this is that you can create an instance of a function which throws a checked exception and then using a static

Re: [Numbers] Formatting classes

2019-01-28 Thread Eric Barnhill
Fraction already has a toString() method which should cover VALJO concerns by representing the instance in one specific way. The FractionFormat classes allow for options beyond this such as proper fractions or region-specific versions. It doesn't seem to me like it violates VALJO principles to

Re: Math Sparse Linear Programing -- Math Commons

2019-01-28 Thread Eric Barnhill
It sounds like this is a worthwhile upgrade to the performance of the Simplex solvers. I agree with Gilles that from a design perspective, the class is accomplishing the same task only with an internal modification difference, so if possible it should be set with an argument rather than a whole

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Marcelo Vanzin
On Mon, Jan 28, 2019 at 11:36 AM sebb wrote: > > Haven't looked at the code, but if it's being compiled for java 8, and > > the new methods have a default implementation, then it's fine. clirr > > just complains because it's too old to know about default methods. > > I don't think so. > > I think

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Rob Tompkins
> On Jan 28, 2019, at 2:35 PM, sebb wrote: > > On Mon, 28 Jan 2019 at 19:22, Marcelo Vanzin > wrote: >> >> Haven't looked at the code, but if it's being compiled for java 8, and >> the new methods have a default implementation, then it's fine. clirr >> just complains because it's too old to

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread sebb
On Mon, 28 Jan 2019 at 19:22, Marcelo Vanzin wrote: > > Haven't looked at the code, but if it's being compiled for java 8, and > the new methods have a default implementation, then it's fine. clirr > just complains because it's too old to know about default methods. I don't think so. I think

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Rob Tompkins
Ok good enough. Then I’ll finish up looking at the signatures in a bit. Will be spotty today. I’m flying from Florida back to Virginia. -Rob > On Jan 28, 2019, at 2:22 PM, Marcelo Vanzin > wrote: > > Haven't looked at the code, but if it's being compiled for java 8, and > the new methods

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Marcelo Vanzin
Haven't looked at the code, but if it's being compiled for java 8, and the new methods have a default implementation, then it's fine. clirr just complains because it's too old to know about default methods. On Mon, Jan 28, 2019 at 11:18 AM Rob Tompkins wrote: > > @Marcelo - Many thanks...Yes.

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Pascal Schumacher
Am 28.01.2019 um 20:01 schrieb Rob Tompkins: Before I vote on the the thread, does adding a method to an interface cause BC to break? "Adding a method to an interface does not break compatibility with pre-existing binaries." Source:

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Rob Tompkins
@Marcelo - Many thanks...Yes. That makes sense. Thanks. Seems like this release should be a -1 then because we’re breaking BC without a major version change. Right?? -Rob > On Jan 28, 2019, at 2:07 PM, Marcelo Vanzin > wrote: > > On Mon, Jan 28, 2019 at 11:01 AM Rob Tompkins wrote: >>

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Marcelo Vanzin
On Mon, Jan 28, 2019 at 11:01 AM Rob Tompkins wrote: > Before I vote on the the thread, does adding a method to an interface cause > BC to break? I would think not. All of the clirr errors are merely additions. > Further the JAPICMP report confirms this. Existing classes that implement the

Re: JAPICMP Collections-4.3-RC2 report pdf (Was: Re: [VOTE][RC2] Commons collections 4.3)

2019-01-28 Thread Rob Tompkins
Before I vote on the the thread, does adding a method to an interface cause BC to break? I would think not. All of the clirr errors are merely additions. Further the JAPICMP report confirms this. I’m validating the remainder of the release now, and wanted to ask the above question before

[GitHub] nielsbasjes closed pull request #63: [COLLECTIONS-707] Added PrefixMap - WIP!

2019-01-28 Thread GitBox
nielsbasjes closed pull request #63: [COLLECTIONS-707] Added PrefixMap - WIP! URL: https://github.com/apache/commons-collections/pull/63 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] nielsbasjes commented on issue #63: [COLLECTIONS-707] Added PrefixMap - WIP!

2019-01-28 Thread GitBox
nielsbasjes commented on issue #63: [COLLECTIONS-707] Added PrefixMap - WIP! URL: https://github.com/apache/commons-collections/pull/63#issuecomment-458180957 I released this as a separate project. https://github.com/nielsbasjes/prefixmap

[ANNOUNCEMENT] Apache Commons BCEL 6.3 Released

2019-01-28 Thread Gary Gregory
Apache Commons BCEL Version 6.3 RELEASE NOTES INTRODUCTION: The Apache Commons BCEL team is pleased to announce the release of Apache Commons BCEL 6.3! The Byte Code Engineering Library (BCEL) is intended to give users a convenient way to

Re: [VOTE] Release Apache Commons VFS Distribution 2.3 based on RC1

2019-01-28 Thread Otto Fowler
Builds clean for me, running `mvn clean install` on the downloaded and extracted source. [INFO] [INFO] Reactor Summary for Apache Commons VFS Project 2.3: [INFO] [INFO] Apache Commons VFS Project .

Re: [VOTE] Release Apache Commons VFS Distribution 2.3 based on RC1

2019-01-28 Thread Gary Gregory
Thank you for the review Bruno. All the tests pass for me on Windows 10. There must be something Linux-specific going on here. May you please investigate the failure on your setup? Gary On Sun, Jan 27, 2019 at 11:08 PM Bruno P. Kinoshita wrote: > Hmm, couldn't build it. Tried from the dist

[GitHub] coveralls commented on issue #17: RNG-68: Add private classes for each algorithm

2019-01-28 Thread GitBox
coveralls commented on issue #17: RNG-68: Add private classes for each algorithm URL: https://github.com/apache/commons-rng/pull/17#issuecomment-458083112 [![Coverage Status](https://coveralls.io/builds/21308222/badge)](https://coveralls.io/builds/21308222) Coverage increased

[GitHub] coveralls commented on issue #17: RNG-68: Add private classes for each algorithm

2019-01-28 Thread GitBox
coveralls commented on issue #17: RNG-68: Add private classes for each algorithm URL: https://github.com/apache/commons-rng/pull/17#issuecomment-458083113 [![Coverage Status](https://coveralls.io/builds/21308222/badge)](https://coveralls.io/builds/21308222) Coverage increased

[GitHub] aherbert opened a new pull request #17: RNG-68: Add private classes for each algorithm

2019-01-28 Thread GitBox
aherbert opened a new pull request #17: RNG-68: Add private classes for each algorithm URL: https://github.com/apache/commons-rng/pull/17 I moved the toString() method to the internal class as this holds the reference to the RNG. Note: The rearrangement to private classes is hard

[GitHub] coveralls commented on issue #103: The TreeBuilder constructor does not check the validity of the input String s

2019-01-28 Thread GitBox
coveralls commented on issue #103: The TreeBuilder constructor does not check the validity of the input String s URL: https://github.com/apache/commons-math/pull/103#issuecomment-458036975 [![Coverage

[GitHub] emopers opened a new pull request #103: The TreeBuilder constructor does not check the validity of the input String s

2019-01-28 Thread GitBox
emopers opened a new pull request #103: The TreeBuilder constructor does not check the validity of the input String s URL: https://github.com/apache/commons-math/pull/103 The `TreeBuilder` constructor does not check whether the input string `s` is null before constructing a