RE: Understanding the intent of the test suites and how they fit together

2013-07-04 Thread Smith, Peter
Firstly, thank you for the useful information. There were a couple of questions asked which I address here: >> * There seems no explicit tests for any plugins. Omitted deliberately >> assuming cordova-mobile-spec will work through all this code, or to do? Brian wrote: What plugins do you

Re: Uninstallation of dependency-only plugins

2013-07-04 Thread Ian Clelland
Thanks, Fil, Created CB-4077 to track this. I'll start working on separating those functions. Ian On Thu, Jul 4, 2013 at 7:08 PM, Filip Maj wrote: > File an issue over at issues.cordova.io, tag plugman, and we can go from > there > > On 7/4/13 12:59 PM, "Ian Clelland" wrote: > > >This is the

Re: Uninstallation of dependency-only plugins

2013-07-04 Thread Filip Maj
File an issue over at issues.cordova.io, tag plugman, and we can go from there On 7/4/13 12:59 PM, "Ian Clelland" wrote: >This is the first time I've tried to use the CLI tools with the new 3.0 >project structure, and I've discovered that I can't uninstall a plugin >that >only has dependencies (

Re: Uninstallation of dependency-only plugins

2013-07-04 Thread Filip Maj
*Shrugs* bug, probably. On 7/4/13 12:59 PM, "Ian Clelland" wrote: >This is the first time I've tried to use the CLI tools with the new 3.0 >project structure, and I've discovered that I can't uninstall a plugin >that >only has dependencies (no source files, either JS or native) > >Specifically,

Uninstallation of dependency-only plugins

2013-07-04 Thread Ian Clelland
This is the first time I've tried to use the CLI tools with the new 3.0 project structure, and I've discovered that I can't uninstall a plugin that only has dependencies (no source files, either JS or native) Specifically, I've built a mobilespec app, installing the mobile-spec-dependencies plugin

Re: Success with Cordova CLI and custom plugin

2013-07-04 Thread Filip Maj
A poor man's symlink ;) On 7/4/13 11:08 AM, "Anis KADRI" wrote: >Oh that kinda symlinks :-) > > >On Thu, Jul 4, 2013 at 2:00 PM, Filip Maj wrote: > >> Windows has symlinks, the "Shortcut" stuff. See [1]. >> >> And no, --link throws if you try to use with a URL. See [2]. >> >> [1] >> >>http://n

Re: Success with Cordova CLI and custom plugin

2013-07-04 Thread Anis KADRI
Oh that kinda symlinks :-) On Thu, Jul 4, 2013 at 2:00 PM, Filip Maj wrote: > Windows has symlinks, the "Shortcut" stuff. See [1]. > > And no, --link throws if you try to use with a URL. See [2]. > > [1] > http://nodejs.org/docs/v0.10.0/api/fs.html#fs_fs_symlink_srcpath_dstpath_ty > pe_callback

Re: Success with Cordova CLI and custom plugin

2013-07-04 Thread Filip Maj
Windows has symlinks, the "Shortcut" stuff. See [1]. And no, --link throws if you try to use with a URL. See [2]. [1] http://nodejs.org/docs/v0.10.0/api/fs.html#fs_fs_symlink_srcpath_dstpath_ty pe_callback [2] https://github.com/apache/cordova-plugman/blob/master/src/fetch.js#L21 On 7/4/13 10:5

Re: Success with Cordova CLI and custom plugin

2013-07-04 Thread Anis KADRI
does --link work for URLs ? Also bad idea because no symlinks on Windoz. On Thu, Jul 4, 2013 at 1:40 PM, Michal Mocny wrote: > Either way, I now think real symlinking is a bad idea. We currently must > keep a copy of the files as they existed at "fetch" time so that we can use > them for upgr

Re: Success with Cordova CLI and custom plugin

2013-07-04 Thread Michal Mocny
Either way, I now think real symlinking is a bad idea. We currently must keep a copy of the files as they existed at "fetch" time so that we can use them for upgrade/uninstall. Symlinks break that. Conceptually, we already have "links" in that we remember the original source locations, and we co

Re: Understanding the intent of the test suites and how they fit together

2013-07-04 Thread Joe Bowser
On Thu, Jul 4, 2013 at 9:20 AM, Andrew Grieve wrote: > Comments inline. As are mine. > On Thu, Jul 4, 2013 at 3:27 AM, Smith, Peter > wrote: > >> Hi devs, >> >> >> >> I would like to understand better about the actual intent of the various >> cordova test suites for v2.x. So, this is for 2.x,

Re: Success with Cordova CLI and custom plugin

2013-07-04 Thread Filip Maj
The --link options actually exists in plugman, but it is only an option for the `fetch` command. All it does is copy the plugin code from to a plugins directory. With --link, instead it will symlink. It does not actually create symlinks for native or web plugin code. Would that even work, I wonde

Re: CLI's master2

2013-07-04 Thread Michal Mocny
(small correction, next was actually called future). Also, I don't see any work being done on master. On Thu, Jul 4, 2013 at 1:18 PM, Michal Mocny wrote: > If master is in use, then I think that is a mistake. > > As far as I'm aware, master branch should be "dead" right? We had a > 'next' bra

Re: CLI's master2

2013-07-04 Thread Filip Maj
Master is ---> NOT <--- in use Master is basically where the cli code went into about 2 months ago, then stopped due to merge and other weird stuff that happened. master2 is our current correct snapshot of code for the cli. On 7/4/13 10:18 AM, "Michal Mocny" wrote: >If master is in use, then I

Re: CLI's master2

2013-07-04 Thread Michal Mocny
If master is in use, then I think that is a mistake. As far as I'm aware, master branch should be "dead" right? We had a 'next' branch that was for 3.0 work which diverged from master and the merge back was not clean (for various reasons), hence we "temporarily" went with a master2 until we could

Re: Understanding the intent of the test suites and how they fit together

2013-07-04 Thread Brian LeRoux
More comments inline. >> * Specifically, the plugin coverage is not tested much in this suite. I >> am guessing it is assumed that plugins are covered by >> cordova-mobile-spec? >> > > Correct! Even more: In 3.0, what plugin tests that do exists here will be > removed. To expand on this further,

Re: CLI's master2

2013-07-04 Thread Brian LeRoux
So, what is the difference between master and master2? Right now, master from what I understand is in heavy use w/ tonnes of bugs and fixes. On Thu, Jul 4, 2013 at 9:52 AM, Ian Clelland wrote: > We've had that ticket open for some time now, and Braden has tried on a > couple of occasions to get s

Re: CLI's master2

2013-07-04 Thread Ian Clelland
We've had that ticket open for some time now, and Braden has tried on a couple of occasions to get some movement on it, but there's been no action so far. On Thu, Jul 4, 2013 at 12:34 PM, Filip Maj wrote: > If you want to give it a shot, go for it! > > Didn't we have an INFRA issue filed for th

Re: opening iframe links in system browser and iOS platform

2013-07-04 Thread Filip Maj
Hi Jean, I'd file an issue about this over at issues.cordova.io. Thanks, Fil On 7/4/13 6:55 AM, "Jean Laurent Perpina" wrote: >Hi devs, >I have an app running in cordova 2.9, an sencha touch 2.1.0 and i have >iframes in it. When i click on a link in the iframe, it opens a new >inAppBrowser win

Re: CLI's master2

2013-07-04 Thread Filip Maj
If you want to give it a shot, go for it! Didn't we have an INFRA issue filed for them to move the master HEAD pointer to master2 and fix this for us? :P On 7/4/13 9:23 AM, "Andrew Grieve" wrote: >I feel that having master2 around is now causing us more harm than would >be >done if we just merg

CLI's master2

2013-07-04 Thread Andrew Grieve
I feel that having master2 around is now causing us more harm than would be done if we just merged it into master. I'd like to merge it into master, delete master2, and move on.

Re: Understanding the intent of the test suites and how they fit together

2013-07-04 Thread Andrew Grieve
Comments inline. On Thu, Jul 4, 2013 at 3:27 AM, Smith, Peter wrote: > Hi devs, > > > > I would like to understand better about the actual intent of the various > cordova test suites for v2.x. > > > > (This question was already asked to PhoneGap Forum last week but got not > replies) > > > > Fro

opening iframe links in system browser and iOS platform

2013-07-04 Thread Jean Laurent Perpina
Hi devs, I have an app running in cordova 2.9, an sencha touch 2.1.0 and i have iframes in it. When i click on a link in the iframe, it opens a new inAppBrowser window without the location bar and close button so i can't return to my app. How can i change the inAppBrowser behaviour to manage

Understanding the intent of the test suites and how they fit together

2013-07-04 Thread Smith, Peter
Hi devs, I would like to understand better about the actual intent of the various cordova test suites for v2.x. (This question was already asked to PhoneGap Forum last week but got not replies) >From what I can work out, the testing of cordova (for Android) is shared between a number of