Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-49488330
Thanks Suraj!
I am a little worried about the impact on several outstanding
pull-requests. This is a pretty big change, and will definitely cause merge
And I just got reminded that I haven't introduced myself before on this mailing
list. I'm Suraj and am working for the PhoneGap/Cordova team at Adobe for the
summer. Also, here is a link to the pull request.
https://github.com/apache/cordova-lib/pull/62
Suraj.
On Friday, July 18, 2014 3:12
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/100#issuecomment-49486359
Created [CB-7169](https://issues.apache.org/jira/browse/CB-7169)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Hi everyone,
I have spent the last few weeks working with Anis on cordova-lib and trying to
split up the src into smaller submodules based on functionality. I just
submitted a pull request with my changes. It looks like a lot, but all I have
done is rearrange the files, grouping files that go
GitHub user surajpindoria opened a pull request:
https://github.com/apache/cordova-lib/pull/62
Breaking src into submodules
Split up src/cordova and src/plugman into submodules based on functionality
You can merge this pull request into a Git repository by running:
$ git pull h
Echoing what Jesse said - having a prompt will defeat tools,
especially since early on we kinda had consensus not to add in a
security layer.
The middle way is to add a CLI option to "auto-accept" all prompts
with Y, kinda like a lot of command line tools. I think there is this
pattern in Windows c
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/21
CB-6963 Port Media manual & automated tests for plugin-test-framework
Ported 17 Media automated & manual tests from mobilespec.
This commit adds the work done by javierbb31
What do you mean with "blank splash"? Splash without src?
If yes then I consider this illegal anyway.
I tested these cases on Android:
- no splash in config.xml
- one default splash. No density.
- all densities that exist in project.
- one density (xhdpi)
All worked.
Axel
PS: I am traveling and
Prompting would make it nearly impossible for third party tools to use,
there is no one to accept.
PGBuild will allow scripts, but they will only be for pre-verified plugins,
just like they deal with compiling arbitrary native code ... the
script-exec is NOT a new backdoor in this case, just anothe
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15133006
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -97,6 +101,9 @@ try {
} else {
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15132995
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -81,9 +81,13 @@ try {
keystorepass = session.getKeyStorePa
What about prompting during plugin install instead of prepare? "This
plugin has hooks, would you like continue? Y/N"
I'm concerned about being prompted on each prepare, especially in the face
of --watch type scripts. I'm also not sure that plugin authors should
worry about supporting the "no" us
Github user VVelda commented on the pull request:
https://github.com/apache/cordova-lib/pull/58#issuecomment-49475950
Now it works good with icons. But I have one question, you plain that your
changes removes splashcreen from project, if in config.xml is blank
tag, don't you?
But
Finally got to having a look. Lots of neat stuff in there! Some specific
feedback:
- Not a fan of "
Github user dylin commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15130863
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -81,10 +74,16 @@ try {
keystorepass = session.getKeyStorePass(co
Github user dylin commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15130287
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -81,10 +74,16 @@ try {
keystorepass = session.getKeyStorePass(co
Github user SSRico closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user javierbb31 closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/22
CB-6959 ported capture tests to plugin-test-framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-
Github user javierbb31 closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
I didn't.
I guess we also need to provide the INFRA people with some short
instructions on how to enable this on the AppVeyor site.
On Fri, Jul 18, 2014 at 2:48 PM, Jesse wrote:
> awesome!
> Has anyone created an INFRA ticket for adding the github service hooks?
>
> @purplecabbage
> risingj.com
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/33
CB-7148 Ported contacts tests to plugin-test-framework
Removed js-module from plugin.xml and added manual tests. Can someone
please merge this into cdvtest and then merge cdvtest into
awesome!
Has anyone created an INFRA ticket for adding the github service hooks?
@purplecabbage
risingj.com
On Fri, Jul 18, 2014 at 11:36 AM, Mark Koudritsky wrote:
> The test failure on Travis is in plugman/install spec. It seems to only
> happen with a fresh checkout, once you run the test s
The test failure on Travis is in plugman/install spec. It seems to only
happen with a fresh checkout, once you run the test second time, it works
ok. I was bitten by this before. Maybe something with bad management of
temp dirs. I'll investigate.
For now just removing that spec file "fixes" the bu
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/19
CB-7146 ported geolocation tests to plugin-test-framework
Added manual tests and removed js-module from plugin.xml. Can someone
please merge this into cdvtest and then merge cdvtes
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/23
CB-6965 ported notification tests to plugin-test-framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-d
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/14
CB-6964 port network-information tests to plugin-test-framework
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic
You're more than welcome to submit a patch, since you clearly know
what the problem is.
On Fri, Jul 18, 2014 at 10:30 AM, Jan Velecký wrote:
>
>
>
> Your effort to make Android Cordova looks without bug...
>
>
> Cannon reproduce, not a problem, won't fix...
>
> ---
Your effort to make Android Cordova looks without bug...
Cannon reproduce, not a problem, won't fix...
-
What makes you think I'm interested in this bug?
On Fri, Jul 18, 2014 at 9:52 AM, Jan Velecký wrote:
>From when is Android emulator Sony dev
It would be great if someone with a Gingerbread device could run the
cdvtests for my pull request. [1]
On BB10 Blobs are BlobConstructor objects. With the previous check, the
test failed as unsupported even though it does pass when allowed to run [2]
I'd feel better knowing this still works corre
What makes you think I'm interested in this bug?
On Fri, Jul 18, 2014 at 9:52 AM, Jan Velecký wrote:
> From when is Android emulator Sony device?!?
>
> You downplay every bug, you are interested in...
>
> -
>
>
>
> So, you only tested on Sony de
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/63
[BlackBerry10] Add file system paths & fix tests
cc @jengee @jsoref
1f21e3b3 should be tested on Android 2.3 before merging
You can merge this pull request into a Git repo
>From when is Android emulator Sony device?!?
You downplay every bug, you are interested in...
-
So, you only tested on Sony devices.
That's a way smaller percentage than even ICS. Last time I checked, it was
around 1%. You should test on
So, you only tested on Sony devices.
That's a way smaller percentage than even ICS. Last time I checked, it was
around 1%. You should test on more than one manufacturer's device. While
you may not like Samsung, the fact is that they are ridiculously common
devices and should be tested before othe
Okay, okay, I just have done more testing. It occurs on Xperia X10 mini pro
running Android 2.3 and Xperia mini pro running 4.0 (both better devices
than Samsung and HTC you mentioned). But it don't relate with fact, that
these are qwerty devices – I tested it alson on emulators and 4.0 emula
Did this discussion concluded? What was the conclusion?
I would like to see Ripple to have a healthy future and if having it as a
sub-project on Cordova ensures it, I would like to help with that.
I think we can have one or two people from Red Hat assisting on the
maintenance of Ripple. This proba
Joe, Q&A was just an experiment. I'm doubtful we'll get activity on it,
but if it becomes a distraction we will drop it. The purpose of the
meeting is for commiters to get face time and to make progress on work
which usually happens on these lists -- not to answer cordova user
questions.
-Michal
GitHub user BBosman opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/13
[CB-7166] Fix naviagtor typo
There is a typo in one of the comments.
"naviagtor" should be "navigator".
You can merge this pull request into a Git repository by runnin
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/35
CB-6961 port file-transfer tests to framework
Automated and manual tests ported
You can merge this pull request into a Git repository by running:
$ git pull https://github.c
Github user chaffeqa commented on the pull request:
https://github.com/apache/cordova-wp8/pull/13#issuecomment-49440313
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15115130
--- Diff: bin/templates/project/cordova/lib/session.js ---
@@ -58,6 +58,7 @@ module.exports = {
signerParams = getParams("blac
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114609
--- Diff: bin/templates/project/cordova/lib/localize.js ---
@@ -29,10 +29,10 @@ var Localize = require("localize"),
"en": "Bui
OK, I’ve updated the wiki. Everyone add this to your calendar, and take a look
at the agenda.
I assume that just before the meeting, links will be posted for the read/write
stream (10 slots) and the read-only stream (unlimited slots).
On Jul 18, 2014, at 1:56 AM, tommy-carlos williams wrote:
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114473
--- Diff: bin/templates/project/cordova/lib/cmdline.js ---
@@ -30,7 +30,8 @@ command
.option('-p, --params ', 'Specifies additional
p
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114357
--- Diff: bin/templates/project/cordova/lib/cmdline.js ---
@@ -20,7 +20,7 @@ var command = require("commander"),
command
.v
GitHub user lapo-luchini opened a pull request:
https://github.com/apache/cordova-ios/pull/100
Fix __PROECT_NAME__ replacing code
`&` is a special character for `sed` and this fixes the problem of having
`__PROJECT_NAME__` in the final output when the project name contains an
amper
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114139
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -81,10 +74,16 @@ try {
keystorepass = session.getKeyStoreP
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15113926
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -81,10 +74,16 @@ try {
keystorepass = session.getKeyStoreP
Github user jkeshavarzi commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/169#discussion_r15113856
--- Diff: bin/templates/project/cordova/lib/build.js ---
@@ -108,8 +110,15 @@ try {
bbwpArgv.push("-d");
BTW: I don't know exactly which device you have, since all I really
have is a photo of it. I don't have any modern Android phones with
keyboards, nor am I even aware of a modern Android phone with a
keyboard other than the Desire Z and some weird Samsung Galaxy model
on T-Mobile. These usually te
What's the purpose of the hangout? If it's to allow our users to ask
questions, etc, that's fine. If it's to actually discuss planning
decisions to be made on the list, that's fine as well. However, I
don't think we have time to do both, and I can see us dropping Q&A
really quickly.
On Fri, J
So, where's your repro steps? Also, where's the basic info, like which
device you used to reproduce it. Which version of Android?
https://issues.apache.org/jira/browse/CB-7159
Also, if this is really just a few hundreds of a millisecond, and this
is only on your device, which we don't have, this
Yes, and I think that's what Michal wanted to set up the Hangouts Q&A
feature for, as well -- not for an actual "Q&A session", but to allow
everyone to participate, even if they can't stream their video.
On Fri, Jul 18, 2014 at 8:58 AM, Mike Billau wrote:
> If there are people on the view-only
If there are people on the view-only link that have stuff to say, there is
always IRC that I think a bunch of us monitor during the hangouts.
On Fri, Jul 18, 2014 at 1:59 AM, Jesse wrote:
> +1
>
> @purplecabbage
> risingj.com
>
>
> On Thu, Jul 17, 2014 at 10:56 PM, tommy-carlos williams <
> to.
It's so simple reproduce this even without opacity. Simply make new Android
Cordova project.
Add this to css to make clear that css doesn't play any role here:
* {
background-color: black !important
}
Then infest with HTML code from http://html-ipsum.com/ and ideally
form code. Copy it
55 matches
Mail list logo
