[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...

2015-08-19 Thread idpaterson
Github user idpaterson commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-132706052 Thanks, this works well! Can you follow through with the [recommended contributor workflow](http://cordova.apache.org/#contribute) then update

[GitHub] cordova-blackberry pull request: Default Icon is now copied into p...

2015-08-19 Thread timwindsor
GitHub user timwindsor opened a pull request: https://github.com/apache/cordova-blackberry/pull/190 Default Icon is now copied into platform_www Fixes issue with build failing when no icon tag is present in config.xml You can merge this pull request into a Git repository by

Re: Cordova Face to Face meeting

2015-08-19 Thread Jesse
Any large decisions we make must be taken to the list anyway so everyone can be included. So, don't worry, we are not going to march forward without your input. My team is hiring! @purplecabbage risingj.com On Wed, Aug 19, 2015 at 11:21 AM, Victor Sosa sosah.vic...@gmail.com wrote: As Julio

Re: Cordova Face to Face meeting

2015-08-19 Thread Steven Gill
I have closed the doodle. Oct, wed 14th has the best availability. Everyone who responded can make it. I suggest we pick that day and combine it with either the 13th or the 15th to make this a two day meeting. Let us know if that works for booking space at Microsoft Parashuram! If so, the rest

[GitHub] cordova-windows pull request: Update the README.md

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-08-19 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132692263 Someone please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Cordova Face to Face meeting

2015-08-19 Thread Victor Sosa
As Julio says, please share the notes, recordings or comments you guys agree (I envy all the attendees so much, especially Carlos :P) On Wed, Aug 19, 2015 at 12:46 PM Parashuram N panar...@microsoft.com wrote: Awesome, I will get started on the logistics side to book 14 as the pivot, and see

[GitHub] cordova-plugin-file pull request: Windows prefix paths

2015-08-19 Thread ekambarrao
Github user ekambarrao commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-132689968 I was using this plugin in visual studio 2015 cordova app, and ran the app in windows phone 8.1, Does this app work on windows phone 8.1, It is showing

RE: Cordova Face to Face meeting

2015-08-19 Thread Parashuram N
Awesome, I will get started on the logistics side to book 14 as the pivot, and see if I can do 13 or 15. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, August 19, 2015 9:50 AM To: dev@cordova.apache.org Subject: Re: Cordova Face to Face meeting I

[GitHub] cordova-plugin-file pull request: Windows prefix paths

2015-08-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/121#issuecomment-132746891 @ekambarrao Please stop hijacking other people's pull requests. Your post is about the plugin itself, and not this code. Try stack-overflow,

[GitHub] cordova-lib pull request: CB-9434: Adding a ToDO. 'cordova run' sh...

2015-08-19 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/280#issuecomment-132759350 For further details, see : https://issues.apache.org/jira/browse/CB-9434 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-08-19 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132743916 I dont know enough android either to fix it, all I know is that the op I comment out is the one making trouble. I think that the ops means to do

[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...

2015-08-19 Thread JackStoneDev
Github user JackStoneDev commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/65#issuecomment-132757235 What is the status on this? I'm having a hard time turning the photos returned on iOS into base64-encoded strings. How might I do that? --- If

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-08-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132742487 Commenting out code is never the solution. This file appears to desperately need a refactor anyway. I don't know enough about the android

Cordova-JS on Master Issue

2015-08-19 Thread James Dubee
Hello, I have noticed that in order to call npm install in cordova-js on Master, users must have Visual Studio, and Python installed. This is due to the contextify Node module now being used in cordova-js. Even though I have both the mentioned requirements installed, I still am getting an error

[GitHub] cordova-lib pull request: CB-9434: Adding a ToDO. 'cordova run' sh...

2015-08-19 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/280 CB-9434: Adding a ToDO. 'cordova run' should run build related hooks … …: 'before_build' 'after_build' hooks. You can merge this pull request into a Git repository by running: $ git

Re: CB-9496 - Quick sanity check...

2015-08-19 Thread Joe Bowser
Looks fine. On Wed, Aug 19, 2015 at 3:51 PM Jesse purplecabb...@gmail.com wrote: lgtm! go for it. My team is hiring! @purplecabbage risingj.com On Wed, Aug 19, 2015 at 3:42 PM, Carlos Santana csantan...@gmail.com wrote: I think it should be fine since it was like that before April

[GitHub] cordova-plugin-file-transfer pull request: CB-9493 Fix file paths ...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-js pull request: CB-9342 Fix deviceReady event not fired o...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8532 Adding Windows Plugin Failed wit...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen pull request: CB-9467 SplashScreen doe...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file pull request: Added cdvfile protocol purpose d...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Cordova Face to Face meeting

2015-08-19 Thread Carlos Santana
I don't have travel approval yet, they wanted the specific date first - Carlos Sent from my iPhone On Aug 19, 2015, at 2:21 PM, Victor Sosa sosah.vic...@gmail.com wrote: As Julio says, please share the notes, recordings or comments you guys agree (I envy all the attendees so much,

Re: CB-9496 - Quick sanity check...

2015-08-19 Thread tommy-carlos williams
So can someone look at merging this in then? :) Or am I OK to merge my own PR if everyone (well, Joe and Carlos) are happy with it?  On 18 August 2015 at 12:04:55, tommy-carlos williams (to...@devgeeks.org) wrote: I think they just should have been in the plugin all along…  If it’s not

Re: CB-9496 - Quick sanity check...

2015-08-19 Thread Carlos Santana
I think it should be fine since it was like that before April 2014 and was only introduced for crosswalk initial work - Carlos Sent from my iPhone On Aug 19, 2015, at 6:39 PM, tommy-carlos williams to...@devgeeks.org wrote: So can someone look at merging this in then? :) Or am I OK to

[GitHub] cordova-docs pull request: Blog notification fixes

2015-08-19 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/307 Blog notification fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-docs raghav/notification_fixes Alternatively

Re: CB-9496 - Quick sanity check...

2015-08-19 Thread Jesse
lgtm! go for it. My team is hiring! @purplecabbage risingj.com On Wed, Aug 19, 2015 at 3:42 PM, Carlos Santana csantan...@gmail.com wrote: I think it should be fine since it was like that before April 2014 and was only introduced for crosswalk initial work - Carlos Sent from my iPhone

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

2015-08-19 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/154#discussion_r37478335 --- Diff: bin/templates/scripts/cordova/run.bat --- @@ -15,11 +15,5 @@ :: specific language governing permissions and limitations :: under

[GitHub] cordova-docs pull request: Added plugin search js from cordova-reg...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/306 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Added plugin search js from cordova-reg...

2015-08-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/306#issuecomment-132827839 LGTM. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios pull request: CB-9462 iOS 3.9.0 breaks npm link module...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-geolocation pull request: CB-9355 Fix Geolocation p...

2015-08-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Document Translation to Korean

2015-08-19 Thread Youngho Cho
Hello all, I am Youngho who live in Seoul, Korea. Few years ago, I successfully finished my project with Cordova( 2.x age ). And recently, I started to continue my project with Cordova. In order to contribute to the cordova, I start to translate the document to Korean at the Crowdin. I am not

[CI] Medic Update

2015-08-19 Thread Dmitry Blotsky
Hey folks, Sorry for the lull in sending these updates. These past few weeks’ updates regarding the CI: - iOS build still failing due to CB-9483; Shazron did some investigating and patching - Windows Phone 8.1 builds have been failing because of some issues with cordova-run - Windows builds

[GitHub] cordova-docs pull request: Added plugin search js from cordova-reg...

2015-08-19 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/306 Added plugin search js from cordova-registry-web Adds the React javascript for the NPM plugin search from cordova-registry-web so that it can be integrated into the plugins page. The React

[GitHub] cordova-registry-web pull request: Includes small performance upda...

2015-08-19 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-registry-web/pull/31 Includes small performance updates and other changes: You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-registry-web

[GitHub] cordova-osx pull request: CB-9517 Adding a plugin on OSX that uses...

2015-08-19 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/14 CB-9517 Adding a plugin on OSX that uses a private framework does not work Depends on PR #13 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-9517 Adding a plugin on iOS/OSX that ...

2015-08-19 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-lib/pull/281 CB-9517 Adding a plugin on iOS/OSX that uses a private framework does… see also related PR https://github.com/apache/cordova-osx/pull/14 todo: * update the project templates

[GitHub] cordova-plugin-statusbar pull request:

2015-08-19 Thread runspired
Github user runspired commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/07b55b752960e66ca4d0ba33b9c49d41b7241b43#commitcomment-12795841 Leaving this comment here since there's nowhere to actually open issues for these plugins. This

[GitHub] cordova-plugin-statusbar pull request:

2015-08-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/07b55b752960e66ca4d0ba33b9c49d41b7241b43#commitcomment-12796078 Issues can be reported in JIRA for all cordova core plugins .

[GitHub] cordova-registry-web pull request: Small performance updates and o...

2015-08-19 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-registry-web/pull/31#issuecomment-132805181 these changes look good to me :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: Blog notification fixes

2015-08-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/307#issuecomment-132845353 LGTM. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Document Translation to Korean

2015-08-19 Thread Carlos Santana
Welcome !! Yes this is the correct list One of the guys more involved with docs will see this and I hope they get with you to get you going. We also have Slack you can join the #docs channel http://cordova.slack.com - Carlos Sent from my iPhone On Aug 19, 2015, at 7:12 PM, Youngho Cho

Buildbot: buildslave cordova-windows-slave was lost

2015-08-19 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Wed Aug 19 10:41:59 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky dblot...@microsoft.com '.

[GitHub] cordova-windows pull request: Fix the case of Q requires.

2015-08-19 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-windows/pull/118 Fix the case of Q requires. This is important for case-sensitive file systems (Linux, and some OSX). You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] 4.0.0 Browser Release

2015-08-19 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Brian LeRoux Carlos Santana The vote has passed. I will publish it to npm and dist now. It's changes will be included in the next tools release blog post. On Tue, Aug 18, 2015 at 1:29 PM, Carlos Santana