Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40478236
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40477877
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#discussion_r40477508
--- Diff: src/android/ContactManager.java ---
@@ -48,13 +54,66 @@ Licensed to the Apache Software Foundation (ASF) under
one
public
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40476918
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/78#discussion_r40476235
--- Diff: src/android/ContactManager.java ---
@@ -48,13 +54,66 @@ Licensed to the Apache Software Foundation (ASF) under
one
public
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40475782
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40475167
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40474831
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40473698
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40473658
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/220#discussion_r40473522
--- Diff: framework/src/org/apache/cordova/CordovaPlugin.java ---
@@ -359,4 +361,38 @@ public boolean
onReceivedClientCertRequest(CordovaWebView vie
+1 to major version.
Thanks for the PR, Joe. Makes it easier to review.
On Sep 24, 2015 3:07 PM, Joe Bowser wrote:
As requested, here's the pull request for Cordova-Android. This should
still work with the other smores plugins.
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgi
Sorry a typo
to use "bundleDependencies" you will have a node_modules/ directory
directly under "common/node_modules/cordova-error/"
and the the small modules (i.e. cordoba-util, cordova-plugin-info, etc..)
will be located there.
then have explicit ignores for the dependencies you don't want to b
I also really like what Carlos suggests. The first release will be tedious
but it should get easier after that and make things easier to follow. Using
ranges, like we do with pinned platforms, for modules would ease the work
during releases and not require us to update every package that depends on
Yes after reviewing the changes, I understood the purpose of the code that
you seperated to avoid duplicate code between the other top level modules
(i.e. platforms, lib, cli)
I still think small modules is the way to go.
Don't let process, bureaucracy, and ceremony hamper the engineering process
Separate modules are tempting, but I think they'll make the release process
much harder.
On Fri, Sep 25, 2015 at 11:40 AM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> I tend to agree w/ Carlos here, but from practical side it might be very
> hard to maintain and release such a gra
I tend to agree w/ Carlos here, but from practical side it might be very hard
to maintain and release such a granular modules, for example,
- cordova-error has been updated ->Vote -> update cordova-config-parser +
Vote-> update + Vote other depended modules
- now we want to add some new feature
It's me debugging and doing maintenance again.
Estimated downtime is ~4 hours.
Thanks,
Alexander Sorokin
-Original Message-
From: build...@apache.org [mailto:build...@apache.org]
Sent: Friday, September 25, 2015 2:08 PM
To: dev@cordova.apache.org
Subject: Buildbot: buildslave cordova-wi
The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Fri Sep 25 11:03:09 2015 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
htt
19 matches
Mail list logo
