[GitHub] cordova-plugin-dialogs pull request: Added option to specify the i...

2015-10-07 Thread uzlov
GitHub user uzlov opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/62 Added option to specify the input type of the prompt dialog + max lenght for prompt dialog (android only) Clean code from https://github.com/apache/cordova-plugin-dialogs/pull/30 +

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-07 Thread ngopal
GitHub user ngopal opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103 Added note about iOS9 and Xcode (7 and higher) quirks. I spent many hours identifying this issue and propose modifying the README file with a helpful pointer (to save the time

[GitHub] cordova-plugin-file pull request: Fix crash and add new feature

2015-10-07 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/136#discussion_r41450691 --- Diff: src/android/ContentFilesystem.java --- @@ -193,7 +193,7 @@ protected Long lastModifiedDateForCursor(Cursor cursor) {

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

2015-10-07 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/314#discussion_r41439142 --- Diff: cordova-serve/src/server.js --- @@ -17,121 +17,51 @@ under the License. */ -var chalk = require('chalk'), -fs

[GitHub] cordova-windows pull request: Creating new solution file for dev14...

2015-10-07 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-windows/pull/124#issuecomment-146317296 LGTM ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-file pull request: Adding permissions, giving read ...

2015-10-07 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/135#issuecomment-146346202 The [permission reference](http://developer.android.com/reference/android/Manifest.permission.html#READ_EXTERNAL_STORAGE) seems to indicate that getting

[GitHub] cordova-windows pull request: Creating new solution file for dev14...

2015-10-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

2015-10-07 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/123#issuecomment-146366478 @robpaveza Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

2015-10-07 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-146336013 "If you are using iOS9 or have upgraded to Xcode7" should be "If you are using iOS9 and have upgraded to Xcode7", there is no problem with

Buildbot: buildslave cordova-windows-slave was lost

2015-10-07 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Wed Oct 7 22:32:40 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '.

[GitHub] cordova-plugin-inappbrowser pull request: CB-9760 InAppBrowser: fa...

2015-10-07 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/118 CB-9760 InAppBrowser: fallback to default windows.open behavior on Ripple https://issues.apache.org/jira/browse/CB-9760 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-inappbrowser pull request: Cannot open the camera w...

2015-10-07 Thread iosdroid
Github user iosdroid closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser pull request: CB-9760 InAppBrowser: fa...

2015-10-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: Cannot open the camera w...

2015-10-07 Thread iosdroid
GitHub user iosdroid opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/117 Cannot open the camera with inappbrowser cordova You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-inappbrowser pull request: Cannot open the camera w...

2015-10-07 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/117#issuecomment-146120130 Please, close this, you created a pull request, pull requests are for providing fixes, not for asking questions. You can't use

[GitHub] cordova-plugin-inappbrowser pull request: CB-9760 InAppBrowser: fa...

2015-10-07 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/118#issuecomment-146123708 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

RE: [CI] Update (Crashes!)

2015-10-07 Thread Vladimir Kotikov (Akvelon)
I'll take a look at https://issues.apache.org/jira/browse/CB-9759 - Best regards, Vladimir -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Wednesday, October 7, 2015 5:12 AM To: Subject: [CI] Update

[GitHub] cordova-android pull request: Makes CLI build play nice along with...

2015-10-07 Thread saharshtibrewal
Github user saharshtibrewal commented on the pull request: https://github.com/apache/cordova-android/pull/224#issuecomment-146404319 File Exists Check missing. Will add and resubmit. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: Makes CLI build play nice along with...

2015-10-07 Thread saharshtibrewal
Github user saharshtibrewal closed the pull request at: https://github.com/apache/cordova-android/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

RE: [DISCUSS] CORDOVA AND LIVERELOAD

2015-10-07 Thread Mefire O .
Thanks for the feedback, it was received. As follow up actions, I've done the following changes: - Changed things into a plugin - Added support for multiplatform support: `cordova run android ios --device -- --livereload` - Added the capability to mirror gestures: clicks, scrolls, form inputs -

[GitHub] cordova-docs pull request: GapDebug

2015-10-07 Thread AnabellaGenuitec
Github user AnabellaGenuitec commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/369#discussion_r41469984 --- Diff: www/_data/tools.yml --- @@ -1,9 +1,10 @@ -# - name: Example Tool -# image: cordova.png -# url:

RE: Cordova website redesign

2015-10-07 Thread Ryan J. Salva
I'm personally a big fan of Ben's proposal. The typography really stands out and gives the brand a strong, updated and modern presence. I know there's a lot of pride in the heritage of the logo, and for that reason I wouldn't dream of losing our beloved robot. However, the typography is a

[GitHub] cordova-docs pull request: Adding Framework7 to the tools list and...

2015-10-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/370#issuecomment-146388019 Both in one PR should be fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: GapDebug

2015-10-07 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/369#discussion_r41467792 --- Diff: www/_data/tools.yml --- @@ -1,9 +1,10 @@ -# - name: Example Tool -# image: cordova.png -# url: http://example.com

Re: Cordova website redesign

2015-10-07 Thread Steven Gill
+1 On Oct 7, 2015 9:15 PM, "Brian LeRoux" wrote: > Well said, and ya updated typeface looks slick.  > On Wed, Oct 7, 2015 at 6:10 PM Ryan J. Salva wrote: > > > I'm personally a big fan of Ben's proposal. The typography really stands > > out and gives the

Re: Buildbot: buildslave cordova-windows-slave was lost

2015-10-07 Thread Dmitry Blotsky
Sorry, I accidentally kicked the switch and it set the machine's Ethernet cable loose. ): Back up now! Kindly, Dmitry > On Oct 7, 2015, at 3:37 PM, build...@apache.org wrote: > > The Buildbot working for 'ASF Buildbot' > has noticed that the buildslave named cordova-windows-slave went away >

[GitHub] cordova-android pull request: Makes CLI build play nice along with...

2015-10-07 Thread saharshtibrewal
Github user saharshtibrewal commented on the pull request: https://github.com/apache/cordova-android/pull/224#issuecomment-146406700 Submitted a new one: https://github.com/apache/cordova-android/pull/225 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-android pull request: Makes CLI build play nice along with...

2015-10-07 Thread saharshtibrewal
GitHub user saharshtibrewal opened a pull request: https://github.com/apache/cordova-android/pull/225 Makes CLI build play nice along with Android Studio Recently, I had had an issue after opening my cordova project with Android Studio whereby the cordova build android command

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-10-07 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-146384452 Alkashi - getDuration definitely works as expected on ios devices. I use it every day in my app and have tested it extensively on multiple devices and

[DISCUSS] Front Page Wording

2015-10-07 Thread Dmitry Blotsky
Hey folks, This is mostly just a question of curiosity: should we be saying “Native mobile apps” on the front page or “Hybrid mobile apps”? I’ve had some folks ask me which word makes more sense, so I thought I’d forward the inquiry. Kindly, Dmitry

Re: Cordova website redesign

2015-10-07 Thread Brian LeRoux
Well said, and ya updated typeface looks slick.  On Wed, Oct 7, 2015 at 6:10 PM Ryan J. Salva wrote: > I'm personally a big fan of Ben's proposal. The typography really stands > out and gives the brand a strong, updated and modern presence. I know > there's a lot of pride

[GitHub] cordova-docs pull request: GapDebug

2015-10-07 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/369#discussion_r41471386 --- Diff: www/_data/tools.yml --- @@ -1,9 +1,10 @@ -# - name: Example Tool -# image: cordova.png -# url: http://example.com

[GitHub] cordova-android pull request: Makes CLI build play nice along with...

2015-10-07 Thread saharshtibrewal
GitHub user saharshtibrewal opened a pull request: https://github.com/apache/cordova-android/pull/224 Makes CLI build play nice along with Android Studio Recently, I had had an issue after opening my cordova project with Android Studio whereby the cordova build android command

[GitHub] cordova-medic pull request: CB-9759 Link cordova-common -> cordova...

2015-10-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/68#issuecomment-146411244 Hey! I just saw this PR as I merged in a fix. Sorry for the duplicate work! It's basically the same fix, with an extra line. --- If your project is set up for

[GitHub] cordova-docs pull request: replaced NewVo iamge in app showcase

2015-10-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/347#issuecomment-146387478 Hey @boblikesoup, sorry for the delay in addressing this! Would you please be able to submit an image that contains the app's logo only? We've drafted some

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-10-07 Thread Alkashi
Github user Alkashi commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-146427668 @ghenry22 OK Thanks for the feedback I'll try again asap. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Cordova website redesign

2015-10-07 Thread Tommy-Carlos Williams
Yeah... I kinda fell into the "not sure, wait and see what others thought" category on this one. I would also like more discussion unless everyone really has no opinion. > On 8 Oct 2015, at 05:42, Jesse wrote: > > I would suggest that the lack of response on the

CB-9745 Camera plugin docs should be generated from the source

2015-10-07 Thread Sergey Shakhnazarov (Akvelon)
Hello guys, Please review the PR[1], making the Camera plugin docs to be generated from JSDoc. I wanted to discuss it once more in terms of the following points: 1. Should this change be merged in or not? 2. If yes, where should we store the DMD template plugin (common template

RE: [VOTE] 1.0.0 cordova-serve release

2015-10-07 Thread Vladimir Kotikov (Akvelon)
I vote +1 * Verified ability to run browser platform based on cordova-serve * Verified ability to run 'cordova serve' based on cordova-serve - Best regards, Vladimir -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Tuesday, October 6, 2015 1:04 PM

[GitHub] cordova-medic pull request: CB-9759 Link cordova-common -> cordova...

2015-10-07 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-medic/pull/68 CB-9759 Link cordova-common -> cordova-lib to prevent `npm install` failures This fixes Buildbot failure, described in [CB-9759](https://issues.apache.org/jira/browse/CB-9759)

Cordova-common is merged in

2015-10-07 Thread Vladimir Kotikov (Akvelon)
Hey, guys. We've recently pushed the change, that makes cordova-lib depend on cordova-common module [1], which won't be published, but will be bundled into cordova-lib as bundled dependency. There also a PR to coho that support this scenario [2]. Unfortunately this change breaks dev workflow,

[GitHub] cordova-ios pull request: CB-9719 set allow_non_modular_includes t...

2015-10-07 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-ios/pull/171 CB-9719 set allow_non_modular_includes to yes Ran into some issues with git so did a new pull request. @shazron @csantanapr I added that setting change in build.xcconfig and confirmed that it

[GitHub] cordova-plugin-file pull request: CB-9763: added handling for enco...

2015-10-07 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/137 CB-9763: added handling for encoding exception in readAsText on Windows readAsText on windows uses Windows.Security.Cryptography.CryptographicBuffer.convertBinaryToString to convert

[GitHub] cordova-ios pull request: CB-9719 set enable_modules build setting...

2015-10-07 Thread eymorale
Github user eymorale closed the pull request at: https://github.com/apache/cordova-ios/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Added a block for Cocoon tool

2015-10-07 Thread keianhzo
GitHub user keianhzo opened a pull request: https://github.com/apache/cordova-docs/pull/372 Added a block for Cocoon tool Added a text block and image for Cocoon in the Cordova Tools section You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: Added Intel XDK to tools list

2015-10-07 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-docs/pull/373 Added Intel XDK to tools list You can merge this pull request into a Git repository by running: $ git pull https://github.com/tony--/cordova-docs add-tool-intel-xdk Alternatively you

[GitHub] cordova-lib pull request: CB-9598 Switching to use `cordova-common...

2015-10-07 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/311#issuecomment-146290986 :nit Looks like we need to update 'cordova-lib' to 'cordova-common' in the README.md file :

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-10-07 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-146297576 Is this fixing the same issues as #93? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Cordova website redesign

2015-10-07 Thread Jesse
I would suggest that the lack of response on the logo change means we don't need it. I think there should at least be some discussion before moving on it. > On Oct 7, 2015, at 11:31 AM, Brad Gashler wrote: > > Hi Everyone, > > I wanted to follow up on the branding

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

2015-10-07 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/314#issuecomment-146290411 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

2015-10-07 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/314#discussion_r41426471 --- Diff: cordova-serve/serve.js --- @@ -17,9 +17,41 @@ under the License. */ -module.exports = { -sendStream:

[GitHub] cordova-windows pull request: Creating new solution file for dev14...

2015-10-07 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-windows/pull/124 Creating new solution file for dev14 and renaming old to vs2013.sln You can merge this pull request into a Git repository by running: $ git pull

RE: Cordova website redesign

2015-10-07 Thread Brad Gashler
Hi Everyone, I wanted to follow up on the branding changes proposed by Ben Sperry (his email is included below). I’m planning on implementing his changes, since no objections were raised. This includes the new logo, with its modern typeface, as shown in picture A below. Also, we may

[GitHub] cordova-lib pull request: Refactor cordova-serve to use Express.

2015-10-07 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/314#discussion_r41429108 --- Diff: cordova-serve/src/server.js --- @@ -17,121 +17,51 @@ under the License. */ -var chalk = require('chalk'), -fs

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

2015-10-07 Thread Justin-Credible
Github user Justin-Credible commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-146258586 Any updates on this? Can we get this merged please? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: Fixed the images on homepage and associ...

2015-10-07 Thread bgashler1
Github user bgashler1 closed the pull request at: https://github.com/apache/cordova-docs/pull/364 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the