[GitHub] cordova-plugin-file-transfer pull request: Gzip support for wp8.x ...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/85#issuecomment-151058822 Ping, @sviluppatoribk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-151060275 Thanks, @shazron. So do we still need this PR or can it be closed? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42972214 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-plugin-inappbrowser pull request: CB-9274 Adds missing met...

Github user dennisexozet commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/107#issuecomment-151105586 Hello contributors, when will this fix be part of the current branch? It's older than 3 month and has not yet been merged.

[GitHub] cordova-plugin-file-transfer pull request: uploadResponse encoding...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/71#discussion_r42969855 --- Diff: src/ios/CDVFileTransfer.m --- @@ -552,6 +552,8 @@ - (void)connectionDidFinishLoading:(NSURLConnection*)connection

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#discussion_r42970796 --- Diff: plugin.xml --- @@ -20,8 +20,8 @@ http://apache.org/cordova/ns/plugins/1.0;

[DISCUSS] Copying node_modules during platform install

Hey folks, I’ve come across a bug with symlinks and platform installation recently. The point of interest is this line: https://github.com/apache/cordova-ios/blob/4039aeb6f87c6803df5814b8cdefb8c2058504a0/bin/lib/create.js#L93. Is copying node_modules a safe operation? In my case there was a

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/174#issuecomment-151308616 The only thing new is 371c136315b0c4f481ee479242dd769c4280b932 correct? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request: CB-9565 with logic tweak

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-9565 with logic tweak

GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-windows/pull/130 CB-9565 with logic tweak Fixes a small oversight in the previous pull request. You can merge this pull request into a Git repository by running: $ git pull

Re: [DISCUSS] cordova-ios 4.0.0 release

Thanks guys! I've commented on the PR, there is one more commit to add. Created the board: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=96 (based off the label you created) On Mon, Oct 26, 2015 at 8:42 AM, Vladimir Kotikov (Akvelon) wrote: > Hi, guys.

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

This case has been covered by the tag itself -- the specifications say there is a "platform" attribute. The engine requirement will not be checked if you are not on the specified platform(s). On Fri, Oct 23, 2015 at 7:21 PM, Carlos Santana wrote: > I mean is that I should

[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/175#issuecomment-151285278 This should make it in as well: https://issues.apache.org/jira/browse/CB-9721 --- If your project is set up for it, you can reply to this email and have

Re: [DISCUSS] CocoaPods dependencies for iOS plugins

Great ! So in other words you are telling me RTFM :-p On Mon, Oct 26, 2015 at 5:56 PM Shazron wrote: > This case has been covered by the tag itself -- the > specifications say there is a "platform" attribute. The engine > requirement will not be checked if you are not on the

[GitHub] cordova-ios pull request: CB-9685 Enhanced the fix for the iOS9 lo...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/174#issuecomment-151310777 Pulled in. Can you add docs too, please? Thanks :) Here: https://github.com/apache/cordova-docs/blob/master/www/docs/en/edge/guide/platforms/ios/config.md

[DISCUSS] Cordova App Hello World Release

Does anyone have any reason to delay a cordova-app-hello-world release? Any outstanding patches to land?

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151321669 Unfortunately I can't take this patch in as is. The apple watch sample extension contains source files, which are not Apache Licensed:

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-151323347 11 failing tests: ``` Failures: 1) ios project handler installation of elements should call into xcodeproj's addSourceFile appropriately

[GitHub] cordova-plugin-file-transfer pull request: Added note about iOS9 a...

Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-151282089 With the next CLI release when it comes out, this PR will not be relevant. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-device pull request: Don't fail completely if devic...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request: CB-9865 Better simulator detec...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request: Few changes in Spanish Transla...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Cordova App Hello World Release

Issue: https://issues.apache.org/jira/browse/CB-9870 On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill wrote: > Does anyone have any reason to delay a cordova-app-hello-world release? > Any outstanding patches to land? > > >

Re: [DISCUSS] Cordova App Hello World Release

RELEASE NOTES: https://github.com/apache/cordova-app-hello-world/blob/master/RELEASENOTES.md On Mon, Oct 26, 2015 at 4:36 PM, Steven Gill wrote: > Issue: https://issues.apache.org/jira/browse/CB-9870 > > On Mon, Oct 26, 2015 at 4:34 PM, Steven Gill

[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/402#issuecomment-151297369 @stevengill or @purplecabbage: I'm not very familiar with this topic. Could either one of you please review this when you have a moment? Or point to someone that

[GitHub] cordova-ios pull request: CB-9836 Add .gitattributes to prevent CR...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [VOTE] Cordova-common release

I'm going to rescind my +1 and agree with Carlos (in the discuss thread) that we should bump the version to 1.0.0. Check the discuss thread for his feedback. On Fri, Oct 23, 2015 at 5:08 PM, Steven Gill wrote: > +1 > > * Ran coho audit-license-headers over the repo > *

[GitHub] cordova-plugin-device pull request: Added basic Android support fo...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-device pull request: Don't fail completely if devic...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/27#issuecomment-151306983 Realistically this cannot happen unless somehow the JS side of the plugin exists and the native side does not. This would be a signal of MUCH

[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/402#issuecomment-151317454 I think @nikhilkh might have more info on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

Github user charlesverge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-151165724 @nikopolv Does the Sony Aqua M2 with 4.4 kitkat work with the branch issue #93 is based off of ? --- If your project is set up for it, you can

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151138324 I'm not android SME, maybe @macdonst can take a look. My general comment on this PR, is that if you don't know what are not sure what's the

[GitHub] cordova-windows pull request: CB-9565: Build failure for Windows 1...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-windows/pull/123#issuecomment-151123814 tested with the mod as in the comments, resolved the error for me --- If your project is set up for it, you can reply to this email and have your reply appear

RE: [DISCUSS] cordova-ios 4.0.0 release

Hi, guys. We've cherry-picked all the commits related to iOS9 / Xcode 7 issues into 3.9.x and send corresponding PR to 3.9.x branch [1]. Shazrov, Steve please review when possible. Regarding new board for 3.9.2 release - neither Sergey nor me don't have a permissions to create a shared

[GitHub] cordova-plugin-whitelist pull request: add JIRA issue tracker link

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-device pull request: CB-9865 Better simulator detec...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/41#issuecomment-151180573 @purplecabbage please have a look, this fixes build failure on older versions of XCode --- If your project is set up for it, you can reply to this

[GitHub] cordova-ios pull request: Prepare cordova-ios 3.9.2 release

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/175 Prepare cordova-ios 3.9.2 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios 3.9.2-release

[GitHub] cordova-plugin-device pull request: CB-9865 Better simulator detec...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device/pull/41 CB-9865 Better simulator detection for iOS https://issues.apache.org/jira/browse/CB-9865 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-whitelist pull request: Update some confusing comme...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: Remove ops

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-151176788 Is there a JIRA issue related to this pull request. We need to be able to see what the problem is before we can talk about this issue. We're not

RE: [DISCUSS] Tools Release

Looking forward to the release today. Btw, cordova-app-hello-world also needs to be released at the same time and cordova-lib needs to take a dependency on the new version. This will resolve the npm@3 bug that I’ve seen being reported by multiple people. We should push to get that resolved and

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-151242639 @jeroenv, thanks for your contribution! Could you please file a [Jira bug](https://issues.apache.org/jira/browse/CB) with the issue details

Re: [DISCUSS] Tools Release

Sounds good. I'll be going through the process today. On Mon, Oct 26, 2015 at 8:45 AM, Nikhil Khandelwal wrote: > Looking forward to the release today. > > Btw, cordova-app-hello-world also needs to be released at the same time > and cordova-lib needs to take a