[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/241 CB-10112 Parse additional CLI arguments properly This fixes [CB-10112](https://issues.apache.org/jira/browse/CB-10112) by updating `build.js` to take an addtional platform options

Re: [DISCUSS] cordova-ios-4.x release (for real)

I'm guessing "pending" is the same as skipping the test. I'm guessing WKWebView doesn't support Web SQL, but window.openDatabase exist but it doesn't do anything? I ask because I only saw the pending for wkwebview spec.18 for using it, not for spec.9 where it checks that exists. Anyway after all

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

visual inspection looks good, and only touches ubuntu specific code. Go ahead and merge it. On Wed, Dec 2, 2015 at 6:56 AM David Barth wrote: > On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana > wrote: > > > David do we need to have the CB-9618

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161331277 No objections from my side. The PR has passed internal review, all CR notes has been addressed. @sgrebnov? --- If your project is set up for it, you can

Re: [NOTICE] David Barth has become a committer

There is no Ubuntu simulator/emulator? I think I tried to look for one but didn't find. Then I was looking for a cheap phone for testing and was not able to find one that I could buy locally. Any lottery process to get a Free Ubuntu Phone for dev/testing? :-) On Wed, Dec 2, 2015 at 4:58 AM David

[GitHub] cordova-plugin-media pull request: ionic pluginFixing issues on An...

GitHub user lucViana opened a pull request: https://github.com/apache/cordova-plugin-media/pull/77 ionic pluginFixing issues on Android 6.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lucViana/cordova-plugin-media master

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161393743 Just make sure your name is on your github profile, which it appears to be. :+1: We just needed the name at https://github.com/sencenan to

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161387695 I don't understand: so what is the bug, and how are we fixing it? I don't have a lot of context on this. Or if we have someone else with a lot of

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46454382 --- Diff: src/windows/FileTransferProxy.js --- @@ -49,6 +49,17 @@ function nativePathToCordova(path) { return

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161391018 Is it possible to check by loading the contact and comparing the date in a human-readable format with a fixed string like `"16-May-1984"`? --- If

[GitHub] cordova-docs pull request: CB-8917: adding docs for Android lifecy...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161388988 Thanks! The change looks much cleaner now. How are this PR and #77 related? Will they both be merged in? --- If your project is set up for it, you

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46446244 --- Diff: tests/tests.js --- @@ -29,6 +29,7 @@ exports.defineAutoTests = function () { // constants var

Re: Where to download Cordova shell tools?

Thank you for these links! Please find below some thoughts... maybe they can help you make the documentation and user experience for dummies like me even better :) In hindsight "npm install cordova-android" seems obvious, but I would not have guessed it. Especially because I want to be

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46445757 --- Diff: README.md --- @@ -230,6 +230,10 @@ __Parameters__: - Download requests is being cached by native implementation.

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161378270 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161390659 How would I associate my full name with my github id? I also fixed the problem with Google Photos which touches the same area of code. Should I remove

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill wrote: > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As > far > as I know, cordova-ubuntu should work the same with cordova@4.x and > cordova@5.x. The platform API changes aren't necessary to work with

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161413648 You do not need the Camera permission for the Camera plugin because we use intents. Why are we trying to request this permission? That's the

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

Github user david-barth-canonical commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/294#discussion_r46471716 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,51 @@ function toCamelCase(str) { }).join(''); }

[DISCUSS] Deprecate cordova-wp8

We've talked about it for awhile, but never moved on it. cordova-wp8 has been a work horse that seen us through tough times but the sun is setting. cordova-windows has been a viable alternative for some time now, and allows developers to target newer device features from wp8.1 and wp10 as well.

[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-android/pull/241#issuecomment-161410824 Thanks for the quick fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: iOS White Listing documentation

Send a PR please! https://github.com/apache/cordova-docs On Wed, Dec 2, 2015 at 9:21 AM, Robert Hoffmann < robert.hoffmann@gmail.com> wrote: > In the 5.4.0 docs it says under iOS Whitelisting: "As above, see > cordova-plugin-whitelist for details." > ( >

Re: [DISCUSS] Deprecate cordova-amazon-fireos

+1 On Wed, Dec 2, 2015 at 11:40 AM, Steven Gill wrote: > Issue for deprecation: https://issues.apache.org/jira/browse/CB-10121 > > Cc'ed Archana to see if she has any concerns. > > On Wed, Dec 2, 2015 at 12:03 AM, julio cesar sanchez < > jcesarmob...@gmail.com > > wrote:

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417577 Here's one that declares it: https://github.com/phonegap/phonegap-plugin-barcodescanner --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user Sinistralis commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161420725 When you say you do not get cookies set, are you talking about using this code or default functionality? I did not test against XWalk, but I

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161415816 @ochakov 1. Yes, it still works, because this relies on the permission of the Camera, not the permission of the application firing the event.

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416757 I feel like we can easily handle it, though, by programmatically checking if the permission was declared before we take a picture and only requesting it

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. We need one other committer to give a +1 so I can wrapnit up and publish On Dec 2, 2015 10:47 AM, "David Barth" wrote: > On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill >

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161412438 I have two questions then: 1. When you do not declare camera permission in the manifest, does it work on older Android versions? 2. When you do

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417898 Right, Barcode Scanner! That thing! So, if there's an app that uses the Barcode Scanner and takes a picture, then it can cause a problem. I'm

Re: [VOTE] cordova-ubuntu 4.3.1

+1 On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill wrote: > Please review and vote on this 4.3.1 Ubuntu Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-10030 > > The archive has been

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423220 Agreed. But this PR should be updated to check the PackageInfo first. @ochakov does that sound alright to you? --- If your project is set up for it,

iOS White Listing documentation

In the 5.4.0 docs it says under iOS Whitelisting: "As above, see cordova-plugin-whitelist for details." (https://cordova.apache.org/docs/en/5.4.0/guide/appdev/whitelist/index.html) This is confusing because at first I thought this plugin (https://github.com/apache/cordova-plugin-whitelist)

Re: [DISCUSS] Deprecate cordova-wp8

+1 On Wed, Dec 2, 2015 at 11:06 AM, Jesse wrote: > We've talked about it for awhile, but never moved on it. cordova-wp8 has > been a work horse that seen us through tough times but the sun is setting. > > cordova-windows has been a viable alternative for some time now,

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410396 Thanks for submitting a PR! I actually just ran into this issue while working on [another issue in

Re: [DISCUSS] Deprecate cordova-amazon-fireos

Issue for deprecation: https://issues.apache.org/jira/browse/CB-10121 Cc'ed Archana to see if she has any concerns. On Wed, Dec 2, 2015 at 12:03 AM, julio cesar sanchez wrote: > +1 > > 2015-12-02 5:54 GMT+01:00 Simon MacDonald : > > > +1 > >

Re: [DISCUSS] Deprecate cordova-amazon-fireos

+1 On Wed, Dec 2, 2015 at 11:45 AM Joe Bowser wrote: > +1 > > On Wed, Dec 2, 2015 at 11:40 AM, Steven Gill > wrote: > > > Issue for deprecation: https://issues.apache.org/jira/browse/CB-10121 > > > > Cc'ed Archana to see if she has any concerns. > > >

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414060 @infil00p if a third party plugin declares the permission in their plugin.xml so that is inserted into the manifest, then you get a SecurityException

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414408 In the developer reference: http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions --- If your project is set

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416812 BTW: Do we have a third-party plugin that asks for Camera? And if a Third-Party plugin is asking for the CAMERA permission, shouldn't they have their

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414891 @riknoll Yeah, but that's a problem that should be in the docs, and not in this code. --- If your project is set up for it, you can reply to this

Re: [DISCUSS] Deprecate cordova-wp8

+1 On Wed, Dec 2, 2015 at 11:32 AM Steven Gill wrote: > +1 > > On Wed, Dec 2, 2015 at 11:06 AM, Jesse wrote: > > > We've talked about it for awhile, but never moved on it. cordova-wp8 has > > been a work horse that seen us through tough times

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423854 riknoll, Sounds alright. I would also check camera and storage permissions separately in case someone will approve one of them, but deny the other.

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/349 Cb 9590 - Ubuntu support for the new plugin naming convention Re-opening the pull request with hopefully a better fix that can handle all situations. You can merge this pull

[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...

Github user vincipop commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-161224895 @vladimir-kotikov, I tried out #94 and it works for me. Perfect, thanks ! --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161450864 @vladimir-kotikov is the issue that Android saves the date in a different format from other platforms? If that is the case, I guess the greater issue is

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161447751 @sencenan Sure, go ahead and submit a new PR. Tag both JIRA's in the commit message (CB-10093 and CB-9960) if you don't mind. --- If your project is

[GitHub] cordova-cli pull request: Removing the '--usegit' flag from `cordo...

Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/229#issuecomment-161460255 related pull request: https://github.com/apache/cordova-lib/pull/350 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/350 Removing the '--usegit' flag from `cordova platform`. The recommended method is to use `cordova platform add git_url#branch`. You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46483328 --- Diff: src/android/ContactAccessorSdk5.java --- @@ -1854,6 +1859,38 @@ public boolean remove(String id) { return (result > 0)

RE: Where to download Cordova shell tools?

Robert, I think you have some wonderful suggestions for making the documentation better. Could we request to send in pull request for the changes that you have outlined - this way, others could benefit from your input even more. It may be a while before existing committers may be able to get

Re: [GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

The issue is that the date object is not stored in a method that is compatible with other applications on the android device. This is strictly a native issue, and as Vlad said, not testable via our own automated tests. We get back exactly what we store, so our current tests all pass. The native

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

GitHub user jasongin opened a pull request: https://github.com/apache/cordova-lib/pull/351 CB-10125: Android build fails on read-only image files Ensure image files are writeable before trying to delete them. I considered an alternative: ensuring files are writeable after

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/176#issuecomment-161500951 I've already pulled in this change, it's in the Apache git repos and somehow it hasn't mirrored yet:

[GitHub] cordova-docs pull request: Update index.md

GitHub user h2ospace opened a pull request: https://github.com/apache/cordova-docs/pull/434 Update index.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/h2ospace/cordova-docs patch-1 Alternatively you can review and apply

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

Github user sencenan closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [DISCUSS] Deprecate cordova-wp8

+1, I updated my device as soon as I could and all people I know that had WP8 did the same 2015-12-03 3:38 GMT+01:00 Parashuram N : > I am in the process of getting number of folks from VS who may be using > WP8. These numbers should be able to add more data to this

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161523938 Making a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [DISCUSS] Deprecate cordova-wp8

I am in the process of getting number of folks from VS who may be using WP8. These numbers should be able to add more data to this decision. On 12/2/15, 4:05 PM, "Tommy Williams" wrote: >+1 > > > >> On Dec 3 2015, at 10:47 am, Tim Barham tim.bar...@microsoft.com

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

GitHub user sencenan opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/143 [CB-10093][CB-9960][android] fix error resolving content uri to file url fixing: https://issues.apache.org/jira/browse/CB-10093 Different app returns different uri. This is

RE: [DISCUSS] Release file-transfer, media and media-capture

Indeed. This also applies to all packages, not just to plugins. -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Tuesday, December 1, 2015 8:49 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Release file-transfer, media and media-capture +1 on specifying

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/350#issuecomment-161461873 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/350#issuecomment-161462802 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/349#discussion_r46494465 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,54 @@ function toCamelCase(str) { }).join(''); }

RE: [DISCUSS] Deprecate cordova-wp8

Oh yes please :). -Original Message- From: Anis KADRI [mailto:anis.ka...@gmail.com] Sent: Thursday, December 3, 2015 5:58 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Deprecate cordova-wp8 +1 On Wed, Dec 2, 2015 at 11:32 AM Steven Gill wrote: > +1 > >

Re: [DISCUSS] Deprecate cordova-wp8

+1 > On Dec 3 2015, at 10:47 am, Tim Barham tim.bar...@microsoft.com wrote: > > Oh yes please :). > > \-Original Message- From: Anis KADRI [mailto:anis.ka...@gmail.com] Sent: Thursday, December 3, 2015 5:58 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Deprecate

[GitHub] cordova-cli pull request: Removing the '--usegit' flag from `cordo...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161466199 We really need to get all this file reading code in one place for Android. The camera plugin does things a bit differently (see

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

Github user zanemcca commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161468650 @asfgit @stevengill When is the 4.0.0 release expected to be on NPM with this fix? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user ochakov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161470590 Added both fixes to this PR Camera permission will not be required unless android.permission.CAMERA is set in the package. BTW, barcode scanner

Re: [DISCUSS] cordova-ios-4.x release (for real)

Marked the two known failures as pending. Now everything is green (and yellow) across the board for UIWebView and WKWebView. On Tue, Dec 1, 2015 at 11:49 PM, Jesse wrote: >>> Or should I just let it fail still? > It depends how long it'll be until we fix them. The build

Re: [NOTICE] David Barth has become a committer

Thanks everyone for the kind welcome messages. Yeah, Ubuntu is here, either as a host platform for cordova-android or as a target with cordova-ubuntu (desktop, device or as a converged platform). So let me know if you have questions or issues you'd like me to look at. David On Wed, Dec 2, 2015

[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...

Github user aliokan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-161247566 @riknoll I create a JIRA issue and change patch name and increase z-index value. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161247540 @dblotsky, updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#discussion_r46394555 --- Diff: README.md --- @@ -217,6 +217,10 @@ function specified by the __contactSuccess__ parameter. - Windows 8 - Windows

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161241738 > Is this bug saying that the method can't find phone numbers from linked contacts, or that it can't find phone numbers at all? I

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46402705 --- Diff: src/android/ContactAccessorSdk5.java --- @@ -451,7 +452,13 @@ else if

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161271526 I think this is not possible to cover this issue with our automated tests, because, strictly speaking, the plugin code stores and reads

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana wrote: > David do we need to have the CB-9618 fix in cordova-lib before continuing > vote? > Not strictly speaking. You can manage to prep, build and run an app on Ubuntu if you add some symlinks or fake icon file to pass the

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161286724 @dblotsky, could you please review once more? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

Github user MarsupiL commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161456736 +1 for resolving this issue. I am using the ng-cordova plugin to pick contacts and almost every contact in my contact book is linked, which

[GitHub] cordova-cli pull request: Removing the '--usegit' flag from `cordo...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/229 Removing the '--usegit' flag from `cordova platform`. The recommended method is to use `cordova platform add git_url#branch` You can merge this pull request into a Git repository by running:

[GitHub] cordova-lib pull request: CB-10108 Fixes android frameworks instal...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/348 CB-10108 Fixes android frameworks installation/removal This fixes [CB-10108](https://issues.apache.org/jira/browse/CB-10108) You can merge this pull request into a Git repository by

Re: [DISCUSS] cordova-ios-4.x release (for real)

Also, check footnote 3 above. Yes, WebKit defines window.openDatabase but it doesn't do anything. Not sure why their tests didn't catch this... (see footnote for the bug) With CSP off to rule things out: XHR to yourself of course works, but doesn't really make sense for real-world use. XHR to a

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user nicoabie commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161486476 Sorry for not being explicit enough, I made a fork of the inappbrowser code and applied this pull request. I'm using XWalk and debuggind the code

Re: [DISCUSS] cordova-ios-4.x release (for real)

Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in the PR comments that the changes can go in to cordova-ios-4.x: https://github.com/apache/cordova-ios/pull/176 On Wed, Dec 2, 2015 at 5:38 PM, Shazron wrote: > Also, check footnote 3 above. > > Yes, WebKit