[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/95 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: CB-10108 Fixes android frameworks instal...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

Github user snstarosciak commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161878128 @ghenry22 Oh man, this is great! I'll try this all out and let you know how it goes. I appreciate you nudging me into the right direction for stuff to

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46653820 --- Diff: tests/tests.js --- @@ -31,9 +31,11 @@ exports.defineAutoTests = function () { var ONE_SECOND = 1000; // in

[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/241 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161548065 @dblotsky, as @purplecabbage mentioned, there is no way to cover this by autotests, because from JS perspective everything works well - we

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161549915 @dblotsky, this replaces #77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161597318 @riknoll, other platforms (iOS, Windows) don't try to resolve relative paths. Instead they expect image path/URI to be absolute. Probably we

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161633720 @MarsupiL, app crash due to missing permissions, while accessing linked contacts already has been fixed in

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

Github user nicoabie commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161656697 Thanks @Sinistralis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161725537 @vladimir-kotikov That sounds good to me! I agree we should be handling `file://android_asset` URIs --- If your project is set up for it, you can

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46581788 --- Diff: src/windows/FileTransferProxy.js --- @@ -49,6 +49,17 @@ function nativePathToCordova(path) { return

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46582720 --- Diff: README.md --- @@ -230,6 +230,10 @@ __Parameters__: - Download requests is being cached by native implementation.

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

Github user david-barth-canonical commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/349#discussion_r46569876 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,54 @@ function toCamelCase(str) { }).join(''); }

[GitHub] cordova-plugin-camera pull request: [iOS] Returns a specific error...

Github user nleclerc commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/24#issuecomment-161702527 Hi, sorry to resurrect an old thread but i'm having trouble with this modification. When users click cancel in camera interface, we get a `has no

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

Github user zanemcca commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161746193 @stevengill Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161748614 @ochakov I'll do some testing, but this looks pretty good! In the meantime, can you fill out an Apache ICLA? There are instructions for doing so

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161746483 The mention of BackgroundUploader/Downloaded in the Windows quirks section confused me a bit. At first, I thought they were some options we

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-161756979 @vladimir-kotikov can you check this one out? Looks simple enough, but iOS is not my forte. --- If your project is set up for it, you can reply to

[iOS] Github mirror is not mirroring

https://issues.apache.org/jira/servicedesk/agent/INFRA/issue/INFRA-10889 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

Shouldn't that be just pinned versions in package.json ? Can you share the install issues you had. I can compare and adjust quickly with a couple LXD containers. On Thu, Dec 3, 2015 at 7:03 PM, Carlos Santana wrote: > We should check into git repo node_modules > while

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/176 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [NOTICE] David Barth has become a committer

There is an emulator : see https://wiki.ubuntu.com/Touch/Emulator for reference. The trick for testing on a device is to either have an old Nexus 4 around, or get a BQ or Meizu pre-installed. On Wed, Dec 2, 2015 at 3:40 PM, Carlos Santana

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/142#discussion_r46596545 --- Diff: src/android/CameraLauncher.java --- @@ -178,7 +181,7 @@ else if ((this.srcType == PHOTOLIBRARY) || (this.srcType ==

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46598691 --- Diff: src/android/ContactAccessorSdk5.java --- @@ -1854,6 +1859,39 @@ public boolean remove(String id) { return (result >

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46598813 --- Diff: src/android/ContactAccessorSdk5.java --- @@ -1854,6 +1859,39 @@ public boolean remove(String id) { return (result >

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161811902 I agree the file path handling code probably should be centralized in the platform lib for each platform. But it should be done as part of a broader

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161817573 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9964 - Add --template to create comma...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-9964 Make --copy-from use --template ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Cordova-cli doesn't work with node 5

Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: Cordova-cli doesn't work with node 5

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-cli/pull/228#issuecomment-161818866 @unimonkiez Open a JIRA issue if node 5 having issues in your use cases, latest cli works with node 4 and 5 --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/351#issuecomment-161805351 Thanks @jasongin, found the references. I was using github to perform search, I now realize it was a bad idea. --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/351#issuecomment-161808443 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Cb 9964

Github user dubeejw closed the pull request at: https://github.com/apache/cordova-cli/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46627985 --- Diff: tests/tests.js --- @@ -31,9 +31,11 @@ exports.defineAutoTests = function () { var ONE_SECOND = 1000; // in

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

Github user sencenan commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-161787751 @riknoll that's my finding too with regard to ExifInterface class. I do think copying the image could be a viable solution like @purplecabbage said.

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161745773 @zanemcca it is on npm, just not set to latest until we release cordova 6.0.0 cordova plugin add cordova-plugin-file@4.0.0 --- If your

Re: [VOTE] cordova-ubuntu 4.3.1

The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill David Barth Carlos Santana The vote has passed. I will now publish to dist and npm. On Thu, Dec 3, 2015 at 10:02 AM, Carlos Santana wrote: > I vote +1 > verify tags > verify archive >

[GitHub] cordova-docs pull request: CB-9964 - Add --template to online docu...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/432#issuecomment-161821043 Was this PR stale? Is the change invalid? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/349#issuecomment-161826181 Thanks - LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Von Miss Esther Desmond.

Von Miss Esther Desmond. Mein Lieber, Ich hoffe, dieser Mail trifft man gut, lassen Sie mich bitte zu mir selbst vorstellen, ich bin Fräulein Esther Desmond die Tochter des verstorbenen Herrn und Frau Michael Desmond von der Elfenbeinküste. Wer war ein berühmter Kakaohändler hier in Abidjan

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161733972 @dblotsky, @jasongin, I've addressed the CR notes and also added a few fixes for the last commit changed the timeouts - please take a look. ---

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

We should check into git repo node_modules while recreating the archive I saw differences, I think this was due to the npm version I used. But adding from git is broken, since git doesn't node_modules (i.e. shelljs, and others) But this should not stop the release since the dist archive contains

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

GitHub user nleclerc opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/144 [iOS] Fixed authorization error when user clicks cancel in image selector view. I'm resurrecting a change from [an old pull

Re: [NOTICE] David Barth has become a committer

Thanks David, cool to see that an Emulator is available On Thu, Dec 3, 2015 at 3:05 PM David Barth wrote: > There is an emulator : see https://wiki.ubuntu.com/Touch/Emulator > for reference. > > The trick for testing on a device

Re: [DISCUSS] Deprecate cordova-wp8

+1 Focusing on Universal and more doc around leveraging native is a good strategy On Thu, Dec 3, 2015 at 2:33 AM julio cesar sanchez wrote: > +1, I updated my device as soon as I could and all people I know that had > WP8 did the same > > 2015-12-03 3:38 GMT+01:00

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161844312 @snstarosciak I'm not going to be much help to you on this one unfortunately. The media plugin is for audio and my app only plays audio not video so I

Re: [DISCUSS] cordova-ios-4.x release (for real)

+1 let's move forward this items with WKWebview I don't see holding up the platform. Don't see any changes going on the platform, if any they will go into the pluggable webview plugin or creating new plugin to handle. On Wed, Dec 2, 2015 at 8:40 PM Shazron wrote: > Regarding

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/351#issuecomment-161728837 Where is this method called from ? cordova-android ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: [DISCUSS] CLI Templates

I will be working later today with James from my team on merging initial implementation of --template. it will update a few repos (cli, lib, doc) Anyone oppose? On Fri, Nov 13, 2015 at 1:50 PM Carlos Santana wrote: > alias, deprecate and later remove > > On Fri, Nov 13,

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/351#issuecomment-161730103 @omefire It is called during the prepare phase when building android. See more info including stack trace in the CB-10125 JIRA issue. --- If your project is set

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-161732640 Copy the image to an app accessible temp location and return that url. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

Github user snstarosciak commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-161729984 @ghenry22 Hellooo sir. I know this isn't really the appropriate place to ask this question, but it was the only way I knew I could contact you and

Re: [VOTE] cordova-ubuntu 4.3.1

I vote +1 verify tags verify archive recreated archive, with some minor differences in node_modules with no impact to functionality On Wed, Dec 2, 2015 at 3:26 PM David Barth wrote: > +1 > > On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill >

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/143#issuecomment-16175 @purplecabbage @sencenan I agree that getting the file path out of a content URI is becoming too convoluted to be sustainable. Getting the InputStream

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161745285 @vladimir-kotikov makes sense to me! Thanks for the clarification! --- If your project is set up for it, you can reply to this email and have your