[VOTE] Cordova windows 4.3.1 release

2016-02-01 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this cordova-windows 4.3.1 release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10495 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10495

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51469779 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...

2016-02-01 Thread zhangkaizhao
GitHub user zhangkaizhao opened a pull request: https://github.com/apache/cordova-docs/pull/477 Execute jekyll in the context of the bundle Execute jekyll in the context of the bundle because jekyll is installed by bundle here. You can merge this pull request into a Git repository

Re: help running android native tests

2016-02-01 Thread Carlos Santana
Hi Tony your I tried your PR and now tests pass. I will merge it in On Fri, Jan 29, 2016 at 9:37 PM Homer, Tony wrote: > I thought about the test some more and looked at what happens when a > missing file is loaded. > Normally CordovaActivity shows a dialog that exits

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178139856 @dblotsky I think that medic-log and medic-run are both performed in the same directory (I got the `getLocaLCLI()` function from medic-run). See [this

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178145536 @dblotsky addressed the synchronous `exec` calls --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51471937 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-android pull request: fix HtmlNotFoundTest so that it pass...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178125278 @nikhilkh sorry for the delay, addressing the code review now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

2016-02-01 Thread dubeejw
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/372 CB-10499 - --template should pull the latest template from NPM when version isn't specified - Pull the latest template if no version is specified You can merge this pull request into

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51471311 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...

2016-02-01 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/47#issuecomment-178261450 lgtm! If only we could get rid of all the @'s ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/372 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-178228435 For reference, [this](https://github.com/apache/cordova-plugin-camera/commit/929733b8913311f2cfd504937268a8a1d22f4f9a) is the commit I mentioned. ---

[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Sitemap Improvements

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/472#issuecomment-178262039 @nikhilkh The plugin does not support adding custom URIs to the sitemap, and extending it took more effort than just writing a templated config.xml. --- If your

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

2016-02-01 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/160 CB-10270 android: Added back support for file:// URIs to getRealPath Our `getRealPath()` function is unable to handle `file: //` URIs, which can occasionally lead it to return an

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

2016-02-01 Thread csantanapr
GitHub user csantanapr opened a pull request: https://github.com/apache/cordova-lib/pull/373 CB-10499 - --template should pull the latest template from NPM when version isn't specified - Pull the latest template if no version is specified - Rename NPM to npm

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/373 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Steven Gill
Hey Vlad! This looks great! You are using istanbul for code coverage it seems. Why did you remove spec-cordova in your pr? Your [2] I think it is a great idea to include this in our repos. It would be nice to track our coverage and work on improving it. Though I do believe it is important not

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Jesse
This looks good, as a metric to add. What is the impact to our workflow? are we just adding a node dependency, or are there other config/integration parts that we need to do? @purplecabbage risingj.com On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill wrote: > Hey Vlad! >

Re: [VOTE] Cordova windows 4.3.1 release

2016-02-01 Thread Jesse
+1 - ran coho audit-license-headers - ran coho check-license - ran coho verify-archive - created project and added/ran platform, smoke test @purplecabbage risingj.com On Mon, Feb 1, 2016 at 12:46 PM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Please review and vote on this

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/73#discussion_r51514684 --- Diff: medic/medic-log.js --- @@ -69,18 +70,72 @@ function logBlackberry() { return; } -function logIOS() { -var

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/464#issuecomment-178269844 @nikhilkh that is a difficult bug to fix because it relies on knowing that all children of "Architecture" also don't have any URIs. It will start to have some

Re: Cordova iOS build how to enable DEBUG for #ifdef DEBUG in CDVDebug.h

2016-02-01 Thread Shazron
I'm sure you realize this is an Xcode thing. As such, Google offers lots of info: http://stackoverflow.com/questions/1540322/xcode-setting-gcc-preprocessor-definitions-for-different-build-configurations by default when you build it builds for the Debug config, which has this macro set. If you do

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/369#discussion_r51511432 --- Diff: cordova-common/src/superspawn.js --- @@ -113,11 +139,15 @@ exports.spawn = function(cmd, args, opts) {

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178305625 Overriding an implementation's logging with your own sounds like a roundabout way to get what you need. This sounds like it's exposing internal events for the

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178318882 I tried this on my machine and I ran into an issue where it couldn't find the deployed simulator because there were other non-deployed simulators installed. Is

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/74#issuecomment-178267638 Does this need to be fixed? It's an intermittent connectivity issue and already gets polled, so if some polls fail it's not a problem. --- If your project is

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/73#discussion_r51514920 --- Diff: medic/medic-log.js --- @@ -69,18 +70,72 @@ function logBlackberry() { return; } -function logIOS() { -var

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/73#discussion_r51514960 --- Diff: medic/medic-log.js --- @@ -69,18 +70,72 @@ function logBlackberry() { return; } -function logIOS() { -var

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178333571 @dblotsky I'm not sure; I copied `cordova run's logic for choosing the emulator. This does not support choosing a specific simulator, just the default. I'll look

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178267393 @riknoll: The value returned by `getLocalCLI()` is used after `shell.pushd()` is called [here][pushd] to get into the `mobilespec` app directory in `medic-run`,

Re: [DISCUSS] Cordova-Ubuntu Release

2016-02-01 Thread Steven Gill
Hey David, I think you need to add your gpg key to dist/keys Can you run through https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg.md up to the point of adding your key to dist/keys? I was trying to verify your archive and ran into it not being able to find the public key.

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178293314 @dblotsky no problem; we need to be in a cordova project for that command (`cordova run --list`) to work anyway, so I'll just call `pushd` here as well. Thanks

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/73#discussion_r51515589 --- Diff: medic/medic-log.js --- @@ -69,18 +70,72 @@ function logBlackberry() { return; } -function logIOS() { -var

Re: Cordova iOS build how to enable DEBUG for #ifdef DEBUG in CDVDebug.h

2016-02-01 Thread Shane MacPhillamy
Thank you Shazron. > On 2 Feb 2016, at 12:23 PM, Shazron wrote: > > I'm sure you realize this is an Xcode thing. As such, Google offers > lots of info: > http://stackoverflow.com/questions/1540322/xcode-setting-gcc-preprocessor-definitions-for-different-build-configurations >

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178308453 @dblotsky updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178308498 Why not return the stdout and stderr objects on which calling code can subscribe to the `"data"` events directly? --- If your project is set up for it, you can

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

2016-02-01 Thread Carlos Santana
Julio I tested on my iPad Air 2 used ios@4.0.1 the buttons show up, buttons work, I can do splitview no crashes On Mon, Feb 1, 2016 at 10:36 AM julio cesar sanchez wrote: > cordova should support launch storyboards > https://issues.apache.org/jira/browse/CB-7521 >

RE: [DISCUSS] Cordova windows 4.3.1 release

2016-02-01 Thread Sergey Grebnov (Akvelon)
+1 -Sergey -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Saturday, January 30, 2016 1:23 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova windows 4.3.1 release Hi all We're planning to do a patch release of cordova-windows

[GitHub] cordova-docs pull request: Do not escape markdown code for relativ...

2016-02-01 Thread mikrobi
GitHub user mikrobi opened a pull request: https://github.com/apache/cordova-docs/pull/476 Do not escape markdown code for relative links The links were not clickable. The markdown code was just shown in plaintext. You can merge this pull request into a Git repository by running:

[GitHub] cordova-windows pull request: CB-10487 WindowsStoreIdentityName sh...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-docs/pull/471#issuecomment-177849723 @riknoll, +1, makes sense --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-file pull request: Fix/file locations for Chrome

2016-02-01 Thread davetayls
Github user davetayls commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/159#issuecomment-177888223 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/143#issuecomment-177913909 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-inappbrowser pull request: CB-6702 InAppBrowser han...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...

2016-02-01 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser pull request: CB-10441 Add auto tests ...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-10441 Add auto tests ...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/142#issuecomment-177913876 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/370 CB-10430 Allow to modify events source This fixes [CB-10430](https://issues.apache.org/jira/browse/CB-10430). This change is needed to allow other tools to replace default

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/369 CB-10052 Expose child process' io streams via promise progress notification This implements [CB-10052](https://issues.apache.org/jira/browse/CB-10052). The `superspawn.spawn`

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

2016-02-01 Thread Carlos Santana
I have an iPad that supports multitasking but it's at home, I can test it tonight if no one else have gotten to it first You said "cordova doesn't officially support multitasking yet" Do you have a JIRA item describing what would be necessary to have support? On Sun, Jan 31, 2016 at 5:15 PM

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

2016-02-01 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738 For what version is this for? cordova-windows@5.0.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

2016-02-01 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/147#issuecomment-178059859 This will be a breaking change, so yes, probably for cordova-windows@5. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-02-01 Thread Titoine
Github user Titoine commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-177920211 I'm testing it with the developper option "Don't keep activities" and this isn't working everytime. After a camera camera getPicture, I get the

RE: [DISCUSS] inAppBrowser plugin release

2016-02-01 Thread Sergey Grebnov (Akvelon)
Does anyone have any reason to delay InAppBrowser 1.2.1. patch release? If not, I will start the release tomorrow. To be released: General: CB-10428 Fix syntax error when browserifying inAppBrowser plugin Android: CB-10407 InAppBrowser not firing loadstart event on android CB-6702

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

2016-02-01 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240 I've taken a look too, and I agree this seems the best approach. Changes look good to me, except I agree with your comment @sgrebnov that we should use a

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser bugfixing o...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Prefer .bat over .cmd on windows platfor...

2016-02-01 Thread pbakondy
GitHub user pbakondy opened a pull request: https://github.com/apache/cordova-lib/pull/371 Prefer .bat over .cmd on windows platform Fixes ant-running issue on windows platform. Originally I wanted to build android platform with ant: ``` cordova build android

[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/369#discussion_r51532148 --- Diff: cordova-common/src/superspawn.js --- @@ -113,11 +139,15 @@ exports.spawn = function(cmd, args, opts) {

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Vladimir Kotikov (Akvelon)
> What is the impact to our workflow? are we just adding a node dependency, or > are there other config/integration parts that we need to do? The only thing, required from our side is to replace `npm test` (or the command, that executes jasmine tests) witn `npm run cover` in Travis

[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...

2016-02-01 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178404256 Ah sorry @fattalgazi - I just fixed this and missed that you already had a PR open. Fixed now in #161. --- If your project is set up for it, you can

[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...

2016-02-01 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-178412993 Thanks for this @aliokan. I've tweaked the commit a bit to store the magic number in a constant, and I'll merge it. --- If your project is set up for

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-01 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178414449 Yeah, I too am not entirely behind this. It seems like an anti-pattern here, and a consequence of require('../events') only being executed once per

[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178421841 Returning data instead of raw eventEmitter is IMO just less complex for caller API, because you, as a caller, do not need to create handlers, subscribe,

[GitHub] cordova-plugin-camera pull request: CB-10502 Fix camera plugin exc...

2016-02-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Sitemap Improvements

2016-02-01 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/472#issuecomment-178340343 Fair enough - let's get it in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-camera pull request: CB-10502 Fix camera plugin exc...

2016-02-01 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/161 CB-10502 Fix camera plugin exception in Chrome when click capture. The `MediaStream.stop()` method has been deprecated as of Chrome 47. We were using it, and it was generating an

[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...

2016-02-01 Thread magnusburton
Github user magnusburton commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/133#issuecomment-178395468 Looks great! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...

2016-02-01 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/368#issuecomment-178344384 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

2016-02-01 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/464#issuecomment-178351575 Could you comment "Architecture" and it's sub-sections? We might not get to write these topics till April or something. It's best to not to have empty

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

2016-02-01 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/73#issuecomment-178123204 @riknoll What's required to get this merged in? Let's try to get this asap as without this we don't understand why cordova-ios is failing:

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-02-01 Thread adamduren
Github user adamduren commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-178123878 @Titoine I experienced this as well. I thought it was a device specific bug but it was resolved by attaching the listeners as soon as possible. --- If

[DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Vladimir Kotikov (Akvelon)
Hey, guys I've spent a couple of hours and have a prototype of how we can visualize, track and analyze code coverage for our repos. Here is the fork of cordova-lib repo integrated with codecov.io [1] (notice the coverage badge at the top of README), and a PR with some coverage metrics [2]. The

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

2016-02-01 Thread julio cesar sanchez
cordova should support launch storyboards https://issues.apache.org/jira/browse/CB-7521 https://issues.apache.org/jira/browse/CB-9161 and "Requires full Screen" should be configurable, right now is set to true (this is the JIRA item that set it to true

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

2016-02-01 Thread biasmv
Github user biasmv commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-178005303 Thanks for taking a look! I agree that it would be better to use relative paths. At the moment, csproj files are also referenced using absolute paths, so one

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

2016-02-01 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/147 CB-10480 Remove Windows 8 template from cordova-windows [Jira issue](https://issues.apache.org/jira/browse/CB-10480) You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2016-02-01 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-178109811 @Titoine you may be seeing a known issue in the fix (see [CB-10498](https://issues.apache.org/jira/browse/CB-10498)). Basically, it is possible in some