[GitHub] cordova-lib pull request: CB-10611 fixed the before_plugin_install...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10611 fixed the before_plugin_install...

2016-02-15 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/388#issuecomment-184563301 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-10550 Fixed the issue of plugin id ma...

2016-02-15 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/387#discussion_r52976299 --- Diff: cordova-lib/src/plugman/fetch.js --- @@ -132,10 +132,14 @@ function fetchPlugin(plugin_src, plugins_dir, options) { ));

[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...

2016-02-15 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-windows pull request: CB-10622 Fix targetsize images being...

2016-02-15 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/148#issuecomment-184521979 Hey @andorman, the PR's source and destination branches are incorrect - you can see there are many unrelated commits/changes here. --- If your project is

Re: [DISCUSS] Cordova-common 1.1.0 release

2016-02-15 Thread Steven Gill
Yes. I'd like us to go ^1.0.0 and include minors. Just need to be careful when doing minor common releases to not break platforms. On Feb 15, 2016 8:11 PM, "Carlos Santana" wrote: > Should we be consistent about how we declare the dependency for platforms > against

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2016-02-15 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/9#issuecomment-184513731 Wew lad. I think I just had a heart attack... I don't really know where to begin to answer your question. The whitelist addition borked years

[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...

2016-02-15 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/9#issuecomment-184509346 Can you open a JIRA for this change, and the reasoning behind? What is content:// for? Why do you think this have to be added by

Re: [DISCUSS] Cordova-common 1.1.0 release

2016-02-15 Thread Carlos Santana
Should we be consistent about how we declare the dependency for platforms against cordova-common ? On Mon, Feb 15, 2016 at 11:04 PM Steven Gill wrote: > Sounds good. > > Cordova-lib, Cordova-android and cordova-ios will need to have releases > with this updated

Re: [DISCUSS] Cordova-common 1.1.0 release

2016-02-15 Thread Steven Gill
Sounds good. Cordova-lib, Cordova-android and cordova-ios will need to have releases with this updated cordova-common. cordova-windows won't as it has the dependency listed as ^1.0.0 which includes minor releases. On Mon, Feb 15, 2016 at 6:29 AM, Vladimir Kotikov (Akvelon) <

Re: Android and iOS bug release

2016-02-15 Thread Carlos Santana
Tomorrow is my birthday, I will take them as gifts :-) On Mon, Feb 15, 2016 at 10:55 PM Steven Gill wrote: > Yeah, I can start these releases. Hopefully tomorrow. > > -Steve > > On Mon, Feb 15, 2016 at 7:46 PM, Carlos Santana > wrote: > > > +1 > >

Re: Android and iOS bug release

2016-02-15 Thread Steven Gill
Yeah, I can start these releases. Hopefully tomorrow. -Steve On Mon, Feb 15, 2016 at 7:46 PM, Carlos Santana wrote: > +1 > Steve would you mind doing these bug release? > > Should we wait to see what happens with the ios freeze bug [1],? or just do > a bug release now,

Re: [DISCUSS] Update to starter template

2016-02-15 Thread Carlos Santana
I'm always in favor of having simple answers and guidelines, and we can take this as a good convention/practice "Always bind/attach after deviceready even and you will be in a happy place" But between you and me you know that we can attach before, will leave that little secret between us :-)

Re: Android and iOS bug release

2016-02-15 Thread Carlos Santana
+1 Steve would you mind doing these bug release? Should we wait to see what happens with the ios freeze bug [1],? or just do a bug release now, and then do another later when that one is resolved and keep the train going [1] : https://issues.apache.org/jira/browse/CB-10530 On Mon, Feb 15, 2016

Re: [DISCUSS] Update to starter template

2016-02-15 Thread Parashuram N
The reason to say that all events are fired after device ready is just to make it simpler. As you say, events by webviews are indeed fired before that, but I think it is safe to say that if we attach listeners after deviceready, we are guaranteed to have the plugins also initialized. This makes

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

2016-02-15 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-docs/pull/493#issuecomment-184499148 Sorry I'm late to this one, It looks like @stevengill already review. Just some dumb questions 1. What impact this has to translation process?

Re: [DISCUSS] Update to starter template

2016-02-15 Thread Carlos Santana
Why do you think that binding is required after "deviceready" ? Attaching before "deviceready" fires is still supported for events like resume, pause, offline, online, etc.. At least that's always being my impression for a long time The only thing I would think it could be a potential confusion

[GitHub] cordova-lib pull request: CB-10235 Added clearer error message for...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/379 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-splashscreen pull request: CB-10606 fix deprecation...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-globalization pull request: CB-10605 fix deprecatio...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/493 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: Android and iOS bug release

2016-02-15 Thread Dan Polivy
Is there any progress on an android bugfix release? It looks like Richard's PR has been merged in, and I'm waiting for that (and the fix for CB-10138) to be pushed out in a production release. Thanks, Dan -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent:

[GitHub] cordova-windows pull request: CB-10622 Fix targetsize images being...

2016-02-15 Thread andorman
GitHub user andorman opened a pull request: https://github.com/apache/cordova-windows/pull/148 CB-10622 Fix targetsize images being ignored Only "scale" images were properly recognized, targetsize icons were ignored. You can merge this pull request into a Git repository by running:

[GitHub] cordova-lib pull request: Master

2016-02-15 Thread andorman
GitHub user andorman opened a pull request: https://github.com/apache/cordova-lib/pull/391 Master You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-lib master Alternatively you can review and apply these changes as

[GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: Cordova http request

2016-02-15 Thread Joe Bowser
Is the Android TV Emulator connected to the Internet? The error is indicating that it can't resolve the URL, which tells me that the emulator is probably not working correctly. If you can't get DNS resolution, that's the first thing to check. On Sat, Feb 13, 2016 at 7:07 PM, Kevin Palmer

Cordova http request

2016-02-15 Thread Kevin Palmer
I am working on an android TV project with the android emulator. Im really at a loss here. I simply cannot get a http request to work with cordova on the android tv emulator. I tried all the recommendations on your website. Ive also scoured the internet and adjusted the whitelisting of the

[GitHub] cordova-lib pull request: CB-10621 fix for amazon-fireos

2016-02-15 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-lib/pull/390 CB-10621 fix for amazon-fireos For android specific code include test for amazon-fireos platform as well. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: Fix FileHelper / port cordova-...

2016-02-15 Thread TanaseButcaru
GitHub user TanaseButcaru opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/170 Fix FileHelper / port cordova-plugin-filepath-unofficial and replace getRealPath with it I recently encountered the ``FileNotFoundException ouputModifiedBitmap`` error while

[GitHub] cordova-plugin-camera pull request: separate FILE_URI and NATIVE_U...

2016-02-15 Thread TanaseButcaru
GitHub user TanaseButcaru opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/169 separate FILE_URI and NATIVE_URI / take in account user defined destType Right now, on Android, ``FILE_URI`` and ``NATIVE_URI`` returns the path with ``content://`` scheme,

[GitHub] cordova-plugin-wkwebview-engine pull request: Support the scroll d...

2016-02-15 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/4 Support the scroll deceleration speed preference. Adds a new preference `WKWebViewDecelerationSpeed`, but will safely fall back to the `UIWebViewDecelerationSpeed` for

[GitHub] cordova-plugin-globalization pull request: CB-10605 fix deprecatio...

2016-02-15 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/44#issuecomment-184342462 Thanks @jcesarmobile. I'll merge it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-splashscreen pull request: CB-10606 fix deprecation...

2016-02-15 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/82#issuecomment-184342200 Thanks @jcesarmobile. I'll merge it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-10618 Do not call prepBuildFiles for ...

2016-02-15 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/389 CB-10618 Do not call prepBuildFiles for cordova-android@>=5.2.0 An implementation for [CB-10618](https://issues.apache.org/jira/browse/CB-10618) This PR disables calling

[GitHub] cordova-android pull request: CB-10618 Handle gradle frameworks on...

2016-02-15 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/259 CB-10618 Handle gradle frameworks on plugin installation/uninstallation An implementation for [CB-10618](https://issues.apache.org/jira/browse/CB-10618) This PR brings

[GitHub] cordova-docs pull request: Update about easing of Apple IOS restri...

2016-02-15 Thread karandeepmalik
GitHub user karandeepmalik opened a pull request: https://github.com/apache/cordova-docs/pull/501 Update about easing of Apple IOS restrictions for testing IOS Apps on… … Devices For testing out apps on devices, you are no longer required to necessarily sign in to

[GitHub] cordova-ios pull request: fix formating issues from pull request 1...

2016-02-15 Thread benconnito
GitHub user benconnito opened a pull request: https://github.com/apache/cordova-ios/pull/192 fix formating issues from pull request 191 You can merge this pull request into a Git repository by running: $ git pull https://github.com/benconnito/cordova-ios master Alternatively

[DISCUSS] Cordova-common 1.1.0 release

2016-02-15 Thread Vladimir Kotikov (Akvelon)
Hi, guys. I'm planning to do a minor release for cordova-common. Here is the list of JIRAs to be resolved in this release (aka RELEASENOTES): * CB-10052 Improve superspawn to allow to handle spawned process io streams * CB-10176 Cordova-common should contain a default logger implementation *

[GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...

2016-02-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/70#issuecomment-184211059 @sarangan12, LGTM, thank you for updating the PR! A few notes: - Could you please add a fallback for

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

2016-02-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/385#issuecomment-184180642 Added [CB-10616 Cover browserify scenario with tests](https://issues.apache.org/jira/browse/CB-10616). --- If your project is set up for it, you can reply to this

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

2016-02-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-globalization pull request: CB-10605 fix deprecatio...

2016-02-15 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/44#issuecomment-184175201 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-splashscreen pull request: CB-10606 fix deprecation...

2016-02-15 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/82#issuecomment-184167577 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Buildbot: buildslave cordova-windows-slave was lost

2016-02-15 Thread buildbot
The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Mon Feb 15 10:38:43 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

2016-02-15 Thread biasmv
Github user biasmv commented on the pull request: https://github.com/apache/cordova-windows/pull/139#issuecomment-184110837 That's fantastic! Thanks for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your