Sure, I can send it this weekend.
2016-02-18 18:49 GMT+01:00 Joe Bowser :
> Cool, want to send a PR so we can get this resolved? I tried string
> manipulation, but for some reason it didn't work.
>
> On Thu, Feb 18, 2016 at 1:22 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> >
Github user alejandromagnorsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/51#issuecomment-186101074
I confirm that THIS plugin unexpectedly disabled another background
geolocation plugin I'm using.
But @mauron85 fork (cordova-plugin-ge
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/496#discussion_r53429424
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -216,11 +220,13 @@ platform. See [Icons and Splash Screens](images.html)
for more information.
Github user tripodsan commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/496#discussion_r53429286
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -58,7 +58,8 @@ platform. See [Icons and Splash Screens](images.html) for
more information.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-186081564
We could also add a Travis build step verifying that the `npm run gen-docs
> TEMP_README.md` equals `README.md`.
---
If your project is set up for it, y
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-186075786
@dblotsky, docs generation will run automatically as a pre-commit hook but
you need to do `npm install` first. I agree this is not very intuitive though,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/152#issuecomment-186026434
1. Why does running the script manually print repeatedly? Is that a use
case?
2. What is the 2-second delay for? It doesn't wait on Ctrl-C if the script
wa
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/152#issuecomment-186026681
I just realized that a lot of my above comments apply to the logging script
in general, not to this specific fix. This fix seems to work, so it LGTM. Only
one
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-186021548
Thanks @jcesarmobile for commenting we wanted someone to review it before
we took it out.
@eymorale looks like it's OK to go ahead and remov
I like the idea. I suggest starting small and expanding as necessary. Right now
the two most important pieces of information that I think our PRs could use are:
Did you sign the ICLA? [ ] Yes / [ ] No
Related JIRA: CB-[ ]
Kindly,
Dmitry
-Original Message-
From: Carlos Santana [mailt
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/496#discussion_r53415988
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -216,11 +220,13 @@ platform. See [Icons and Splash Screens](images.html)
for more information.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/496#discussion_r53415915
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -58,7 +58,8 @@ platform. See [Icons and Splash Screens](images.html) for
more information.
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-186017788
Thanks @mhartington for testing you were able to recreate very easy in your
setup.
---
If your project is set up for it, you can reply to this email and have yo
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/508#issuecomment-186014176
@stevengill just removing code that's not needed anymore. The search box at
the top basically obsoletes it.
---
If your project is set up for it, you can reply t
I agree, Running tests as easy as npm install && npm run config && npm test
:-)
On Thu, Feb 18, 2016 at 4:40 PM Nikhil Khandelwal
wrote:
> I think for plugins, platform name should be required as part of title of
> the PR and commit message in addition to JIRA number.
>
> Checklist:
> [ ] Test
Github user thomasMary commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-186005928
Works for me. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/507#issuecomment-185996114
Merged
[here](https://github.com/apache/cordova-docs/commit/f8e4b8b8ee0c9f0a8afef27a7d9a9c48b9274d36).
---
If your project is set up for it, you can reply to thi
Github user rakatyal closed the pull request at:
https://github.com/apache/cordova-docs/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/508#issuecomment-185993325
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/508#issuecomment-185991371
Looks fine to me.
I don't know the context behind the change though.
---
If your project is set up for it, you can reply to this email and have your
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/508
Removing keyword index.
It has been replaced by search.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs no-keyword
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/508#issuecomment-185980598
@rakatyal @stevengill please review when you have a moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/507#issuecomment-185978070
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/507#discussion_r53397157
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -1,21 +1,37 @@
-- name: "Overview"
-url: "guide/overview/index.html"
-# - name: "Ar
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/507#discussion_r53396702
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -1,21 +1,37 @@
-- name: "Overview"
-url: "guide/overview/index.html"
-# - name: "Ar
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/507
CB-10336: Adding platform and plugin guides and other articles to TOC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-
Github user mhartington commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-185951944
Same here, couldn't get anything to break for me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user dpogue commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-185951530
:+1: from me. I have not seen the splashscreen hanging bug while testing
this branch.
---
If your project is set up for it, you can reply to this email and have you
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53392433
--- Diff: www/_data/redirects.yml ---
@@ -6,6 +6,8 @@ general:
# redirects paths relative to /docs/XX/
docs:
+- {old: "dev/guide
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53392250
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
- {old: "guide_plugin-development_blackberry10_index.md.html", new:
"gu
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53391759
--- Diff: www/_data/redirects.yml ---
@@ -6,6 +6,8 @@ general:
# redirects paths relative to /docs/XX/
docs:
+- {old: "dev/guide
Github user jamessharp closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user jamessharp commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/47#issuecomment-185945597
Scrap that - no it doesn't - more work needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-185941604
@daserge thanks for pointing that out. I made the change in the source.
However, this was not a very intuitive process. Can this be done automatically?
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/233#issuecomment-185939263
Merged here: 6b090dcf50da26ede6e9e642bd74bf2c9f7caa41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-cli/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
I think for plugins, platform name should be required as part of title of the
PR and commit message in addition to JIRA number.
Checklist:
[ ] Tests that were added or run for a new feature/regressions
[ ] Does the new feature broadly apply to multiple platforms?
We probably need to make it eas
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/80
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/394#discussion_r53380925
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -48,11 +48,17 @@ function getPlatformApi(platform, platformRootDir) {
var PlatformApi;
GitHub user jamessharp opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/47
Fix for CB-10288
The statusbar plugin was causing some weird sizing issues when multitasking
on ipads etc. I think this fixes it.
You can merge this pull request into a Git rep
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-windows/pull/152
CB-10640: Windows logging is broken
**Issue**
In the current system, the logs which are collected in the events must be
listed in the CI logs is broken. For example, if there is a sy
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53368735
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
- {old: "guide_plugin-development_blackberry10_index.md.html", new:
"gui
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53367760
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
- {old: "guide_plugin-development_blackberry10_index.md.html", new:
"gui
Not intentionally on my end, but when I add the CrossWalk plugin I
seem to get two APKs as output (one for armv7, one for x86).
On 18 February 2016 at 11:05, Joe Bowser wrote:
>
> Hey
>
> Based on the feedback on those two issues, and other places, I think that
> most hated change from Cordova-An
Might want to check with CrossWalk plugin, I think they generate multiple
APKs but is good to check if they depend on cordova for this or they handle
on their own.
On Thu, Feb 18, 2016 at 2:05 PM Joe Bowser wrote:
> Hey
>
> Based on the feedback on those two issues, and other places, I think th
Hey
Based on the feedback on those two issues, and other places, I think that
most hated change from Cordova-Android 4.0 that we didn't fix in
Cordova-Android 5.0 was the fact that we have an undocumented way of
generating an arbitrary build number that makes absolutely no sense.
Furthermore, this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-185850104
@TimBarham thanks for the review; I'll update the PR in a bit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53358585
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/**
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/471#discussion_r53357772
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
# Android Plugins
This sectio
Cool, want to send a PR so we can get this resolved? I tried string
manipulation, but for some reason it didn't work.
On Thu, Feb 18, 2016 at 1:22 AM, julio cesar sanchez wrote:
> I already answered on CB-10625
>
> When android 4.4 broke input type file support I wrote a plugin at work to
> use
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/260#issuecomment-185830008
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/83#issuecomment-185826893
@dhams, Travis CI has been setup for Device plugin as of now, so you can
disregard the CI message.
---
If your project is set up for it, you can re
Hello,
Travis CI has been enabled for all the plugins recently in order to run JSHint
[1] validation.
.travis.yml setup has been done and merged for cordova-plugin-device as of now,
other plugins will be updated soon.
[1]: https://issues.apache.org/jira/browse/CB-10636
Please let me know if
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-185819372
Is this fixing a regression in behavior from previous versions? Let's make
sure we label the associated JIRAs as such.
---
If your project is set up for it, you c
Big plus one to Jesse's comment. I've felt like the template is too
over complex for quite some time.
On Tue, Feb 16, 2016 at 3:21 PM, Ryan J. Salva wrote:
> Check out the default template we use in TACO-CLI.
>
> Index.js is a lot simpler and we adopted the new Cordova typeface. If folks
> like
Github user aaront commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-185781196
JIRA link: https://issues.apache.org/jira/browse/CB-10645
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user aaront opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/31
CB-10645 The battery status handler doesn't reinitialize on Android after
window.location.reload()
Instead of throwing an error, rather remove the status handler and
re-initial
Hey, guys.
I've opened a PR that adds a message about deprecation. Could anybody please
review that?
The only question I wanted to know your opinion on is where we should print
this message. In the PR above cordova-lib will show it each time when polyfill
is instantiated and this might be ann
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185747825
The return value of `Q.then(thePromise)` is the same as for `thePromise()`
due to its' (promise) nature, so i think there is nothing changed for caller.
-
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/394
CB-10644 Adds deprecation message about old platforms support removal
JIRA: [CB-10644](https://issues.apache.org/jira/browse/CB-10644)
You can merge this pull request into a Git reposi
I am trying to commit some code in Splashscreen plugin . but its giving
error like
"Travis can suddenly not find .travis.yml even though it exists"
while I try to submit the pull request..
Can someone plz tell me how to add .travis.yml file where to add this ?
--
Thank you
Dharmendra sharma
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-185729885
Yep, that looks right to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185719821
Oops, sorry :smile: ... LGTM. There's nowhere we call these directly
internally and expect an actual value in return?
---
If your project is set up for it, you c
Thanks for the reply Parashuram. I hadn't looked at ManifoldJS but now
that I have I don't think that's the route I want to take, for my use case
a least. The plugin was quite helpful. This was what I was looking for on
the iOS side:
https://github.com/manifoldjs/ManifoldCordova/blob/master/src
Github user dhams commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/83#issuecomment-185711822
trying to correct travis-ci issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dhams closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/145
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-185703790
@TimBarham, could you please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185703661
@TimBarham, ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user dhams opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/83
Give option for Splashscreen spinner cancelable event
Added option to choose user whether they want cancelable dialog or not
while loading splashscreen.
I added preference `
`
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/260#issuecomment-185698067
@nikhilkh, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/173#discussion_r53307265
--- Diff: src/windows/CameraProxy.js ---
@@ -19,7 +19,7 @@
*
*/
-/*jshint unused:true, undef:true, browser:true */
+/*
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/173
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull https://
I agree shrinkwrap is better technical, it was just buggy in the past and now I
think is more stable.
Also in the past there was a debate if the shrinkwrap goes in git, as it
confuse some committers when they updated a dependency in package.json then npm
install nothing got updated, why? becau
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305903
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305804
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305710
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Frederico
I didn't want unnecessary pressure on anyone to work on a bug by putting a
release on hold.
I spent some time with Mike from Ionic and I was not able to reproduce or make
heads or tail out of this bug.
I'm glad to hear progress on the bug, thanks to Torsten and Shaz :-)
- Carlos
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305319
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304887
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304649
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/260#issuecomment-185680615
Worked on this with @vladimir-kotikov - there is a way to solve this using
`require.cache` but it looks like an overkill for this case.
Decided to require `
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/393
CB-10641 Run prepare _after_ plugins were installed
This is a fix for
[CB-10641](https://issues.apache.org/jira/browse/CB-10641) and
[CB-10586](https://issues.apache.org/jira/browse/C
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53302711
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301932
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301382
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null;
}
+
+/*
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300652
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300300
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300134
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53299072
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298695
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function getInst
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298645
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function getInst
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53297519
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -492,17 +492,13 @@ function list(hooksRunner, projectRoot, opts) {
var platforms_on_fs = c
I already answered on CB-10625
When android 4.4 broke input type file support I wrote a plugin at work to
use a file picker instead.
For google Photos I use this code:
if (isGooglePhotosUri(uri))
return uri.getLastPathSegment();
Where isGooglePhotosUri is
public static boolean
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185598264
+1
In addition, it's not consistent with other platforms. Android is the only
one that shows this warning.
We should encorage users to use
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53283872
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -74,190 +67,123 @@ There are two ways to download Xcode:
Once Xcode is installed,
I don’t have a strict opinion about dynamic vs static dependencies, but IMO if
we want to pin the version of every subdependency, shrinkwrap is better than
bundling. At least it would be less prone to human errors (missing packages'
files, line endings in subpackages - we'd ran into all of this
99 matches
Mail list logo
