[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-188131082 @dblotsky ouch. That's clearly a bug. It shouldn't do that. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-statusbar pull request: CB-10636 CB-10683 Add JSHin...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/49 CB-10636 CB-10683 Add JSHint for plugins [CB-10636 Add JSHint for plugins](https://issues.apache.org/jira/browse/CB-10636) [CB-10683 Fix wrong StatusBar.isVisible initial value

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

Github user adyz commented on the pull request: https://github.com/apache/cordova-ios/pull/193#issuecomment-188126958 Works for me too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

RE: Android and iOS bug release

Sorry, yes. I'll send out votes for both tomorrow. Android can be a patch I believe. IOS we will have to review. -Steve On Feb 23, 2016 6:26 PM, "Nikhil Khandelwal" wrote: > Where are we with releases here? Can we still do a patch release (not > requiring a TOOLS

Re: Hamronize CFBudleIndtifier

Oops. My +1 was for removing them in this case. But I don't have a issue with keeping them either. Let's see what Shaz says when he manages to feel better. He has been sick the last few days. On Feb 23, 2016 6:39 PM, "Tobias Bocanegra" wrote: > On Tue, Feb 23, 2016 at 4:16 PM,

Re: Hamronize CFBudleIndtifier

On Tue, Feb 23, 2016 at 4:16 PM, Steven Gill wrote: > +1 +1 to what? keep the prefixes or remove them? :-)) regards, toby > > On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez > wrote: > >> +1 to prefixed versions >> >> I always use the same

RE: Android and iOS bug release

Where are we with releases here? Can we still do a patch release (not requiring a TOOLS update)? Looks like there is also this JIRA: https://issues.apache.org/jira/browse/CB-10493 which is causing iOS apps to be rejected. Thanks, Nikhil -Original Message- From: Carlos Santana

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53878681 --- Diff: appium-tests/android/android.spec.js --- @@ -1,28 +1,34 @@ -/*jslint node: true, plusplus: true */ +/*jshint node: true */

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/177#issuecomment-187991977 Thanks for fixing some of the grammar errors in the comments, btw! --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53877650 --- Diff: appium-tests/android/android.spec.js --- @@ -1,28 +1,34 @@ -/*jslint node: true, plusplus: true */ +/*jshint node: true */

Re: Hamronize CFBudleIndtifier

+1 On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez wrote: > +1 to prefixed versions > > I always use the same bundle identifier/package name for the same app, but > I sometimes have to use a different version for the android or iOS app, so > it's better if I can

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53862395 --- Diff: gulpfile.js --- @@ -210,9 +213,9 @@ gulp.task("watch", ["serve"], function () { ); gulp.watch( [ -

[GitHub] cordova-docs pull request: Adding latest redirects for platform gu...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Adding latest redirects for platform gu...

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/518#issuecomment-187937121 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53852122 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-187914846 @alsorokin those other commands print only new messages continuously. The Windows script prints existing messages over and over again, which is a different

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53848875 --- Diff: appium-tests/android/android.spec.js --- @@ -1,28 +1,34 @@ -/*jslint node: true, plusplus: true */ +/*jshint node: true */

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53848104 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/517#issuecomment-187898038 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/518#issuecomment-187897554 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

Github user rpayanm commented on the pull request: https://github.com/apache/cordova-ios/pull/193#issuecomment-187893848 :+1: Works for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/518#issuecomment-187893217 Alright. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-windows/pull/152#issuecomment-187893159 @dblotsky when I was writing this code, I made continuous logging the default behavior because the log script for Android platform is continuously printing

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/518#issuecomment-187892982 Might as well add comments for all the platform guides while you're here. For iOS and Android, it's just switching the dev redirects to latest redirects --- If

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/518 Adding latest redirects for windows guide @dblotsky, @riknoll to review. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: Making windows guide single page

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/512#discussion_r53843320 --- Diff: www/_data/redirects.yml --- @@ -13,6 +13,8 @@ docs: - {old: "dev/guide/platforms/ios/config.html", new:

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53843179 --- Diff: gulpfile.js --- @@ -210,9 +213,9 @@ gulp.task("watch", ["serve"], function () { ); gulp.watch( [ -

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53843081 --- Diff: gulpfile.js --- @@ -210,9 +213,9 @@ gulp.task("watch", ["serve"], function () { ); gulp.watch( [ -

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53842863 --- Diff: gulpfile.js --- @@ -24,6 +24,8 @@ var uglify = require("gulp-uglify"); var envify = require("envify"); var htmllint =

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53842656 --- Diff: gulpfile.js --- @@ -24,6 +24,8 @@ var uglify = require("gulp-uglify"); var envify = require("envify"); var htmllint =

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53842352 --- Diff: gulpfile.js --- @@ -249,7 +252,14 @@ gulp.task("regen", ["jekyll"], function () { }); gulp.task("fetch", function (done) {

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/516#discussion_r53842391 --- Diff: gulpfile.js --- @@ -236,7 +239,7 @@ gulp.task("serve", ["build"], function () { }); }); -gulp.task("build",

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53842147 --- Diff: www/_data/fetched-files.yml --- @@ -1,153 +1,146 @@ +# REFERENCE ENTRY: +# +# - +# src:

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53841732 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53841393 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53840883 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/363#issuecomment-187874856 Fixed jasmine tests and created a JIRA for this ([CB-10679](https://issues.apache.org/jira/browse/CB-10679)) --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/363#discussion_r53838895 --- Diff: cordova-lib/src/cordova/util.js --- @@ -185,6 +187,22 @@ function listPlatforms(project_dir) { }); } +function

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53838196 --- Diff: appium-tests/android/android.spec.js --- @@ -295,13 +318,35 @@ describe('Camera tests Android.', function () {

[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...

Github user accomplix commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-187867060 Tested and working ! Thanks, this is a life saver. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user sarangan12 commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/517#discussion_r53834939 --- Diff: www/_data/toc/de-dev-manual.yml --- @@ -25,12 +25,12 @@ - name: "Windows" url:

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/517#discussion_r53833896 --- Diff: www/_data/toc/de-dev-manual.yml --- @@ -25,12 +25,12 @@ - name: "Windows" url:

[GitHub] cordova-android pull request: CB-10680 Expose useHttpAuthUsernameP...

GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-android/pull/262 CB-10680 Expose useHttpAuthUsernamePassword in ICordovaHttpAuthHandler You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: Making windows guide single page

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/512#discussion_r53826023 --- Diff: www/_data/redirects.yml --- @@ -13,6 +13,8 @@ docs: - {old: "dev/guide/platforms/ios/config.html", new:

[GitHub] cordova-plugin-camera pull request: Create Pictures directory if i...

GitHub user TheBosZ opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/178 Create Pictures directory if it doesn't exist. Possibly should throw an exception if the directory can't be created. A log message is emitted and behavior is no worse than current

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/516 Improve gulp watch perf and add --nofetch option Improves by reducing the set of files that we watch. Also, 'watch' was broken because of fetching behavior resulting an endless watch -

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/516#issuecomment-187806485 @riknoll @dblotsky --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53814811 --- Diff: www/_data/fetched-files.yml --- @@ -1,153 +1,146 @@ +# REFERENCE ENTRY: +# +# - +# src:

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53814215 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53813916 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-docs pull request: Docs fetching improvements

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/514#discussion_r53813684 --- Diff: tools/bin/fetch_docs.js --- @@ -25,42 +25,103 @@ var child_process = require("child_process"); var yaml = require("js-yaml");

[GitHub] cordova-docs pull request: Fixed Typo: ccordova to cordova

GitHub user Samshal opened a pull request: https://github.com/apache/cordova-docs/pull/515 Fixed Typo: ccordova to cordova You can merge this pull request into a Git repository by running: $ git pull https://github.com/Samshal/cordova-docs patch-1 Alternatively you can

[GitHub] cordova-plugins pull request: Fix Keyboard Shrink View without Acc...

Github user kaynz commented on the pull request: https://github.com/apache/cordova-plugins/pull/14#issuecomment-187738268 up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Hamronize CFBudleIndtifier

+1 to prefixed versions I always use the same bundle identifier/package name for the same app, but I sometimes have to use a different version for the android or iOS app, so it's better if I can set them directly from the config.xml and not use a hook. 2016-02-23 7:54 GMT+01:00 Tobias Bocanegra

[GitHub] cordova-lib pull request: New plugin version selection implementat...

Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/363#issuecomment-187701057 Other than one small remaining question, looks great! Thanks @riknoll! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

Github user michschu commented on the pull request: https://github.com/apache/cordova-ios/pull/193#issuecomment-187600116 Not having a problem with _cordova-plugin-splashscreen 3.1.0 "Splashscreen"_ However _cordova-plugin-inappbrowser 1.2.1 "InAppBrowser"

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/511#discussion_r53748431 --- Diff: www/_data/toc/en-dev-manual.yml --- @@ -25,12 +25,12 @@ - name: "Windows" url:

[GitHub] cordova-docs pull request: Making windows guide single page

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/512#discussion_r53748270 --- Diff: www/_data/redirects.yml --- @@ -13,6 +13,8 @@ docs: - {old: "dev/guide/platforms/ios/config.html", new: