[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203159625 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Buildbot: buildslave cordova-windows-slave was lost

The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Tue Mar 29 23:02:35 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The

Buildbot: buildslave cordova-osx-slave was lost

The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Tue Mar 29 22:36:41 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The

[GitHub] cordova-docs pull request: Adding both Chinese versions.

Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/569#discussion_r57813112 --- Diff: www/.htaccess --- @@ -18,29 +18,31 @@ RewriteEngine on # pages to new pages. # 302 (temp): -# docs ->

[GitHub] cordova-android pull request: CB-10963: Handle overlapping permiss...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203137750 Is there any reason to specify the upper bound? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: Inclusion of Evothings Studio on https://cordova.apache.org/

Hey, While the discussion on including additional tools is still happening on the mailing list, I had a quick question about the Evothings Studio. I was looking at the website and it was not clear if the tool is based on Cordova/Phonegap. Is Evothiongs based on Cordova and are the device APIs

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203131675 Also I couldn't understand the reason for creating a new testproj directory. Couldn't we have used the existing DummyProject repo for this? --- If your

RE: [DISCUSS] Curating Apps

I think it would not be fair to say "submissions now closed", since we had never initially mentioned such a timeframe for submitting apps. The question is, if more folks submit apps, what is the policy on accepting them ? -Original Message- From: Dmitry Blotsky

RE: Adding Examples for Plugins in the ReadMe

I agree that we should not call these tests yet - they are just showcases/examples. Let me ask if the folks contributing the example are ok with contributing them to an Apache repo. The only hesitation they may have is that some of these examples may include services from a specific company,

RE: Cordova for browser extensions

We do not have platforms that are specific for browser-extensions. Browser extensions in themselves may not blend well with the "plugin model" or don't really need a "bridge", two of the key things that Cordova provides. Also, most modern browsers have "similar" ways to build extensions, so I

[GitHub] cordova-docs pull request: Adding both Chinese versions.

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/569#discussion_r57806664 --- Diff: www/.htaccess --- @@ -18,29 +18,31 @@ RewriteEngine on # pages to new pages. # 302 (temp): -# docs ->

[GitHub] cordova-plugin-contacts pull request: CB-10881 Add extra logging t...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media pull request: CB-10783: Media Plugin - Modify...

Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/89#issuecomment-203122183 Locally always... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request: Adding both Chinese versions.

Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/569#issuecomment-203118863 @rakatyal @riknoll ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-contacts pull request: CB-10881 Add extra logging t...

GitHub user omefire opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/111 CB-10881 Add extra logging to gather more information about tests behavior You can merge this pull request into a Git repository by running: $ git pull

[CI] Status for 03/29

Hey folks, Here is the CI status for last week. Sorry that I missed sending it yesterday! Build Status (# of test failures): 3 - Android on Windows 3 - Android on OS X 13 - iOS 0 - WP 8.1 0 - Windows JIRAs that need attention: - CB-10944: NoSuchMethodError in InAppBrowser plugin - CB-10933:

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-203109141 So, I've done a bit of testing on Marshmallow and it seems like this works pretty well. It does have the caveat of returning a `content://` URI, but that

[GitHub] cordova-plugin-statusbar pull request: CB-10884 Inappbrowser break...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/53#issuecomment-203104592 LGTM The bug I told you about on slack was already present, it's not caused by this code. I'll file a new issue for it. --- If your

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57799518 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57799378 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var

[GitHub] cordova-plugin-camera pull request: Update plugin.xml

Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/199#issuecomment-203098986 I believe we do actually require that permission even in API level 19+. The current code requires access to the photos directory, which is outside of the

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57798321 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -441,40 +451,47 @@ describe('windows project handler', function () { });

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57797833 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -164,6 +164,7 @@ describe('windows project handler', function () { }

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57797472 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -305,17 +306,25 @@ describe('windows project handler', function () { var

Re: [DISCUSS] cordova-windows patch release

Can you merge and include CB-10927 [1] ? [1]: https://github.com/apache/cordova-windows/pull/163 On Tue, Mar 29, 2016 at 10:47 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Hi all > > We'd like to do a cordova-windows patch release to fix the following > issues: > *

Re: Does Cordova have a problem making developers happy?

I did, but as my reply said, it wasn't showing up. Regards *Rob Posener* 0419 012 627 On 30 March 2016 at 05:01, Jesse wrote: > Good observations Julio, we should definitely talk to stack-overflow about > the merged tags. > > Robert, you didn't send the pull request

Re: [DISCUSS] Curating Apps

I put apps and tools in the same bucket when it came to adding them to the site. I interpreted our last discussion as, “we’ve gotten enough; close the submissions now”. If we’re cool to still add this tool, then let’s just add it. Kindly, Dmitry On Mar 29, 2016, at 7:53 AM, julio cesar sanchez

Re: Does Cordova have a problem making developers happy?

Good observations Julio, we should definitely talk to stack-overflow about the merged tags. Robert, you didn't send the pull request back to cordova/cordova-discuss, so no one could see it. I have done so here: https://github.com/cordova/cordova-discuss/pull/35 @purplecabbage risingj.com On

Cordova for browser extensions

Is it possible to create browser extensions with Cordova? > cordova platform add safari-extension > cordova platform add chrome-extension > cordova platform add explorer-extension Best, Tim ᐧ

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/59#discussion_r57764840 --- Diff: src/android/Capture.java --- @@ -250,13 +304,17 @@ private static void createWritableFile(File file) throws IOException {

Re: Adding Examples for Plugins in the ReadMe

Calling these 'tests' to me is way out of scope, and very easily broken. Adding a demo project to a plugin makes sense from both a development perspective AND a demonstration perspective. When developing, you need something to actually exercise the api you are writing, so putting this in the repo

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/59#issuecomment-203012656 LGTM. Don't be afraid to delete conditionals that check for things that are below the minimum supported API. --- If your project is set up for

[GitHub] cordova-plugin-media-capture pull request: Removing global state a...

Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/59#discussion_r57764130 --- Diff: src/android/Capture.java --- @@ -250,13 +304,17 @@ private static void createWritableFile(File file) throws IOException {

[GitHub] cordova-plugin-file pull request: CB-10977 android: Removing globa...

Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57762270 --- Diff: src/android/FileUtils.java --- @@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long size) throws

[GitHub] cordova-plugin-file pull request: CB-10977 android: Removing globa...

Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57761716 --- Diff: src/android/FileUtils.java --- @@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long size) throws

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-202988290 ping @rakatyal can you review this PR and merge if its good --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-camera pull request: Update plugin.xml

GitHub user mehmetcodes opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/199 Update plugin.xml In principle Cordova should not use a permission where it is no longer relevant as it might leave things less secure. You can see this documentation

Re: [DISCUSS] Curating Apps

I meant rejecting because it was an old PR and it was rejected now. But even if there is no button, people can still send PRs. It's less likely, but still possible. And as most of the topic here was about apps, I wanted to know if we have an official statement for tools. So, if I review this

[DISCUSS] cordova-windows patch release

Hi all We'd like to do a cordova-windows patch release to fix the following issues: * CB-10845 Invalidate manifest cache in prepare (a4c673e3) * CB-10714 Ignore case for --archs (49812d44) * CB-10138 Adds missing plugin metadata to plugin_list module for Windows (45e5bd13) The proposed

[VOTE] Tools release attempt 2

Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10980 Both tools have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10980 The packages were

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

Github user mikaelkindborg commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-202922042 @jcesarmobile Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Adding Examples for Plugins in the ReadMe

"With great power comes great responsibilities" Adding this would require responsibilities of maintenance and up to date working examples backed up with CI. In other words it's good idea to add docs with more complex examples on how to use the plugin, some of them already are located in

Re: [DISCUSS] Curating Apps

Julio "rejecting" sounds so harsh Since we removed the "add app" and "add tool" from the webpage, there is no process to submit something to be accepted or rejected I think right now my opinion is that a PMC member would need to do the leg work to review, propose something to be added, and do

[GitHub] cordova-plugin-statusbar pull request: CB-10884 Inappbrowser break...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/53 CB-10884 Inappbrowser breaks UI while Screen orientation changes from… … landscape to portrait on iOS [Jira issue](https://issues.apache.org/jira/browse/CB-10884) You

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-202902395 We are still discussing it, we'll let you know when something is decided. --- If your project is set up for it, you can reply to this email and have your

Re: [DISCUSS] Curating Apps

I bring the topic back again because recently a tool was rejected and the author mailed us asking (and we have not answered him yet) So, are we rejecting tools too? The original topic was "[DISCUSS] Curating Apps" and all the messages were about apps, except this one from Steve that mentions

RE: [Vote] Tools Release

The vote has failed. I will start a new VOTE thread soon - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, March 25, 2016 4:59 PM To: dev@cordova.apache.org Subject: Re: [Vote] Tools Release I vote -1 I think this is a critical

RE: 6.1.0 (cordova-lib@undefined) ?

Created a jira for cordova-common removal from lib package: CB-10981 Cordova-lib should not bundle cordova-common anymore (https://issues.apache.org/jira/browse/CB-10981) - Best regards, Vladimir -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Friday, March

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

Github user mikaelkindborg commented on the pull request: https://github.com/apache/cordova-docs/pull/410#issuecomment-202873303 @dblotsky Hi, I emailed the dev list as you suggested, but got no response as far as I can tell. Note that this pull request is not the app showcase, but

Re: [DISCUSS] Tools Release CLI/LIB 6.1.1

I agree, we can discuss later the release for cordova-commons - Carlos @csantanapr > On Mar 29, 2016, at 7:27 AM, Vladimir Kotikov (Akvelon) > wrote: > > Carlos, I've reviewed and merged these PRs. However the only two PRs that > need to be included into this release

Re: Does Cordova have a problem making developers happy?

Joe said: "I also find it interesting that people are hating on Cordova, and not PhoneGap, Ionic, Taco or the other distributions." It's curious that Ionic has it's own tag, with about the same number of questions that Cordova tag, but it's not on any of the lists (and it's not because all Ionic

RE: [DISCUSS] Tools Release CLI/LIB 6.1.1

Carlos, I've reviewed and merged these PRs. However the only two PRs that need to be included into this release are #415 [1] and #416 [2]. The other two are for cordova-common and I guess we have nothing to do with them for now. Summarizing, the release notes for 6.1.1 will look like this: ###

[GitHub] cordova-plugin-splashscreen pull request: CB-10979 Fix splashscree...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/96 CB-10979 Fix splashscreen ios native tests Added jshintignore for tests/ios [Jira issue](https://issues.apache.org/jira/browse/CB-10979) You can merge this pull request

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/416#issuecomment-202818205 @csantanapr, i merged a bit different change, which uses `preparePlatforms` method instead of `prepare` .It is a subset of `prepare` but doesn't include

[GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10908 - Add a plugin with the --save ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-10965 xml helper allows multiple inst...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/417 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

Github user elsewhat commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/198#issuecomment-202773421 Pull request has been tested by debugging. The cordova-plugin-camera plugin was added to a local cordova project from my forked repository and the new

[GitHub] cordova-plugin-camera pull request: CB-10857 android : Camera.getP...

GitHub user elsewhat opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/198 CB-10857 android : Camera.getPicture return null for Google Drive (camera 2.1.1) FileHelper getRealPath will fallback to URI string if no other type of path has been found You

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/418#issuecomment-202768180 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/418#issuecomment-202764912 Addressed, thanks @vladimir-kotikov, please take a look when you have a moment. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-10622 Fix targetsize images being...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-10622 Support any MRT qualifiers ...

Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/159#issuecomment-202743738 Reviewed and verified on sample config/images :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-windows pull request: CB-10845 Invalidate manifest cache i...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/418#discussion_r57676830 --- Diff: cordova-common/spec/events.spec.js --- @@ -0,0 +1,30 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

Re: Does Cordova have a problem making developers happy?

I think I have created a discussion, but it is not showing up... yet another frustrations! Rob Regards *Rob Posener* 0419 012 627 On 29 March 2016 at 16:48, Parashuram N wrote: > I am not sure if everyone got the attachment. Rob, can I request you to > create an issue

[GitHub] cordova-plugin-file-transfer pull request: CB-10978 Fix file-trans...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: CB-10978 Fix file-trans...

GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/134 CB-10978 Fix file-transfer.tests JSHint issues [Jira issue](https://issues.apache.org/jira/browse/CB-10978) You can merge this pull request into a Git repository by running: