[GitHub] cordova-plugin-camera pull request: Update plugin.xml

2016-03-30 Thread mehmetcodes
Github user mehmetcodes commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/199#issuecomment-203739264 You mean to say if we compile, contrary to the docs API 19+ still demands this permission? Well, anyways what I can say is that I noticed tha

[GitHub] cordova-plugin-contacts pull request: Fix for the specs 26&27 to u...

2016-03-30 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/112#issuecomment-203714929 LGTM. I'll merge this tomorrow morning --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57990944 --- Diff: buildbot-conf/cordova-config.json.sample --- @@ -12,8 +12,8 @@ "appium": { "androidDeviceName": "Galaxy_Nexus",

[GitHub] cordova-plugin-contacts pull request: Fix for the specs 26&27 to u...

2016-03-30 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/112 Fix for the specs 26&27 to use the newly created contacts for removal test The newly created contact is not used for deletion. The removal logic still holds the reference to the

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

2016-03-30 Thread Shazron
I don't have opposition to it being in Tools if there is consensus. For randomization, right now it's all static and that's easy, but now we have to introduce *JavaScript* into the mix :^O On Wed, Mar 30, 2016 at 1:17 PM, Parashuram N wrote: > Thanks Mikael for the information. Others on the list

Re: [DISCUSS] cordova-ios release

2016-03-30 Thread Shazron
Thanks Edna - appreciated :) On Wed, Mar 30, 2016 at 8:15 AM, Edna Y Morales wrote: > Hi, > > I'd like to drive the release for cordova-ios 4.1.1. Does anyone have any > oppositions or any reason to wait? > > Thanks, > *Edna Morales* > > [image: Inactive hide details for Edna Y Morales---03/24/2

[GitHub] cordova-plugin-file-transfer pull request: Removing the expectatio...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: Removing the expectatio...

2016-03-30 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/135#issuecomment-203677753 Could you please refer to the JIRA number ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-plugin-file-transfer pull request: Removing the expectatio...

2016-03-30 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/135#issuecomment-203677537 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Re: [VOTE] Tools release attempt 2

2016-03-30 Thread Carlos Santana
I vote +1 coho verify-archive vote-6.1.1/cordova-6.1.1.tgz coho verify-archive vote-6.1.1/cordova-lib-6.1.1.tgz coho verify-archive vote-6.1.1/plugman-1.2.1.tgz verify tag for cordova-plugman 6.1.1 was not able to verify tags for lib and cli, no problem with release content and signatures, just

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203621399 @rakatyal Thanks for prompt review and working with @dubeejw :+1: --- If your project is set up for it, you can reply to this email and have your reply appe

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

2016-03-30 Thread Parashuram N
Thanks Mikael for the information. Others on the list, with this information, do we think that we should include this in our listing. While I do understand that we have a max limit and would not want the home page to be a place where we list a million tools, an option could be to separate tools

[GitHub] cordova-plugin-media pull request: README: add parameters type in ...

2016-03-30 Thread dannywillems
GitHub user dannywillems opened a pull request: https://github.com/apache/cordova-plugin-media/pull/90 README: add parameters type in error and status callback. Add parameters type in error and status callback. You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-file-transfer pull request: Removing the expectatio...

2016-03-30 Thread sarangan12
GitHub user sarangan12 opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/135 Removing the expectation in spec.34 for the transfer method to be called The expectation in this spec is causing the crash in the build process. The error message is "Expect

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203584731 Cool. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-splashscreen pull request: Show splashscreen everyt...

2016-03-30 Thread Panajev
Github user Panajev commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/95#issuecomment-203582719 @jcesarmobile Sorry for the early PR and for not really following all the steps of the process in the right order :/. **Signing** Goff M

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203582975 @rakatyal, I just copied the content from DummyProject to create the testProj. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57940423 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -419,6 +426,8 @@ describe('windows project handler', function () { var

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203562741 I see. Thanks for explaining. Just to make sure, from where did you copied the content to the proj and the solution files? --- If your project is set up for i

[GitHub] cordova-plugin-file pull request: CB-10977 android: Removing globa...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: Adding Examples for Plugins in the ReadMe

2016-03-30 Thread Jesse
Currently, 'Cordova plugin add local/path' will copy the entire contents of local/path to currentApp/plugins/new-plugin This is only true of local git clones and installs via githuburls. Npm installs should use .npmignore to exclude demo code inclusion. We should eventually make plugin install

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57907153 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -305,17 +306,25 @@ describe('windows project handler', function () { var fra

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57906698 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var dest

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on the pull request: https://github.com/apache/cordova-windows/pull/163#issuecomment-203483657 @rakatyal, the existing test fixtures could not be used because the paths to the framework references are no longer absolute, they are now relative to the Cordo

Re: [DISCUSS] cordova-ios release

2016-03-30 Thread Edna Y Morales
Hi, I'd like to drive the release for cordova-ios 4.1.1. Does anyone have any oppositions or any reason to wait? Thanks, Edna Morales From: Edna Y Morales/Durham/IBM@IBMUS To: dev@cordova.apache.org Date: 03/24/2016 09:41 AM Subject:Re: [DISCUSS] cordova-ios release bump to

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57905517 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var dest

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57905311 --- Diff: template/cordova/lib/PluginHandler.js --- @@ -85,12 +85,12 @@ var handlers = { var src = obj.src; var dest

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57904729 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -441,40 +451,47 @@ describe('windows project handler', function () { });

[GitHub] cordova-windows pull request: CB-10927 - Framework references in p...

2016-03-30 Thread dubeejw
Github user dubeejw commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/163#discussion_r57904108 --- Diff: spec/unit/pluginHandler/windows.spec.js --- @@ -164,6 +164,7 @@ describe('windows project handler', function () { }

[GitHub] cordova-android pull request: CB-10833 Reuse plugin installation l...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-android/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/408#issuecomment-203470641 This has been integrated as a part of #414, closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-10981 Remove cordova-common from bund...

2016-03-30 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/419 CB-10981 Remove cordova-common from bundled dependencies Since cordova-common has been released to NPM we do not need to bundle it into cordova-lib release packages. See [CB-10981](ht

[GitHub] cordova-lib pull request: CB-10833 Deduplicate platform-agnostic c...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-10833 Deduplicate platform-agnostic c...

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/414#issuecomment-203459332 @omefire, @daserge, thanks for reviewing. Rebased and going to merge --- If your project is set up for it, you can reply to this email and have your reply

Re: Adding Examples for Plugins in the ReadMe

2016-03-30 Thread Alexis Kofman
Hello all, +1 also. In my case I've added demo apps from the manual tests of my plugins. I thought it was a good location to permit users to easily "test" plugins. @purplecabbage, even if you have a demo folder in your plugins, it is just dowloaded by github users but not installed in their proje

Re: Adding Examples for Plugins in the ReadMe

2016-03-30 Thread Raymond Camden
Huge +1. This is an incredibly good idea. On Mon, Mar 28, 2016 at 4:47 PM, Parashuram N wrote: > Hey folks, > > At the moment, the sample code in our plugins is limited to only show basic > usage of the API. While this is great for someone who has already written > Cordova projects, I believe t

[GitHub] cordova-plugin-splashscreen pull request: Added new spinner style,...

2016-03-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/95#issuecomment-203421921 Thanks for this PB, but I think we should keep plugins simple and this PR add too many features and they are iOS only. Why does it need

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57871214 --- Diff: medic/medic-appium.js --- @@ -197,9 +214,10 @@ function parseArgs() { return options; } -function getLocalCLI(

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57862046 --- Diff: medic/medic-appium.js --- @@ -197,9 +214,10 @@ function parseArgs() { return options; } -function getLocalCLI() {

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57861718 --- Diff: medic/medic-appium.js --- @@ -197,9 +214,10 @@ function parseArgs() { return options; } -function getLocalCLI(

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57860875 --- Diff: lib/appium/helpers/wdHelper.js --- @@ -0,0 +1,112 @@ +/* jshint node: true */ +/* global navigator */ +/* + * + *

[GitHub] cordova-lib pull request: CB-10833 Deduplicate platform-agnostic c...

2016-03-30 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/414#discussion_r57860731 --- Diff: cordova-common/src/PluginManager.js --- @@ -0,0 +1,148 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/85#discussion_r57860571 --- Diff: lib/appium/helpers/wdHelper.js --- @@ -0,0 +1,112 @@ +/* jshint node: true */ +/* global navigator */ +/* + * + *

Re: Inclusion of Evothings Studio on https://cordova.apache.org/

2016-03-30 Thread Mikael Kindborg
Hi, Evothings is a tool that speeds up the development of Cordova apps, and provides plugins and libraries for IoT-functionality, notably Bluetooth Low Energy (BLE). Evothings Workbench is a tool you run on your computer. Code files can be edited in any editor and when a file is updated the curre

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

2016-03-30 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-203324738 Related PR to Medic: https://github.com/apache/cordova-medic/pull/85 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-medic pull request: Appium runner improvements

2016-03-30 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/85 Appium runner improvements * Changed ios device in appium config to match the emulator on osx slave * Added 'common' folder to the search paths for Appium runner * Save appium log

[GitHub] cordova-plugin-splashscreen pull request: Added new spinner style,...

2016-03-30 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/95#issuecomment-203286589 @Panajev, could you please rebase and force-push your PR to check the test/build status? --- If your project is set up for it, you can reply to thi

[GitHub] cordova-plugin-splashscreen pull request: CB-10979 Fix splashscree...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: CB-10884 Inappbrowser break...

2016-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th