[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216424469 @ktop Can you provide the steps you used to verify that this is working please? What I did was create a new project, and added the cordova-plugin-devi

[GitHub] cordova-docs pull request: Improving SEO for plugin api pages

2016-05-02 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/592#issuecomment-216418675 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-inappbrowser pull request: Enable thirdparty cookie...

2016-05-02 Thread hosikiti
GitHub user hosikiti opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/165 Enable thirdparty cookies on >=Android 5.0 device I added some codes to accept thirdparty cookies for >= Android 5.0 devices. Since Android Lollipop changed its thirdparty p

[GitHub] cordova-docs pull request: Improving SEO for plugin api pages

2016-05-02 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/592#issuecomment-216409900 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216402414 @afourney: Thanks. You should be able to access it with this change by platform.activationContext.detail.result. --- If your project is set up for it, you can

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread afourney
Github user afourney commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216401081 @rakatyal Understood. Tomorrow I'll try to reproduce what I was seeing before. In any case, detail.result *must* be cloned. The result object is undefined outs

[GitHub] cordova-docs pull request: Improving SEO for plugin api pages

2016-05-02 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/592#issuecomment-216400151 @nikhilkh @rakatyal take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-docs pull request: Improving SEO for plugin api pages

2016-05-02 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/592 Improving SEO for plugin api pages This changes all of our canonical links in docs to point to the pages at latest if available. It also adds redirects for all old versions of plugin pages to

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216400132 @afourney: Thanks for the info. I am a little skeptical of changing the way args were being passed since people might have been modifying the original object.

RE: Buildbot: buildslave cordova-osx-slave was lost

2016-05-02 Thread Mefire O .
Upgrade completed! Thanks, Omar Mefire -Original Message- From: Mefire O. [mailto:ommen...@microsoft.com] Sent: Monday, May 2, 2016 4:37 PM To: dev@cordova.apache.org Subject: Re: Buildbot: buildslave cordova-osx-slave was lost All, I’m currently upgrading the OS X slave from Yosemite t

Re: Buildbot: buildslave cordova-osx-slave was lost

2016-05-02 Thread Mefire O .
All, I’m currently upgrading the OS X slave from Yosemite to El Capitan. It will be back on once the update is completed. Thanks, Mefire > On May 2, 2016, at 3:45 PM, build...@apache.org wrote: > > The Buildbot working for '' > has noticed that the buildslave named cordova-osx-slave went away >

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread afourney
Github user afourney commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216389330 Also, my primary use case is launching an app via Cortana. (e.g., https://code.msdn.microsoft.com/windowsapps/Voice-Commands-Quickstart-64ce68ce/sourcecode?file

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread afourney
Github user afourney commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216389081 I was commenting on JIRA, sorry. I definitely needed to clone it when I submit the initial request. I spent a good amount of time debugging this issue.

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/173#discussion_r61818393 --- Diff: cordova-js-src/platform.js --- @@ -56,9 +57,9 @@ module.exports = { // OR cordova.require('cordova/platform').activationCo

Buildbot: buildslave cordova-osx-slave was lost

2016-05-02 Thread buildbot
The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Mon May 2 22:40:29 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://ci.apache.o

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216386708 @ogoguel: I guess I can pass the actual object as it is to platform.activationContext instead of cloning it. That should solve your use-case? --- If your pro

[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...

2016-05-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-216386608 I too am seeing @macdonst 's issue. ``` ... ``` --- If your project is set up for it, you can repl

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread ogoguel
Github user ogoguel commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216383571 +1 for that feature! A quick question though :how to pass the `platform.activationContext` back as a `WebUILaunchActivatedEventArgs` object to a C# Win

[GitHub] cordova-cli pull request: Telemetry

2016-05-02 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-cli/pull/247 Telemetry Work In Progress... You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-cli Telemetry Alternatively you can review an

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/173#discussion_r61789809 --- Diff: cordova-js-src/platform.js --- @@ -56,9 +57,9 @@ module.exports = { // OR cordova.require('cordova/platform').activat

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/173#discussion_r61787246 --- Diff: cordova-js-src/platform.js --- @@ -56,9 +57,9 @@ module.exports = { // OR cordova.require('cordova/platform').activationCo

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/173#discussion_r61786080 --- Diff: cordova-js-src/platform.js --- @@ -56,9 +57,9 @@ module.exports = { // OR cordova.require('cordova/platform').activat

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

2016-05-02 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-android/pull/295#issuecomment-216320625 I updated the PR based on feedback. As mentioned in the other comment I've kept the clean functionality, but it is now skipped when not invoked via the CLI.

[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...

2016-05-02 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-216319068 I updated the PR to use target creation times instead of modified-times. It works much better: it doesn't require the messy workaround on Windows and doesn't have

[CI] Status for 05/02/16

2016-05-02 Thread Sarangan Rajamanickam
Hi everyone, Here is the CI status for last week. Build Status (# of test failures): 2 - Android on Windows 1 - Android on OS X 15 - iOS 0 - WP 8.1 1 - Windows JIRAs that need attention: CB-11050: Flaky XHR tests on Windows Phone 8.1 CB-10475: iOS contacts permission modal causes contacts t

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-02 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-216315269 @riknoll It should skip HTML and JS changes. If not, this isn't really worth doing other than correctness. --- If your project is set up for it, you can rep

[GitHub] cordova-android pull request: CB-11117: Use FileUpdater to optimiz...

2016-05-02 Thread jasongin
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/295#discussion_r61776793 --- Diff: bin/templates/cordova/lib/prepare.js --- @@ -26,26 +26,43 @@ var AndroidManifest = require('./AndroidManifest'); var xmlHelpers = requ

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread jasongin
Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-216309577 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...

2016-05-02 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/173#discussion_r61774665 --- Diff: cordova-js-src/platform.js --- @@ -56,9 +57,10 @@ module.exports = { // OR cordova.require('cordova/platform').activationC

[GitHub] cordova-docs pull request: Removing NewVo from the app showcase

2016-05-02 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/591 Removing NewVo from the app showcase The linked website does not appear to exist anymore You can merge this pull request into a Git repository by running: $ git pull https://github.com/MS

[DISCUSS] TELEMETRY

2016-05-02 Thread Mefire O .
Hi All, I have put together a proposal for implementing telemetry into cordova-cli. Please, take a look at the details here: https://github.com/cordova/cordova-discuss/pull/43 Your feedback will be much appreciated. Thanks, Omar Mefire

[GitHub] cordova-plugin-file-transfer pull request: Fix documentation for o...

2016-05-02 Thread dflourusso
GitHub user dflourusso opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/144 Fix documentation for options.headers You can merge this pull request into a Git repository by running: $ git pull https://github.com/dflourusso/cordova-plugin-file-tr

[GitHub] cordova-docs pull request: Fix URL to cordova-sqlite-ext plugin Re...

2016-05-02 Thread slomek
GitHub user slomek opened a pull request: https://github.com/apache/cordova-docs/pull/590 Fix URL to cordova-sqlite-ext plugin Readme You can merge this pull request into a Git repository by running: $ git pull https://github.com/slomek/cordova-docs patch-1 Alternatively you

[GitHub] cordova-plugin-file pull request: CB-10317 Encoded # in uri parse

2016-05-02 Thread dhams
Github user dhams commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/172#issuecomment-216162738 @adamscybot Right , iOS version is able to parse this special char. --- If your project is set up for it, you can reply to this email and have your reply ap

Buildbot: buildslave cordova-windows-slave was lost

2016-05-02 Thread buildbot
The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Mon May 2 07:16:55 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://ci.apac

[GitHub] cordova-docs pull request: Update index.md

2016-05-02 Thread richardyu-au
GitHub user richardyu-au opened a pull request: https://github.com/apache/cordova-docs/pull/589 Update index.md For Orientation, there was a type in allowed values, portait should be portrait You can merge this pull request into a Git repository by running: $ git pull https://