[GitHub] cordova-plugin-contacts issue #128: Resolved crash in Samsung S6 and S7. See...

2016-06-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/128 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/128/commits/master) **Dashboard** -

[GitHub] cordova-plugin-contacts pull request #128: Resolved crash in Samsung S6 and ...

2016-06-06 Thread proverbface
GitHub user proverbface opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/128 Resolved crash in Samsung S6 and S7. See CB-11206. ### Platforms affected Android ### What does this PR do? Fixes crash on Samsung S6, S7 possible on other

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-06-06 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-lib/pull/453 This is cool, I just worry about how we handle localization of the app display name. All platforms support having multiple sets of metadata for different markets, and I would like to

Re: Supporting a "display name" in config.xml

2016-06-06 Thread Shazron
+1 Update the Platform's API functions, if available. For iOS, you would modify: https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L171 Two issues [1][2] are asking for the same thing, but have no PR attached (perhaps you can attach to one? and resolve

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-06 Thread Shazron
Time to wrap up the vote, David? On Fri, Jun 3, 2016 at 9:24 AM, Shazron wrote: > One more vote needed! Let's get this release out :) > > > On Thursday, May 19, 2016, David Barth wrote: > >> Hey, >> >> Just a quick note to say I'm going to do

Re: [Vote] Tools Release

2016-06-06 Thread Shazron
The releases need to have the permanent tag "rel/VERSION". They are missing in the repos. On Sun, May 22, 2016 at 2:33 AM, Steven Gill wrote: > The vote has now closed. The results are: > > Positive Binding Votes: 3 > > Steve Gill > Omar Mefire > Alexander Sorokin > >

Supporting a "display name" in config.xml

2016-06-06 Thread Darryl Pogue
One feature that has been requested a few times is the ability to specify a different display name for an app. On iOS this corresponds to CFBundleDisplayName, on Android this is the Activity label, and on Windows this is the DisplayName. It turns out that the W3C Widgets/Packaged Apps spec that

[GitHub] cordova-cli pull request #256: CB-11349 passing --fetch to create

2016-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #454: Fix failing cordova-fetch tests

2016-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib issue #454: Fix failing cordova-fetch tests

2016-06-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/454 Thanks @dpogue! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Re: [FYI] If you are using Gmail, emails from microsoft.com may be in your Spam folder

2016-06-06 Thread Steven Gill
Any forward movement on getting this fixed? I just found another 6 emails in spam On Wed, Jun 1, 2016 at 2:10 PM, Shazron wrote: > If the emails are "filtered" to a label, it will still show in the label, > and Spam. That's apparently why I still saw the emails, and was able

[GitHub] cordova-plugin-dialogs issue #79: allow programatically dismissing dialogs

2016-06-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/79 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-dialogs/pull/79/commits/master) **Dashboard** -

[GitHub] cordova-plugin-dialogs issue #79: allow programatically dismissing dialogs

2016-06-06 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/79 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-android issue #309: CB-11383: Update to gradle for using jcenter and...

2016-06-06 Thread macdonst
Github user macdonst commented on the issue: https://github.com/apache/cordova-android/pull/309 @infil00p should we leave `mavenCentral` in just in case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Cordova-Android 5.2.0 Release

2016-06-06 Thread Joe Bowser
So, I guess we should probably just go and do this. I would have liked to get the new AndroidManifest changes into the template. I have a PR waiting as well. https://github.com/apache/cordova-android/pull/309 On Tue, May 31, 2016 at 1:34 PM, Nikhil Khandelwal wrote: >

New network information jira issue and code review request

2016-06-06 Thread Close, Rob
Hi, The Jira issue: https://issues.apache.org/jira/browse/CB-11384 Merge request: https://github.com/rob-close/cordova-plugin-network-information/pull/1 Summary: Source is not passing sonarqube scan. Thanks, Rob.

[GitHub] cordova-plugin-inappbrowser issue #169: CB-11381 android: Does not pass sona...

2016-06-06 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

New inappbrowser lira issue and code review request

2016-06-06 Thread Close, Rob
Hi, The Jira issue: https://issues.apache.org/jira/browse/CB-11381 Merge request: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 Summary: Source is not passing sonarqube scan. Thanks, Rob.

[GitHub] cordova-plugin-inappbrowser issue #169: CB-11381 android: Does not pass sona...

2016-06-06 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/169/commits/master) **Dashboard**

[GitHub] cordova-android pull request #309: CB-11383: Update to gradle for using jcen...

2016-06-06 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/309 CB-11383: Update to gradle for using jcenter and use app plugin This is a housekeeping pull request so we can use gradle more easily. You can merge this pull request into a Git repository

[GitHub] cordova-plugin-inappbrowser pull request #169: CB-11381 android: Does not pa...

2016-06-06 Thread rob-close
GitHub user rob-close opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/169 CB-11381 android: Does not pass sonarqube scan The problem is "Empty Catch Block", which sonarqube considers a blocker. Added a log message to the empty block. You can

[GitHub] cordova-lib pull request #454: Fix failing cordova-fetch tests

2016-06-06 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/454#discussion_r65937033 --- Diff: cordova-fetch/index.js --- @@ -152,7 +152,7 @@ function trimID(target) { //also support scoped packages

[GitHub] cordova-plugin-file-transfer pull request #148: Fix CB-11340 - Documentation...

2016-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib issue #454: Fix failing cordova-fetch tests

2016-06-06 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-lib/pull/454 /cc @stevengill One test is still disabled, the "create with Git URL --fetch" fails in Appveyor, and then causes the next test ("create with npm package --fetch") to fail as well with

[GitHub] cordova-plugin-file pull request #102: CB-8554 Updated source to pass Fortif...

2016-06-06 Thread rob-close
Github user rob-close closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-dialogs pull request #48: CB-8549 Updated source to pass Fort...

2016-06-06 Thread rob-close
Github user rob-close closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-wkwebview-engine issue #7: Fixes CB-11074: WKWebView configur...

2016-06-06 Thread macrozone
Github user macrozone commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/7 It seems that this bug prevents autoplay in and elements on IOS, because the config "MediaPlaybackRequiresUserAction" is never passed to the WkWebview instance and

RE: [ANNOUNCE] Cordova-windows 4.4.0 released

2016-06-06 Thread Vladimir Kotikov (Akvelon)
Blog: http://cordova.apache.org/announcements/2016/06/03/cordova-windows-4.4.0.html Tweet: https://twitter.com/apachecordova/status/739769950504648705 - Best regards, Vladimir