Nightly build #84 for cordova has succeeded!

2016-07-27 Thread Apache Jenkins Server
Nightly build #84 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/84/consoleFull - Jenkins for Apache Cordova

CB-11078 Empty string for BackgroundColor preference crashes application #316

2016-07-27 Thread Akila Wicky
Hi all, I fixed the issue CB-11078. Can you check code merge if there is no other problem. If their is any problem please tell me i'll fix it. -- *Thanks and Regards,*Akila Wickramarachchi Undergraduate at University Of Peradeniya

[GitHub] cordova-lib issue #468: CB-8978 Add resource-file parsing to config.xml

2016-07-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/468 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) is 80.62% (diff: 100%) > Merging [#468](https://codecov.io/gh/apache/cordova-lib/pull/468?src=pr) into

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72543969 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72543906 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #468: CB-8978 Add resource-file parsing to config.x...

2016-07-27 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/468 CB-8978 Add resource-file parsing to config.xml Original JIRA issue https://issues.apache.org/jira/browse/CB-8978 Related to/replaces https://github.com/apache/cordova-lib/pull/214 See

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72542674 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72541227 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72541191 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

2016-07-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/467 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/467?src=pr) is 80.71% (diff: 100%) > Merging [#467](https://codecov.io/gh/apache/cordova-lib/pull/467?src=pr) into

[GitHub] cordova-lib issue #467: CB-9825: tests for cocoapod integration for plugins

2016-07-27 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/467 This looks good! Aside from the minor comments I left, I think it might be good to go. Travis hasn't run yet. Queued up. @shazron any comments? --- If your project is

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538340 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538273 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538178 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72538082 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72537902 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72535870 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -356,3 +356,123 @@ describe('plugin add and rm end-to-end --fetch', function () {

[GitHub] cordova-plugin-inappbrowser pull request #177: CB-11178 allow to open other ...

2016-07-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #177: CB-11178 allow to open other apps on...

2016-07-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/177 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-plugin-inappbrowser pull request #177: CB-11178 allow to open other ...

2016-07-27 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/177 CB-11178 allow to open other apps on iOS 9 ### Platforms affected iOS 9 ### What does this PR do? Removes the canOpenURL check and just call

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72528694 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/plugin.xml --- @@ -0,0 +1,16 @@ +

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72528666 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cordova-plugin-cocoapod-dependent/plugin.xml --- @@ -0,0 +1,15 @@ +

[GitHub] cordova-docs issue #623: CB-11621 Add windows@4.4.2 release blog post

2016-07-27 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/623 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72488127 --- Diff: cordova-lib/spec-cordova/fixtures/plugins/sample-cocoapod-plugin-overlapping-dependency/RELEASENOTES.md --- @@ -0,0 +1,141 @@

[GitHub] cordova-lib pull request #467: CB-9825: tests for cocoapod integration for p...

2016-07-27 Thread juliascript
Github user juliascript commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/467#discussion_r72487562 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -33,326 +33,453 @@ var helpers = require('./helpers'), var projectRoot =

[GitHub] cordova-docs issue #623: CB-11621 Add windows@4.4.2 release blog post

2016-07-27 Thread TimBarham
Github user TimBarham commented on the issue: https://github.com/apache/cordova-docs/pull/623 Couple of comments. Other than that looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request #623: CB-11621 Add windows@4.4.2 release blog post

2016-07-27 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/623#discussion_r72483583 --- Diff: www/_posts/2016-07-27-cordova-windows-4.4.2.md --- @@ -0,0 +1,33 @@ +--- +layout: post +author: +name: Vladimir Kotikov

RE: [Vote] Cordova-windows 4.4.2 release

2016-07-27 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes: 3 Vladimir Kotikov Tim Barham Sergey Grebnov Negative Binding Votes: 0 The vote has passed. - Vladimir -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Tuesday, July 26, 2016

RE: [DISCUSS] Cordova-windows@4.4.2 release

2016-07-27 Thread Vladimir Kotikov (Akvelon)
Please take a look at the blog post: https://github.com/apache/cordova-docs/pull/623 - Vladimir -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Monday, July 25, 2016 1:10 PM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-windows@4.4.2

[GitHub] cordova-docs issue #623: CB-11621 Add windows@4.4.2 release blog post

2016-07-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/623 @sgrebnov, @TimBarham, could you please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request #623: CB-11621 Add windows@4.4.2 release blog post

2016-07-27 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/623 CB-11621 Add windows@4.4.2 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-docs

[GitHub] cordova-docs issue #613: CB-11477 Add a page about nightly builds

2016-07-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-docs/pull/613 @stevengill, ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-media-capture pull request #66: CB-11630: (iOS) Implement pro...

2016-07-27 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/66 CB-11630: (iOS) Implement property 'quality' in captureImage() ### Platforms affected iOS ### What does this PR do? Allows developers to set JPEG

[GitHub] cordova-plugin-camera issue #223: CB-11447 Fix Appium camera tests failures

2016-07-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/223 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-windows issue #189: CB-11579 windows: fix bug with 'cordova clean wi...

2016-07-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/189 ## [Current coverage][cc-pull] is 73.30% (diff: 100%) > Merging [#189][cc-pull] into [master][cc-base-branch] will increase coverage by **0.25%** ```diff @@

[GitHub] cordova-windows pull request #189: CB-11579 windows: fix bug with 'cordova c...

2016-07-27 Thread matrosovN
GitHub user matrosovN opened a pull request: https://github.com/apache/cordova-windows/pull/189 CB-11579 windows: fix bug with 'cordova clean windows' command You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-media-capture issue #64: CB-11629: (iOS) Implement 'animated'...

2016-07-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/64 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media-capture pull request #64: CB-11629: (iOS) Implement 'an...

2016-07-27 Thread ryanwilliams83
GitHub user ryanwilliams83 opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/64 CB-11629: (iOS) Implement 'animated' property and updated English docs ### Platforms affected iOS ### What does this PR do? Add property 'animated' to